[07:40:47] @/ [07:57:34] * takidelfin waves [08:10:34] * Urbanecm waves to takidelfin [08:13:41] Still no time for anything :( Too much school stuff now [08:34:34] I hope you'll have time for non-school time stuff sometime soon too takidelfin [09:54:35] (03PS14) 10Shreyasminocha: Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 [09:54:43] (03CR) 10jerkins-bot: [V: 04-1] Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 (owner: 10Shreyasminocha) [10:03:05] (03PS15) 10Shreyasminocha: Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 [10:06:45] (03CR) 10jerkins-bot: [V: 04-1] Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 (owner: 10Shreyasminocha) [10:07:39] * shreyasminocha needs to get out of the habit of using `grunt lint` instead of `npm test` for testing [10:10:16] (03PS16) 10Shreyasminocha: Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 [10:19:29] shreyasminocha, what about some kind of aliasing? :D [10:19:41] yeah, perhaps :D [10:19:45] `ntest` [10:19:52] (03CR) 10Shreyasminocha: "This change is ready for review." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 (owner: 10Shreyasminocha) [10:20:53] shreyasminocha, nice to see your change as ready for review [10:21:01] yes [10:22:03] btw should probably make all buttons and nav lowercase using text-transform [10:22:24] btw #2: js in .html files is unlinted [10:22:39] eslint-plugin-html to the rescue [10:23:08] shreyasminocha, I think your patch should depend on https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/478495, so it uses the new mediainfos and not the old ones [10:23:23] right [10:24:29] Ok, back in HexChat, lag is back to normal [10:25:03] nice [10:25:27] Urbanecm: on rebasing onto your patch, there are several outstanding commits [10:25:49] btw why haven't you merged https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/478495? [10:25:51] (03PS30) 10Urbanecm: Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [10:27:10] shreyasminocha, till we're done with our work )read as "enough to release it to prod"), photographers are supposed to use the old system [10:27:27] point [10:29:05] I've rebased my patch on top of master, I'm not sure if your issue is resolved by that [10:31:05] a97c2d4 (HEAD -> commons-selection) Add Commons media selection interface [10:31:06] 3d42587 (review/unknown/T211508) Introduce new MediaInfo in the backend [10:31:13] outstanding commits. [10:33:06] ah, this thing [10:33:08] that's normal [10:33:14] if that's raised by git review -R [10:33:32] yeah. first it had 4 outstanding though so your rebase onto master helped [10:33:43] so i'll just enter "yes" and move on [10:33:44] it means something like "Do you really want to create a dependency chain?" [10:33:46] Yes [10:33:58] (03PS31) 10Shreyasminocha: Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [10:34:00] (03PS17) 10Shreyasminocha: Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 [10:36:21] * Urbanecm is reviewing shreyasminocha's patch [10:49:36] (03CR) 10Urbanecm: Add Commons media selection interface (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 (owner: 10Shreyasminocha) [12:18:26] (03PS32) 10Urbanecm: Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [12:18:38] shreyasminocha, ping ^^ [12:19:29] (03CR) 10jerkins-bot: [V: 04-1] Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [13:37:36] (03PS18) 10Shreyasminocha: Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 [13:38:45] (03CR) 10jerkins-bot: [V: 04-1] Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 (owner: 10Shreyasminocha) [13:57:12] (03PS19) 10Shreyasminocha: Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 [14:43:01] (03PS20) 10Shreyasminocha: Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 [14:44:18] (03CR) 10jerkins-bot: [V: 04-1] Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 (owner: 10Shreyasminocha) [17:35:57] Hi shreyasminocha [17:35:59] (and takidelfin) [17:40:06] (03CR) 10Urbanecm: [C: 03+2] Localisation updates from https://translatewiki.net. [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/482060 (owner: 10L10n-bot) [17:55:17] (03PS21) 10Shreyasminocha: Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 [17:57:30] (03CR) 10jerkins-bot: [V: 04-1] Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 (owner: 10Shreyasminocha) [18:02:53] (03PS33) 10Urbanecm: Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [18:03:08] (03PS22) 10Urbanecm: Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 (owner: 10Shreyasminocha) [18:04:08] (03CR) 10jerkins-bot: [V: 04-1] Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [18:05:00] (03CR) 10jerkins-bot: [V: 04-1] Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 (owner: 10Shreyasminocha) [18:06:55] (03PS1) 10Urbanecm: Allow to customize branch used per instance [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/482092 [18:08:16] (03CR) 10Urbanecm: [C: 03+2] Allow to customize branch used per instance [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/482092 (owner: 10Urbanecm) [18:09:35] (03Merged) 10jenkins-bot: Allow to customize branch used per instance [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/482092 (owner: 10Urbanecm) [18:13:46] (03PS34) 10Urbanecm: Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [18:18:57] (03CR) 10Urbanecm: [C: 03+2] Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [18:21:06] (03CR) 10Urbanecm: [C: 03+2] "This change is ready for review." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [18:22:27] (03Merged) 10jenkins-bot: Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [18:24:18] (03PS8) 10Urbanecm: Update import logic to allow importing new MediaInfos [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479225 (https://phabricator.wikimedia.org/T211581) [18:25:48] (03CR) 10Urbanecm: [C: 03+2] "This change is ready for review." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479225 (https://phabricator.wikimedia.org/T211581) (owner: 10Urbanecm) [18:27:03] (03Merged) 10jenkins-bot: Update import logic to allow importing new MediaInfos [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479225 (https://phabricator.wikimedia.org/T211581) (owner: 10Urbanecm) [18:31:48] (03CR) 10Urbanecm: [C: 03+2] "This change is ready for review." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480029 (https://phabricator.wikimedia.org/T211636) (owner: 10Urbanecm) [18:32:13] (03CR) 10jerkins-bot: [V: 04-1] Expose old MediaInfo in the API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480029 (https://phabricator.wikimedia.org/T211636) (owner: 10Urbanecm) [18:34:34] (03PS7) 10Urbanecm: Expose old MediaInfo in the API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480029 (https://phabricator.wikimedia.org/T211636) [18:35:50] (03CR) 10jerkins-bot: [V: 04-1] Expose old MediaInfo in the API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480029 (https://phabricator.wikimedia.org/T211636) (owner: 10Urbanecm) [18:37:07] (03PS8) 10Urbanecm: Expose old MediaInfo in the API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480029 (https://phabricator.wikimedia.org/T211636) [18:38:24] (03CR) 10Urbanecm: [C: 03+2] Expose old MediaInfo in the API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480029 (https://phabricator.wikimedia.org/T211636) (owner: 10Urbanecm) [18:39:35] (03Merged) 10jenkins-bot: Expose old MediaInfo in the API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480029 (https://phabricator.wikimedia.org/T211636) (owner: 10Urbanecm) [18:39:38] (03PS23) 10Urbanecm: Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 (owner: 10Shreyasminocha) [18:40:43] (03CR) 10jerkins-bot: [V: 04-1] Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 (owner: 10Shreyasminocha) [18:52:37] (03PS24) 10Shreyasminocha: Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 [18:57:23] (03PS25) 10Shreyasminocha: Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 [20:00:17] (03CR) 10Urbanecm: [C: 04-1] "1) We need to allow users to remove photos too." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 (owner: 10Shreyasminocha) [20:09:12] (03PS26) 10Urbanecm: Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 (owner: 10Shreyasminocha) [20:10:12] (03CR) 10Urbanecm: [C: 04-1] "> Patch Set 25: Code-Review-1" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 (owner: 10Shreyasminocha)