[06:01:46] [telegram] https://t.me/joinchat/AAAAAFg6SZD4Oi5sIDx3kg [10:15:14] [telegram] Is anyone here familiar with Fandom/Wikia and the code they run? [10:15:15] [telegram] Does anyone know how did they implement Global modules? [10:15:16] [telegram] See: [10:15:17] [telegram] https://dev.fandom.com/wiki/Global_Lua_Modules [10:15:19] [telegram] https://dev.fandom.com/wiki/Lua_templating/Glossary [10:15:20] [telegram] Is this something that we can port to our code? [10:55:57] [telegram] Máté ^ [11:17:11] [telegram] I can’t check this in detail right now, but isn’t it just “global” in the sense that it uses global data (we have lots of i18n data tables on Commons that are indeed globally used in templates)? [11:18:09] [telegram] I know that we can use global data from .tab files/pages on Commons, but it looks like they talk about actual Lua code and not just data. [11:19:48] [telegram] Heyo, yeah, they load the modules from a different wiki. [11:20:11] [telegram] The 1.19 inplementation is messy, the 1.33 extension is a more kosher one that will be made public in few weeks time [11:20:20] [telegram] Hi Máté ! Great to hear from you! [11:20:27] [telegram] WOW WOW WOW [11:20:46] [telegram] It only relies on a custom hook added to scribunto that allows intercepting the module load and loading module content from a foreign wiki if the module name matches a pattern [11:21:30] [telegram] And, um, ultra-mega-naïve question: will Wikimedia sites be able to use this, and resolve https://phabricator.wikimedia.org/T41610 ? :) [11:23:12] [telegram] Or will it get stuck somewhere... because the Wikia Scribunto code diverged too far from the Wikimedia Scribunto code? Or because Wikimedia's caching is not compatible? Or for some other technical reason? [11:25:12] [telegram] Impressive! Any performance issues? [11:27:24] [telegram] Not that I am aware of - the output would land in the parser cache anyways. [11:27:56] [telegram] Once we polish up and publish the 1.33 version, it could be made compatible with wikimedia scribunto as well [11:38:15] [telegram] I will be expecting this eagerly!! Where will you announce it? (re @Máté: Once we polish up and publish the 1.33 version, it could be made compatible with wikimedia scribunto as well) [11:38:58] [telegram] Is there any blog it wiki page where you publish updates about such things? [11:41:26] [telegram] We have an eng blog on medium, although its not strictly wiki related. I can reach out to see if we can post there once such update happens :) [11:55:03] [telegram] I, at least, find this supremely exciting. So yes, please tell this to whoever is relevant. (re @Máté: We have an eng blog on medium, although its not strictly wiki related. I can reach out to see if we can post there once such update happens :)) [12:11:46] [telegram] How much is "few weeks", if it's not a secret? :) (re @Máté: The 1.19 inplementation is messy, the 1.33 extension is a more kosher one that will be made public in few weeks time) [12:13:58] [telegram] Core Platform is starting some prereq cleanup work next week or so. Let me check... [12:15:46] [telegram] Fandom core platform or WMF core platform? :) (re @Máté: Core Platform is starting some prereq cleanup work next week or so. Let me check...) [12:16:53] [telegram] I doubt it’s WMF :p [12:22:53] [telegram] Me too, but I have to check. I'm also wondering whether WMF core platform people know this, and what do they think about this (re @tehreedy: I doubt it’s WMF :p) [12:23:09] [telegram] They probably don’t [12:24:06] [telegram] When it’s ready for upstreaming it’d be worth creating a task and tagging a few teams to look at [12:24:36] [telegram] Hopefully it’s behind a feature flag so merging it can be a little less painful [12:24:45] [telegram] 👍 [12:26:28] [telegram] It is a wholly separate extension, only coupled via a single hook addition [12:27:21] [telegram] Aha [12:27:38] [telegram] How is it called? Is it on GitHub! (re @Máté: It is a wholly separate extension, only coupled via a single hook addition) [12:27:42] [telegram] How is it called? Is it on GitHub? (re @Máté: It is a wholly separate extension, only coupled via a single hook addition) [12:28:21] [telegram] GlobalLuaModules :) Not yet, but will be soon! [12:28:34] [telegram] (I have reached out, waiting for an answer) [12:41:03] [telegram] Unrelated, you have only today to vote on gerrit's favicon: https://phabricator.wikimedia.org/V21 [12:50:51] [telegram] 👍 (re @Máté: GlobalLuaModules :) Not yet, but will be soon!) [12:57:51] [telegram] I'm not sure it's totally right to call it that, because Scribunto can support more than Lua. Just GlobalModules would be a bit better. But the function is more important than the name. (re @Máté: GlobalLuaModules :) Not yet, but will be soon!) [13:02:49] [telegram] It’s not like Wikimedia is any better at naming things :p [13:03:05] [telegram] See also SyntaxHighlight Geshi, which doesn’t use geshi anymoee 😂 [13:03:13] [telegram] See also SyntaxHighlight Geshi, which doesn’t use geshi anymore 😂 [13:30:47] [telegram] === Bug fixes in 1.35 === [13:30:47] [telegram] * … [13:30:48] [telegram] NO BUGS WERE FIXED IN 1.35 [13:31:43] [telegram] yay. how many were introduced? :) [13:32:21] [telegram] heh [13:32:37] [telegram] (what if we had inclusionists not only in article but also in bug context. but then why I am so sure that there aren't any) [13:34:23] [telegram] Isn't this a feature of Semantic versioning? https://semver.org/ [13:36:50] [telegram] Except we've been on the major version 1 of MediaWiki for decades... ;) [13:38:48] [telegram] sure, but even for minor versions you don't do bugfixes [13:39:25] [telegram] We do? [13:39:36] [telegram] The security releases include backported bug fixes [13:40:02] [telegram] well, then we are not following semver and anything's game :) [13:40:09] [telegram] Doesn't mean that [13:40:13] [telegram] omg I never realised semver has 2 versions itself and spans several screens in length. [13:40:20] [telegram] Bug fixes don't have to be breaking changes [13:40:21] [telegram] we are most definitely not following semver, nor do I think we should [13:48:11] [telegram] we can go to other extreme and generate the list of phabricator tickets resolved in 1.35 (re @tehreedy: === Bug fixes in 1.35 === [13:48:11] [telegram] * … [13:48:12] [telegram] NO BUGS WERE FIXED IN 1.35) [13:48:20] [telegram] we can go to the other extreme and generate the list of phabricator tickets resolved in 1.35 (re @tehreedy: === Bug fixes in 1.35 === [13:48:20] [telegram] * … [13:48:21] [telegram] NO BUGS WERE FIXED IN 1.35) [14:07:57] [telegram] 1.35.0-rc.0 is out [16:38:42] [telegram] https://t.me/joinchat/AAAAAEMf49G3ylffKjyS6w [17:42:07] [telegram] Do you also have global templates or only modules? (re @Máté: GlobalLuaModules :) Not yet, but will be soon!) [17:43:01] [telegram] Only modules and scary transclusion (mostly for few user pages) [17:45:38] [telegram] Thanks! (re @Máté: Only modules and scary transclusion (mostly for few user pages))