[17:10:59] <taavi>	 how did zuul merge https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/931652 despite it having a -1?
[17:31:06] <Reedy>	 Isn't that expected behaviour?
[17:31:27] <MatmaRex>	 -1 doesn't prevent merging, only -2
[18:10:19] <Krinkle>	 taavi: the chronology does make that awkward indeed. to cancen an in-flight +2 that's about to merge via jenkins, you have the power to remove the +2 score, that's usually how I do it, as -2 feels more lasting in nature (means I have to remove -2 again later, instead of someone just re+'2ing after a while).
[18:10:46] <Krinkle>	 Gerrit will verify at the last second between job success and merge whether there there is a CR/V+2 at that time and no -2 blocking it
[18:11:21] <taavi>	 the problem is that I did not even notice that +2 until I saw the "merged" message..
[18:12:18] <taavi>	 but -1 not blocking a merge makes sense in general, although in some specific situations like this it's not ideal
[18:56:54] <Krinkle>	 ack, I believe -2 would have worked in that race condition, but I'm not 100% sure. Depends on whether -2 is enforced only by zuul or also/instead by gerrit (i.e. does gerrit prevent jenkins-bot from performing "Submit" after it performs V+2 because there is a CR-2, or do we only configure Zuul to not run the gate on CR+2 if there is also a CR-2).