[14:51:34] <James_F>	 Anyone more familiar with the pagelinks setup than me able to help me debug? https://phabricator.wikimedia.org/T361701#9846937 – WikiLambda is adding items into ParserOutput::addLinks(), but they're not making it to the PL table.
[15:37:10] <bawolff>	 James_F: Looking at the code, there is a return early in the function if HTML content is not requested. This would be the case in linksupdate code most likely (Depends on what other extensions are doing as to whether or not this is true)
[16:07:34] <James_F>	 bawolff: … oh, hah. That's such an obvious issue. Thanks!
[16:09:26] <bawolff>	 The whole "no request html" parser output thing seems to be a pretty big source of confusion and bugs
[16:09:37] <James_F>	 Indeed.
[16:10:29] <James_F>	 Maybe "fillParserOutput" should have been split into "fillHTMLParserOutput" and "fillMetadataParserOutput" or similar?
[16:15:55] <bawolff>	 That sounds like a good idea to me to be honest
[16:38:02] <James_F>	 Filed as T366305.
[16:38:02] <stashbot>	 T366305: Consider splitting ContentHandler's fillParserOutput method into "fillHTMLParserOutput" and "fillMetadataParserOutput" or similar - https://phabricator.wikimedia.org/T366305
[18:48:58] <Krinkle>	 Amir1: do you prefer ConnectionProvider()->getPrimaryDatabase() + '@phan-var IMaintainableDatabase $dbw'; over LBFactory->getMaintainable ?
[18:49:04] <Krinkle>	 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UserMerge/+/1034902/2/includes/MergeUser.php#b660
[18:49:35] <Krinkle>	 UserMerge calls tableExists() there, and I'm not sure we actually want to use ICP there, but maybe we do?
[19:16:46] <Amir1>	 Krinkle: I always advocated against online schema checks, since you might hit a db that has a different schema, pass and try it on another db that doesn't. All sorts of fun
[19:17:02] <Amir1>	 the table exists there is useless, just remove it 
[19:17:14] <Amir1>	 if ( $dbw->tableExists( 'actor', __METHOD__ ) ) {
[19:17:46] <Amir1>	 actor has been around long enough and if you're using ICP, you're hitting a version of mw that definitely is going to have actor otherwise you're going to have bigger problems
[19:21:35] <Krinkle>	 Right, ok. I'll just remove it then.
[19:22:40] <Krinkle>	 Amir1: so in terms of my original question, I guess the answer is neither. Don't force type, but also don't use LBFactory->getLB->getMaintainable. Instead use ICP in web code, and use Maintenance->getDB in CLI. 
[19:22:55] <Krinkle>	 If it's not a Maintenance script, don't need to reach to the old LB/getMaint way.
[19:23:00] <Krinkle>	 shouldn't*
[19:26:21] <Krinkle>	 T167246 is still open :)
[19:26:22] <stashbot>	 T167246: Refactor "user" & "user_text" fields into "actor" reference table - https://phabricator.wikimedia.org/T167246
[19:26:40] <Krinkle>	 updated https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UserMerge/+/1034902 accordingly
[20:23:11] <Amir1>	 Krinkle: yup indeed