[03:54:23] AaronSchulz: I'll think about it [23:00:52] Reedy: James_F: regarding extension v1 freezing T258668, I'd like to do this before the branch cut. Is this a doc-only change? Or do we have some scripting or tooling that adds (or requires) v1 and v2 to both be updated / in sync? I couldn't find anything like that. [23:00:52] T258668: Freeze extension.json manifest_version 1 - https://phabricator.wikimedia.org/T258668 [23:01:16] we do it manually currently in both, and enforce via CR, is that right? [23:09:21] In CR... or it gets caught in a followup [23:09:49] But yeah, there isn't much probably to be done [23:10:51] We should decide (again; there was a conversation years ago in that task) if we want to emit any sort of deprecation warning [23:11:34] I suspect a simple test should be created inside MW that basically makes sure the v1 schema is always the same hash... With a comment (in the test?) that if you're changing it, make sure you know what you're doing [23:12:06] Only reason anyone should probably be changing it post freezing is maybe changing description stuff [23:13:36] https://codesearch.wmcloud.org/search/?q=%5C%22manifest_version%5C%22%3A+1&files=&excludeFiles=&repos= has more than I'd have expected [23:13:50] I bet many would be very trivially upgraded still