[00:46:56] :nod: I eventually read the backscroll close enough to get that as the jist too.. [20:11:52] I was looking into T383327 and did some testing on mwdebug for load.php to see what kind of queries it currently makes to MainStash (message:SELECT AND "objectstash") [20:11:53] T383327: Re-architecture mainstash (x2) to allow easier maintenance - https://phabricator.wikimedia.org/T383327 [20:12:11] And low and behold I just by freak accident reproduced a deadlock that I haven't been able to reproduce for months [20:12:19] ref T348235 [20:12:20] T348235: Deadlock in SqlBagOStuff::modifyTableSpecificBlobsForSet - https://phabricator.wikimedia.org/T348235 [20:12:43] > Error 1213 from SqlBagOStuff::modifyTableSpecificBlobsForSet, Deadlock found when trying to get lock; try restarting transaction INSERT INTO `objectstash` (keyname,value,exptime,modtoken) VALUES ('commonswiki:ResourceLoaderModule-dependencies:ext.wikimediaBadges|vector-2022|en','…) ON DUPLICATE KEY UPDATE … [20:21:00] Ah, actually that's from a mw-web request, not my debug request. [20:21:13] so I don't have the other end of that, and no verbose logging for either of them. [20:52:08] tgr: should i merge https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/1121047 and the re-revert, or do you want to think about it / consult it more? [20:52:16] (looks good to me) [20:53:39] MatmaRex: I think it's good to go. [20:54:00] I found some bugs in the meanwhile so I'm holding off with the backport, but merging should be fine. [20:54:41] alright. might as well see it on beta again