[17:46:05] <Amir1>	 taavi: Hi, do you think this is good for turning on the strict mode? https://phabricator.wikimedia.org/T161859#10579966
[17:46:42] <Amir1>	 specially whether "select ln_name from localnames where ln_wiki = 'labswiki' and ln_name not in (select lu_name from localuser where lu_wiki = 'labswiki' and lu_attached_timestamp like '20%');"  will catch all unattached accounts
[17:46:54] <Amir1>	 Triple checking to avoid messing up
[17:50:35] <taavi>	 Amir1: one second
[17:51:10] <Amir1>	 thanks
[17:56:22] <taavi>	 Amir1: what's up with that `lu_attached_timestamp like '20%'` condition?
[17:56:59] <Amir1>	 to make sure all types of null are weeded out
[17:57:04] <taavi>	 aha
[17:57:57] <taavi>	 anyhow, your query seems fine and I also checked that the `localnames` table matches with the local `user` table (sans `Global rename script` which is more system account weirdness and can be ignored for now)
[17:58:24] <taavi>	 so I think it should be fine to enable strict mode (and then account creation at some point)
[17:58:50] <Amir1>	 awesome \o/
[17:59:04] <Amir1>	 Is there anything stopping us from turning on account creation right now?
[17:59:31] <Amir1>	 (I mean beside laziness)
[18:00:03] <taavi>	 not really
[18:00:39] <Amir1>	 I will deploy that right after this then
[18:02:15] <taavi>	 great
[18:43:48] <Amir1>	 bd808: so for the last point of the checklist, it says we should drop tables. I'm looking at https://phabricator.wikimedia.org/P73353 and these seems to be the list of tables to bite the dust?
[18:43:48] <Amir1>	 external_user [only in 'labswiki']
[18:43:48] <Amir1>	 ldap_domains [only in 'labswiki']
[18:43:48] <Amir1>	 oathauth_users_restore [only in 'labswiki']
[18:43:48] <Amir1>	 oathauth_users 
[18:43:49] <Amir1>	 oauth2_access_tokens 
[18:43:49] <Amir1>	 oauth_accepted_consumer 
[18:43:50] <Amir1>	 oauth_registered_consumer
[18:43:50] <Amir1>	 oathauth_types
[18:43:50] <Amir1>	 oathauth_devices
[18:43:51] <Amir1>	 loginnotify_seen_net
[18:43:52] <Amir1>	 Does this list sound good to you?
[18:50:07] <taavi>	 Amir1: are there any echo tables that need dropping?
[19:12:38] <Amir1>	 Probably those too
[19:12:41] <Amir1>	 Yeah
[22:13:37] <bd808>	 Amir1: w00t! Awesome job finishing it all up. Would you like to write to wikitech-l that we are now done, or should I?
[22:16:16] <Amir1>	 bd808: I'm about to get dinner, I'd appreciate if you do it. my brain is fried. 
[22:16:20] <Amir1>	 if you don't mind
[22:16:54] <bd808>	 Not at all, I'll send something out soon. Have a good dinner and a nice rest :)
[23:01:39] <bd808>	 \o/ [Wikitech-l] Wikitech SUL migration is complete! -- https://lists.wikimedia.org/hyperkitty/list/wikitech-l@lists.wikimedia.org/thread/TDSBWLR4OHDBNNGOX4Q2XE7I534UREME/