[17:40:19] duesen, re https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1153092, Krinkle and I had a discussion about this today. First of all, thanks for the patch and the improvements you made to it. However, there is one bit that was removed in your patch that I missed - fixed in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1153665. Your patch nicely asserts that the `maxSize` / `maxSizeUncompressed` must exist in the JSON structure which the [17:40:20] previous code would silently pass if it didn't or if you made a typo. [17:41:23] But what got removed was that devs are not encouraged to set both `maxSize` and `maxSizeUncompressed` in the perf budget, I've restored that in the patch proposal. [17:41:33] I'll add you and Krinkle for review. [19:42:31] TimStarling: I don't understand the example at https://www.postgresql.org/message-id/c913f8b24f5eab529b45040fecee79eef2339715.camel%40cybertec.at . Why would there be a conflict on "id" (assuming it is SERIAL and not something dumb like DEFAULT 1). More to the point, why use col = col instead of col = EXCLUDED.col? Having EXCLUDED be available with ON CONFLICT is OK, similar to VALUES() in MySQL for DUPLICATE KEY UPDATE. I prefer [19:42:31] VALUES() since it is a function and not subject to the pedantry of being a 1 row "table" with the same column names. Still, it seems intuitive for col=col to mean "assign to col to the existing row value of col" rather than "assigning to it the corresponding value in the proposed row (with missing VALUES columns resolved to defaults) that doesn't exist anywhere but we are temporarily pretending that it does exist in magic 1 row [19:42:31] table)". [19:45:12] When I read "That thread is going as expected." had to go read the pgsql list ;) [21:33:12] tgr: we used to do sampled logging for some MW channels at $job - 1, for e.g. normalized SQL queries and other noisy things, so theoretically IMO it would be fine for non-error channels if we wanted [21:47:40] mszabo: yeah I'm adding that in https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1153363 [21:47:54] perfect :)