[09:29:32] <Reedy>	 Anyone know how you stop Phan complaining about trait methods?
[09:29:49] <Reedy>	 Well, the use of $this in trait methods, and presumably resolving what this is...
[09:29:52] <Reedy>	 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OATHAuth/+/1182964/109/src/HTMLForm/KeySessionStorageTrait.php
[09:32:53] * Lucas_WMDE looks
[09:33:29] <Lucas_WMDE>	 Reedy: by declaring `getRequest()` abstract with an appropriate return type, I think
[09:33:41] <Lucas_WMDE>	 and then PHP will check the class using the trait has a compatible method
[09:34:10] <Reedy>	 We don't seem to need to do that in MediaWikiTestCaseTrait
[09:34:18] <Lucas_WMDE>	 hm
[09:34:30] <Lucas_WMDE>	 indeed I’m only finding one instance of this with codesearch, which surprises me https://codesearch.wmcloud.org/search/?q=abstract+function&files=Trait%5C.php%24&excludeFiles=&repos=
[09:34:37] <Lucas_WMDE>	 I could’ve sworn we did that elsewhere
[09:34:42] <Reedy>	 The fact all the phan ignores are (or were) needed in the OATHAuth one felt... odd
[09:34:59] <Reedy>	 PhpStorm magically resolving these things isn't a surprise, ofc
[09:35:07] <Lucas_WMDE>	 aha, visibility modifiers https://codesearch.wmcloud.org/search/?q=abstract.*function&files=Trait%5C.php%24&excludeFiles=&repos=
[09:35:21] <Lucas_WMDE>	 see e.g. https://gerrit.wikimedia.org/g/mediawiki/core/+/b511b49953f986fc7c4dcec0bb4e1edacd135d29/includes/api/ApiCreateTempUserTrait.php#88
[09:36:44] <Lucas_WMDE>	 re MediaWikiTestCaseTrait, I think we generally don’t have Phan check the PHPUnit tests?
[09:36:47] <Lucas_WMDE>	 see https://gerrit.wikimedia.org/g/mediawiki/core/+/b511b49953f986fc7c4dcec0bb4e1edacd135d29/.phan/config.php#125
[09:37:01] <Reedy>	 ah, yeah, that probably explains that...
[20:59:48] <Reedy>	 MatmaRex: Around?
[21:00:56] <MatmaRex>	 Reedy: sup
[21:02:20] <Reedy>	 Any ideas on the test failures in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/1192214 ? :)
[21:04:46] <MatmaRex>	 hmm
[21:09:59] <MatmaRex>	 Reedy: it probably wants this https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1101111/6/includes/Html/HtmlHelperTrait.php
[21:10:38] <MatmaRex>	 (just the change to that file, not the rest of the patch)
[21:11:04] <Reedy>	 lol
[21:11:14] <Reedy>	 I tried to cherry pick that to REL1_43 in May :D
[21:11:14] <Reedy>	 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1148340
[21:11:18] <MatmaRex>	 you apparently tried to backport that before
[21:11:19] <MatmaRex>	 yeah
[21:11:39] <MatmaRex>	 it probably has some crazy dependency chain for the other changes
[21:12:22] <MatmaRex>	 but the HtmlHelper parts are safe to backport
[21:12:42] <Reedy>	 I wonder what specifically I was trying to backport it for
[21:15:16] <AaronSchulz>	 Krinkle: I guess https://phabricator.wikimedia.org/T175146 can be updated. Mercurious uses extensions/EventBus/maintenance/runSingleJobStdin.php . :)
[21:35:40] <Krinkle>	 AaronSchulz: he, go ahead. Another one!
[21:35:50] <Krinkle>	 We do seem to create runners faster than we deprecate them
[23:29:12] * AaronSchulz updates the task