[14:18:14] tgr_: xSavitar: looks like CentralAuth needs some follow-up patch for https://gerrit.wikimedia.org/r/c/mediawiki/core/+/122912 - see this build failure: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php83/44524/console [14:18:18] 15:02:00 1) CentralAuthSessionProviderTest::testProvideSessionInfo [14:18:18] 15:02:00 MediaWiki\Config\ConfigException: MediaWiki\Config\HashConfig::get: undefined option: 'JwtSessionCookieIssuer' [14:18:58] (err, i meant to link https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1229121 ) [14:22:10] MatmaRex: I am hit by the same thing on Wikibase and I am pretty sure my change is unrelated [14:22:41] tgr_: ^ :-) [14:23:08] and xSavitar ! :] [14:23:54] I guess that is yet another occurrence of a patch to mediawiki/core breaking CentralAuth [14:24:48] ( https://phabricator.wikimedia.org/T333541 ) [14:27:44] yep [14:28:06] to be clear, this looks like test-only issue. we need to add mocks or something for some of the new stuff [14:29:21] MatmaRex, hashar: created T418487 to track it [14:29:22] T418487: Extension CI broken: CentralAuthSessionProviderTest: undefined option: 'JwtSessionCookieIssuer' - https://phabricator.wikimedia.org/T418487 [14:29:55] ah great thank you! [14:33:26] MatmaRex: unrelated, I have deployed your patch to enable CI for the `policy-violation` inference service [14:34:13] hashar: no, that was the other Bartosz! :D [14:34:21] DAMN [14:34:31] can't everyone be simply named Antoine [14:34:35] with an incremental number! :b [14:34:42] sorry for the mistake :-] [14:35:53] np. it sure is getting out of hand to have two of us [14:36:03] :D [14:36:09] and there's a third in phabricator, people keep cc'ing him by accident [14:36:10] hashar: we should just have Antoine, Anton, Антон etc. [14:36:26] Bartosz is quite an unusual first name for someone based in France as I am [14:36:31] :D [14:36:44] and I am pretty sure I never heard of any other one beside MatmaRex until NOW! [14:37:23] I guess there is a reason we have nicknames on IRC and uniqueness is enforced [14:39:28] oh idea [14:40:07] the CI gate is blocked by T418487 , what if in the Gerrit web interface we would display any #ci-test-error tasks that is marked UBN ? :] [14:40:08] T418487: Extension CI broken: CentralAuthSessionProviderTest: undefined option: 'JwtSessionCookieIssuer' - https://phabricator.wikimedia.org/T418487 [14:55:16] it would be cool if jenkins could higlight relevant error messages in the huge CI log (maybe there's some way to highlight lines that don't appear in recent successful job logs, or something?), and then the Gerrit interface could look up Phab tasks that mention the relevant errors [14:55:34] it'd also help with the random failures [14:55:35] hashar, I just uploaded a fix now [14:55:37] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/1244684 [15:02:58] xSavitar: awesome thank you! [15:02:58] :) [15:04:22] I'll chcek to finally have mediawiki/core to be tested with CentralAuth [15:04:31] Apologies for the hassle. I agree that we need to look at https://phabricator.wikimedia.org/T333541 at some point [15:04:31] I have left myself a note for next monday [15:04:41] Thank you hashar 🙏🏽 [15:21:18] anyone know of a complete write-up on redirects somewhere? looking for details of exactly what happens in varnish and MW [15:35:44] milimetric, I'm aware of https://www.mediawiki.org/wiki/Help:Redirects [15:36:00] There are several "See also" links that are also helpful to further reads [15:39:06] On Wikitech, I think there is https://wikitech.wikimedia.org/wiki/URL_path_normalization#Redirect_to_the_canonical_URL (as part of URL path normalization page). I can't find docs related to varnish level redirects but maybe someone else knows about this. [15:47:35] xSavitar: thx, I read those links, looks like the {{method doclink template on mw.org needs an update (and I don't know exactly how to do that but the new link seems to have maybe the MW version in it or something?) [15:47:41] right link: https://doc.wikimedia.org/mediawiki-core/master/php/classMediaWiki_1_1Output_1_1OutputPage.html [15:47:56] current link 404s at:https://doc.wikimedia.org/mediawiki-core/master/php/classOutputPage.html [15:48:13] (so I don't know if someone needs to add a redirect on the doc.wikimedia.org side or something else) [15:49:26] and back to redirects - those help links are good for general understanding, but what I'm seeing is different from what even the code might suggest. Client-side I see an HTTP 307 followed by a 200 for the /wiki/Redirect title and nothing for /wiki/Redirect_Target, but I see the rendering is indeed for /wiki/Redirect_Target [16:17:05] mediawiki page redirects are not HTTP redirects. the URL is updated client-side in JavaScript [16:17:21] milimetric: can you say where you're seeing the HTTP 307? we may be talking about different kinds of redirects [16:33:18] hashar: I have been thinking of filing a feature request for something similar (a non-voting fake test that fails with an error message it reads from some easy-to-edit source so when you are working on unbreaking CI you can put the task number there) [16:34:01] another use case would be cyclic dependencies (like certain vendor changes) which usually leave MediaWiki/extension repos broken for a half hour or so while they merge [16:36:56] MatmaRex: see T364849 for some past discussion [16:36:57] T364849: Display CI errors in the Gerrit UI - https://phabricator.wikimedia.org/T364849 [16:38:23] MatmaRex: in the Network tab, when browsing for, say, /wiki/Obama, I get a 307 for Obama followed by a 200 for Obama. [16:39:11] I see the JS client-side URL update, but I wonder what's actually happening in the background. Because what's actually displayed is the article text for Barack_Obama with a little "redirected from..." subtitle [16:40:09] tgr_: looks like we are not short of having nice ideas. The devil is that I don't quite know how to implement that, but if there was a Toolforge system exposing some status, it is quite trivial to add it as a Check in the Gerrit Web UI ( https://gerrit.wikimedia.org/r/Documentation/pg-plugin-checks-api.html ) [16:40:23] for the task you filed, we would need testsuite to expose the failure in a machine readable way [16:40:46] have them stored somewhere (currently Jenkins), then Gerrit can come retrieve those test results and show them in the Checks tab in the Gerrit web UI [16:40:55] phpunit has an XML output format, I'm sure everything else has too [16:41:05] it's a fair amount of legwork though [16:41:13] * hashar nods [16:41:44] I wanted to that for Phan, but itdoes not support writing a json/xml AND outputting to the console which was a deal breaker so I gave up [16:42:27] Kosta and me played around at some point with a bot taking structured CI outoput and turning it into Gerrit comments [16:42:28] milimetric: as in https://en.wikipedia.org/wiki/Obama ? i get a 200 response when visiting that [16:42:37] but then the Gerrit APIs got revamped [16:43:22] that sounds like something upstream could fix quickly if someone files a bug? [16:44:52] MatmaRex: yep, tried it again, only see the 200 (but I definitely didn't imagine the 307) [16:45:37] milimetric: maybe you were looking at REST APIs? those behave differently [16:47:07] the only place in mediawiki where i see anything about 307 statuses is indeed in the rest api [16:47:57] tgr_: I only opened the dev console on Chrome, typed in en.wikipedia.org/wiki/Obama and pressed enter [16:48:34] in any case, so we see a 200 for Obama, but the content is the HTML render of the wikitext under Barack_Obama - so where does that happen? [16:48:35] e.g. https://en.wikipedia.org/w/rest.php/v1/page/Obama/html issues a 307 [16:49:13] somewhere in MediaWiki, the Article class maybe? [16:49:38] gotcha, ok, so Varnish doesn't know about it, MW resolves the redirect and caches it that way under /wiki/Obama [16:49:40] cool, interesting [16:50:34] here: https://gerrit.wikimedia.org/g/mediawiki/core/+/0e1a3b2aab46e86a6e80957142f851f845c61e07/includes/Actions/ActionEntryPoint.php#637 [16:53:46] hashar: filed as T418514. The laziest solution with decent access control would be using a paste. [16:53:47] T418514: Have an editable "CI broken" error message that can be displayed in Gerrit - https://phabricator.wikimedia.org/T418514 [18:37:19] ok, I found the write-up on redirects I was looking for, it was Marcel on our team that had written it a while back. I'll review, update, and link from the other places redirects are discussed [18:37:20] https://wikitech.wikimedia.org/wiki/Data_Platform/Data_Lake/Traffic/Pageviews/Redirects [18:37:36] thx much for your help above [19:10:13] cscott: every day that those TTL debug changes don't land is a day I spend focused on my day job, advancing the dark and eldritch schemes of my employer in ways too unspeakable to mention, instead of tinkering and improving WMF stuff. [19:10:49] think of the planet [19:14:31] lol