[17:16:18] Reedy: I'm doing some work with #wikimedia-fundraising for a couple months. If you rebase these two, I could review and land them :) https://gerrit.wikimedia.org/r/q/project:mediawiki/extensions/CentralNotice+is:open+owner:Reedy [17:16:31] zomg [17:16:43] I bet it's just jgit sucking [17:17:17] oh no, it conflicts with stuff that I know I wrote [17:17:18] lol [17:29:22] Krinkle: Rebased and stacked (because they seem to manage to conflict each other) [17:48:02] ack [19:07:24] Krinkle: do you know why ext-FlaggedRevs.php never happened with https://phabricator.wikimedia.org/T308932 ? [19:44:51] I could see why it would tricky though, with FlaggedRevsSetup::doSetup and all (though most of those settings would not be affected and could go in an ext- file). I guess it would have to be piecemeal though. [19:55:54] MatmaRex: https://phabricator.wikimedia.org/T420522 is this desired behaviour? [19:57:14] Reedy: yes. do you hate it? [19:58:01] Not completely [19:58:10] the vertical movement annoys me though :P [19:59:01] It's truncated to a nice character (ie a /) [19:59:37] those stashbot comments are rally long sometimes and 99% of people don't need them [20:00:07] e.g. https://phabricator.wikimedia.org/T419895#11722958 [20:00:30] and that's not even the worst example, just one from today [20:01:16] there shouldn't be vertical movement when the comment fits on one line. CSS is the worst though, so it's not perfect. i'll try to take another look at that some time [20:01:46] but i haven't had the time to work on improvements to the phab styles in weeks, people keep inventing new urgent problems i need to take care of [20:01:57] heh [20:02:29] there should also be an ellipsis "…" where it's truncated. maybe that doesn't work with nested code markup in the log line [20:02:40] which task is that in the video? [20:04:03] https://phabricator.wikimedia.org/T404363 [20:04:07] I just added that to the bug desc [20:07:13] thanks [20:07:25] i'll put that on my todo list next to https://phabricator.wikimedia.org/T416964 [20:08:24] thanks :) [20:08:59] i claimed it, so that andre will remind me if i don't do it within 2 years :P [20:18:45] :D