[19:10:36] <MatmaRex>	 Reedy: these backports won't work on REL branches: https://gerrit.wikimedia.org/r/q/I0faf859e7e7beac98c790bf6589e6cfa0b7ae7da since i only added CentralAuthServices::getApiTokenManager() on master in https://gerrit.wikimedia.org/r/q/I371b75237e8265092f30d5e8fcfba602fbf64685
[19:10:58] <Reedy>	 Why didn't CI complain...
[19:11:00] <MatmaRex>	 Reedy: it shouldn't be necessary to backport those, though, that was just cleanup
[19:11:10] <MatmaRex>	 good question
[19:11:25] <Reedy>	 no phan?
[19:11:31] <MatmaRex>	 idk if tests cover this, but Phan should complain
[19:11:39] <MatmaRex>	 but apparently we don't run POhan on REL branches. huh
[19:11:42] <MatmaRex>	 Phan*
[19:12:29] <MatmaRex>	 and, um, it doesn't look like we run PHPUnit either
[19:13:04] <Reedy>	 https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php82/24732/console
[19:13:16] <Reedy>	 Not on all PHP versions
[19:13:25] <MatmaRex>	 oh, yeah, that one has PHPUnit. i see
[19:13:25] <Reedy>	 (phpunit anyway)
[19:13:59] <SomeRandomDev>	 We should really run phan on release branches, this would've prevented https://phabricator.wikimedia.org/T421995
[19:15:04] <MatmaRex>	 anyway, the 3 backports here https://gerrit.wikimedia.org/r/q/I0faf859e7e7beac98c790bf6589e6cfa0b7ae7da need reverting
[19:15:18] <MatmaRex>	 oh, you're doing it. thanks
[21:48:03] <Krinkle>	 T226945
[21:48:03] <stashbot>	 T226945: Decide on future of running Phan tests on release branches - https://phabricator.wikimedia.org/T226945
[21:48:10] <Krinkle>	 2019
[21:48:40] <Krinkle>	 T231966
[21:48:41] <stashbot>	 T231966: Phan job should use composer instead of vendor for release branches ( undeclared class \Wikimedia\Equivset\Equivset ) - https://phabricator.wikimedia.org/T231966