[11:53:22] TIL you can yield the same key twice from a generator in PHP. https://3v4l.org/XMhhO#v8.2.0 [13:18:25] well, you'd have to build an array of past keys to prevent it, and avoiding that is the entire point of generators [15:39:30] how on earth did you come across that? (Kri nkle) [20:47:08] apergos: I was post-merge reviewing https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1298732/10/includes/Mail/UserMailer.php because it adds a new library (Symfony, so no sec review, although it does include an odd transient dependency on something called `egulias/email-validator`) [20:47:38] it also takes a bit of an odd approach in exporting headers and then using raw sending rahter than Symfony's documented/recommended way of sending emails. [20:47:44] so I was looking for differences/lossy conversion. [20:48:36] we seem to export it pre-send in order to satisy a hook. I suppose another way to do that would be to store it as arrays, or to translate anything the hook does back into setHeader() calls and keep the $email object as the way to send it. Thus preserving anything not modified by hook. [20:48:46] It seems all hook consumers only add, not read, so might not even be needed. [20:50:18] it's by a fairly new contributor as well, and it's a major change to file a task and carry out with little discussion so that stood out in my weekly Gerrit mail. [20:51:03] anyway, it's unowned, so who is to say that anyone should do to it. [20:51:16] https://www.mediawiki.org/wiki/Developers/Maintainers#Email [21:32:21] another item for the ownership project [21:32:40] "fun" to see that the windows problem goes all the way back to 2006