[01:39:20] Reedy: RoanKattouw: see my comment at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/1372099 - hope that helps :) [01:40:26] Reversing "Replace stub(obj, method, fn) with stub(ob, method).callsFake(fn)" should do it. [01:41:38] Note that the old syntax via this.sandbox does work on latest master too, so that could've been a universal patch. [02:25:47] Krinkle: Thanks! I should be able to upload a new patch in about 2 hours [03:55:52] 03:52:29 /src/tests/qunit/ext.math.popup.test.js [03:55:52] 03:52:29 3:1 error 'QUnit' is not defined no-undef [03:55:52] 03:52:29 4:2 error 'QUnit' is not defined no-undef [05:03:44] 2 VE patches and one OATHAuth on master left [05:04:03] When the 1.43.12 prep patch lands, I'm tagging it, then to bed (as it's after 5am) [05:09:05] Oh, and everything not bundled is TODO [05:09:16] CI is still fairly backed up, and i18n updates coming too, yay [05:14:16] That's over 200 commits landed