[01:28:50] <Lestat9>	 Near Death Experiencer / Ghost Person Chat site - 47.203.235.203
[02:42:32] <danielyepezg>	 Can I submit a patch from vscode.dev?
[02:50:42] <moonmoon>	 most projects are on gerrit, although a small number are on gitlab
[02:50:51] <moonmoon>	 as long as vscode.dev can submit to either of those, then sure
[02:53:44] <danielyepezg>	 That is, from a mirror repo on Github I can send the patch?
[02:54:45] <moonmoon>	 no
[02:55:53] <moonmoon>	 see https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker and https://www.mediawiki.org/wiki/Gerrit/Tutorial
[02:57:09] <moonmoon>	 pull requests raised against github mirrors will be automatically closed
[03:02:36] <danielyepezg>	 In the same way I will do them directly to Gerrit
[03:05:33] <danielyepezg>	 Is it necessary to put the changeid or how do I look at that? I don't want to make a fool of myself on my first commit.
[03:19:25] <moonmoon>	 the change-id is automatically added as part of the commit hook set up when following the linked tutorial
[03:19:36] <moonmoon>	 (specifically by installing the git-review plugin)
[03:24:30] <danielyepezg>	 say "Your change was committed before the commit hook was installed. Amending the commit to add a gerrit change id. danielyepezgarces@gerrit.wikimedia.org: Permission denied (publickey). fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists."
[03:33:56] <moonmoon>	 did you create a wikimedia developer account?
[03:34:34] <moonmoon>	 if no, see https://www.mediawiki.org/wiki/Gerrit/Tutorial#Create_a_Wikimedia_developer_account
[03:34:42] <moonmoon>	 if yes, see https://www.mediawiki.org/wiki/Gerrit/Tutorial#Set_Up_SSH_Keys_in_Gerrit
[03:35:00] <moonmoon>	 if you have questions with any of those instructions, or something seems to not being working with them, post back here
[03:36:41] <danielyepezg>	 Yes i have 
[03:37:07] <danielyepezg>	 I think, need the Trusted-Contributors permissions
[03:37:21] <danielyepezg>	 Since it is a patch for Wikibase
[03:38:01] <moonmoon>	 so if you do ssh -p 29418 danielyepezgarces@gerrit.wikimedia.org it says that you've successfully connected?
[03:38:45] <moonmoon>	 trusted-contributors shouldn't be needed to send up a new patch, regardless of repo
[03:38:56] <danielyepezg>	 https://usercontent.irccloud-cdn.com/file/GzwVIXh8/image.png
[03:39:07] <danielyepezg>	 ok wait and i tried other method
[03:41:44] <moonmoon>	 what OS are you using?
[03:43:28] <danielyepezg>	 Windows and sometimes I use WSL
[03:43:34] <danielyepezg>	 Debian distro
[03:43:54] <moonmoon>	 ok, and are you using WSL to send up the patch or windows itself?
[03:44:30] <danielyepezg>	 Windows, I already tried my second option which was cloning via SSH but it didn't work either
[03:45:07] <moonmoon>	 ok
[03:45:17] <moonmoon>	 are you using command prompt or git bash or some other method to submit the patch?
[03:45:52] <danielyepezg>	 Because for example I see that a user has the Trusted contributors permission and is patching things like the one I am going to send.
[03:46:00] <danielyepezg>	 i use VSC
[03:46:29] <danielyepezg>	 and I put "git review" and I get that message that says I don't have the permission
[03:49:57] <moonmoon>	 hmm
[03:50:29] <moonmoon>	 was your SSH test from earlier also inside of VSC or was that in a command prompt or other window?
[03:52:14] <moonmoon>	 what I'd try is doing git review via the git bash prompt and see if that works. If so, then there is some setting in VSC where you need to instruct it to use your key. however I'm not finding such a setting in a search and I don't use VSC myself so you've reached the limits of my knowledge on this matter :(
[03:52:20] <moonmoon>	 perhaps someone else will be able to assist
[03:55:28] <danielyepezg>	 Don't worry, as I said, it could be the permission issue, there's no other way :)
[03:57:04] <danielyepezg>	 I haven't even been added to that list :')
[05:54:40] <p858snake|cloud>	 trusted-contribs is only needed if you are amending some elses patchset
[05:55:40] <p858snake|cloud>	 https://www.mediawiki.org/wiki/Special:MyLanguage/Gerrit/git-review#Windows
[06:48:55] <danielyepezg>	 p858snake|cloud, I've tried every possible way and I still get the same error
[06:49:55] <p858snake|cloud>	 can you copy the exact commands you are doing into a pastebin somewhere? (eg: https://dpaste.org/)
[06:55:47] <danielyepezg>	 Well I make the commit and then I put "git review" and it comes out https://www.irccloud.com/pastebin/fz3DnnLy/
[07:08:01] <danielyepezg>	 I achieved it after 4 hours :D
[14:43:42] <bawolff>	 danielyepezg: Can you tell me (paste to dpaste) the output of: git push ssh://danielyepezgarces@gerrit.wikimedia.org:29418/mediawiki/core.git HEAD:refs/for/master
[14:44:13] <bawolff>	 danielyepezg: (That's assuming you are trying to contribute a patch to core, change the repo name to whatever repo you are trying to make a patch to
[14:45:19] <bawolff>	 err, i meant to include a -v in there: GIT_SSH_COMMAND="ssh -v" git push -v ssh://danielyepezgarces@gerrit.wikimedia.org:29418/mediawiki/core.git HEAD:refs/for/master
[14:45:57] <bawolff>	 (That might only work on linux)
[14:46:29] <bawolff>	 danielyepezg: if you absolutely can't get ssh to work, you can also push to gerrit with https instead of ssh. However the password is not your normal password, but one set in your prferences in the gerrit web interface
[17:31:59] <danielyepezg>	 How to submit an update to a patch?
[17:43:07] <Vulpix>	 danielyepezg: https://www.mediawiki.org/wiki/Gerrit/Tutorial/tl;dr#Update_your_patch
[17:43:51] <danielyepezg>	 Yeah, but git review doesn't work for me
[17:44:05] <danielyepezg>	 y use  git push-for-review
[18:52:03] <bawolff>	 danielyepezg: You just need to ammend your previous patch (e.g. Edit some files, do `git add` for the files you changed, and then `git commit --amend` ). After you ammended the patch locally, you should just be able to run `git push-for-review`
[18:52:21] <bawolff>	 I'm assuming git-push-for-review here is just an alias for git push origin HEAD:refs/for/master
[23:36:35] <KiDa44>	 Hello,
[23:36:36] <KiDa44>	 I'm currently facing an issue with OpenID Connect (OIDC) extension and could use some assistance troubleshooting the problem. As the title suggests, I'm encountering a redirect loop after my SSO provider (Keycloak) redirects to Special:PluggableAuthLogin on my MediaWiki site. The redirects between Keycloak and Special:PluggableAuthLogin seem to be
[23:36:36] <KiDa44>	 happening infinitely.
[23:36:37] <KiDa44>	 PluggableAuth passes to OpenIDConnect which gives another redirect back to Keycloak
[23:36:37] <KiDa44>	 I've verified that Keycloak is sending the correct query parameters back to PluggableAuthLogin, so I'm not sure where the issue is.
[23:36:38] <KiDa44>	 Here are the versions I'm running:
[23:36:38] <KiDa44>	     MediaWiki 1.39.10
[23:36:39] <KiDa44>	     PluggableAuth 7.1.0 (db07c04)
[23:36:39] <KiDa44>	     OpenID Connect 8.0.3 (0cd85ca)
[23:36:40] <KiDa44>	  Here is a debug log too: Topic:Yg0wtew7lklqijwy
[23:49:40] <KiDa44>	 Debug log link: https://dpaste.org/69o1P