[00:00:11] <Svellere>	 Wiki had been on 1.41 recently, updated to 1.43. Did not have GlobalBlocking installed prior, just tried installing today on 1.43.
[00:01:08] <Svellere>	 I created a DB called centralauth, I gave all other wiki DB users full privileges on that DB, I copied the mentioned sql file into that DB, and I ran the update script on all wikis, with --doshared on the central wiki update script.
[00:01:36] <Svellere>	 and in my LocalSettings.php I have:
[00:01:36] <Svellere>	 $wgSharedDB = 'meta';
[00:01:37] <Svellere>	 $wgSharedTables = array_merge( $wgSharedTables, ['user', 'user_properties', 'user_autocreate_serial', 'actor', 'spoofuser', 'global_user_groups'] );
[00:01:37] <Svellere>	 $wgVirtualDomainsMapping['virtual-checkuser-global'] = [ 'db' => $wgSharedDB ];
[00:01:38] <Svellere>	 $wgVirtualDomainsMapping['virtual-globalblocking'] = ['db' => 'centralauth'];
[00:02:10] <Svellere>	 and no I do not have the centralauth extension installed, I just liked the name better than globalblocking
[00:02:42] <Reedy>	 user_autocreate_serial pg?
[00:03:09] <Reedy>	 oh, no
[00:03:50] <Svellere>	 I guess that doesn't need to be in there since 1.39, but isn't harming anything either way
[00:04:24] <Reedy>	 weird new tables slip in quietly
[00:06:42] <Svellere>	 Increased to 512MB, still same issue, so yeah, it's not that.
[00:07:05] <Svellere>	 I tried the 1.42 release of GlobalBlocking as well, no difference.
[00:07:10] <Reedy>	 Are you using autopromote with APCOND_BLOCKED ?
[00:07:18] <Svellere>	 uhhhh no idea what that is
[00:07:29] <Reedy>	 Probably not then
[00:07:48] <Reedy>	 that's about the only reported performance issue I can obviously see wrt that extension
[00:08:19] <Reedy>	 You can certainly file a bug about it... or read into how to do performance/memory profiling for PHP
[00:09:14] <Svellere>	 All I did was follow the instructions at the top of the extension page, so yeah I am not sure if maybe I missed something or did something wrong
[00:09:48] <Reedy>	 If you can, it may be worth trying to increase the memory limit a lot (1GB? 2GB?) and see if things start working
[00:09:50] <Svellere>	 I grabbed tables-generated-globalblocks.sql from the extension folder, which I assume I was supposed to do, since it didn't specify.
[00:10:08] <Reedy>	 If it is still failing...
[00:12:20] <Svellere>	 Still failing, just takes a whole lot longer to spit out the error.
[00:12:27] <Svellere>	 Beautiful memory spike in GCP overview.
[00:13:23] <Reedy>	 o_0
[00:13:36] <Reedy>	 It feels like your setup has some sort of recursive/similar stack overflow
[00:14:18] <Svellere>	 I haven't customized anything wrt MW code. Just set custom favicons/logos, changed some basic stuff like footer text, and set up shared user tables + checkuser extension.
[00:14:49] <Svellere>	 If you want to see the full setup, I made a blog post on my company website that's a tutorial going over exactly how I set up my install, because I couldn't find a comprehensive resource when I was doing it myself.
[00:15:22] <Svellere>	 but it's just info aggregated from mediawiki.org pages + some youtube videos
[00:15:36] <Reedy>	 like I say, it kinda needs a stack trace/similar to even start working out where the issue is
[00:15:51] <Svellere>	 Hmm
[00:15:54] <Reedy>	 random memory exhaustion lines unfortunately don't tell people much for complex stuff
[00:18:48] <Svellere>	 Let me see if I can get xdebug going
[00:30:25] <Svellere>	 How do I download a release as a .zip from the MW gerrit?
[00:30:41] <Svellere>	 Want to try 1.41 release of GlobalBlocking because I know a wiki using it where it works fine
[00:31:01] <Svellere>	 Nvm I am blind, I found the download link
[00:31:34] <Reedy>	 heh
[00:31:44] <Reedy>	 Note there may be other incompatilibity issues
[00:31:59] <Svellere>	 Yeah I figure there may be
[00:34:02] <Svellere>	 1.41 works
[00:34:07] <Svellere>	 1.42 and 1.43 do not
[00:34:30] <Reedy>	 curious
[00:35:22] <Reedy>	 Definitely might be worth filing a bug in phabricator
[00:36:35] <Reedy>	 1.42 introduced numerous new services...
[00:36:43] <Reedy>	 (in GlobalBlocking)
[00:37:12] <Reedy>	 Wouldn't be a complete surprise if there's some edge case in there that when run without CentralAuth...
[00:38:08] <Reedy>	 And if it's replicable on a fairly vanilla MW install...
[00:40:35] <Reedy>	 Dreamy_Jazz: ^^
[00:41:10] <Svellere>	 Filing a bug, though not super sure what to name it
[00:41:28] <Reedy>	 OOM in GlobalBlocking
[00:41:33] <Reedy>	 or something is good enough
[00:42:06] <Dreamy_Jazz>	 Question: Do you have `$wgBlockDisablesLogin = true;`?
[00:42:11] <Reedy>	 heh
[00:42:17] <Svellere>	 Yes
[00:42:29] <Dreamy_Jazz>	 We saw this issue and made a fix for 1.44
[00:42:32] * Reedy looks for the popcorn
[00:42:38] <Reedy>	 Backport to be done?
[00:42:40] <Svellere>	 Will disable that for now then
[00:42:40] <Dreamy_Jazz>	 This is a problem from MediaWiki core that was exposed by GlobalBlocking
[00:43:14] <Reedy>	 Fancy digging it out?
[00:43:21] <Dreamy_Jazz>	 The phab task is https://phabricator.wikimedia.org/T384197
[00:43:42] <Dreamy_Jazz>	 Applying the patch https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1124753 to previous release versions should fix the issue
[00:43:53] <Reedy>	 test conflicts
[00:43:58] <Reedy>	 (quelle surprise)
[00:44:10] <Reedy>	 just gerrit being stupid, as always
[00:44:33] <Dreamy_Jazz>	 It should be fine to backport without tests if needed
[00:44:42] <Dreamy_Jazz>	 The fix added the tests to regression test it
[00:44:54] <Dreamy_Jazz>	 but the fix is fairly un-complicated
[00:45:54] <Reedy>	 just where it was in the file, the context it was missing/in between is 250-300+ lines
[00:46:01] <Reedy>	 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1127179
[00:46:26] <Reedy>	 same again to REL1_42 (from REL1_43)
[00:46:29] <Reedy>	 ahhh jgit
[00:46:40] <Dreamy_Jazz>	 Will need to backport the fix to REL1_43 and REL1_42, as since REL1_42 we have supported global account blocks which was the feature that exposed the problem
[00:47:00] <Dreamy_Jazz>	 Before REL1_42 should be fine AFAIK
[00:47:12] <Reedy>	 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1127180
[00:47:53] <Dreamy_Jazz>	 +2'd
[00:48:08] <Reedy>	 Should've pinged you earlier ;)
[00:48:27] <Svellere>	 Can confirm everything is working after setting `$wgBlockDisablesLogin` to false.
[00:48:40] <Reedy>	 Svellere: they'll be merged into the git branches in the next 30 minutes (at worse case)...
[00:48:49] <Reedy>	 next releases for the branch is due at the end of the month
[00:49:09] <Svellere>	 Aha good to know, I'll be sure to update next month then.
[00:49:13] <Dreamy_Jazz>	 Thanks. If you also have FlaggedRevs installed on your wiki, there may be additional issues which we have not fixed yet with `$wgBlockDisablesLogin`
[00:49:30] <Svellere>	 I do not have that installed, if it's an extension.
[00:49:36] <Dreamy_Jazz>	 Yes, it is an extension
[00:50:57] <Svellere>	 One question, is it expected behavior that adjusting Special:GlobalUserRights will not reflect in a local wiki's Special:UserRights page?
[00:51:14] <Svellere>	 Poor will getting pinged all the time
[00:52:47] <Dreamy_Jazz>	 Yes. The systems are separate and so it's different places being updated when you use the form.
[00:54:24] <Dreamy_Jazz>	 However, the global user groups will still give the functionality on the local wiki (as long as the global group is enabled on that wiki).
[00:55:09] <Svellere>	 Ah okay gotcha, just making sure.
[00:56:22] * Dreamy_Jazz goes afk
[00:57:26] <Svellere>	 Thanks for the help :) Cya