[05:41:23] <MirahezeRelay>	 <ugochimobi, replying to cosmicalpha> Deleted permanently
[05:41:34] <MirahezeRelay>	 <cosmicalpha> Okay
[05:41:59] <MirahezeRelay>	 <ugochimobi> @agentisai any update on the vanish?
[05:43:43] <MirahezeRelay>	 <cosmicalpha> I'll deal with your Phabricator account tomorrow I forgot I need to use shell to permanently delete and I am off that for tonight.
[16:33:33] <Orange_Star>	 Is using globals in PHP an unforgivable sin?
[16:33:44] <Orange_Star>	 I mean outside of stuff like MediaWiki config
[16:59:37] <Orange_Star>	 nevermind, it wouldn't even work for what I want them
[17:21:09] <RhinosF1>	 Orange_Star: globals should die
[17:21:44] <Orange_Star>	 global 4 teh win 
[17:23:37] <Orange_Star>	 Is the only way I see to do https://phabricator.miraheze.org/T7582#234392
[18:13:58] <Orange_Star>	 I'm going insane/msg 7
[18:14:01] <Orange_Star>	 oops
[18:25:19] <MirahezeRelay>	 <originalauthority> Just get an instance via `RequestContext`
[18:25:52] <Orange_Star>	 I was speaking with RhinosF1 on DM about another thing
[18:26:38] <Orange_Star>	 I can't test it since I don't have RequestSSL locally installed, but I was thinking that you could just get the status at the beggining of ->submitForm()
[18:26:59] <Orange_Star>	 Then just check it before calling ->updateManageWiki
[18:27:23] <Orange_Star>	 But I must be missing something
[18:27:35] <MirahezeRelay>	 <originalauthority> That's why I haven't done any work on it. It's a whole palava to get ManageWiki installed etc.
[18:29:09] <MirahezeRelay>	 <originalauthority> from what I'm understanding, we need to know the status, so updateManageWiki should only be called once the status changes?
[18:29:27] <Orange_Star>	 Yes
[18:29:39] <Orange_Star>	 once it changes to completed more specifically
[18:30:15] <MirahezeRelay>	 <originalauthority> surely just storing `$oldStatus` as a variable and then checking if its completed would work?
[18:30:35] <Orange_Star>	 that's what I'm thinking
[18:31:04] <MirahezeRelay>	 <originalauthority> [1/12] which seems to be what:
[18:31:04] <MirahezeRelay>	 <originalauthority> [2/12] ```php
[18:31:04] <MirahezeRelay>	 <originalauthority> [3/12] public function updateManageWiki ( string $remotewiki ) {
[18:31:05] <MirahezeRelay>	 <originalauthority> [4/12]         $status = $this->getStatus;
[18:31:05] <MirahezeRelay>	 <originalauthority> [5/12]         if ( $status == 'complete' ) {
[18:31:05] <MirahezeRelay>	 <originalauthority> [6/12]             $remoteWiki = new RemoteWiki( $this->getTarget() );
[18:31:05] <MirahezeRelay>	 <originalauthority> [7/12]             $remoteWiki->setServerName( $this->getCustomDomain() );
[18:31:06] <MirahezeRelay>	 <originalauthority> [8/12]             $remoteWiki->commit();
[18:31:06] <MirahezeRelay>	 <originalauthority> [9/12]         }
[18:31:06] <MirahezeRelay>	 <originalauthority> [10/12]     }
[18:31:07] <MirahezeRelay>	 <originalauthority> [11/12] ``` 
[18:31:07] <MirahezeRelay>	 <originalauthority> [12/12] is doing so I'm confused even more.
[18:31:35] <Orange_Star>	 No that's just checking that the status is complete
[18:31:52] <Orange_Star>	 problem is it will run everytime someone comments on a completed request
[18:32:00] <Orange_Star>	 I was thinking something like $oldStatus = $this->requestSslManager->getStatus() at the beggining of ->submitForm
[18:32:21] <Orange_Star>	 I keep going over the code and see no reason why it shouldn't work, but I'm not sure
[18:32:33] <Orange_Star>	 Too bad there's no CI
[18:32:48] <MirahezeRelay>	 <originalauthority> right yeah I see https://github.com/Reception123/RequestSSL/blob/a2f4ca3f7a5609f9ccc6caaf80011eb513d5cb21/includes/RequestSSLViewer.php#L558
[18:33:21] <Orange_Star>	 Then you would compare it with the one from $formData
[18:34:28] <MirahezeRelay>	 <originalauthority> without actually physically looking at what is happening when something is submitted, its hard
[18:35:22] <MirahezeRelay>	 <originalauthority> But I'm not sure why anyone would comment on a completed request, anyway, so I'm not sure why it matters, but
[18:36:14] <Orange_Star>	 it spams the logs?
[18:36:24] <Orange_Star>	 Also could maybe cause issues with step4
[18:37:54] <MirahezeRelay>	 <originalauthority> perhaps splitting the function up into two, one for a comment, and one for when managewiki needs to be updated with the domain. Idk
[18:38:24] <Orange_Star>	 Anyone wants to wire me some $$$ for the GitHub CI to test? :)
[18:41:07] <Orange_Star>	 I'll just submit the original idea and let SRE test on mirabeta.
[18:55:54] <Orange_Star>	 Done https://github.com/Reception123/RequestSSL/pull/4