[01:12:35] I freaking had to remove all punctuation and spaces in my request in order not to get a “wiki request contains an invalid character” wtf [01:14:33] My request with punctuation and spaces are in the comments [01:28:53] some dumb bug maybe [01:41:22] MediaWiki/ManageWiki being drunk [06:06:46] [1/3] lol @pixldev you created the exact same task twice? [06:06:47] [2/3] https://issue-tracker.miraheze.org/T12502 [06:06:47] [3/3] https://issue-tracker.miraheze.org/T12534 [06:30:01] heh [06:30:06] he forgot it seems [06:30:28] Morning @cosmicalpha @agentisai [06:30:36] Neither of you should be awake at this time [06:30:59] It's like 3pm for CA iirc [06:31:17] as for me, you're right [06:31:38] Oh is @cosmicalpha still is AUS or back US? [06:36:57] Still AUS [06:38:09] Till the end of this month [06:39:07] @rhinosf1 btw I love some of the new features on Phorge lol. Finally better menus on mobile, and other things [06:39:21] Ye I saw [06:39:39] Phorge was a good idea [06:39:54] I saw Wikimedia switched also? [06:39:56] I'm surprised it's been so long since they forked though [06:40:01] Yes [06:40:14] Doesn't feel like that long ago we were using phab before they abandoned it [06:41:00] Its been about 10 months since switching to Phorge lol [06:41:15] They abandoned phab a while ago though [06:41:23] But it hadn't been updated since until yesterday [06:41:25] It's been quite a few years now [06:41:37] Oh wow really? I thought that was recent [06:42:07] June 1st 2021 [06:42:12] So 3 years now [06:42:42] Wow I can't believe that. I remember that announcement I can't believe it has been 3 years lol [06:44:00] oh wow [06:44:08] incredible [06:47:36] [1/2] Oh hey that's new lol [06:47:36] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1280418905759940649/Screenshot_20240903_144722_Chrome.png?ex=66d80288&is=66d6b108&hm=d5106862522d866d1143313d6a28b22d0b5a5c20310a74101dd953229d05461c& [06:48:51] nice to see Phorge is getting updates [06:48:59] I wonder what else is new [06:50:19] FIDO2 support, mobile menu improvements, and a lot of bug fixes. [09:27:55] i'm here waiting for https://issue-tracker.miraheze.org/T12371 to be public [09:34:57] What I'd really like is herald to be able to also automatically change workboards [09:35:16] Or for integrated canned responses [09:35:40] i feel like herald wouldn't be the best tool for manually invoked canned responses [09:35:51] (not like i've used it before, but i think it reacts to events?) [09:36:09] auto change workboards would be nice, e.g. CSP Review Pending Addition -> Completed [11:10:42] @bluemoon0332 the cloudflare api is a mess of a trial and error [11:11:13] I guess [11:13:53] BIND is quite the change from gdnsd [11:18:36] Software replacements often are [12:29:27] hi BlankEclair [12:35:10] hello PixDeVl [12:35:26] i did a gerrit [12:35:36] i noticed <3 [12:36:01] not as painful as expected [12:36:10] although the gerrit backlog is nuts [12:36:40] pix gon [13:02:34] wow not even 24h and my patch is already 4 pages in [13:02:40] i feel bad for the reviewers [13:02:58] wha? [13:03:34] PixDeVl: you didn't assign any reviewers, that's going to make it impossible to find your change [13:03:42] oh [13:03:59] oh [13:04:23] i thought it would be rude/presumptuous to randomly assign someone to a patch [13:04:42] how do extension maintainers know when to review? do they get a notif when a patch set been made to a repo they control? [13:05:11] some have a bot that automatically adds them to cc, I remember reading that [13:06:12] There is a listed maintaner for the extension [13:06:14] PixDeVl: "You are encouraged to invite one or two maintainers as reviewers on your change. [...] If you don't know who to invite for reviewing, check the maintainers list for the component you've modified, or ask on IRC (#mediawiki)" [13:06:20] They don't seem super active [13:06:21] from https://www.mediawiki.org/wiki/Gerrit/Tutorial/tl;dr [13:06:36] how did i miss that [13:07:15] https://www.mediawiki.org/wiki/Special:Contributions/FreedomFighterSparrow not super active on wiki, ill look for their gerrit [13:08:15] aaand im not logged in on my laptop [13:08:28] aaand the password was a jumble stored on my PC [13:08:30] great [13:09:10] found him https://gerrit.wikimedia.org/r/q/owner:FreedomFighterSparrow@gmail.com [13:09:33] one patch since 2022 [13:14:08] should i try reaching out on their talk or just add them and wait [13:18:46] ill prob ask in #mediawiki [13:24:12] I took a look at your change: [13:24:24] [1/7] ```$wikiPage2->getParserOutput()->getCategoryNames(); [13:24:25] [2/7] = [ [13:24:25] [3/7] "Global_policies", [13:24:25] [4/7] "Documentation", [13:24:26] [5/7] "Global_user_groups", [13:24:26] [6/7] "Stewards", [13:24:26] [7/7] ]``` [13:24:56] after the extension runs that through all the array functions, you end with this: [13:25:03] [1/8] ``` [13:25:04] [2/8] > array_map( 'strval', array_keys(array_flip($wikiPage2->getParserOutput()->getCategoryNames()))); [13:25:04] [3/8] = [ [13:25:04] [4/8] "Global_policies", [13:25:04] [5/8] "Documentation", [13:25:05] [6/8] "Global_user_groups", [13:25:05] [7/8] "Stewards", [13:25:05] [8/8] ]``` [13:25:16] that's so stupid, just to end up with the same array you started with [13:26:38] the whole thing is a mess(i didnt touch those parts i think though) [13:26:46] its a miracle it lasted this long [13:29:29] made for 1.25 [13:30:03] im considering doing a full update to modern mediawiki standards to get practice with them when i have time and want to practice php [13:33:33] left a comment on the change [13:36:11] So you're saying the array_flip does nothing effectively? [13:36:22] Because that's not what I encountered in testing [13:37:20] no, I'm saying there's no need apparently for further processing of the return of ->getCategoryNames since we effectively get the same array we get from that method [13:37:49] all the array_flips, array_keys and array_maps serve no purpose [13:38:18] ah, ill look at it in a sec [13:38:38] side note updating a patch causes jenkins to need to be rechecked? [13:38:45] it probably was needed with the old methods, but with the new method in your change, it's not needed [13:38:49] yes [13:39:00] I'm on the whitelist so I can also run CI there [13:40:50] aight [13:41:11] i almost said alight(halfway between aight and alright) [13:41:28] i should update the README change log as well [13:49:47] alight can also mean to set on fire :3 [13:58:19] i didnt remember LMAO. in my defense I did search calendar on maniphest [14:05:48] [1/2] so basically this? [14:05:49] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1280529183214272625/QTo4gV6.png?ex=66d8693c&is=66d717bc&hm=eb3bfde9da71af8542b6c6362962f378b4bf727a77de25d11971da2c1b019db1& [14:06:15] also get rid of the comment [14:06:20] but yes, basically [14:07:09] https://cdn.discordapp.com/attachments/1006789349498699827/1280529522193596466/Y5wdtsB.png?ex=66d8698d&is=66d7180d&hm=6a92a91c3adbb74410474ded294bb94ec3f92c9c127296f1c5fd895c83068c94& [14:07:12] looks good [14:07:30] submit a new patch then [14:07:41] will, gonna update the readme [14:08:55] should i list the compatibility of older versions as until the version where the old method was deprecated or hard removed? [14:09:22] i think it was depre'd in 1.40? [14:09:52] yup [14:10:09] yup removed in 42 [14:10:29] I don't really know this extension's policy about this [14:10:37] hm [14:10:40] ill check on wiki [14:12:22] dont see [14:12:26] ill ask on irc [14:18:04] [1/2] the pain. it uses external links to link to the mw.org page, but in wikitext instead of markdown. pick a side [14:18:04] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1280532268598825031/qseO2b5.png?ex=66d86c1b&is=66d71a9b&hm=90415de7929fff7d3c71a799d1bf1ca87e7b4de2114fdbd9e9abf1a8bb5dffec& [14:29:07] > [04/09/2024 00:10] I don't really know this extension's policy about this [14:29:11] Master maintains backward compatibility. [14:31:22] someone mentioned doing a check for if the new method exists [14:31:32] should probably do that [14:32:10] well, no one is maintaining that extension in practice right? [14:32:53] not in practice [14:33:10] last update by a human seems to be 2017 [14:33:12] why not take over and just... not keep back compat in master [14:33:16] going off the change log [14:33:28] SMW does that and I hate it [14:33:46] smart [14:33:50] i am considering taking over maintenance if i wanna use it as proper practice, well, practice [14:33:54] does what [14:34:04] master back compat? [14:35:12] with the extension in Gerrit branches can be auto created everytime a REL branch is made in mediawiki so even better [14:35:29] i mean in this case i think it would just be a matter of wrapping the new and old code in a if statment using whatever the php way of checking for a method exists [14:35:40] we're getting close to the one month anniversary of https://github.com/miraheze/mw-config/pull/5633 [14:35:54] lmao [14:36:36] for the g calender thing do you think we(or i if you dont care) should add that functionality into your extension or a new one [14:37:08] at this point we should just make an iframe extension [14:37:24] i was thinking google embeds but yeah prob [14:37:40] is there a way to dynamicly check for entries in a CSP [14:37:56] csp is handled by nginx [14:38:25] drat [14:38:34] that being said, perhaps the extension could take in an array of hosts/paths/whatever in php [14:38:54] that way, you can have LocalSettings.php (or others) parse the .yml file and dynamically generate the allowlist from that [14:39:04] very brief i know, but iwanna eep [14:39:05] maybe [14:39:12] should rename it as well probably [14:39:35] we can figure it out more concretely at a later date [14:39:48] i die i mean start school tmr so [14:39:56] kk, nini, don't let the queers turn you gay <3 [14:40:03] I try [14:47:18] does backwards compatibility apply to php version as well or just MW [14:54:09] given arrayflip seems to cover all version mw used i think its finehttps://www.php.net/manual/en/function.array-flip.php [15:31:18] @bluemoon0332 patch pushed. also added the maintainer [15:31:26] time to wait for signs of life [15:32:18] can you recheck? [15:32:45] oh it ran [15:32:50] and failed [15:32:50] damn [15:40:05] weird it ran without a command when i commented and added the maintainer [15:40:09] not now though [15:40:55] oh no ran again [15:41:27] oh no comment didnt load [15:42:06] that was me: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AutoCreateCategoryPages/+/1070058/comments/76ec9e4b_16f9029d [15:42:09] [1/4] ```11:39:17 69 | ERROR | [ ] Expected 1 space after closing brace; newline found [15:42:09] [2/4] 11:39:17 | | (Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace) [15:42:10] [3/4] 11:39:17 69 | ERROR | [x] Whitespace found at end of line [15:42:10] [4/4] 11:39:17 | | (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)``` [15:42:11] si [15:42:18] you want a space agter [15:42:25] but complain theres whitespace [15:42:26] WHAT [15:42:57] wait ones marked with an x [15:44:42] let me check my reformat prefs [15:47:01] welp phpstorm really thinks its way is write [15:47:07] fuck it [15:47:47] see if this appeases it [15:58:38] @bluemoon0332 jenkins makes me want to die [15:58:44] any idea how to appease this dark god [15:58:58] new line below maybe? [16:04:56] There's a reason it used to be called jerkins on irc [16:05:48] im using that now [16:17:46] It's MaxSem's [16:54:37] actually how would setting up these damn lints locally work [18:22:37] anyways uh local testing aquired [18:38:11] hell yeeeeeaaa [18:38:21] @rhinosf1 new charts extension is on wmf beta [18:38:38] an early version at least [18:38:39] https://wm-bot.wmcloud.org/logs/%23mediawiki/ [18:38:46] https://commons.wikimedia.beta.wmflabs.org/wiki/Data:1993_Canadian_federal_election.chart [18:38:57] https://www.mediawiki.org/wiki/Extension:Chart/Project/Updates [18:39:14] @pixldev I heard [18:39:28] We probably won't see it for another year [18:40:02] i just happen to see it by chance looking through the wikitech-l list [18:41:32] https://meta.wikimedia.org/wiki/WMDE_Technical_Wishes/Sub-referencing#Sub-referencing_in_a_nutshell also neat [18:41:34] You should read Tech News [18:42:08] yea [18:42:16] im gonna sign up for the mailing list [18:42:23] or on wiki if there is one [18:42:45] there is! [20:22:36] Those mean composer can fix them automatically [20:22:56] With composer test -fix or some variant of that [20:24:17] oooh [20:24:29] yeah i just used compser fix [20:24:35] it was a confusing error [20:26:26] Also with phpstorm there is a mediawiki extension on the marketplace that will enforce codestyle as you type [20:26:37] ye i used it [20:26:44] didnt catch this though [20:27:37] the patch has a +2 from jerkins now [20:27:57] so now i just have to hope the maintainer awakes from their slumber [20:28:18] which may take a while [20:28:59]