[01:51:35] claire [01:52:09] im not sure "So fucking old i cant install it anyways" counts as passed security review IMHO but i wont argue /hj [01:54:33] PixDeVl: i mean, i didn't see any security issues [01:55:59] does... does the security review require me to review the libraries [01:56:43] not what i meant [01:56:51] i wouldnt know and doubt it [01:57:16] I can not believe how many race conditions I am finding in CW... [01:57:27] oh no [01:59:05] I'm not, it's had... how many authors and bandaids over the years? [01:59:22] Design by committee on a shaky foundation lends itself to a tangled mess. [02:00:16] Yeah... I finally fixed a race condition that prevents ManageWiki setting/extension/namespace cache from updating on all servers till like hours later. Not it works from what I've seen within a few minutes. [02:01:50] ...wait, is that maybe why setContainerAccess sometimes just fails mysteriously during instantiation? [02:02:08] That could be yes. [02:02:15] But it may be another issue also [02:02:15] (Actually that's probably just run-of-the-mill overtaxing our available resources, now that I think about it) [02:03:09] That bug has existed for years also. I think I also fixed issues with cache not purging on wiki creation leading to sporadic Wiki Not Found and when custom domains are added also, but those are harder to test so can't confirm. [02:04:07] I like having cache code I actually understand so it is easier to update and fix bugs lol [02:04:36] > code I actually understand [02:04:41] not in this house bucko [02:05:59] what do you mean you don't enjoy looking at obfuscated code? [02:06:24] (i do minified code, but shh) [02:06:46] lol [02:07:09] love it when the resourceloader debug parameter doesn't work on cloudflare wikis [02:07:40] tbf my rewrite to use PHP code is actually not that much better than the old JSON version but at least I actually understand it and can work with it to fix bugs lol [02:07:47] It doesn't? [02:08:18] oh wait is that issue fixed now? [02:08:43] oh fuck yeah finally [02:16:31] Okay I think I better stop trying to improve performance even more or I'll end up doing the opposite as I just did on beta for a second lol [02:16:48] Its to the point it can't get much better lol [12:04:15] i'm making a fairly complex special page for our wiki--should i try to squeeze the code in mw-config or should i make it an extension [12:09:48] Explain [12:09:51] I’m curious [12:10:27] pixldev: i'm making a special page where you can input a comic page url (e.g. https://rain.thecomicseries.com/comics/2), and it will redirect you to the wiki page for that comic page (e.g. Rain: 1: Prologue 1) [12:43:18] BlankEclair: why [12:43:28] RhinosF1: why by which part [12:43:41] why do you need it [12:43:51] we don't really like deploying wiki specific stuff [12:43:56] it's kinda annoying to search for the page name to get the page [12:44:01] why is it needed and why can't it be done as a gadget [12:44:20] can there be a task to discuss with tech [12:44:22] for some comicfury urls, i need to scrape the html to get the "global" id [12:44:38] though i suppose that could be done with External Data? [12:44:44] that sounds awful [12:44:57] i don't like making things javascript-only [12:45:06] but i'd like to see a task tbh before you start to see if it's something that can be done on-wiki [12:45:16] and see if it's something we're willing to deploy [12:45:17] hence a special page instead of a gadget [12:45:41] or if we can make it more usable for others [12:46:00] extensions have an overhead cost [12:46:15] and increase risk [12:46:32] so i don't like the idea of wiki specific extensions for niche special pages [12:46:39] unless we really have to do it [12:50:08] honestly i feel like this is too niche to be more useful for others [12:50:26] so i suppose i'll try to make my eldritch contraption in javascript instead, and use ExternalData for scraping [12:52:33] i wonder if i can still have a special page that kinda works like Special:BlankPage though, and i can fill it in at runtime [13:01:33] oh external data is disabled, hmm, guess i'll have to do SR/RC [13:04:30] you can use Special:BlankPage ye [13:05:20] i kinda want it to be on Special:ComicLinkToWikiPage [13:11:30] depending how tricky it is I would like to overhaul the admin links extension a bit [13:11:43] even if only for interface/contents [15:04:29] You can just hijack any special page that doesn't exist [15:04:37] Although it wont show in search ig [15:10:39] i guess... [15:11:31] tried it on my test install, if i set $wgSpecialPages then it emits warnings: https://files.catbox.moe/h64by3.png [15:13:00] unrelated but how would you feel if i used both regex and proper parser to handle wikitext [15:21:03] Yeah you need to also add the alias for the special page [15:21:51] Which is $wgExtensionMessagesFiles i think if not using extension.json [15:22:04] Instructions unclear [15:22:32] is it okay if i have a special page stub instead of a full-blown implementation? [15:22:58] hmm looks like $wgExtensionMessagesFiles needs a file, not sure how ideal that is [15:23:29] Rip [15:23:48] I can't see any harm in it I guess, but might want to check with @cosmicalpha [15:37:58] i'm gonna go sleep, but i'll check logs when i wake up [19:20:22] s [19:29:23] https://meta.miraheze.org/wiki/Special:RequestImportQueue/878#mw-section-comments - my import request failed multiple times; thankfully, I also made a Phorge task [19:33:31] t [19:44:47] Hello, I am extremely new to this and apologize if this is not possible, but I was wondering if there was a way for me to insert the Wikipedia Routemap template that uses Bsicon. I know how to create a basic one temporarily on Wikipedia but am having trouble migrating the template over to mine. [19:55:48] accidental type oops [20:11:38] Do you have a link to try template? [20:15:45] @urbanecm why does GrowthExperiments strictly require CommunityConfig when https://github.com/wikimedia/mediawiki-extensions-GrowthExperiments/blob/62214975134ff51824071b3430f3c544671968c9/includes/Util.php#L369 implies its optional [20:15:58] Cause we have Growth but not CommunityConfig [20:16:13] And I don't think we want CommunityConfig [20:16:50] Very good question. It shouldn't, or at least not now. I saw the patch, but didn't really look into it yet (PTO) [20:17:01] Thanks for the reminder though, I can review that tomorrow [20:17:15] @urbanecm ye paladox created https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/1075079 [20:17:22] Can you review tomorrow? [20:17:27] Ye you said [20:17:29] It's late [20:17:35] I will add you as reviewer [20:17:43] CommunityConfig is your code isn't it [20:18:00] Yeah. [20:18:27] I saw it missing triggered some issues for someone, but not sure what exactly. But I'll find out tomorrow and see what can be done [20:18:34] _is at a hackathon and 2 drinks in_ [20:18:44] Thanks! [20:24:09] Enjoy the hackathon! [20:24:11] And drinks [20:27:43] Is the alcohol free? [20:29:14] In england? [20:29:49] Doubt it, nothings free in england [20:30:07] Deleted an reposted lol i hate that edits dont mirror to IRC [20:35:33] Felenov: only thing you have to pay for [20:35:42] Everything else is free [20:36:09] £6.50 a cider [20:37:07] Jesus [20:37:23] Good cider tho? [20:37:26] Tell me its not darkfruit [20:37:38] Old mout pineapple & raspberry [20:37:49] Even worse [20:38:09] I like old mout [20:38:29] If its cider i tend to stick to carlin blackfruit or magnums on a push [20:38:57] Don't think I've had carling [20:39:27] I normally have old mout or rekorderlig [20:39:41] Its virtually the same as darkfruit but less acidic it doesnt give you wind [20:39:46] Rekordelig is okay yeah [20:40:21] At least alcohol is the only paid for thing [20:40:31] Like its work so everything else is free [20:40:46] And also it's prepaid so I don't even have to argue with oracle's shitty expenses system [21:05:48] MirahezeRelay: https://en.wikipedia.org/wiki/Template:Routemap [21:07:39] H u h [21:07:45] RhinosF1: Nice, the events I go to usually have the free booze [21:07:48] Are those all image pieces? [21:08:18] Yup [21:08:49] Felenov: only one of 6 nights [21:08:53] 5 nights [21:08:54] Guest4: well since the images are on commons if you enable instant commons on your wiki it should work(????7 [21:09:51] Normally importing from [[Wikipedia]] is bad but I don’t think there’s a clean version [21:09:52] [23:23:27] You work for oracle? [23:24:18] he doesn't [23:24:23] Oh [23:24:36] Wherever he works uses oracles expense software [23:24:42] Well last I heard he worked for the civil service or some public agency [23:24:44] Oh [23:24:56] I don’t drink tbh [23:25:09] Govem’nt [23:25:31] Bastards [23:25:57] I like fizzy drinks tbh [23:26:08] Diet Coke / Pepsi max. Occasional Fanta [23:26:15] I hate alcohol and carbonated stuff [23:26:20] That's no good for teeth (but i agree) [23:26:26] Booooo [23:26:28] Also can’t legally drink anyways [23:26:34] Thats rough [23:26:43] I wouldn’t anyways [23:26:56] I don’t understand why people like it [23:27:07] crazy [23:27:19] I love getting mortal on a night out [23:27:49] If you are sober don’t be around drunk people tbh [23:27:52] It’s not fun