[03:36:35] looking to watch this later haha [03:38:35] how coincident, hope that i18n changes are pushed to TW today [04:47:50] hmm? [05:32:30] today is Monday, which TW should pull the changes at the moment [05:32:49] ah [05:33:16] Yeah my rewrite broke a lot of CW i18n and moved a lot to MirahezeMagic. [05:33:40] at least there's no new security vulnerabilities :p [05:33:53] Thats always a bonus lol [05:34:57] a bonus that everybody will dances for it (if there really is none) [05:35:39] i mean, i didn't find any new ones during the review [05:35:45] the 80 comment review... [05:39:02] Up to you [05:39:04] I actually watched for new messages, so yea, I'm already saw the changes get pulled [05:39:19] that's an old one, not new :p [05:39:47] time to update my security trinklets page... blep [05:42:28] last post on Community Portal, eiki not created [05:43:13] what's funny, it's the 50k-th request lol [05:44:06] [05:44:40] awh :( [05:44:49] something broken with the job queue? [05:49:05] I will fix that in a second [05:52:27] Fixed [06:02:33] ah logged out again 🥲 [06:02:52] mood [11:02:29] how graph stuff looked, again? was it used on Meta? [11:02:57] because I only remembered people asking for help w/ timeline [12:06:50] @cosmicalpha something's gone wrong [12:06:52] https://cdn.discordapp.com/attachments/1006789349498699827/1292820438468264090/image.png?ex=6705205b&is=6703cedb&hm=14bf02c3391063a2d6f0acc4da92541034a2b5c703aefffe9a0acfd6e60765b8& [12:07:23] huh? [12:07:34] What is the problem? [12:07:35] for https://meta.miraheze.org/wiki/Special:RequestWikiQueue/4975 [12:07:41] I certainly didn't request that wiki but that's the email I got [12:07:52] I only commented on it and requested more details [12:07:56] but CW seems to think I'm the requestor [12:08:30] Thats should be impossible more likely it is sending the same email to all involved users [12:08:40] @suzuneu did you also get a notification? [12:08:53] well in any case it wouldn't be good [12:09:25] as long as at least the error doesn't affect non-WCs that's not so dramatic but it'd still probably be nice not to have it [12:09:43] Well it isn't necessarily an issue it is a bug but it isn't like a UBN I don't think. I will take a look soon. [12:10:14] Wait 4975, from years ago? [12:10:29] That is an issue if you suddenly got that email... [12:10:41] oh no, I copied it wrongly [12:10:42] https://meta.miraheze.org/wiki/Special:RequestWikiQueue/49750 [12:10:47] oh lol [12:11:02] oh no, it would've been high if it affected non-WCs but if it's just sending out wrong emails to WCs it's not that bad [12:11:25] I've my email set to not receive notifications. And I haven't received any “declined” notifications, at least on the web. [12:12:21] If it affected non WCs if could be UBN depends on if in the db it actually thought you were the requester. [12:14:10] [1/9] doesn't seem so: [12:14:10] [2/9] `MariaDB [metawiki]> SELECT cw_user FROM cw_requests WHERE cw_id = 49750; [12:14:10] [3/9] +---------+ [12:14:11] [4/9] | cw_user | [12:14:11] [5/9] +---------+ [12:14:11] [6/9] | 298605 | [12:14:12] [7/9] +---------+ [12:14:12] [8/9] 1 row in set (0.000 sec) [12:14:12] [9/9] ` [12:14:35] that's definitely not my ID as mine is definitely single or double digits [12:16:59] Good [12:17:10] @reception123 also btw https://issue-tracker.miraheze.org/T12724#255202 [12:18:20] After my initial part it should be fairly straightforward for you to add them later on if you want more also. [12:18:27] Sounds good! [12:18:44] RequestWikiFormUtils provides a lot of helper functions to add fields anywhere in the forms [12:19:11] Like at end or beginning of a section after a particular field, remove another field etc... [12:21:08] Maybe I should try and sleep an hour lol [12:21:25] hmm yeah the error just happened again [12:21:31] for another request I commented on [12:22:17] I assume I did a logic error in getting involved users [12:22:33] I will fix in a bit but it shouldn't be a huge issue. [12:23:11] Not a huge issue unless you approve a couple hundred wikis and spam your email lol [12:29:26] I did a few days ago so heh [12:34:22] Is there somewhere I can check the status of a job my wiki has had in the job queue for over 24 hours now? (It’s a recreate cargo table data job) [17:34:04] I think that should be fixed btw. Can you please confirm? [17:36:09] not unless another WC changes the status on one of the requests I replied to [17:38:00] [1/2] Oh that was the issue? Lol I misunderstood, I think there was two potential issues and I fixed one. This was always the case I think, all involved users got notifications for it, or at least intended to in the code, just that I actually fixed some notifications so it now actually happens. I will fix that issue later. But yeah there were two separate issu [17:38:00] [2/2] es one of whicu I fixed lol [17:39:20] Well not notifications but for example when I simply commented on a request after it was declined by another WC I got the email addressed to me as if I had requested that wiki and my own wiki was declined [17:41:31] @originalauthority have you used change-prop? And Kafka? [17:51:11] The code always did that but the notifications didn't which they now do. I'll change the behavior later. [19:48:18] What’s with the log entry from User:CreateWiki Extension preforming unknown action “farmer/createwiki-failure” on request 49959 [19:49:27] link? [19:51:12] It means it failed. The createwiki-failure logic is mostly unchanged from before I think. But now full backtraces properly log so we can debug it better. [19:52:09] hey @cosmicalpha [19:52:21] That’s the only log entry associated with that account lmao [19:52:36] I’m updating the user page to say it’s not currently used [19:52:41] Maybe it didn't work before and I unintentionally fixed it? [19:53:00] Fixed the original logic which was wrong maybe [19:53:06] hey [19:53:25] it actually seems to have been a sane rollout [19:54:02] oh [19:54:08] that's good [19:54:20] i didn't wake up this morning to have to rever it [19:54:28] maybe because it doesn't exist. And it seems never did. I will fix. [19:54:32] i was very worried when i saw #announcements [19:54:42] No it’s exists [19:54:48] Yep. Only a couple minor bugs I already fixed. [19:54:53] [[User:CreateWiki Extension]] [19:54:54]

[19:55:02] I mean the create-failure log type [19:55:06] Oh [19:55:28] It exists as create-failuire [19:55:35] typo [19:56:55] And fixed. [19:57:53] @cosmicalpha jump onto mattermost a sec please [20:09:51] Nah redis is superior [20:11:27] redis for jobs is shite [20:11:38] although that's not redis' fault [20:12:03] Why is it [20:12:30] cause the runner doesn't scale and is piss easy to crash @originalauthority [20:12:41] and when it does fail, it explodes completely [20:12:51] Thats nothing to do with redis though [20:12:57] Thats an implementation problem [20:13:05] ask @zppix about some very long nights dealing with the jobrunner [20:13:13] And also its much better when configured properly which miraheze did not [20:13:15] oh it's 100% the jobrunner's fault not redis [20:13:25] Having all the servers running the same configuration is a stupid idea [20:13:32] i did say it wasn't redis' fault [20:51:10] I'm really having a hard time understanding how it worked before or why. I can't base a fix based on how it was I guess I just need a detailed explanation for how it should be so I can remake it rather than trying to understand the code before lol