[01:44:31] can i make the v22 Appearance menu (thing that includes the text size selection) appear instead of the old limited-width toggle is used when logged-out? [23:18:29] @cosmicalpha if you're not busy can you sanity check https://github.com/miraheze/CreateWiki/pull/605#discussion_r1810423338 i do not know what claire is complaining about but shes smarter then me [23:18:50] maybe got confused with the }}? but they are used right.. [23:19:06] It is invalid JSON yeah [23:19:27] or maybe just tabbing and newline wrong [23:20:02] WHYYYYY [23:20:17] [1/2] THE COLORS LINE UP [23:20:17] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1300237666465611827/svd2qdS.png?ex=67201c30&is=671ecab0&hm=92e36452dd45eb535673b2a5f3554cbb985addfc82761977b402e9aa58432888& [23:20:39] It is technically valid yeah but wrong formatting [23:20:58] https://tenor.com/view/ja-je-kent-het-wel-gif-24394639 [23:21:12] Needs one more tab then the second bracket in a newline with the current amount of tabs [23:21:40] so one lines up with the " in default and one with the " in value [23:23:01] [1/2] ? [23:23:01] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1300238354691915860/vOcFb7O.png?ex=67201cd5&is=671ecb55&hm=985687c7671aea603baa6ef78c9ce884e63613bc0c255263a6508dfcf6894b02& [23:23:21] That looks right [23:23:32] is there a linter or smt [23:23:43] oh well phan [23:23:51] hey siri how run phan locally [23:25:50] Phan and PHPCS for PHP, eslint for JS, stylelint for CSS/LESS, and banana checker for i18n. But there is oddly nothing that lints extension.json lol. PHPUnit will tell of fatals but thats all. [23:26:10] banana checker [23:26:27] ill just, ask someone to run CI... [23:27:14] Wierd name lol https://www.npmjs.com/package/grunt-banana-checker [23:27:52] I didn't know the format was called "Banana" lol [23:28:13] https://cdn.discordapp.com/attachments/1006789349498699827/1300239663440855113/changes.patch?ex=67201e0d&is=671ecc8d&hm=f4aa038bf1df3b0399d64af8df722fe922a5cb5820c97979e219e351db34aaea& [23:28:52] i think thats all [23:29:24] ill commit and push to my repo so someone can hit CI [23:29:31] and if it passes yaaay [23:30:18] we can see about dry running it, or depending on how many years the back and forth of commenting on my bad code takes ill test it myself [23:33:17] having a copy of a high traffic repo for a PR is pain [23:35:09] committed, someone with access can rerun https://github.com/miraheze/CreateWiki/pull/605 [23:35:55] ow [23:35:58] pro tip [23:36:10] walking into a wall with your shoulder hurts said shoulder