[14:56:57] @abaddriverlol The icons exist on conmons for fisch i’ll copy those and add leading zeros [15:00:45] Alright [18:40:52] [1/3] Opened a PR for the ManageWiki issue: https://github.com/miraheze/ManageWiki/pull/713 [18:40:52] [2/3] The list style was bug on Minerva was caused by styles being overriden by Minerva. [18:40:53] [3/3] And the misalignment between the button and input seem to be an upstream bug in OOUI (see https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=mobile#SelectFileInputWidget for example), I also fixed it in ManageWiki [18:46:41] Nice! Thanks! [18:52:34] @asko1 you want me to merge that so you can test on beta [18:53:18] i believe i can test without merging but can do in a moment, finishing up my wiki work [18:53:23] Cool [18:53:39] You should be able to [18:54:03] mwdeploy could use a bit more documentation ngl [18:54:14] remind me in like 6 months if no one else does [18:59:04] I want to completely redo it tbh [18:59:18] Its scope creeped and never been fully rebuilt [18:59:19] with documentation hopefully [18:59:22] ahhhh [18:59:30] The original version was pre multi version [18:59:43] So it's gained quite a lot [18:59:50] But without a design review [19:00:12] It's better than nothing but it's terrible [19:00:23] Imagine the days before it @asko1 [19:02:11] [1/2] No :thanks: [19:02:11] [2/2] I retract my potentially-viewed-as-negative statements, I love mwdeploy and it is a cool tool [19:16:55] I wrote the first version mwdeploy out of spite and frustration at our deployment process [19:17:09] I got that sick of it I decided to script it [19:17:17] my favourite type of motivation [19:17:48] There was also a desire to have a security patching process [19:17:49] (anybody reading here should definitely start making PRs just because they're tired of waiting on us btw) [19:17:57] We haven't finished that 4 years on [19:18:11] I plan on doing the redesign in August [19:18:42] Too busy with uni but it's giving my a coding bug because I'm doing significantly more report writing than coding at the moment [19:19:07] I need to start writing in c and python instead of English again before I become actually good at English [19:20:04] I was born here and have always spoken and written English as basically my own language but I can still code better than I can write [19:20:26] @asko1 [19:21:44] can't relate as I wasn't born an english-speaking native, but I can definitely say that both my code and english suck at times :P [19:22:23] but I would much rather write code than reports [19:23:10] I dare not claim it outright, but debugging centralauth would probably be more enjoyable than writing reports [19:24:00] can't wait for the redesign in august [19:26:26] ok lets see if I can deploy the PR [19:47:13] I was planning to improve the mwdeploy documentation, maybe I'll do that in the next days if I can find time to [19:47:58] [1/2] can you tell me rq if I can even deploy an extension from another branch [19:47:58] [2/2] or does it just ignore and pull from main anyway [19:47:59] especially stuff like checking out a PR and deploying it on beta, patching stuff locally and changing a repo branch (although that one doesn't involve running mwdeploy) [19:48:26] check it out in staging, and then `mwdeploy --folders=1.43/extension/ManageWiki --no-log --servers=all` [19:48:47] ah ok I used --upgrade-extension [19:48:50] ty <3 [19:48:53] *extensions [19:49:04] that causes it to pull the repo [19:49:14] Ye making --branch work or removing it is on the list [19:49:21] figure as much after it mysteriously changed branches [19:49:23] So is looking at git cache [19:49:26] --pr would be cool [19:49:41] [1/8] to replace [19:49:41] [2/8] ```sh [19:49:41] [3/8] cd /srv/mediawiki-staging/config [19:49:42] [4/8] sudo -u www-data git fetch origin pull/[PR NUMBER]/head:[BRANCH] [19:49:42] [5/8] sudo -u www-data git checkout [BRANCH] [19:49:42] [6/8] cd ~ [19:49:43] [7/8] mwdeploy --config --servers=all [19:49:43] [8/8] ``` [19:49:48] that would be super cool indeed [19:49:57] That would be cool [19:50:07] Can you make a task tagged with #sre-automation [19:50:12] sure [19:53:02] [19:53:47] @asko1 btw make sure to checkout the PR and sync the ext folder on 1.44 too if your beta wiki is on 1.44 [19:54:04] i went through hell to downgrade it to 1.43 [19:54:17] or rather, I put Claire through hell to downgrade it to 1.43 [19:54:21] [1/4] ```sql [19:54:22] [2/4] ALTER TABLE echo_event ADD event_variant VARBINARY(64) DEFAULT NULL; [19:54:22] [3/4] ``` [19:54:22] [4/4] was sufficient in my case [19:54:41] oh [19:54:52] i will pretend we didn't rebuild my wiki's db [19:54:56] lol [19:55:32] I checked out the sql error and then basically rolled back the changes done by the migration that was added to Echo in 1.44 [19:56:18] maybe I should've put it somewhere in the docs [19:59:28] [1/2] This PR only fixes the misalignment for Minerva, right? Citizen is still looking like this [19:59:29] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1390059320888004608/image.png?ex=6866e120&is=68658fa0&hm=308556e793ffd3d9f6438cf8cdbfa5ff2a858ca6ed899faab4bef4c0b3a78c70& [20:04:05] Ah that just needs to update Citizen to the latest commit [20:04:22] Those styles were dropped recently to sync with the ManageWiki update: https://github.com/StarCitizenTools/mediawiki-skins-Citizen/commit/9ef5c041568a5a76b13a184fe888c9d1117b58cd [20:04:41] ah, fair enough [20:53:06] I merged but i cant be assed to ssh in to deploy it rn so 🙈 [20:54:50] @abaddriverlol i'm volunteering you :p ^ [20:55:11] will do [20:57:52] done [20:57:59] \o/ [21:42:16] MW 1.44.0 is released: https://lists.wikimedia.org/hyperkitty/list/mediawiki-l@lists.wikimedia.org/thread/C3ZZDKSFH2PW55GRH6Y4SXIM37GBXL32/ [21:42:51] great! lets skip whatever 1.43.2 was [21:43:06] We've barely even begun testing [21:43:15] there's also .3 [21:43:16] Last time I looked was 6% complete [21:43:23] yeah only the skins were tested [21:43:31] class aliases will still be annoying [21:43:42] At this rate we aren't going to upgrade for months [21:43:51] I've fixed like 10 extensions/skins in the last few months [21:44:02] but so many are still broken on 1.44 [21:44:38] You can push beta to 1.44 though @abaddriverlol [21:44:45] Although you should probably go to bed like me [21:45:22] true, will do later/tomorrow [21:45:49] just remembered that 1.44 has a bunch of core patches I made, since I started contributing when 1.43 was cut [21:45:50] https://cdn.discordapp.com/emojis/1144716926854119594.webp?size=48 [21:46:01] , for example