[01:50:57] <MirahezeRelay>	 <paladox> @atxatx i've done https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/6171
[01:51:17] <MirahezeRelay>	 <paladox> but it seems to cause things to get stalled on `Importing from smw.groups.json ...` and i'm not sure why
[01:51:17] <MirahezeRelay>	 <atxatx> Oh shit.... I am also working on that
[01:51:21] <MirahezeRelay>	 <paladox> oh
[01:51:23] <MirahezeRelay>	 <paladox> my goal wasn'
[01:51:30] <MirahezeRelay>	 <paladox> wasn't to fix it entirely
[01:51:38] <MirahezeRelay>	 <paladox> it was just so the installation step would work
[01:51:46] <MirahezeRelay>	 <paladox> you can integrate the change if you want
[01:51:51] <MirahezeRelay>	 <paladox> *into yours
[01:53:48] <MirahezeRelay>	 <atxatx> Yeah I also rewrote all the imports as well and am still going through it :/
[01:54:10] <MirahezeRelay>	 <atxatx> Let me publish the branch and see how bad the rebase would be
[01:54:43] <MirahezeRelay>	 <paladox> dunno why it gets stuck
[01:55:02] <MirahezeRelay>	 <paladox> but it at least is progress but then breaks 1.43 lol as it also gets stuck somehow
[01:55:39] <MirahezeRelay>	 <paladox> oh maybe the maintenance script? idk
[01:56:14] <MirahezeRelay>	 <atxatx> I fixed maintenance script on my branch, hmm let me go through the PR now
[01:58:57] <MirahezeRelay>	 <atxatx> Oh god the github diff is crashing my browser
[01:59:39] <MirahezeRelay>	 <atxatx> I am still going through it but you can try this branch: https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/6172
[02:08:09] <MirahezeRelay>	 <atxatx> Okay I am intergrating your changes
[02:08:19] <MirahezeRelay>	 <atxatx> Would probably be a while :/
[02:12:37] <MirahezeRelay>	 <cosmicalpha, replying to originalauthority> no objections I went ahead and merged your current patch just because it was nice to have lol. But feel free to do another.
[03:01:49] <MirahezeRelay>	 <cosmicalpha> I also need to do some major cleanup to Cosmos...
[03:03:04] <MirahezeRelay>	 <cosmicalpha> CI always fails because of CreateRedirect or something. I need to do a patch to remove it from CI and just have it done in phan.
[06:32:44] <MirahezeRelay>	 <atxatx> @paladox I finally finished with the class import, it was 456 files sigh
[06:33:38] <MirahezeRelay>	 <atxatx> I am going to call it a day, the tests are still failing primarily because of the database query stuff
[13:31:58] <MirahezeRelay>	 <paladox> Nice!
[18:13:23] <MirahezeRelay>	 <paladox> @atxatx i'm not sure how you fix that test (but also there's more failures, just hidden as they haven't run yet).
[18:14:13] <MirahezeRelay>	 <atxatx> I removed the test user initialization since it wasn't being used
[18:14:29] <MirahezeRelay>	 <paladox> really doesn't make sense (the failure). testCreate_ReplaceableOnCreator works. But the only difference is exists is set to false and user isn't set.
[18:15:37] <MirahezeRelay>	 <atxatx> It doesn't make sense to me either. In the worst case, maybe we'll have to mark it as skipped or broken, and move on to fix the next batch of failing tests
[20:05:37] <MirahezeRelay>	 <paladox> I guess it may be https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/update-class-import/src/Importer/ContentCreators/TextContentCreator.php#L182 @atxatx
[20:36:09] <MirahezeRelay>	 <paladox> so some how getUser returns null and user->getId equals 0 @atxatx ? Although i used assertSame to see what the value returned.
[20:44:56] <MirahezeRelay>	 <atxatx, replying to paladox> I will take a look later. But getUser isn't capable to return null in the original behavior, so it is probably something wrong with the test mocking
[20:45:28] <MirahezeRelay>	 <atxatx> Or the type annotation of `$page` is completely wrong. It is difficult to trace the actual type of an object in SMW