[01:16:33] i figured it out @atxatx [01:16:59] unless the code was previously buggy, moving `isCreatorLastEditor` back to it's original code but modified fixed it [01:17:12] [1/15] ``` [01:17:13] [2/15] private function isCreatorLastEditor( WikiPage $page ): bool { [01:17:13] [3/15] $lastEditor = MediaWikiServices::getInstance() [01:17:13] [4/15] ->getUserFactory() [01:17:13] [5/15] ->newFromId( (int)$page->getUser() ); [01:17:14] [6/15] if ( !$lastEditor instanceof User ) { [01:17:14] [7/15] return false; [01:17:14] [8/15] } [01:17:15] [9/15] $creator = $page->getCreator(); [01:17:15] [10/15] if ( !$creator instanceof User ) { [01:17:15] [11/15] return false; [01:17:16] [12/15] } [01:17:16] [13/15] return $creator->equals( $lastEditor ); [01:17:17] [14/15] } [01:17:17] [15/15] ``` [01:17:45] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/src/Importer/ContentCreators/TextContentCreator.php#L195 is it on master [01:20:49] Just for visibility, but can someone disable CommentStream on `lhmnwiki` for now? [01:21:03] It has been brok for a few days now [01:35:07] yes [01:36:10] should be done [02:01:53] The previous code was buggy because `WikiPage::getCreator` does not return an `User` object, so the code would always go to false :/ [02:07:59] Idk how `getUser` can return null, I traced it upstream and still could not find anything [02:09:23] I guess we can settle for that if it passes the test, there are other more important stuff to fix anyways (200+ failing tests 😭 ) [02:20:45] :ultraseeth: [02:21:05] If you want you can do that separately, unless you want to do that in the same change [02:21:22] Yeah we can follow up with that later [02:21:30] Passing the tests are more important [02:26:40] @atxatx some of the test failures are incorrect namespace [02:26:50] Yeah I fixed those locally [02:27:10] [1/6] 220) SMW\Tests\Integration\MediaWiki\Jobs\UpdateJobRoundtripTest::testValidCovers [02:27:10] [2/6] RuntimeException: Tracking is already enabled [02:27:11] [3/6] /var/www/html/includes/libs/rdbms/ChangedTablesTracker.php:29 [02:27:11] [4/6] /var/www/html/tests/phpunit/MediaWikiIntegrationTestCase.php:712 [02:27:11] [5/6] /var/www/html/tests/phpunit/MediaWikiIntegrationTestCase.php:642 [02:27:12] [6/6] /var/www/html/extensions/SemanticMediaWiki/tests/phpunit/SMWIntegrationTestCase.php:203 [02:27:15] How do you even fix this lol [02:27:24] I took ages looking but came up with nothing [02:27:58] I found a related ticket on phabricator but SMW is using a very different practice for testing so I don't even know where to start [02:59:47] I think there are even more stuff broken, all the stuff like `$this->getMockBuilder( '\Title' )` should not be working tbh [03:00:07] The proper way to do it is `$this->getMockBuilder( Title::class )` and then you update the import [04:14:18] Okay I addressed the MockBuilder issue, it is mainly for 1.44. Still I can't figure out the `Tracking is already enabled` error. Perhaps I will take a look again another day [04:14:43] @paladox did you test SMW on an actual test environment? [04:15:21] I did when I tried looking but I don’t have it anymore. You can run the ci locally as it’s a docker image [04:15:49] I tried running their CI and it is slower than GitHub Actions lol [04:16:22] I am not sure if it is possible to fix the tests completely, so I am wondering if any tests have been done outside of the automated tests [04:41:17] IIRC this happens if you call ChangeTabledTracker which used to be defining tablesUsed but is now addDBDataOnce. But can happen if you call mediaWikiSetUp() more than once somehow or call something like DatabaseMysqlTest at the same time. Would be odd to hit it that way though. [04:42:01] CC @paladox [04:43:27] Oh, it happens in https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/tests/phpunit/SMWIntegrationTestCase.php @cosmicalpha [04:43:56] Maybe you’ll spot the issue in there? [04:44:22] It’s a wrapper over MediaWikiIntegrationTestCase [04:48:13] let me trace it. I see a potential issue [04:51:36] @paladox what happens if you call ChangedTablesTracker::stopTracking() in either setup or teardown out of curiosity. [04:56:55] @atxatx ^ [04:57:08] I’m mobile currently. [04:57:12] I’m about to head off [05:12:28] @paladox @atxatx So I think I tracked what is happening [05:13:09] I was planning to try that but I spent too much time on it today 🥲 [05:14:11] [1/14] PHPUnit starts test run [05:14:11] [2/14] → Calls @before methods (which mediaWikiSetUp() is) [05:14:12] [3/14] → mediaWikiSetUp() calls ChangedTablesTracker::startTracking() [05:14:12] [4/14] SMWIntegrationTestCase::run() is called [05:14:12] [5/14] → (Before calling parent::run()) [05:14:13] [6/14] → Does some setup [05:14:13] [7/14] → Calls parent::run() [05:14:13] [8/14] parent::run() (from PHPUnit) creates a new test instance [05:14:13] [9/14] → PHPUnit lifecycle repeats for that instance: [05:14:14] [10/14] → Calls @before methods again (yes, AGAIN) [05:14:14] [11/14] → mediaWikiSetUp() is called again [05:14:14] [12/14] → ChangedTablesTracker::startTracking() is called again [05:14:15] [13/14] → "Tracking is already enabled" [05:14:15] [14/14] Test fails because ChangedTablesTracker was already enabled [05:14:40] now that was some tracing lol [05:15:30] Only a theory I didn't confirm though. [05:18:52] Curiously it only fails with the JSON test case, but I think you're on the right track [05:21:57] odd but yeah im almost certain it is something like that anyway. [05:22:08] But who knows maybe totally wrong lol [05:24:12] [1/2] ` [05:24:12] [2/2] [1a9a17b0682a93f1539b3a28] 2025-07-26 05:22:16: Lỗi chí tử loại “DomainException”` (fatal on type DomainException) [05:36:03] {{phorge:T14045}} [05:36:05]

[1/2] Open: Fatal exception of type “DomainException” at lhmnwiki [05:36:06]

[2/2] [07:35:34] Need to confirm something from #tech-ops , but was the change to send email a meta-wiki only or was it global? [07:48:21] A global thing. There will be a full public announcement given on that later. [07:49:20] apparently "be gay do crime" is not a valid strategy /lh [08:06:01] So what will happens to certain local wikis that relies on emails? Like any wikis in Vietnamese that I am currently maintaining? [08:06:51] wait what [08:07:07] We will give an announcement later that will explain why the change was made. Apologies for any inconvenience but its impossible to retain such functionality again. [08:07:09] (not re sendemail being disabled, but re that wikis rely on it) [08:07:22] can we just make an off-cuff comment as to why [08:09:16] Laws [08:09:20] Not necessarily a secret. In short it is due to regulatory measures due to new laws in certain countries. [08:09:36] Announcement will hopefully come real soon [08:10:11] Wait... hold on a sec, does ContactForm also on the target list? [08:10:20] i... hope not? [08:11:06] Uh no comment right now. I will find out. [08:11:25] Im not certain but it could. [08:11:42] It wouldn’t, as far as I can tell [08:11:56] my personal interpretation of the _australian_ bill is that business stuff would be exempted [08:11:57] the features removed were specifically due to the way they can be used [08:12:10] my call is not obviously definitive though [08:15:46] can we abolish all commonwealth countries please \:( [08:16:41] https://www.thepinknews.com/2025/07/24/uk-online-safety-act-what-to-know-age-verification/ [08:16:54] we have self-id [08:16:54] well [08:16:57] okay, kinda [08:17:01] we half-have self-id [09:27:35] Im trying to decide if I should rename dpl3wiki to dpl4wiki or dplwiki lol [09:57:18] theres a dpl wiki? [09:57:48] yeah the manual for dpl3(now dpl4) [09:58:31] It moved from Gamepedia/Fandom to one I controlled since it diverged enough lol... especially with DPL4. [09:58:42] dpl3.wikitide.org [09:59:11] oh wikitide.org wikis still exist [09:59:13] that's cool [09:59:59] Yep lol, hosted by the same servers though just maintained so URLs didn't have to change during merge. [10:00:05] honestly it'd be cool if you could request to switch domains between miraheze.org and wikitide.org [10:00:11] you can [10:00:25] Its just a simple switch in ManageWiki now. [10:00:34] but restricted [10:00:41] like in Special:RequestWiki i meant [10:00:50] Its been planned for awhile. [10:00:57] I had the code for it even. [10:01:39] But wikitide.org isnt on cloudflare so wanted to minimize what ones we did for reason like not having excessive problems with them. [10:02:08] We dont have the wildcard support for it on cloudflare yet. [10:02:49] also planned to allow mira.wiki and wiki.surf too. [10:03:01] oh and orain.org [10:04:29] Does DPL4 work yet [10:06:06] it works but its still in alpha stages. [10:06:26] a few bugs to work out still. [10:08:07] I'll probably release the last alpha release tomorrow then the first beta a few days later. [10:10:03] it's always TERF island huh? [10:10:24] it's always terf island... [10:10:40] though the US is competing too [10:10:52] (in terms of transphobia) [10:11:09] A long release process due to the severity of the changes lol. Its practically rewritten entirly. Almost 13,000 (~12,800) lines changed so far [10:11:34] Yeah I'm looking at the PR that's pretty big [10:12:04] how would i see tasks that i've subscribed to on Phorge 🤔 [10:12:06] I've been slowly moving UT/DR to 1.44 so I could probably test that branch [10:12:34] Not that we use it particularly extensively [10:12:36] https://issue-tracker.miraheze.org/maniphest/query/subscribed/ [10:12:55] yesss thank u queen [10:13:02] you're welcome... [10:13:46] Nice! Technically I'm trying to maintain 1.43 (LTS) compatability for the first DPL4 stable release at least. I'll probably manage that lol. Before it goes stable I'll add 1.45/categorylinks migration support also though. [10:15:47] is there any updates on this? https://issue-tracker.miraheze.org/T13724 [10:16:05] categorylinks migration was part of why I did this lol. Its much easier to maintain without raw queries and using MediaWiki's QueryBuilder [10:16:22] I forgot about that. [10:16:28] Ill look later [10:16:47] It was probably caused by my rewrite to ManageWiki lol [10:18:48] Anyway it's 4:18AM so I should sleep. I'll look when I wake up. [10:21:55] na, the UK is still much worse in my opinion, transphobia in the US is a bunch of right-wing weirdos and politicians using it as a wedge issue. The UK has a formerly beloved cultural figure in JK Rowling going TERF and used their government to veto a Scottish bill reforming the GRA, the first and so far only time they've used such a power [10:22:23] the US is trying to compete is what i mean :p [10:22:32] but yeah, UK is very fucked [10:22:37] they can't beat the OGs [11:45:15] @rodejong DarkMode was fixed, you can enable it on your wiki again [11:52:00] [1/2] the sql fix for this was backported today and the special page is now probably populated correctly, but now there's a class alias error lol [11:52:01] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1398633949374451793/image.png?ex=688612de&is=6884c15e&hm=0b5c20f4f86d5a295f29357791c0017557de7181c03b4b374c0382f8da99bbdf& [11:52:16] oh my fucking god lmao [11:52:20] i'll make a patch [11:52:46] thx [11:54:43] I've upgraded the extension on prod so it should at least work on 1.43 now lol (pretty sure it didn't before) [11:55:14] oh I love cute little extensions with only 1 file of actual code and [11:58:29] my biggest patch to date https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UnusedRedirects/+/1172800 [11:59:40] nice lol [11:59:59] works for me locally [12:00:01] what a surprise [12:48:39] Thank you [13:24:42] doesn't seem to fix it. [13:27:05] we use something like https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/tests/phpunit/Utils/Connection/TestDatabaseTableBuilder.php in SMWIntegration test. [13:51:16] it's being thrown here https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/update-class-import/tests/phpunit/SMWIntegrationTestCase.php#L186 [15:50:12] Yeah that didn't tell much. That lines up with CosmicAlpha's theory on it being called again from the parent. So that means the tracking is enabled somewhere before this line [16:33:45] Wonder where [16:36:44] What if we just do a try catch block on the parent run line [16:37:10] If the exception is the tracking one, then we stop tracking [16:55:28] Maybe? Idk [16:55:41] Hmm I'll give it a try [17:25:55] i want to have $2 and $1 but it appears that $1 works but $2 doesnt [18:35:51] [1/2] Try catch did not work unfortunately. [18:35:51] [2/2] Both `ParserFirstCallInitIntegrationTest` and `PageMoveCompleteIntegrationTest` tests (extends `SMWIntegrationTestCase`) failed because of the same error, while `ParserAfterTidyIntegrationTest` (extends `PHPUnit\Framework\TestCase`) did not. That seems to indicate that the issue lies within the `SMWIntegrationTestCase` class. [18:37:29] Well SMWIntegration extends the MW test but yeh [18:37:49] Maybe the test db setup stuff we’re doing but idk. Just throwing out stuff [18:41:07] It is definitely from the test db set up stuff, but I can't say I understand what is happening there [21:11:08] manual config in mw-config needed