[00:12:20] [1/3] got it to work after reverse engineering Echo because the APIs are stupid and will change in 1.45 [00:12:21] [2/3] https://cdn.discordapp.com/attachments/1006789349498699827/1449554566466244660/image.png?ex=693f5264&is=693e00e4&hm=98f4ef9eb19d1c7c41d38d07ca8d3398de9a25207182948dc1ba3f3559dcf148& [00:12:21] [3/3] https://cdn.discordapp.com/attachments/1006789349498699827/1449554567015567522/image.png?ex=693f5264&is=693e00e4&hm=6886d7cada24d5d61b47b1ecdc14eddb764ef62238a22416b59f392f65cc18e2& [00:12:57] Unfortunately, Echo does not parse notification contents, so it's not possible to use wikitext [00:13:26] https://cdn.discordapp.com/attachments/1006789349498699827/1449554844468777020/image.png?ex=693f52a6&is=693e0126&hm=f6117855cf72a5b805411dafd9b639898ccb1b48cfd8da53e677ca1e01ebc92a& [00:18:13] if anybody wants to review [00:18:38] [1/2] also works locally if you add this line [00:18:38] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1449556152709812459/image.png?ex=693f53de&is=693e025e&hm=601f033d66274aab8559844ba5b98d9a6b2c6aeb801a714e8ee2ca331660e233& [00:23:55] i18n isn't implemented btw since I don't think it's feasible to translate notifications we send only once to wikis [00:55:29] salute [01:08:26] I had the exact same issue when trying to make Yappin notifications work, but turns out 1.44 is not much different from 1.45, so I just used the 1.45 interface. [01:24:00] [08:27:52] [1/3] Took me a while to notice but Mirabeta's api is borked [08:27:52] [2/3] https://meta.mirabeta.org/w/api.php [08:27:52] [3/3] Backtrace also in error 2 of https://issue-tracker.miraheze.org/P562 [15:13:44] @abaddriverlol i think we should announce the extension removals [15:14:12] Including LangSel [15:14:27] that is why it says removals not removal [15:19:48] I meant to add ? [15:19:59] I don't think we're ready to remove LanguageSelector yet, and SemanticDrilldown doesn't really need an announcement IMO since it's been disabled for months anyway and only 14 wikis were using it [15:20:28] I was trying to use the new NotificationService in core, but the implementation is still a work in progress in 1.44 [22:22:39] Since we now have a way to notify affected wiki admins/bureaucrats, we can now figure out how exactly we will replace LanguageSelector [22:23:53] Looking at the code, `$wgULSLanguageDetection` seems to add a vary header to the response to split up cached responses for different Accept-Language headers, which is not great... (assuming our caching systems respect this header in the first place) [22:24:52] it does which is why yesterday some poor lads got served with a russian main page on a wiki [22:25:05] I'm talking about ULS [22:25:09] oh [22:25:09] we don't have that setting enabled anywhere [22:25:27] [22:28:58] hmm [22:29:57] then no issue? [22:30:17] not right now, but @posix_memalign suggested the option as an alternative to LanguageSelector [22:30:24] [22:31:00] I think it's probably still better than whatever LanguageSelector does; but I don't want too many wikis to enable this setting if it will degrade performance [22:31:10] We could add a warning to the setting [22:33:51] could we disable caching for non-default languages [22:34:46] Vary on Accept-Language shouldn't be too much of an issue [22:34:56] Remember varnish cache only applies to logged out users [22:35:18] The number of logged out users who are going to do a non default language is probably low [22:42:27] Doesn't the browser automatically include the OS language in the header? [22:42:42] I would assume that a large part of users reading English wiki content is actually using a different OS language [22:42:54] (I use en-US, but I'm also probably not an average wiki reader) [22:44:23] True [22:44:59] I wonder if we'd need to do some normalisation [22:45:38] I can't imagine that many logged out users will visit wikis in a different language to one they speak [22:45:50] We can think about it [22:48:58] I don't really have an issue enabling this for wikis that have different languages and use it properly, as it might be useful; but if there are wikis using only one language, it's absolutely unnecessary to split up the cache for that