[06:57:53] [1/3] It's working for Google. GoogleBot no longer sends requests to the Special:UserLogin page. [06:57:53] [2/3] Meanwhile Bing does not care. [06:57:53] [3/3] https://cdn.discordapp.com/attachments/1006789349498699827/1494955107488497674/image.png?ex=69e47cf0&is=69e32b70&hm=64be46a9f38c04930e6af936d61a6098141669ae852ce641fed954e2981a4c01& [09:48:12] what's working for Google? [09:48:18] The robots or [09:49:57] You ain't merged that [09:50:02] So ye what change worked [09:59:43] He did merge the robots.txt PR [10:58:52] Weird [10:59:01] It showed as open in the GitHub app [16:06:25] GH seems to cache pretty aggressively. They serve me outdated pages on the browser a few seconds after merging as well. [20:12:38] okay, now that I have my accounts and beta access set up at least on my new device, back to dipping in dev [20:13:46] @posix_memalign so looking at your PR https://github.com/miraheze/MirahezeMagic/pull/649/commits/33539730dffd890bd46cff19de195ba16d0cd3ea to try and move my hook down [20:14:31] And also partially learning how hooks work more ig [20:35:47] chat how do i use phan to check if my code is shot [20:37:44] Also not super clear on how HookHandler files boilerplate works based off looking at the current MM repo but fuck it we ball a:frbounce: [20:39:19] mediawiki is fun [20:39:23] I was using `composer phpcs -- extensions/MirahezeMagic` for phpcs failures. Not sure about phan though. [20:39:48] I may also be looking for phpcs :react_shrug: we'll find out [20:40:02] [1/2] i just do composer phan [20:40:03] [2/2] i think it wanted me to download some things first but that's about it [20:40:10] It's fun diving into something I feel so not good at but can still figure out in a day [20:40:30] Nice change of pace from staring at people discussing Linux kernel compatibility :kek: [20:40:31] Yeah `composer phan` wants me to install `php-ast` [20:41:28] Hm, I got some other error [20:41:44] what's it yappin [20:41:53] [1/6] ```[pixldev@test151:/srv/mediawiki-staging/1.45/extensions/MirahezeMagic/includes/HookHandlers]$ sudo -u www-data composer phan [20:41:54] [2/6] No composer.json in current directory, do you want to use the one at /srv/mediawiki-staging/1.45/extensions/MirahezeMagic? [Y,n]? y [20:41:54] [3/6] Always want to use the parent dir? Use "composer config --global use-parent-dir true" to change the default. [20:41:54] [4/6] > phan -d . --long-progress-bar [20:41:54] [5/6] sh: 1: phan: not found [20:41:55] [6/6] Script phan -d . --long-progress-bar handling the phan event returned with error code 127``` [20:42:16] run it in the root of the ext duh [20:42:35] oh you did [20:42:43] you did composer install right [20:42:55] hahaha [20:42:57] course not [20:43:24] The number of composer commands i've run is probably single digit [20:44:21] Giving it the auth token is asks for is fine? [20:48:13] Why would it need an auth token? [20:49:09] I have no idea [20:49:14] You need to set the env variable to use the bastion proxy [20:49:18] oooooo [20:49:28] Is that doc'd [20:49:51] No [20:50:06] [1/4] try [20:50:07] [2/4] ```bash [20:50:07] [3/4] sudo -u www-data https_proxy=http://bastion.fsslc.wtnet:8080 composer install [20:50:07] [4/4] ``` [20:50:09] taken from mwdeploy [20:52:04] danke [20:52:58] Installing the php-ast package is fine per user? [20:55:27] I don't think you're able to do that [20:55:29] it's an extension [20:55:43] (php extension) [20:56:02] I would recommend running phan locally [20:56:09] How do you push to the repo from test151 anyway? [20:56:49] I'm planning on getting it working on beta and exporting it as a patch then either copy pasting or maybe SFTP\ [20:57:31] I'd recommend exporting it every time you're done changing something then as staging repos are occasionally reset [20:58:04] But you won't be able to run phan this way [21:01:40] I think I can [21:01:51] > ERROR: The php-ast extension must be loaded in order for Phan to work. Either install and enable php-ast, or invoke Phan with the CLI option --allow-polyfill-parser (which is noticeably slower) [21:01:55] You can't without the extension [21:01:59] Oh [21:02:05] Ig the polyfill would probably work [21:02:12] But phan is already very slow without it [21:02:49] [1/2] Thank you composer [21:02:49] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1495167742804889791/image.png?ex=69e542f8&is=69e3f178&hm=ee33c16e7483f2fdc8cc2452d5c910b8d552586daf95ca80f1813236f4c0553c& [21:03:17] use `--` [21:03:34] is it a different character... [21:03:48] no [21:04:02] `sudo -u www-data composer phan -- --allow-polyfill-parser` [21:04:03] okay that also didnt see [21:04:08] huh [21:04:12] Since you want to pass the arg to phan and not composer [21:04:19] Interesting [21:05:11] [21:05:21] (this is about ssh but it applies to composer as well) [21:08:07] proob should have told it to just look at the one file [21:08:14] 4 minutes to tell me im missing a } [21:08:25] lol [21:08:35] phan won't work with only one file [21:08:48] god [21:08:56] it needs to scan MW Core to understand the classes and functions you're using [21:09:02] oh [21:09:10] phpcs is usually used to detect syntax errors [21:09:24] it usually runs within one second for extensions [21:09:34] yeah lets use that from here out [21:21:34] how do i mahve phpcs auto fix [21:22:32] `composer exec phpcbf -- extensions/MirahezeMagic/` [21:23:50] cool [21:23:51] welp [21:24:03] composer fix my beloved [21:24:06] guess ill add it to tje extensions.json and deploy when i get home