[04:32:17] I'll make a pull request for making the mw.notify popup never go away. [05:21:33] Feel free to mix some other wording adjustments in there as well. [06:31:39] should it be a message with i18n? [06:32:01] just like the console message [06:41:15] [1/4] https://cdn.discordapp.com/attachments/1006789349498699827/1566341330634932295/image.jpg?ex=6ae8308a&is=6ae6df0a&hm=910d74c42e072d47db151dd168e8a83d6e4b3f88b62ce66870a2424b7874914e& [06:41:15] [2/4] https://cdn.discordapp.com/attachments/1006789349498699827/1566341331218075788/image.jpg?ex=6ae8308a&is=6ae6df0a&hm=e446d766e280253a52d501e5101176d4372da9cc70164ba17986896153427374& [06:41:16] [3/4] https://cdn.discordapp.com/attachments/1006789349498699827/1566341331666731018/image.jpg?ex=6ae8308a&is=6ae6df0a&hm=684eb600a4a2d3e7810d77443c2f0b7a6c68368d219234733207ac31890f4781& [06:41:16] [4/4] https://cdn.discordapp.com/attachments/1006789349498699827/1566341332115398767/image.jpg?ex=6ae8308a&is=6ae6df0a&hm=8dd32defc555f2b71a5998770679af35afee056416ac698ce9826d69f1f47bbc& [06:45:51] The popup is actually 2 messages. 1 for the main thing and another one for when the message is too long and gets truncated. [07:23:35] [1/2] Two PR's that can be tested and merged if successful if anyone has the time, thanks: https://github.com/miraheze/mw-config/pull/6619 [07:23:35] [2/2] https://github.com/miraheze/mw-config/pull/6588 [07:40:07] [1/3] For T16420, I'm not sure if we want all of these settings in ManageWiki. Most of them seem somewhat useful but since no one requested these yet I assume they are very niche and are likely only ever needed by a handful of wikis. [07:40:08] [2/3] In particular `UseRealName` and `DisableCache` involve things we do not like. Disabling the cache is always problematic, and revealing the real name field is a privacy risk in case someone wrote that in the account registration form not knowing that it will be shown like this. `UseRoughEditCount` I don't know if anyone ever wants it. It's a performance meas [07:40:08] [3/3] ure that only applies to the largest wikis on which this extension is going to be slow. I have not seen such a wiki yet. Adding it only adds bloat. [07:41:00] I'm using Contribution Scores on my wiki (doorsgame.wiki) so I want these settings added, maybe I should've specified that. [07:41:29] Initially I was gonna lock UseRealName and DisableCache behind `managewiki-restricted`. [07:41:44] But I decided against it, because DisableCache is already present within LocalSettings.php. [07:42:00] We do not allow it under any circumstances anymore, when it is optional/configurable. [07:42:09] If it's true it should be false [07:42:20] Ah, so no more disabling caches? [07:42:30] I can remove that config addition then, and remove it from `LocalSettings.php`. [07:42:32] Not when it is disabled on every page view. [07:42:38] What about RealName? `managewiki-restricted`? [07:43:07] RealName I would leave out completely until we decide what we are doing with those types of configs. [07:43:20] Alrighty, those will be removed in a minute. [07:43:46] if DisableCache is default true in LS that could/should also be switched to false. [07:44:32] It's just that it's a huge performance issue to allow and there are other alternatives/JS ways that don't have the same performance impact. [07:44:41] The extension provides the configuration, but it's defaulted to false unless defined as true. [07:44:46] So, if I remove it, cache will always be active. [07:45:15] Even if the extension defaults it to false, we should probably still define it as false and add a comment to make it clear we shouldn't enable tbh [07:45:34] Alrighty, I will define it as false, and I will leave a comment stating not to change it if you like. [07:45:55] That works with me. [07:46:01] For external image I think there is a legitimate use case but I'm not sure if it warrants changes to ManageWiki settings. Maybe you can get 90% of what you need through the CSP. Plus, IIRC external image isn't too useful anyway since it's really hard to make adjustments to the loaded image. I think Extension:ImgTag gives you the same feature set and more. [07:47:22] I think there is some risk for that being in ManageWiki, and I feel it may make some things confusing as well. It's a little complex configuration for most people and kinda just bloats ManageWiki IMO also. [07:48:30] Anyway I kinda had a minor emergency today so I wasn't on much, and likely won't be for the next day or two just an FYI. [07:48:43] I can see that you want to remove `Maintenance script` and `FANDOMbot` from the list, but for that use case the `IgnoreUsernames` setting alone is probably sufficient. Alternatively the `IgnoreBots` and `IgnoreBlockedUsers` combination probably work as well. [07:49:19] [1/2] I see that IgnoreBots is already an option. So maybe there is an easy to get what you need with the minimal changes. [07:49:19] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1566358463351890020/image.png?ex=6ae8407f&is=6ae6eeff&hm=30515b725e09247105b5a1674a9c8925e92642b9bd02a2c974f29a7f6c9f1da9& [07:49:25] I need it for RobloxAPI for retrieving images from Roblox's CDN, I could ask for a CSP review, but I don't want to wait even longer for someone to do that. [07:50:01] I can approve a CSP within 2 or 3 days probably if you want that. [07:50:21] I am planning to go through all CSP stuff pending my review in a couple days. [07:51:16] [1/2] I think it already works? [07:51:16] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1566358950075699320/image.png?ex=6ae840f3&is=6ae6ef73&hm=fd2d1a39c1540643ff4e38f967cc4d1328031cde75eacf05cc3073ba503dab14& [07:51:22] We already allow people to use external images on their wikis, so allowing a whitelisted version that bureaucrats can control shouldn't be an issue. [07:54:37] https://cdn.discordapp.com/attachments/1006789349498699827/1566359797580963860/image.png?ex=6ae841bd&is=6ae6f03d&hm=f87f53faafae11eba2a855f1e7c546a8fd19a21a7102ea0a323268515ba5e683& [07:54:51] https://cdn.discordapp.com/attachments/1006789349498699827/1566359855629860986/image.png?ex=6ae841cb&is=6ae6f04b&hm=cd22cb4074a690d0410f3d0df3a505d97620b140e0cad185b40c0a0b6cf7652e& [07:55:22] [1/2] https://discord.com/channels/407504499280707585/1006789349498699827/1566357634141913139 [07:55:22] [2/2] > I think Extension:ImgTag gives you the same feature set and more. [07:55:27] Unless you meant it as an example, I don't believe wikitext can parse imhg tags. [07:56:50] Yeah okay, that works. [07:57:03] It would've been nicer if someone pointed this out almost a month ago. [07:58:22] I didn't know about that or rather forgot I think. I've lost track of all of our extensions and exactly what they do lok... [07:58:22] Anyways, if there are other more reliable ways of using external images within wiki articles than relying on using external images, then external images should probably be disabled? [07:59:07] [1/2] You asked for `wgEnableImageWhitelist` so I didn't say anything because ImgTag by default allows for external images from everywhere. There is a whitelist setting but adding a ManageWiki option to the extension adds the same amount of bloat as adding a new core setting. [07:59:07] [2/2] Though now that I think about it only wikis with ImgTag will see the new setting so it is less bloat for most wiki. [08:00:31] I don't think "bloat" matters when it comes to configuring wikis, a redesign of ManageWiki could fix that problem. [08:00:32] We also have an adjustable CSP now which we didn't have back then. This also makes things a lot easier since you can just remove websites you don't need from the `img-src` directive. [08:02:32] IgnoreUsernames would be used for users who either caused vandalism, spam, farmed edit counts, etc. [08:04:37] [1/3] Having too many options hides the really useful ones. For example I think very few people have read through everything in ManageWiki/settings due to its sheer length. A lot of settings should be fine being left as default am I'm not sure why we have these in ManageWiki. [08:04:37] [2/3] Same goes for extensions. We have an extension that adds hieroglyphics support in the same list with DynamicPageList4 and EmbedVideo. [08:04:38] [3/3] https://cdn.discordapp.com/attachments/1006789349498699827/1566362311994908672/image.png?ex=6ae84414&is=6ae6f294&hm=7900444834220b80bdaad3d8d21883b046182b023aff056779edf2b7b6769945& [08:04:52] Yeah I think adding `IgnoreUsernames` alone would be good enough for the use case. [08:05:09] Bots can be excluded through this setting as well. [08:06:04] I think ManageWiki needs to change, rather than us limiting what users can change just because someone isn't using it, or it doesn't seem useful for everyone at this moment. While Special:ManageWiki/extensions gives you a link to configure the settings for that extension, we should be splitting MW core settings from extension settings. [08:06:13] But since this is limited to ContributionScores it's not a huge issue because only wikis that enable CS will see it in their settings. I just prefer to add the minimal settings to achieve what you need. [08:06:53] Also, should CacheTTL for ContributionScores be `managewiki-restricted`, or have pre-approved values in an options list? [08:07:44] Cause you can define how long values are cached for, default is 30 minutes. [08:08:56] I don't think we want this value to be adjustable? It doesn't seem very useful and could have some serious performance implications. [08:10:04] TBH I thought this whole time that Special:ContributionScores is populated by the update special page maintenance script, as trying to create it in a web request is very likely to time out out a large wiki. [08:11:08] [1/2] That special page is frequently inaccessible on Moegirlpedia due to the sheer number of edits and I think the extension is uninstalled in the end. [08:11:08] [2/2] We don't have any wiki with a comparable size using the extension fortunately. [08:13:50] I can remove the setting if we don't want it configurable. [08:27:14] If it's in LocalSettings.php alone it should be fine? [08:27:52] Well yeah, we can force it to keep the extension default value, just like `DisableCache`. [08:29:51] I've updated the PR. [08:32:42] what about https://github.com/miraheze/mw-config/pull/6621 ? can this be safely merged? [08:56:40] [1/2] I think it needs approval first, which should be pretty easy since YouTube is already in the CSP. [08:56:40] [2/2] But I think you need to explain in the task why they are needed and provide examples where the fetch fail. [08:57:35] Is `wgContribScoreUseRoughEditCount` ever going to be needed? I find it implausible tbh [08:58:46] For larger wikis, I think it would be beneficial as it helps alleviate any performance issues that may arise. [09:03:27] Yeah though I don't think it's a huge issue so the wikis we have so I'm a bit reluctant to add it preemptively. If perf issues ever happen local admins probably won't know about the existence of this setting anyway, and it gives a footgun to anyone who is curious enough to see this setting. [09:09:31] can you guys close [[mh:evade]] [09:09:32] [09:09:37] seems to be a duplicate wiki of [[mh:wikivade]] [09:09:37] [09:24:23] i don't really care if it doesn't popup a tip [09:24:46] but it's an approved csp and adding it can suppress the popup so i want to request [09:28:26] and i've explained in the tasks. one blocks the minify mapping; one blocks the images [09:33:50] [1/5] Up to @cosmicalpha I guess. We have 3 right now: [09:33:50] [2/5] * https://issue-tracker.miraheze.org/T16417 [09:33:50] [3/5] * https://issue-tracker.miraheze.org/T16416 [09:33:51] [4/5] * https://issue-tracker.miraheze.org/T16424 [09:33:51] [5/5] The CF one we can probably blacklist in MirahezeMagic so that it doesn't show up in the popup. The remaining 2 provide marginal features which could either go into a blacklist or be added to the CSP. [09:34:06] Mostly depends on how useful we think they are. [09:34:46] Meanwhile deployment of @jenny_on_wiki's PR to prod failed likely because `GlobalSettings.php` is populated before anything else and cannot see the `$wmgScribuntoShareInvocationEnv` variable. Strangely enough this is not a problem on test151. [09:35:30] https://issue-tracker.miraheze.org/T16417#328159 [09:36:06] @posix_memalign did you say somewhere you wanted a custom domain on beta? [09:36:23] We do need that to test some cookie issues. [09:36:30] the cf one blocks devtools from debugging [09:36:44] Yeah. There's a CentralAuth cookie bug that only triggers for custom domains. [09:37:03] Remind me in like 2 hours [09:37:05] The CF one I am hesitant about. I will review it more later. [09:37:07] I had it working before [09:38:16] [1/2] like this [09:38:16] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1566385879444889731/image.png?ex=6ae85a07&is=6ae70887&hm=2bdb36bd41e3d2c5924a69e8fba017ecd53591401a92cf1c365fa5d251705902& [09:38:44] js works but it's difficult to debug with the minified variables [09:39:11] It is somewhat unlikely to be approved because of the way CF can inject some things and do tracking which this would open us up more to. Can't say for sure until I look more though. [09:40:10] CA and I might be asleep but I guess anyone in this server can send the reminder. [09:40:34] I just realized Daylight savings just ended lol. [09:40:52] Yes [09:41:02] My week of being confused as to what time you Americans are is over [09:47:08] Never mind there are lots of other stuff that use wmg variables. Probably due to opcache. [09:47:18] oh i just noticed the packages i use also exist on npm so i can actually use jsdelivr [09:48:23] i'll check if they all exist on npm i'll simply withdraw the request. i just used what's easier to find at that time without being aware the difference between jsdelivr and cf [09:50:58] Likely opcache yeah [09:51:45] [1/15] @cosmicalpha I think canary checks fail no matter what. [09:51:46] [2/15] ``` [09:51:46] [3/15] petramagna@mwtask181 /s/m/config> sudo -u www-data git reset --hard 80583a36cdc3feff4cb5c835713648de8d54d4f6 [09:51:46] [4/15] HEAD is now at 80583a36 Fix markers not showing in Kartographer (#6617) [09:51:47] [5/15] petramagna@mwtask181 /s/m/config> mwdeploy --config --servers=all --versions=all --debug [09:51:47] [6/15] Execute: sudo -u www-data rsync -R --update -r --delete --exclude=PrivateSettings.php --exclude=OAuth2.key --exclude="ExtensionMessageFiles-.php" --exclude="." /srv/mediawiki-staging/./config /srv/mediawiki/ [09:51:47] [7/15] Completed (0) in 0s! [09:51:47] [8/15] Canary check passed for publictestwiki.com@localhost. [09:51:48] [9/15] ``` [09:51:48] [10/15] and then [09:51:49] [11/15] ``` [09:51:49] [12/15] Canary check failed for publictestwiki.com@mw151. Aborting... - use --force to proceed [09:51:50] [13/15] FAIL mw151 [09:51:50] [14/15] config [#-----------------------------] 4% (1/24) [09:51:51] [15/15] ``` [09:52:02] Also fails on a known good commit [09:52:48] Maybe has something to do with https://github.com/miraheze/puppet/commit/392615c65 ? [09:53:12] I tested it after that was deployed and it worked [09:53:24] mwtask181 no longer has access to the public network [09:53:44] Once I dropped the public IP I tested it and it worked. [09:53:54] Is it safe to copy mwdeploy, add a bunch of debug statements, and then run `./mwdeploy`? [09:54:20] Seems safe since it's a self-contained python script [09:54:27] It's safe but you can just use --force for this if you want. I confirmed PTW on 151 works. [09:55:43] i've updated my pr [09:56:11] hmm. It does seem to work? [09:56:39] [1/14] ``` [09:56:39] [2/14] ==> Starting deploy of "{'pull': 'config', 'config': True, 'nolog': True}" to all [09:56:40] [3/14] Execute: sudo -H -u www-data git -C /srv/mediawiki-staging/config/ pull --quiet [09:56:40] [4/14] Completed (0) in 0s! [09:56:40] [5/14] Execute: sudo -u www-data rsync -R --update -r --delete --exclude=PrivateSettings.php --exclude=OAuth2.key --exclude="ExtensionMessageFiles-.php" --exclude="." /srv/mediawiki-staging/./config /srv/mediawiki/ [09:56:41] [6/14] Completed (0) in 0s! [09:56:41] [7/14] Canary check passed for publictestwiki.com@localhost. [09:56:41] [8/14] ==> Deploying config [09:56:41] [9/14] Execute: sudo -u www-data rsync -R --update -r --delete --exclude=PrivateSettings.php --exclude=OAuth2.key --exclude="ExtensionMessageFiles-*.php" -e "ssh -i /srv/mediawiki-staging/deploykey" /srv/mediawiki/./config www-data@mw151.fsslc.wtnet:/srv/mediawiki/ [09:56:42] [10/14] Completed (0) in 0s! [09:56:42] [11/14] Canary check passed for publictestwiki.com@mw151. [09:56:43] [12/14] OK mw151 [09:56:43] [13/14] config [#-----------------------------] 4% (1/24) [09:56:44] [14/14] ``` [10:06:45] [1/2] Still failing on my end. I think I might know why. The "X-Served-By" should've been mw151 for the canary check but it shows mw201 [10:06:46] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1566393049964085279/image.png?ex=6ae860b5&is=6ae70f35&hm=fb6b136bc8cb1b9155b11bb07292b00b2e47895e488d4c1eaf8e209d30c1b998& [10:08:24] [1/2] Tried again. [10:08:24] [2/2] https://cdn.discordapp.com/attachments/1006789349498699827/1566393464516776098/image.png?ex=6ae86118&is=6ae70f98&hm=7de5982f3fac8b8a964bfe43f131ed7cc93231125e597f4595c7b8a9da470cfc& [10:09:42] I force deployed. This is quite mysterious though. [10:26:47] That would indicate a varnish problem [10:26:50] I think [10:26:54] Or Cloudflare end [10:27:05] @paladox you able to look ^ [10:42:09] It wouldn't be Varnish, it might be haproxy, but I can't reproduce it. [10:46:38] Canary checks succeed for me as well now... [10:47:41] Very odd... [12:18:09] [1/4] https://cdn.discordapp.com/attachments/1006789349498699827/1566426113658593521/image.jpg?ex=6ae87f80&is=6ae72e00&hm=f5978bfc9017a0154728ad7a0ba3bc3b57b1d54b76a321d7c3acff1a04bd0e0f& [12:18:09] [2/4] https://cdn.discordapp.com/attachments/1006789349498699827/1566426114337931274/image.jpg?ex=6ae87f80&is=6ae72e00&hm=69f44b5987b471ac77763eec7df9b808c9d385a0ab6062d0d004e4235bd6d225& [12:18:09] [3/4] https://cdn.discordapp.com/attachments/1006789349498699827/1566426114660765918/image.jpg?ex=6ae87f80&is=6ae72e00&hm=695eef83fd67bed9bae13201f61530236ab81a20aa5e718ddf2d9bf6c0ff534e& [12:18:09] [4/4] https://cdn.discordapp.com/attachments/1006789349498699827/1566426115176923199/image.jpg?ex=6ae87f80&is=6ae72e00&hm=29b9c7fe8096b55a691ce606edc43118a1184c218a67b2132acf2e3c62d3abd7& [12:40:33] @posix_memalign I tried to setup https://bluemoon.rhinosf1.com/ but it didn't work [12:40:42] I'll debug this afternoon and try to get it working [12:47:08] that's just weird, it shouldn't be doing that: https://github.com/miraheze/puppet/blob/main/modules/varnish/templates/default.vcl#L252 [12:51:34] maybe it is haproxy? @cosmicalpha did some changes to load balance haproxy [12:54:38] > http-reuse always [12:54:47] we can't use that with cloudflare [12:57:55] is this a new script you're trying? [13:00:04] changing it to never didn't fix it. [13:01:10] i don't believe your script set DEBUG_ACCESS_KEY [13:05:34] i dunno why this is happening @cosmicalpha [13:06:07] debug shows as false here. Doesn't it have to be true? [17:38:03] I copied mwdeploy and added a print line to show the `X-Served-By` header in the request. [17:44:32] Can I make a Phorge issue for the blacklist? [17:45:45] It used to do that anyway [17:45:51] I guess that got lost in the redo [17:46:00] It used to show the output of the check if it failed [17:46:08] For the reason it's normally hard to tell [17:46:54] If the `X-Served-By` header does not contain `Debug` it'll print debug false even though `--debug` is passed to the script. [17:47:11] Yeah feel free to do so [17:47:40] That makes no sense [20:05:38] That's how it always was [20:06:46] That probably is why. I wrote the original bit. [20:08:35] haproxy is possible but what's weird is it only happened for a second then worked again. [21:06:14] [1/5] bro [21:06:14] [2/5] https://cdn.discordapp.com/attachments/1006789349498699827/1566559000626077706/1.jpg?ex=6ae8fb43&is=6ae7a9c3&hm=ba06e60aa5862a3bb674665ec4c1ad53ffaa335792a831e5d5b3453113142105& [21:06:14] [3/5] https://cdn.discordapp.com/attachments/1006789349498699827/1566559001137651792/2.jpg?ex=6ae8fb43&is=6ae7a9c3&hm=6c1b2abe6eea02ab50c6eda554be6d81742553aea7c42c46f834b3199c48dd5c& [21:06:14] [4/5] https://cdn.discordapp.com/attachments/1006789349498699827/1566559001729179678/3.jpg?ex=6ae8fb43&is=6ae7a9c3&hm=c8601d1b672bfa786afb23cff3a870b52e4adcbe9d16ff1e3f7e3cc9319128ab& [21:06:15] [5/5] https://cdn.discordapp.com/attachments/1006789349498699827/1566559002345738270/4.jpg?ex=6ae8fb43&is=6ae7a9c3&hm=cc2ad54ed901427d101798554ab65db8a86f14bc919479bc5bc276c80f6ef6ac& [21:45:40] [1/4] @paladox @rhinosf1 @posix_memalign [21:45:40] [2/4] https://github.com/miraheze/puppet/pull/5139 [21:45:40] [3/4] should fix that issue with debug. The issue was that it was forwarding from bastion IPv4 which isn't in the wikitide_nets ACL, so X-WikiTide-Debug doesn't work without X-WikiTide-Debug-Access-Key from IPs other than our internal network (which that ACL defined) so under certain circumstances (not always) it wasn't applying because sometimes it used bast IPv6 which was in there an [21:45:41] [4/4] d other times used V4 which wasn't. [21:46:04] Ah thanks [21:51:57] No problem and it does seem that worked. I was debugging with `curl -i --proxy http://bastion.fsslc.wtnet:8080 -H 'X-WikiTide-Debug: mw151' 'https://meta.miraheze.org:443/w/api.php?action=query&meta=siteinfo&formatversion=2&format=json'` which I could always reproduce the issue with in Meta but not PTW sometimes (probably haproxy), but it works now. [21:53:28] So it was a mixture of factors, including the change to mwdeploy to proxy through bastion when I made mwtask181 use internal network only. [21:55:03] I will probably launch mwdeploy server later also. I am not home today, hopefully tomorrow. Easier to launch VMs from PC then phone (though I have from phone before lol)