[13:14:07] watching [13:24:32] There are some issues with the PR, that I will work more on it once I prep my env [13:44:10] replied [13:44:44] sorry the discussion took place on a different server [14:45:49] what other issues did you spot? [14:49:17] I just sent my review; forgot to submit that [15:10:01] that's not my fault. it's code already in the repo [15:10:16] and that philosophy again, trust LocalSettings. If system admins really want to begin with $1 they should be prepared for xss [15:11:23] this mr was made mainly to fix feature imperfections in !18 bc the implementation of !18 is poor to use. i assume security review was already done bc it's already merged [15:20:26] btw other than feature imperfections i also spotted some other bad designs, like much redundancy of configs. also this $1 replace thing with potential security issue. i kept most of them for backward compatibility [15:51:35] i added a new commit to fix this [16:09:39] [1/2] > I'd push back on the "trust LocalSettings" part, though. The sysadmin isn't the one supplying the dangerous input here. [16:09:40] [2/2] What LLM wrote this? [16:25:59] [1/3] RE: CSP, would that be hooked into ContentSecurityPolicy.php too? The main thing to bring up is the injected JS, and things like Common.js that import things from jsdelivr and Wikimedia like gadgets. [16:26:00] [2/3] One level to allow this is `strict-dynamic`; the issue is that it then treats every resource loaded by one with a nonce/hash as trusted, which eliminates the big XSS advantage of it. [16:26:00] [3/3] I forgot what else I want to write [16:26:25] Uhh, can resources that are in script-src be loaded by a nonce'd script? [17:24:44] I've merged your PR; I've started working through a full audit of the entire extension and will clean up any outstanding issues (so Tech I would hold off on updating it until v1.1.0 is released [17:36:51] i also made a task on the managewiki addition [[phab:T16456]] [17:36:52] [20:35:21] [1/3] Are you referring to Redmin's proposal for further tightening the CSP? This seems to be what `strict-dynamic` is for, though I think with how complex MW and all its extensions are, it'll be very difficult for us to get things to work on our end without upstream pushing aggressively for it (the same way they force Parsoid on everyone else). [20:35:22] [2/3] So unless we discover 10 XSS vulnerabilities as bad as https://phabricator.wikimedia.org/T401099 every year I doubt there will be a strong enough willingness for this line of anti-XSS defense. [20:35:22] [3/3] I'm not sure if I understand what you mean by hooking into ContentSecurityPolicy.php. [20:53:09] @honoka55 https://gitlab.com/telepedia/extensions/userprofilev2/-/releases/v1.1.0 [20:53:25] someone will need to do a new security review on it before it can be live