[10:33:33] <plat0>	 hiya! been trying to get Phorge to run under Fastly and I think I spotted an incompatibility; it seems like the self-check at https://we.phorge.it/source/phorge/browse/master/src/applications/config/check/PhabricatorWebServerSetupCheck.php$58 is being sent as a GET request, which Fastly strips the body of; are there any cases where this would be actually sent as a GET request, or would 
[10:33:33] <plat0>	 `->setMethod('POST')` suffice for a fix? (seems to work locally, pondering whether it's something Phorge would like contrib'd)
[16:04:45] <twentyafterfour>	 plat0: I'm not sure I understand why fastly would strip the body off but if it works as a post and it makes things work with fastly then that seems like an improvement worth merging.
[16:06:27] <plat0>	 twentyafterfour: yeah, not really sure why they do that either, and as much as I agree with merging, was curious if there were any other GET-exclusive uses that would break before doing a differential patch for a merge^^
[16:06:41] <plat0>	 don't wanna break existing behavior just because of a really weird setup :P
[16:07:09] <twentyafterfour>	 I'm not very familiar with the setup checks myself.
[16:07:40] <twentyafterfour>	 I could test it locally on my dev instance to confirm it works as a post, but I can't see why it wouldn't 
[16:08:02] <plat0>	 I looked a bit into its history (been trying at this for 4 days now lol), seems to be related to conduit or arc(?) payloads being oversized, and epriestley committing a change that allows them to be gzipped
[16:09:20] <plat0>	 https://secure.phabricator.com/T13507
[16:13:05] <plat0>	 found the exact commit the check was introduced in: https://we.phorge.it/rP6b05d2be287ec61b4d898c2438158f84e170580f
[16:19:43] <twentyafterfour>	 plat0: interesting.  looking
[16:20:11] <twentyafterfour>	 so maybe it's detecting a legit problem? 
[16:20:24] <twentyafterfour>	 I wonder why fastly is mangling the git request 
[16:23:28] <plat0>	 s/git/get/? git works fine on my end :P
[16:25:07] <plat0>	 https://stackoverflow.com/a/983458: from HTTP/1.1 2014 Spec: "A payload within a GET request message has no defined semantics; sending a payload body on a GET request might cause some existing implementations to reject the request."
[16:25:39] <plat0>	 I guess it's all implementation specifics on webserver/proxy/cache layer, so upstream introduced UB?
[16:26:25] <twentyafterfour>	 lol yeah get not git 
[16:27:01] <twentyafterfour>	 oh ... 
[16:27:31] <twentyafterfour>	 I'm now extra confused about why this setup check exists 
[16:28:48] <twentyafterfour>	 it seems like it should have been a post all along and it just worked because most servers don't strip the body even though they could/should
[16:29:11] <twentyafterfour>	 so yeah I think this is a bug in the check and should probably be fixed to be a post 
[16:29:36] <twentyafterfour>	 epriestley probably just didn't notice because the normal apache setup allows it 
[16:30:27] <plat0>	 more than likely :P
[16:30:36] <twentyafterfour>	 well I'd be glad to accept the patch if you want to submit at we.phorge.it, good work tracking down the details on this
[16:30:42] <plat0>	 i guess time to break out arcanist on this windows install :D
[16:30:50] <twentyafterfour>	 oh fun
[16:31:08] <plat0>	 totally not 3rd reinstall of the year
[16:31:23] <twentyafterfour>	 arc on windows used to be a pain, I think it actually works pretty good these days but I never use windows so it would be just heresay 
[16:32:04] <twentyafterfour>	 the last version of windows that I used on a daily basis was XP 
[16:32:15] <twentyafterfour>	 well, XP Media center edition. 
[16:32:24] <plat0>	 mood, stuck on it cause of wireless VR atm :/
[16:33:33] * twentyafterfour switched to Linux around 2006, the year of the linux desktop. 
[16:34:11] <plat0>	 every year is the year, im sure this will be THE one :)
[16:34:17] <twentyafterfour>	 ™
[16:35:58] <plat0>	 twentyafterfour does arcanist work on php8 yet or should i stick to 7.4?
[16:36:22] <plat0>	 doc says last-updated stable was 5.4.6 :P
[16:36:31] <twentyafterfour>	 I'm not entirely sure, I think it works but there may still be bugs lurking 
[16:36:48] <plat0>	 eeee, 7.4 it is i guess, need something stable for now^^
[16:37:23] <twentyafterfour>	 we've had a lot of little annoying php 8 issues but they have slowed down recently 
[16:37:43] <twentyafterfour>	 the main phab app seems to be pretty good now I'm running 8 locally 
[16:37:53] <twentyafterfour>	 and I think arc at least on linux works fine with 8
[16:38:18] <twentyafterfour>	 it worked for me but I've only submitted a few small diffs with it 
[16:42:05] <plat0>	 cls
[16:42:11] <plat0>	 darn you alt-tab!!
[16:42:54] <plat0>	 went w/ php7.4 for now for the sake of keeping it stable and happy :)
[17:13:19] <plat0>	 oof, that took longer than i wanted; kept fighting with arcanist because it apparently *really* doesn't like being on windows
[17:14:13] <plat0>	 xphpast compile script expects `rm`, `g++` in path (both fixed with git bash ofc), but then it took me on an adventure down line-ending lane :)
[17:21:46] <twentyafterfour>	 oh boy fun
[17:22:37] <plat0>	 yep. " Exception: Definition of class 's NuanceQue' in file 'applications/nuance/storage/NuanceQueue.php' duplicates prior definition in file 'applications/nuance/query/NuanceQuery.php'"
[17:22:57] <plat0>	 i might just spin up wsl for it lol
[17:53:57] <plat0>	 twentyafterfour whew, took me too long but here ya go^^ https://we.phorge.it/D25566
[17:55:26] <plat0>	 I might have a look at all my arcanist troubles later & try to upstream some fixes (hopefully for perf too, lint step took aaaages on Windows, while in wsl it took ~20s or so)
[18:12:10] <twentyafterfour>	 plat0: awesome, thank you!  I accepted the diff
[18:13:09] <plat0>	 :D