[08:51:45] <arturo>	 slyngs: hello! reminder that puppet seems still broken in cloudweb2002-dev
[08:51:47] <arturo>	 https://www.irccloud.com/pastebin/1lhdD0li/
[08:52:45] <slyngs>	 Looking at it right now. I'm sort of annoyed that it picks up none of the default values
[08:54:35] <arturo>	 slyngs: I think the hiera key may be misplaced
[08:55:01] <arturo>	 slyngs: `profile::idp::redis_enable` is defined in `hieradata/role/common/idp.yaml`
[08:55:11] <arturo>	 but that file wont be looked up for cloudweb2002-dev
[08:55:57] <arturo>	 because the role for cloudweb2002-dev is `wmcs::openstack::codfw1dev::cloudweb`
[08:56:21] <slyngs>	 Yeah, I'll just put it with the old memcache config
[08:56:35] <arturo>	 I think there are 2 options here
[08:56:48] <slyngs>	 hieradata/hosts/cloudweb2002-dev.yaml or the role
[08:57:05] <arturo>	 the host one is usually not a good pattern
[08:57:09] <slyngs>	 The role seems more correct, but everything else is defined for the host
[08:57:17] <arturo>	 it should be either in the cloudweb2002-dev role, or in the idp profile itself
[08:57:56] <slyngs>	 The profile is good, let's do that
[08:58:29] <arturo>	 example, either `hieradata/role/codfw/wmcs/openstack/codfw1dev/cloudweb.yaml`
[08:58:29] <arturo>	 or
[08:59:05] <arturo>	 `hieradata/common/profile/idp.yaml`
[09:00:41] <arturo>	 I see other keys in the host override
[09:00:54] <arturo>	 that is a bit problematic if we for example replace the server, all that will get lost
[09:01:03] <slyngs>	 I'd like to remove those
[09:02:36] <arturo>	 ok
[09:02:41] <arturo>	 we can do 2 patches
[09:02:44] <slyngs>	 Yes
[09:02:46] <slyngs>	 agreed
[09:02:50] <arturo>	 one to fix the immediate puppet error
[09:02:58] <arturo>	 other to relocate/cleanup as required
[09:03:23] <slyngs>	 I'm just running PCC on https://gerrit.wikimedia.org/r/c/operations/puppet/+/1082423
[09:04:45] <arturo>	 slyngs: +1'd
[09:04:51] <arturo>	 PCC lgtm
[09:07:56] <slyngs>	 Puppet running again
[09:11:04] <arturo>	 slyngs: great, thanks!
[09:11:15] <arturo>	 I'll step out for a bit, back in like ~20m
[09:11:49] <slyngs>	 I'll just make a task for cleaning up the hiera data. It would be nice to get that done before trying to upgrade to CAS 7 for those hosts.
[12:59:46] * arturo nursery run & food time