[12:49:25] <federico3>	 Amir1: regarding https://gerrit.wikimedia.org/r/c/operations/cookbooks/+/1193835 is Puppet not removing the previous installed package?
[12:49:43] <Amir1>	 nope
[12:49:55] <Amir1>	 (as in, mot removing)
[12:50:16] <federico3>	 but it will install the new version when apt dist-upgrade runs? they don't declare conflict with each other? 
[12:50:49] <Amir1>	 it will try to install the new version and if the old version is installed, the puppet run will fail
[12:51:01] <Amir1>	 so it does handle one part but not both
[12:52:01] <federico3>	 also, for minor version upgrades we had  apt dist-upgrade *run by the cookbook* do the actual package upgrade. Are you saying that in this case puppet itself is running apt?
[12:53:05] <Amir1>	 it's different than that. puppet runs apt because the package listed as ensure present is missing. When the package is present, nothing will be run
[12:53:24] <federico3>	 (I'm not too happy with mixing puppet-driven apt runs with manual ones and cookbooks running apt )
[12:55:20] <Amir1>	 puppet is responsible for making sure the package is installed and nothing more. If you're really unhappy, you can force install new version instead of letting puppet do it but then you need to add an argument for it for the cookbook and so on.
[12:56:43] <federico3>	 no it's fine, I meant I'm not 100% happy because it's a bit messy but I'll add a bunch of safety checks and logging
[16:29:03] <federico3>	 I updated the CR with logic to remove the package as needed and a good cleanup for better readability/safety