[06:43:25] <marostegui>	 federico3 dhinus why does this alias has only these 3 hosts? db-clouddb-sanitization: P{an-redacteddb1001.eqiad.wmnet or clouddb1016.eqiad.wmnet or clouddb1020.eqiad.wmnet} 
[08:10:57] <federico3>	 I'm not quite sure where the aliases are configured, looking into puppet
[08:14:51] <federico3>	 indeed: modules/profile/templates/cumin/aliases.yaml.erb
[08:17:38] <federico3>	 marostegui: unlike other aliases, this one hardcodes the hostnames: https://phabricator.wikimedia.org/P85574 
[09:08:40] <dhinus>	 marostegui: federico3: I'm not sure, but my guess is that it was created for some form of testing, to test one host per each "type"
[09:09:14] <dhinus>	 maybe just for use with cumin?
[09:09:39] <federico3>	 anyhow ideally we might want to stop hardcoding hostnames into aliases.yaml.erb 
[09:09:56] <taavi>	 does anythign actually use that alias?
[09:10:32] <dhinus>	 git blame points to https://gerrit.wikimedia.org/r/c/operations/cookbooks/+/1080129/32..52/cookbooks/sre/mysql/sanitize-pii.py#b63
[09:11:02] <federico3>	 taavi: a cookbook does 
[09:12:07] <dhinus>	 btw is it right for that cookbook to only target 3 hosts? from a quick look, I think it should target all
[09:13:12] <federico3>	 dhinus: that's what marostegui was asking
[09:14:49] <federico3>	 yet rather than hardcoding more hostnames I would "tag" the hosts with their alias
[09:22:19] <dhinus>	 yes makes sense, the list will change "soon" as we replace old hosts with new ones
[09:22:48] <dhinus>	 and I think we can destroy that alias completely, my assumption that was used for testing is probably wrong
[09:23:04] <dhinus>	 given that git blame indicates it was created just for use in that cookbook
[09:24:42] <federico3>	 it's being used to check for private data on clouddb hosts in https://gerrit.wikimedia.org/g/operations/cookbooks/+/19f45f8421ec344b8b4377a6f125a795afc866b5/cookbooks/sre/mysql/sanitize-wiki.py#109 
[09:25:29] <dhinus>	 yes but, unless I'm missing something, I think that's wrong, because it will only sanitize 3 hosts instead of all
[09:25:43] <dhinus>	 I think that line should use the "wikireplicas-all" alias
[09:28:04] <dhinus>	 "wikireplicas-all" is already targeting all wikireplicas hosts, without hardcoding: https://gerrit.wikimedia.org/g/operations/puppet/+/production/modules/profile/templates/cumin/aliases.yaml.erb#451
[09:28:04] <federico3>	 dhinus: yes, I'm saying we should fix it. I'm not sure if wikreplicas fits, I'd wait for Manuel to be around
[09:29:09] <dhinus>	 sure, let's make a patch and ask manuel for a review
[09:34:46] <marostegui>	 So my question was because if that alias is used, then it's missing most of the hosts 
[09:35:09] <marostegui>	 But I wasn't sure why it was there and if it's being used
[09:39:11] <jynus>	 gerrit backups are stuck, checking
[09:50:42] <dhinus>	 federico3: can you create a patch for the cookbook? otherwise I'll do it later today
[09:53:32] <federico3>	 marostegui: if we can drop it it's even better, but i'm not sure if we can select the hosts for sanitization more precisely and if it's safe to run it on more hosts
[09:56:22] <marostegui>	 I don't have any strong opinions on that, my point is that that alias is currently wrong