[12:20:31] I wouldn't normally deploy on friday, but if I don't, bad things will happen on monday early hours [12:28:47] federico3: why does user_grant_handler.py (formally add_cumin_grant.py) have a requirement that is only in the dev requirements? [12:34:39] looking [12:35:33] It looks like it is present for the root user on cumin, my concern was that I needed to set up a venv ... so it seems as though it just needs to get moved in the deps [12:35:53] i.e. sudo python3 -c 'import tqdm' is running OK [12:36:23] uhm I'm not seeing it [12:36:49] on cumin venv cannot be set up (pip fetching is blocked) [12:37:05] these scripts rely on deb packages already present on the host [12:38:11] https://gitlab.wikimedia.org/ladsgroup/db-password-rotation/-/blob/main/pyproject.toml?ref_type=heads#L40 https://gitlab.wikimedia.org/ladsgroup/db-password-rotation/-/blob/main/user_grant_handler.py?ref_type=heads#L23 [12:39:38] yes, all those are used for local development and tests. On cumin the whole pyproject is not relevant [12:43:07] Sure, but why make it a dev only dep then? At least uv sync handles it, because dev is added so long as not disabled with UV_NO_DEV [12:46:38] yes, can be moved into a run dependency, works for me [12:47:43] +1 [13:12:48] federico3: one more for you https://gitlab.wikimedia.org/ladsgroup/db-password-rotation/-/blob/main/user_grant_handler.py?ref_type=heads#L241 that seems as though this script will always fail, or am I missing something? [13:17:54] It looks as thought the original script was quite different, do we know when this was last used as the doc show the original script name? [13:22:18] cezmunsta: it has been used, see previous commit and https://phabricator.wikimedia.org/T418849 - there's still some related tasks to be completed in our workboard [13:23:35] cezmunsta: see also the past PRs at https://gitlab.wikimedia.org/ladsgroup/db-password-rotation/-/merge_requests/?sort=created_date&state=all&first_page_size=20 [13:25:06] Well, the commits don't tell me that it has been used :) The past PRs may have been. but the code that I am looking at appeared this year "a7e78be 2026-02-18 15:01:39 +0100 Federico Ceratto Rename and update docstring" [13:25:33] That is when this happened: rename add_cumin_grant.py => user_grant_handler.py (82%) [13:26:24] The code at that point already had SET SESSION sql_log_bin=0 present [13:26:38] sorry I meant "it has been used. Also see previous commits..." [13:27:07] ah are you asking if it has been used recently? I think not [13:27:50] Yes, my concern was that user_grant_handler.py has not been used, at least since it changed from a7e78be [13:28:34] I will proceed with caution aka pdb :D [13:28:37] the assert around orchestrator is because it needs the orchestrator access rights [13:28:43] what do you need it for? [13:29:42] https://phabricator.wikimedia.org/T427884 [13:31:33] I suggest we discuss it on monday's meeting [13:32:04] Yes, I wasn't planning to run it today, just examinig the code [13:32:26] s/examinig/examining/ [13:33:34] cezmunsta: I have a WIP commit for https://phabricator.wikimedia.org/T418844 not ready yet