[00:14:01] AndyRussG: I made a couple of indentation changes - it would be good to deploy this in about an hour [00:21:44] (03PS2) 10Eileen: Run sql to add end dates to old recurring contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715829 (https://phabricator.wikimedia.org/T283798) [00:28:26] ejegg: no further comments there? ^ [00:34:42] (03CR) 10AndyRussG: [C: 03+2] "yeeeeeeeeeeeeeeeeeeeeee" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715829 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [00:43:43] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715829 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [00:45:48] (03Merged) 10jenkins-bot: Run sql to add end dates to old recurring contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715829 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [00:49:07] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/715835 [00:49:28] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/715835 (owner: 10Eileen) [00:53:44] !log civicrm revision changed from e567b4c289 to 7da3eba4f9, config revision is 5f004d94d7 [00:53:47] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:23:00] (03PS6) 10Ejegg: Apple Pay Payment Provider [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702149 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [02:23:42] (03PS3) 10Ejegg: Rename CurrencyRoundingHelper properties [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/715554 [02:23:44] (03PS2) 10Ejegg: Adyen: Add applepay to ReferenceData [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/715774 [02:24:00] (03CR) 10Ejegg: "Thanks for the CR! Comments addressed in PS6" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702149 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [03:00:46] ejegg: AndyRussG - where did we get to on https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/715647 [03:04:02] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Q 2021: Update CiviCRM extensions - https://phabricator.wikimedia.org/T290050 (10Eileenmcnaughton) a:03Eileenmcnaughton [ckeditor5](https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/714837) [export permissions](https:/... [03:45:51] eileen: IIRC there was another upstream change that we could link in the commit message? or push them up separately? [03:45:58] but also not a big deal? [03:46:09] AndyRussG: yeah did I include it or not? [03:46:37] looks like I did - so I guess I can alter the commit message [03:47:16] (03PS3) 10Eileen: Yet another join fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715647 (https://phabricator.wikimedia.org/T289696) [03:47:25] AndyRussG: ^^ [03:50:08] eileen: oki... I am not fully comprehending everything there, but it sounds like enough eyes have checked it out (yours, e jegg's, upstream folks...) so I shall +2 [03:50:32] AndyRussG: yeah - you can kinda see me as the reviewer on that one I guess since Coleman made the change [03:51:02] oki cool! [03:51:09] btw the chicken will be cooked tomorrow [03:51:23] tonight I'm gonna instead get a head start on veggies [03:51:59] (03CR) 10AndyRussG: [C: 03+2] "Yeeeeaaahhhhh!!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715647 (https://phabricator.wikimedia.org/T289696) (owner: 10Eileen) [03:52:22] AndyRussG: sounds yum [03:56:02] ehhh hopefully so! [04:03:14] (03Merged) 10jenkins-bot: Yet another join fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/715647 (https://phabricator.wikimedia.org/T289696) (owner: 10Eileen) [04:13:47] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/715840 [04:14:02] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/715840 (owner: 10Eileen) [04:16:53] !log civicrm revision changed from 7da3eba4f9 to 30cd9c1d90, config revision is 5f004d94d7 [04:16:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [06:18:58] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715874 (owner: 10L10n-bot) [06:22:29] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715874 (owner: 10L10n-bot) [06:23:44] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint Parallel processing roller coaster, and 5 others: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10Eileenmcnaughton) @KHaggard of the... [10:52:10] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Unable to run "Fraud Rejections by IP" report in Civi - https://phabricator.wikimedia.org/T290139 (10RKumar_WMF) [13:45:58] howdy fr-tech [14:07:33] 10fundraising-tech-ops, 10Patch-For-Review: staging-server changes for payments1008 - https://phabricator.wikimedia.org/T289869 (10Jgreen) [14:53:39] damilare: did the overrides work for you? [14:58:48] hi fr-tech [14:59:42] hi jgleeson cstone fr-tech! [15:00:00] hi ejegg [15:00:04] howdy [15:00:11] howdy! [15:02:31] that last meeting on event streaming was an interesting one [15:12:16] the overrides seem to work jgleeson [15:13:26] Although it seems I'm redirected to localhost when I select Adyen checkout from the list [15:14:49] oh interesting [15:15:05] that sounds like the $wgServer vsr might not be set right [15:15:10] var* [15:15:59] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising Sprint NULL calorie food cart, 10fundraising sprint Parallel processing roller coaster, and 5 others: Recurring donors segmentation criteria Civi/Acoustic - https://phabricator.wikimedia.org/T283798 (10KHaggard) Thanks for amending those... [15:24:29] I had set that before not sure why it changed after the setup script... now it's just loading jglesson [15:27:58] oh hey damilare the setup script handles that for you [15:28:08] you shouldn't have to change anything [15:31:18] Ok [16:30:00] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen: duplicate transactions from new integration - https://phabricator.wikimedia.org/T290177 (10MBeat33) [16:47:17] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen: duplicate transactions from new integration - https://phabricator.wikimedia.org/T290177 (10DStrine) @MBeat33 we've confirmed so far that these people have not been charged twice. We're recording this twice in civi. But these donors did get two TY... [16:48:00] (03PS1) 10Ejegg: Adyen Checkout: use auth ref for gateway_txn_id [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715994 [16:50:29] (03CR) 10jerkins-bot: [V: 04-1] Adyen Checkout: use auth ref for gateway_txn_id [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715994 (owner: 10Ejegg) [16:54:33] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen: duplicate transactions from new integration - https://phabricator.wikimedia.org/T290177 (10MBeat33) thanks, @DStrine [16:55:35] (03PS2) 10Ejegg: Adyen Checkout: use auth ref for gateway_txn_id [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715994 [17:03:47] (03CR) 10Jgleeson: [C: 03+2] "Looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715994 (owner: 10Ejegg) [17:06:35] (03Merged) 10jenkins-bot: Adyen Checkout: use auth ref for gateway_txn_id [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715994 (owner: 10Ejegg) [17:07:20] thanks jgleeson|dinner ! [17:08:31] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/715996 [17:09:58] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/715996 (owner: 10Ejegg) [17:10:57] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/715998 [17:11:05] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/715998 (owner: 10Ejegg) [17:11:07] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/715996 (owner: 10Ejegg) [17:12:40] ok, so we need to get rid of the duplicates in Civi [17:20:36] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/715998 (owner: 10Ejegg) [17:31:37] !log updated payments-wiki from c4d56178d0 to f9cbf95a12 [17:31:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:54:03] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen: duplicate transactions from new integration - https://phabricator.wikimedia.org/T290177 (10Ejegg) @MBeat33 We've deployed a fix for the problem, but we haven't gone back and fixed the data in Civi yet. The root of the issue is that Adyen gives a... [18:55:30] 10Fundraising-Backlog: New Adyen integration missing form fields in France - https://phabricator.wikimedia.org/T290197 (10EMartin) [18:55:58] ejegg: thanks for fixing the dupes issue. any insight into why evelyn was seeing errors on the french link even with your new link? [18:56:26] can we tell her to send the link to a small group of french donors? [18:59:04] fr-tech ejegg emartin filed this: https://phabricator.wikimedia.org/T290197 had we been asking for address before? her second point is because she didn't get to go through donate wiki so I'll comment on that [19:01:05] 10Fundraising-Backlog: New Adyen integration missing form fields in France - https://phabricator.wikimedia.org/T290197 (10DStrine) I'm checking on the address. In some places we haven't been collecting certain fields. The second point is not a bug. You didn't go through donate wiki. The link you used had the 3... [19:02:52] ok [19:04:42] @dstrine I was able to resolve the France link issue with what Elliott gave above. I have now sent the France test link to French testers. Rakhi was also able to use the France link from India. That item is resolved. [19:05:38] emartin: it looks like we were never collecting address on France Adyen forms [19:06:08] Ok, that would be a problem for US. We at least need the zip code for best interchange rates [19:06:29] ejegg: I'm not getting the Apple Pay popup when clicking the Donate button after checking out the latest PS on the patches we added [19:06:41] Not that we are running 6ENC this year through Adyen [19:06:59] my local is exposed on https://test1.jackgleeson.co.uk if you wanna see [19:07:39] jgleeson: oh shoot, let me try again locally [19:07:50] I thought I had tested after that last rebase but maybe not [19:08:00] jgleeson: any error in your JS console? [19:08:38] emartin: we DO collect zip code + street address in the US. We have country-specific form fields [19:08:59] hmmm my server just went down [19:09:01] handy [19:09:19] ok, thank you for the explanation on zip code [19:11:03] hmm, it's still working for me on WIP get contact info from Apple Pay sheet (sha 5a8111c1f1ed2e725d743ad2529fcc3b3634302f) [19:11:14] is that the one you're on jgleeson ? [19:12:31] also on the latest PS of Adyen Checkout: Apple Pay (13c0c5c5bc264cb117f96deb66c3e9bff454a8e2) [19:12:55] (03PS9) 10Ejegg: Adyen Checkout: Apple Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/713551 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [19:12:58] (03PS4) 10Ejegg: Apple Pay: correctly format amount for all currencies [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/714876 (https://phabricator.wikimedia.org/T282596) [19:13:02] (03PS6) 10Ejegg: WIP get contact info from Apple Pay sheet [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/715135 (https://phabricator.wikimedia.org/T285722) [19:13:09] oh oops, I had locally rebased those over the logging patch [19:13:18] on DI I'm on https://docs.google.com/spreadsheets/d/1Ng-L0qBWma1U_SHW_u-brtZQSv_PLntyPP9SuknW7Y0/edit#gid=0 [19:13:22] oops wrong pasdte [19:13:24] paste [19:13:34] on DI I'm on b80aa3b53aeff4ab92f1542cb1afc3b1596e8c0e [19:13:47] on SP I'm on d0e9edce838416a107ce1cb4216673f1d2d4afd1 [19:13:56] over at https://test1.jackgleeson.co.uk [19:14:35] ok, try PS9 of that DI patch [19:14:59] the SmashPig patch looks right [19:15:28] also I'll try on test1 from this machine [19:16:23] hmm, taking quite a while to load [19:16:33] maybe hit a breakpoint on your machine? [19:17:11] nope [19:18:00] ejegg: I just need to shut my tunnel down to test out dami's server as he's having problems [19:18:03] 1 min [19:18:58] oh i got an error from your server: POST request to ..../paymentMethods failed 3 times [19:19:11] 10Fundraising-Backlog: New Adyen integration missing form fields in France - https://phabricator.wikimedia.org/T290197 (10EMartin) 05Open→03Resolved a:03EMartin Ok, thank you. Notating that we use different forms for different markets and we don't collect the address in France. [19:21:26] ah dang, i'm getting 'there was an error processing your request' after hitting the touch sensor on that latest patch [19:24:28] sorry ejegg test1 is offline [19:24:41] oh, autoloader weirdness? [19:24:50] I shut it down [19:24:55] mentioned above [19:24:56] sorry jgleeson autoloader weirdness on my local [19:25:00] ahhh [19:25:02] sorry [19:28:04] yeah, I got autoloader weirdness because of that class rename switcheroo in the last PS [19:28:41] so AndyRussG thought the CreateApplePaymentStatus inheriting from CreateDirectDebitPaymentStatus was weird, and I agreed [19:29:32] the generic-sounding CreatePaymentStatus class was really only handling the credit card statuses [19:29:50] Anyway, I renamed CreatePaymentStatus -> CreateCardPaymentStatus [19:29:57] ejegg: [19:30:13] and the direct debit one to just CreatePaymentStatus, so the apple pay one could share it [19:30:19] I think you need to update your config repo [19:30:26] and reapply the overrides [19:30:35] test4's cert is out of date [19:31:05] oh right jgleeson, i just already told Safari to trust it [19:31:28] it's fine that cert won't exist anymore [19:31:46] k, i'll do that in a bit [19:31:55] it got swapped out for the wildcard one and the latest update changes how the overrides work [19:32:03] oh ok [19:32:09] should i do that now? [19:33:39] ok, pulled down PS14 [19:33:55] will re-run setup.sh without destroying containers [19:34:06] jgleeson: or do I need to remove them? [19:35:15] sorry ejegg bit distracted with kids [19:35:20] ok back [19:36:04] so I'd recommend `git checkout mediawiki/LocalSettings.php` to remove the updates made to that file [19:36:41] pull down the latest overrides and then say Yes to destroying containers, updating config-private and applying the overrides [19:36:56] that should then get you to the latest version of that [19:37:56] back shortly [19:38:08] ok, that'll take a bit, but will do [19:54:55] ok, all set [19:56:13] hmm, errors [19:57:18] darn jgleeson|brb it seems to not be listening on the 443 port [19:58:40] if I forward to 9001 it seems to work but with the self-signed cert [19:59:39] so I said Y to Enable ApplePay Payments-wiki override to use ApplePay test server locally? [Yn] [19:59:47] then n to Disable ApplePay Payments-wiki override and restore normal Payments-wiki install? [Yn]n [20:02:24] hmm, but it doesn't seem that the localsettings changes or the apache config got applied [20:03:27] ejegg: I've been in meetings. I see evelyn closed that ticket. Do you think it's alright to ask internal french testers to try out adyen? [20:03:38] yep dstrine definitely [20:03:42] ok thanks [20:07:37] bck ejegg [20:07:52] does the apache config at your end have the Listen 443 line? [20:12:27] jgleeson: no, looks like none of the stuff in the overrides line got applied [20:13:03] I don't see any output at all after between the 'Enable ApplePay' line and the 'Disable ApplePay' line [20:13:21] **** ApplePay test server payments-wiki setup [20:13:21] Enable ApplePay Payments-wiki override to use ApplePay test server locally? [Yn] [20:13:24] Disable ApplePay Payments-wiki override and restore normal Payments-wiki install? [Yn]n [20:13:27] **** Set up Civicrm [20:13:38] I don't see a 'Y' [20:14:14] ejegg: [20:14:39] jgleeson: Y is the default, no? I just pressed enter [20:14:58] if [[ $REPLY =~ ^[Yy]$ ]]; then [20:15:05] is what we're using in some checks [20:15:11] maybe all? [20:15:43] ohh, the [Yn] convention suggests that Y is the default and doesn't need to be pressed [20:16:19] so I'll run that again, but without destroying the containers [20:16:57] it needs to be no by default so I'll change that to yN [20:21:41] (03PS15) 10Jgleeson: Add ApplePay payments-wiki override setup options [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/711216 (https://phabricator.wikimedia.org/T288772) [20:21:44] done [20:22:07] so lemme boot back up my local before I hop off to see if it's working with those patches again [20:22:14] as it wasn't earlier [20:22:42] (bear in mind I'm also now using a new account and not the previously working AD Franch account) [20:23:57] ok tunnel is up [20:24:21] jgleeson: it's all working for me [20:24:54] but I had to fix the autoload file in the vendor dir which was still pointing to a file that's been renamed in the latest SmashPig patch [20:25:42] 'composer dumpautoload' would be the automatic way to do it, lemme see if that works too [20:25:54] 2021-09-01T20:25:46+00:00 5683d90fcf14 SmashPig-Adyen: adyen::25:25.1 | cURL transaction to https://checkout-test.adyen.com/v67/paymentMethods failed: (28) Resolving timed out after 7000 milliseconds. cURL verbose logging: * Expire in 0 ms for 1 (transfer 0x5584493cbba0) [20:26:10] oh weird [20:26:21] DNS issues in your docker image? [20:26:24] POST request to https://checkout-test.adyen.com/v67/paymentMethods failed 3 times. [20:26:27] weird [20:26:37] can you nslookup other URLs from inside the payments box? [20:26:58] it was working earlier... lemme try [20:27:45] if you have to, you can put 193.67.130.57 in that inner hosts file [20:28:11] yep, OK, composer dumpautoload does seem to end up with the correct path [20:28:19] lemme comment that on the PS in gerrit [20:30:39] (03CR) 10Ejegg: "Please note: If using this as a hot-swapped composer library, you will need to run 'composer dumpautoloader' for the latest PS to work. Ot" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/702149 (https://phabricator.wikimedia.org/T282596) (owner: 10Jgleeson) [20:31:29] wth [20:31:36] how did my DNS suddenly break [20:31:45] on the host box too? [20:31:57] ISP troubles? [20:32:04] https://stackoverflow.com/a/45644890 [20:32:10] ubuntu 18 section is what I'm seeing [20:32:19] but this all worked previously [20:32:40] funky [20:32:48] yah much [20:33:40] also grrrrr systemd taking over everything [20:35:10] hmm lemme see if this is a problem on my other stack [20:35:48] ooh fr-tech looks like new-adyen recurrings are having problems getting into Civi [20:36:21] ahh, specifically rtbt [20:36:57] are there non ideal rtbts? [20:37:10] sorry, specifically ideal [20:37:26] https://civicrm.wikimedia.org/damaged/398504 [20:37:26] yeah its missing the step to grab the subscription [20:37:30] k [20:37:40] it comes in on an IPN [20:38:08] oh phooey, do we not get it in the additionalData from the API response? [20:38:13] no [20:38:35] man, that's goofy [20:38:37] although [20:38:52] we can call that API call to get it too but idono if it still wont be there if theres some like bank delay [20:39:03] https://docs.adyen.com/payment-methods/ideal/web-component#recurring-ideal-payments [20:39:49] ok, so it's async-only [20:40:25] well, i guess we can have the listener pick that up and send it to civi [20:41:05] i couldnt get the test env to send over the recurring ipn but if we have example data from this one then I think that WIP patch is almost there then [20:41:05] though that's annoyingly out of order with the initial donation coming in from payments [20:41:14] oh cool cstone [20:42:22] that failmail topic is a bit funny - we DO have a token in that message [20:42:43] no subscr_id, sure [20:45:48] really strange because I don't have the DNS issues on my regular fr-tech docker stack that I use for payments [20:46:30] and the nameserver is the same on both :\ [20:46:42] lemme see what happens if I switch on tunnelling now [20:47:37] ok it loads at https://test1.jackgleeson.co.k [20:47:49] https://test1.jackgleeson.co.uk even [20:48:15] hmm but clicking donate does nothing [20:48:19] same as earlier ejegg [20:50:36] I wonder if I need to set up apple pay on the new account in advance [20:51:21] jgleeson: any errors in the console? [20:52:30] jgleeson it works for me on your server [20:52:41] you have the test card all set up in the wallet? [20:55:01] ahh so it must be the account [20:55:09] just setting up apple pay in advance [20:55:22] good news that it works at your end! [20:55:50] ejegg: I forget whether I had to do that part first, last time around, so I'm doing it now [20:57:52] ok that's it. it was already enabled on the Ad Franch account I was using [20:58:09] Apple Pay can only be enabled on one user on the machine I guess [21:01:40] ok that worked ejegg! [21:07:35] ok the code looks good and seems to be working as expected for me ejegg so it's a +1 but I wanna step through it in debug really before +2'ing to get understanding it better. I'll do tomorrow first thing as I'm leaving now [21:08:12] damilare: I'll also try and work out why test5 isn't letting you tunnel [21:08:24] in the meantime you could use test1 [21:08:30] (I've d/c) [21:09:56] that gateway session id field is huge ejegg [21:10:40] yep yep [21:11:32] ah ok when you b64 decode that it's another big bunch of data with key signatures [21:12:29] ahh, really? I noticed it wasn't the same as the raw token that the apple component gives in the onAuthorized event - I bet that's one of the parts of the big bunch [21:14:39] yeah it looks like this is the full session data [21:15:39] https://phabricator.wikimedia.org/P17133 [21:16:17] huh, ok [21:17:21] might change how we name that field. I seen your TODO on that [21:28:59] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen: duplicate transactions from new integration - https://phabricator.wikimedia.org/T290177 (10MBeat33) thanks, @Ejegg ! [21:29:27] ejegg: AndyRussG I think I need to do a re-removal on end date but permit cancel_action ' (auto) backfilled automated cancel' to be removed since there seem to be cases - eg https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=971987 [21:58:36] (03PS1) 10Eileen: Further fix on end dates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/716047 (https://phabricator.wikimedia.org/T283798) [21:58:56] AndyRussG: ejegg ^^ - on moar data cleanup [22:05:49] well laptop has graduated from completely freezing but now just phpstorm [22:10:11] cstone: hmmmmm did you try updating the graphics stuff? [22:10:37] I did some general updates and it had been behaving [22:10:39] looking eileen [22:10:52] not sure quite how that works on ubuntu but on Debian there are ways to get a more recent package for the graphics system [22:11:10] also, if you're running under Wayland, you might want to try going back to XOrg, or vice versa [22:11:53] ejegg: the second part of Katie's concerns is that we didn't add enough end dates to completed ones - I think that's partly a case of explaining but digging into updating some more [22:12:20] ie status = completed & payments have stopped & end_date not set [22:12:45] - I think it is just more -UI confusing when they have that 'completed' status [22:20:58] okay I have this returning the right stuff but I need help turning it into an update https://etherpad.wikimedia.org/p/adyendouble [22:22:18] cstone: I commented in there [22:22:33] thank you! [22:24:48] (03CR) 10Ejegg: "Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/716047 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [22:25:37] (03CR) 10Ejegg: [C: 03+2] Further fix on end dates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/716047 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [22:25:53] ejegg: I'm trying to get my head around ones like https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=13070474 - how did that get created as 'Complete' - I thought we had ended that - before late 2020 [22:27:52] although, based on the data - maybe it was Jan 2021 [22:28:23] I think perhaps we should fix 'all the completeds' to either a) have an end_date or b be 'In progress' [22:29:05] so for paypal we don't seem to set a status on the contribution_recur, do we? [22:29:20] I think in the end we fixed the default [22:29:20] Hmm, but the default should have changed a while ago too [22:29:30] yeah - I'm starting to think Jan 2021 [22:29:31] in feb 2021 [22:29:37] ah thanks cstone [22:29:49] https://www.mediawiki.org/wiki/Fundraising_tech/Database_cheat_sheet hah [22:30:19] well done! [22:37:19] (03Merged) 10jenkins-bot: Further fix on end dates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/716047 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [22:39:26] (03PS1) 10Eileen: Update in-progress recurrings to have a status of 'in progress' [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/716058 (https://phabricator.wikimedia.org/T283798) [22:40:17] (03PS1) 10Cstone: Fix for duplicate Adyen civi records. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/716059 (https://phabricator.wikimedia.org/T290177) [22:40:29] (03CR) 10jerkins-bot: [V: 04-1] Fix for duplicate Adyen civi records. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/716059 (https://phabricator.wikimedia.org/T290177) (owner: 10Cstone) [22:41:02] I know we are conflicting but just for others to look at for now [22:47:13] cstone: so the actual contributions are being cancelled - not the recurrings? [22:47:28] is that because adyen 'wasn't real' [22:47:31] eileen: I don' [22:47:45] oops, nvm [22:47:52] are there duplicate recurrings too cstone ? [22:47:54] :-) [22:54:31] no recurrings ejegg [22:54:40] ok, cool [22:54:57] oh, eileen were you asking why the first of the two is being set to cancelled? [22:55:13] It's because the one that came in from the listener is the one with the correct gateway_txn_id [22:59:00] (03PS1) 10Eileen: Further addition of end date on past recurrings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/716064 (https://phabricator.wikimedia.org/T283798) [22:59:05] ah ok [23:00:22] ejegg: I think that we can finally put the contribution recur mess to bed if we try to get to the point where all completed have an end date or are switched to in progress - I've put up a couple more patches to that effect - but I added them to the undeployed update - which makes sense if we turn them around quickly, otherwise I'll make a new update function [23:00:46] sure, lemme take a quick look [23:02:45] yep, that seems about right [23:03:47] (03CR) 10Ejegg: [C: 03+2] Update in-progress recurrings to have a status of 'in progress' [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/716058 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [23:03:53] (03CR) 10Ejegg: [C: 03+2] Further addition of end date on past recurrings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/716064 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [23:04:31] thanks ejegg I'll deploy & run those updates & then do some more queries - cstone if you rebase over those I won't add more until yours are merged :-) [23:05:17] ejegg: on the fredge report - I think I addressed your issue [23:05:24] haha eileen :) [23:05:49] oh right eileen that's the next thing I was going to look at [23:11:45] cstone: also - looks like you have some trailing spaces in that commit - might be good to clean them out when you rebase [23:12:06] sounds good eileen [23:13:16] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/716058 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [23:18:05] (03Merged) 10jenkins-bot: Update in-progress recurrings to have a status of 'in progress' [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/716058 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [23:18:07] (03Merged) 10jenkins-bot: Further addition of end date on past recurrings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/716064 (https://phabricator.wikimedia.org/T283798) (owner: 10Eileen) [23:19:20] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/716069 [23:19:58] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/716069 (owner: 10Eileen) [23:24:19] (03PS2) 10Cstone: Fix for duplicate Adyen civi records. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/716059 (https://phabricator.wikimedia.org/T290177) [23:27:12] !log civicrm revision changed from 30cd9c1d90 to ad37f21a7d, config revision is 5f004d94d7 [23:27:14] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:41:50] (03CR) 10Ejegg: Update small code pieces to use more modern PHP 7 syntax (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/683617 (owner: 10Thiemo Kreuz (WMDE)) [23:44:38] dstrine / XenoRyet looks like the sprint didn't get renamed / pic changed. was that becuase of the permissions problem? [23:49:54] (03CR) 10Ejegg: "This mostly works for me locally. Thanks for fixing that yN default indicator. I'd prefer the host port be configurable along with the re" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/711216 (https://phabricator.wikimedia.org/T288772) (owner: 10Jgleeson) [23:54:36] eileen: I don't see a new PS on that fredge report [23:54:42] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/703637 [23:55:03] still getting those 'no such field' errors locally [23:55:14] need to send your local changes up for review? [23:55:25] hmm - maybe [23:55:56] (03PS4) 10Eileen: Update fredge report to show additional information where civicrm reached [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703637 (https://phabricator.wikimedia.org/T285321) [23:56:02] thanks! [23:56:22] ejegg: I'm assuming that patch set was what I meant to push up before... [23:56:27] branch name is 'fredge' [23:56:41] heh, looks like the fixes I was after! [23:56:55] ejegg: yeah I think I just did what you suggested :-) [23:57:27] works for me now! [23:57:30] and the UI looks fine [23:57:55] (03CR) 10Ejegg: [C: 03+2] "PS4 works great, UI looks fine on new civi core" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/703637 (https://phabricator.wikimedia.org/T285321) (owner: 10Eileen) [23:58:01] gotta go help with the kiddo [23:58:05] cool [23:58:07] thanks