[02:12:53] (03CR) 10AndyRussG: "Found a nit! (See inline...)" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/734349 (owner: 10Ejegg) [02:14:53] (03CR) 10AndyRussG: Apple Pay: Validate the validation_url (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732843 (owner: 10Ejegg) [02:19:30] (03Abandoned) 10AndyRussG: [WIP] Refactor ExceptionMapper to handle error code 905 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/736109 (https://phabricator.wikimedia.org/T294032) (owner: 10AndyRussG) [02:20:57] (03Abandoned) 10AndyRussG: [WIP] Adyen Checkout: Update for Exceptionmapper refactor and error 905 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736110 (https://phabricator.wikimedia.org/T294032) (owner: 10AndyRussG) [02:37:17] (03CR) 10AndyRussG: [C: 03+2] "Yayyy cool thanks for this!!!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/735010 (owner: 10Ejegg) [02:42:25] (03CR) 10AndyRussG: "Works great btw! I pushed a change for this for fundraising-dev in config-private (23541baf973eec1e484)." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/734349 (owner: 10Ejegg) [02:43:36] (03CR) 10AndyRussG: [V: 03+2 C: 03+2] Update Main_Page [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/735010 (owner: 10Ejegg) [03:08:01] 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10FR-Docker: Docker dev setup: Fix Amazon testing setup - https://phabricator.wikimedia.org/T293674 (10AndyRussG) I pulled the change in config-private, then accessed my local setup via the proxy server, and it worked great! Thanks so much for... [12:18:17] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7252 7000 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 11 keys, up 1 days 11 hours - memory use is 6.48M (peak 7.41M, 0.13% of max, fragmentation 1.71%), connected_slaves is 3, donations is 29, jobs is 0, jobs-adyen is 1, jobs-paypal is 120, payments-antifraud is 21, payments-init is 51, pending is 6, refund is 0, unsubscribe is 2 [12:28:18] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7272 7000 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 1 days 11 hours - memory use is 6.60M (peak 7.41M, 0.14% of max, fragmentation 1.72%), connected_slaves is 3, donations is 219, jobs is 0, jobs-adyen is 5, jobs-paypal is 115, payments-antifraud is 22, payments-init is 43, pending is 3, refund is 0, unsubscribe is 2 [12:33:17] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7666 7000 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 9 keys, up 1 days 11 hours - memory use is 6.69M (peak 7.61M, 0.14% of max, fragmentation 1.69%), connected_slaves is 3, donations is 57, jobs is 0, jobs-adyen is 0, jobs-paypal is 104, payments-antifraud is 11, payments-init is 5, pending is 8, refund is 0, unsubscribe is 2 [12:38:17] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 8056 7000 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 1 days 11 hours - memory use is 7.13M (peak 7.61M, 0.14% of max, fragmentation 1.62%), connected_slaves is 3, donations is 233, jobs is 0, jobs-adyen is 0, jobs-paypal is 117, payments-antifraud is 4, payments-init is 40, pending is 1, refund is 0, unsubscribe is 2 [12:43:17] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7721 7000 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 11 keys, up 1 days 11 hours - memory use is 6.67M (peak 7.61M, 0.14% of max, fragmentation 1.67%), connected_slaves is 3, donations is 157, jobs is 0, jobs-adyen is 5, jobs-paypal is 96, payments-antifraud is 14, payments-init is 5, pending is 8, refund is 0, unsubscribe is 2 [12:48:20] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7881 7000 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 1 days 11 hours - memory use is 6.72M (peak 7.61M, 0.14% of max, fragmentation 1.65%), connected_slaves is 3, donations is 27, jobs is 0, jobs-adyen is 6, jobs-paypal is 32, payments-antifraud is 19, payments-init is 37, pending is 5, refund is 0, unsubscribe is 2 [12:53:20] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7912 7000 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 1 days 11 hours - memory use is 6.74M (peak 7.61M, 0.14% of max, fragmentation 1.67%), connected_slaves is 3, donations is 125, jobs is 0, jobs-adyen is 3, jobs-paypal is 18, payments-antifraud is 4, payments-init is 2, pending is 4, refund is 0, unsubscribe is 3 [12:58:20] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7920 7000 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 1 days 11 hours - memory use is 6.83M (peak 7.61M, 0.14% of max, fragmentation 1.69%), connected_slaves is 3, donations is 152, jobs is 0, jobs-adyen is 4, jobs-paypal is 20, payments-antifraud is 13, payments-init is 44, pending is 3, refund is 0, unsubscribe is 3 [13:03:20] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7138 7000 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 1 days 11 hours - memory use is 6.13M (peak 7.61M, 0.13% of max, fragmentation 1.79%), connected_slaves is 3, donations is 72, jobs is 0, jobs-adyen is 3, jobs-paypal is 20, payments-antifraud is 5, payments-init is 2, pending is 3, refund is 0, unsubscribe is 0 [13:08:14] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7145 7000 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 1 days 12 hours - memory use is 6.25M (peak 7.61M, 0.13% of max, fragmentation 1.74%), connected_slaves is 3, donations is 53, jobs is 0, jobs-adyen is 1, jobs-paypal is 20, payments-antifraud is 7, payments-init is 30, pending is 3, refund is 0, unsubscribe is 1 [13:13:20] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7152 7000 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 11 keys, up 1 days 12 hours - memory use is 6.22M (peak 7.61M, 0.13% of max, fragmentation 1.76%), connected_slaves is 3, donations is 138, jobs is 0, jobs-adyen is 8, jobs-paypal is 18, payments-antifraud is 19, payments-init is 5, pending is 7, refund is 0, unsubscribe is 1 [13:18:20] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 7173 7000 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 1 days 12 hours - memory use is 6.15M (peak 7.61M, 0.13% of max, fragmentation 1.75%), connected_slaves is 3, donations is 21, jobs is 0, jobs-adyen is 2, jobs-paypal is 12, payments-antifraud is 5, payments-init is 24, pending is 3, refund is 0, unsubscribe is 1 [13:20:17] AndyRussG, cstone: can we please handle/downtime/acknowledge icinga? [13:52:16] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 6416 [13:57:16] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 4917 [14:01:02] hmm let's check those queues out [14:02:14] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 3577 [14:03:20] RECOVERY - check_redis on frqueue1003 is OK: OK: REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 1 days 12 hours - memory use is 4.89M (peak 7.61M, 0.11% of max, fragmentation 1.94%), connected_slaves is 3, donations is 60, jobs is 0, jobs-adyen is 4, jobs-paypal is 13, payments-antifraud is 10, payments-init is 2, pending is 3, recurring is 4868, refund is 0, unsubscribe is 0 [14:06:10] kini [14:06:43] ok looks like the recurring queue is calming down [14:07:07] I'm guessing Paypal hit us with a wave of recurring IPNs [14:07:16] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1575 [14:12:16] RECOVERY - check_mysql on frdb1002 is OK: Uptime: 1607565 Threads: 11 Questions: 90854397 Slow queries: 822 Opens: 402493157 Flush tables: 1 Open tables: 200 Queries per second avg: 56.516 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [14:33:25] RhinosF1: thanks for the heads up. Looks like our icinga alerts for recurring queue messages needs pushing up a little to handle the paypal IPN firehose we've been getting, and consequently the channel spam. I've checked the queues just now and the recurring messages are now ~4k way below the 7k level which triggers the notification [14:33:44] school run, back later! [14:52:24] 10Fundraising-Backlog, 10MediaWiki-extensions-CLDR, 10Continuous-Integration-Config, 10ci-test-error (WMF-deployed Build Failure): quibble-fundraising-cldr-REL1_35-php73-docker is failing - https://phabricator.wikimedia.org/T295114 (10hashar) That is related to Quibble 1.2.0 no more generating PHPUnit JUni... [14:52:48] 10Fundraising-Backlog, 10MediaWiki-extensions-CLDR, 10Continuous-Integration-Config, 10ci-test-error (WMF-deployed Build Failure): quibble-fundraising-cldr-REL1_35-php73-docker is failing - https://phabricator.wikimedia.org/T295114 (10hashar) [14:53:02] 10Fundraising-Backlog, 10MediaWiki-extensions-CLDR, 10Continuous-Integration-Config, 10ci-test-error (WMF-deployed Build Failure): quibble-fundraising-cldr-REL1_35-php73-docker is failing - https://phabricator.wikimedia.org/T295114 (10hashar) 05Open→03Resolved a:03hashar [15:28:22] fr-tech, anyone have any questions they'd like to ask on the adyen call starting shortly? I was planning to ask if they'd managed to figure out how the trxns we provided as examples made it through frontend validation but then failed at backend [15:54:11] (03PS3) 10Damilare Adedoyin: WIP: Handle payment result on reject in validation phase [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/736651 (https://phabricator.wikimedia.org/T295149) [16:05:51] (03PS1) 10Ejegg: Add Apple Pay card-specific strings [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/737420 (https://phabricator.wikimedia.org/T295226) [16:31:52] (03PS1) 10Ejegg: Supposedly clever way to parse Apple Pay cards [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/737426 (https://phabricator.wikimedia.org/T295226) [16:32:14] fr-tech there are two alternatives to fixing the Adyen audit parser ^^^^ [16:32:47] shouldn't need toooooo much context to take a look and let me know which you think is preferable [16:35:45] oh, let me copy that test class over to the simpler fix [16:38:31] ah caught the failmail on those over the weekend ejegg but didn't get to looking into the actual log file [16:38:48] (03PS2) 10Ejegg: Add Apple Pay card-specific strings [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/737420 (https://phabricator.wikimedia.org/T295226) [16:39:20] jgleeson: yeah, instead of just sending 'applepay' in the 'Payment Method' field, they send a different string for each card type [16:39:47] i suspected they might when I saw in the console that you couldn't just search for 'Apple Pay' but had to search for each card's Apple version [16:40:00] ah interesting [16:40:29] So I don't know if we can actually get that card type info from the API calls at the frontend [16:40:48] I've gotta head for an hour but will give them a look later if they're still unreviewed by the time I get to em! [16:40:54] thanks jgleeson [16:40:58] np [16:47:14] fr-tech there's a tiny fix in the dev-images repo to make the IPN listeners work correctly via the wmcloud proxy:https://gitlab.wikimedia.org/releng/dev-images/-/merge_requests/10 [16:49:31] (03Abandoned) 10Ejegg: Apple Pay: Validate the validation_url [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732843 (owner: 10Ejegg) [16:53:57] (03PS4) 10Ejegg: Validate Apple validation_url in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/734349 [16:54:15] (03CR) 10Ejegg: "Thanks for the CR AndyRussG" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/734349 (owner: 10Ejegg) [17:03:09] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-WMF-Audit: Update Civi record with additional data from audit files - https://phabricator.wikimedia.org/T152249 (10Ejegg) [17:19:30] (03CR) 10AndyRussG: [C: 03+2] "lgtm!!! :) :)" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/734349 (owner: 10Ejegg) [17:20:30] (03Merged) 10jenkins-bot: Validate Apple validation_url in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/734349 (owner: 10Ejegg) [17:46:03] ejegg|food: aaarg I'm still unable to sign into gitlab [17:46:17] I could download the patch and test it though [18:03:42] 10Wikimedia-Fundraising-Banners, 10Wikipedia-iOS-App-Backlog, 10Patch-For-Review: 2021 English fundraising messages in iOS app - https://phabricator.wikimedia.org/T294996 (10Tsevener) Just FYI I found a regression in the notifications feature branch when testing this. No change needed in wikifeeds for this b... [18:45:47] jgleeson|away: thanks for explanation [18:46:02] Sorry for slow reply, never got ping [18:49:29] np! [19:09:33] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Amber Johnson - https://phabricator.wikimedia.org/T293679 (10Dwisehaupt) [19:10:29] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: terminal / fredge access for Amber Johnson - https://phabricator.wikimedia.org/T293679 (10Dwisehaupt) 05Open→03Resolved Verified on a call that the config file has been set up and access is working. Closing. [19:27:20] ejegg: I'm leaning more towards the less sophisticated solution for the Adyen Apple Pay reference data fix [19:27:50] we can live with 5/6 applepay specific methods I think [19:29:11] yep, sounds fine to me jgleeson [19:29:29] once I had to add that 'electron' exception the other way stopped seeming better to me [19:33:16] fr-tech here's a second draft outline! https://www.mediawiki.org/wiki/Fundraising_tech/notes/Draft:Documentation_overhaul#Second_draft [19:36:56] (03CR) 10Jgleeson: [C: 03+2] "This looks like a good approach to me. Thanks for the two options!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/737420 (https://phabricator.wikimedia.org/T295226) (owner: 10Ejegg) [19:37:40] (03Abandoned) 10Ejegg: Supposedly clever way to parse Apple Pay cards [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/737426 (https://phabricator.wikimedia.org/T295226) (owner: 10Ejegg) [19:37:48] (03Merged) 10jenkins-bot: Add Apple Pay card-specific strings [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/737420 (https://phabricator.wikimedia.org/T295226) (owner: 10Ejegg) [19:37:58] thanks jgleeson [19:38:10] np [19:38:22] AndyRussG: I REALLY like the layout for documentation [19:40:13] 10Wikimedia-Fundraising-Banners, 10Wikipedia-iOS-App-Backlog, 10Patch-For-Review, 10iOS-app-v6.9-Carp-On-A-Zamboni: 2021 English fundraising messages in iOS app - https://phabricator.wikimedia.org/T294996 (10LGoto) p:05Triage→03Medium [19:41:43] 10Wikimedia-Fundraising-Banners, 10Wikipedia-iOS-App-Backlog, 10Patch-For-Review, 10iOS-app-v6.9-Carp-On-A-Zamboni: 2021 English fundraising messages in iOS app - https://phabricator.wikimedia.org/T294996 (10LGoto) related to Android task here: https://phabricator.wikimedia.org/T294997 [19:44:40] damilare: sorry I know we'd planned to talk through the 600=>800 tickets to break down the work on that but I'm still watching the docs meeting recording from last week in prep for later... so I'm thinking maybe we should instead talk through that stuff on our call tomorrow first thing? [19:45:49] Sure jgleeson: no worries, I totally understand [19:47:18] thanks man! [20:01:07] jgleeson: oh thanks! [20:04:18] (03PS4) 10Ejegg: Adyen Checkout: map error code 905 to submethod [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/732803 (https://phabricator.wikimedia.org/T294032) [20:04:20] (03PS1) 10Ejegg: Adyen: Move validation error mapping, add FIXMEs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/737488 [20:04:35] AndyRussG: I added those comments you suggested in a followup patch ^^ [20:09:16] and split off the validation error mapping [20:11:16] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/736310 (https://phabricator.wikimedia.org/T290253) (owner: 10Eileen) [20:29:02] fr-tech just reformated outline as a table https://www.mediawiki.org/w/index.php?title=Fundraising_tech/notes/Draft:Documentation_overhaul#Second_draft [20:39:51] 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10FR-Adyen, 10FR-Smashpig, 10FR-WMF-Audit: Adyen audit parser failing - https://phabricator.wikimedia.org/T295226 (10XenoRyet) [20:42:27] 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10Patch-For-Review: Payment session lost causing error page throwing exception - https://phabricator.wikimedia.org/T295149 (10XenoRyet) [20:47:10] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising sprint Universal Cereal Bus, 10fr-matching-gifts: Track where we got employer information and export that to Acoustic - https://phabricator.wikimedia.org/T294488 (10XenoRyet) [21:52:32] have a good one fr-tech. bye for now! [21:52:42] cya! thx! [22:11:57] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10fundraising sprint Roller Toaster, 10fundraising sprint Screaming Goats Yelling Zoo, and 3 others: Civi: Auto Recurring Fail email, batch of copy corrections - https://phabricator.wikimedia.org/T289617 (10Eileenmcnaughton) [22:13:53] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10fundraising sprint Roller Toaster, 10fundraising sprint Screaming Goats Yelling Zoo, and 3 others: Civi: Auto Recurring Fail email, batch of copy corrections - https://phabricator.wikimedia.org/T289617 (10Eileenmcnaughton) [22:28:57] eileen: so to add a new checkbox on the relationship type in prod, should we script it out in a wmf-civicrm managed data file? [22:32:54] ejegg: K just about to look at the SP patches, shouldn't take long [22:33:33] fr-tech I looked up definitions of "endpoints" and saw that it has a pretty specific meaning, which is not the way it's used in the outline proposal [22:34:19] I hope it's not too much to still revisit...? in any case, I thought of a few more options for a final fine-tune of topics... they're at the end of the etherpad: https://etherpad.wikimedia.org/p/fr-tech_doc_discussions [22:35:29] I'm sure there are more options too heheheh [22:40:55] (03PS1) 10Ejegg: Add new Adyen IPN types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/737512 [23:03:24] (03CR) 10AndyRussG: [C: 03+2] "Looks great, thanks for this!!! (Regarding inline comments, see Ib6e3b2b7dcc.)" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/732803 (https://phabricator.wikimedia.org/T294032) (owner: 10Ejegg) [23:04:09] (03Merged) 10jenkins-bot: Adyen Checkout: map error code 905 to submethod [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/732803 (https://phabricator.wikimedia.org/T294032) (owner: 10Ejegg) [23:04:23] ejegg: feel like adding the T294957 bug tag to https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/737488, or shall I +2 it as is? [23:04:23] T294957: Refactor ValidationError - https://phabricator.wikimedia.org/T294957 [23:04:59] oh sure, I'll add it [23:05:03] also ahhh https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/732804 is still missing a message param for the e-mail address [23:05:23] I'm seeing "Please try a different card or one of our other ways to give, or contact us at $2" [23:05:32] though the URL for other ways is good [23:05:33] oh? I fixed that locally, must ahve forgotten to push it [23:05:44] ahhh, i only added the one param, right [23:05:48] yeee [23:05:49] k, will fix in a sec [23:06:06] k thx much! and thanks so much for all the work on that, and for ur patience heheh [23:06:09] (03PS2) 10Ejegg: Adyen: Move validation error mapping, add FIXMEs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/737488 (https://phabricator.wikimedia.org/T294957) [23:06:17] 10Fundraising Sprint Technical debt house of horrors, 10Fundraising-Backlog, 10fundraising sprint Roller Toaster, 10fundraising sprint Screaming Goats Yelling Zoo, and 3 others: Civi: Auto Recurring Fail email, batch of copy corrections - https://phabricator.wikimedia.org/T289617 (10XenoRyet) I've fixed FR... [23:06:25] tagged ^^^ [23:07:35] (03CR) 10AndyRussG: [C: 03+2] "Ahhh works great, thanks so much for this and for being so patient here!!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/737488 (https://phabricator.wikimedia.org/T294957) (owner: 10Ejegg) [23:08:10] (03Merged) 10jenkins-bot: Adyen: Move validation error mapping, add FIXMEs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/737488 (https://phabricator.wikimedia.org/T294957) (owner: 10Ejegg) [23:12:01] (03PS5) 10Ejegg: Adyen Checkout: message to try another card [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732804 (https://phabricator.wikimedia.org/T294032) [23:12:54] AndyRussG: that extra message param felt like the length trigger for a refactor->extract method ^^^ [23:30:48] (03CR) 10AndyRussG: [C: 03+2] "Yaaaaayyyyyyyy!!!!! :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732804 (https://phabricator.wikimedia.org/T294032) (owner: 10Ejegg) [23:31:04] yeee [23:31:08] thanks! [23:32:29] AndyRussG: so we can tag that library version and do a couple of deploys (CRM and DonationInterface). I could just bang 'em out or if you want to practice I could hop on a video chat [23:32:48] (03Merged) 10jenkins-bot: Adyen Checkout: message to try another card [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/732804 (https://phabricator.wikimedia.org/T294032) (owner: 10Ejegg) [23:35:55] ejegg: oh cool! thx, we could do a video chat and I could watch how it's done? [23:44:33] sure - how bout in 5 minutes in the channel for that meeting we were last in? [23:46:25] AndyRussG: ^^ [23:48:07] ejegg: oki sounds great thx!