[00:24:28] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/830709 [00:24:32] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/830709 (owner: 10Ejegg) [00:24:59] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/830709 (owner: 10Ejegg) [00:33:50] !log updated standalone Smashpig from 11ba0a1b to 88e5e9bb [00:33:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:36:03] (03PS1) 10Ejegg: Update SmashPig requirement and own version number [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/830711 [00:36:08] (03CR) 10Ejegg: [C: 03+2] Update SmashPig requirement and own version number [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/830711 (owner: 10Ejegg) [00:38:23] (03Merged) 10jenkins-bot: Update SmashPig requirement and own version number [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/830711 (owner: 10Ejegg) [00:46:22] (03PS1) 10Ejegg: Update SmashPig and DonationInterface [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/830712 [00:46:25] (03CR) 10Ejegg: [C: 03+2] Update SmashPig and DonationInterface [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/830712 (owner: 10Ejegg) [00:52:31] (03PS1) 10Ejegg: Update SmashPig and DonationInterface libs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830713 [00:58:09] (03Merged) 10jenkins-bot: Update SmashPig and DonationInterface [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/830712 (owner: 10Ejegg) [01:16:22] (03CR) 10Ejegg: [C: 03+2] Update SmashPig and DonationInterface libs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830713 (owner: 10Ejegg) [01:19:02] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/830716 [01:19:06] OK, ready to go ahead with the CRM deploy again [01:20:17] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/830716 (owner: 10Ejegg) [01:23:36] this time I'm going to stop the recurring charge job [01:26:07] !log disabled recurring charge job [01:26:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:28:13] (03Merged) 10jenkins-bot: Update SmashPig and DonationInterface libs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830713 (owner: 10Ejegg) [01:44:08] (03CR) 10Ejegg: [C: 03+2] "recheck" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/830716 (owner: 10Ejegg) [01:48:03] wfan I'm about to deploy but I'll let you do the process-control work to re-enable the deleted contacts job [01:48:41] !log updated fundraising civicrm from c1f0e041 to efbbcb57 [01:48:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:55:16] ok, cool, we do get some successes! [01:55:59] turning the job back on [01:56:55] !log re-enabled recurring charge job [01:56:56] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:11:00] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising-Backlog: Custom field "AF_has_active_recurring_donation" is showing false positives - https://phabricator.wikimedia.org/T315102 (10Ejegg) OK, this is deployed and scheduled. The first run set 10,685 rows with no do... [02:32:18] Sure I can reenable the process-control job thank Elliott [05:40:35] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10donate.wikimedia.org, and 2 others: Donation Form Error Message - Country Detection - https://phabricator.wikimedia.org/T316578 (10AndyRussG) Thanks so much, @jgleeson, @BBlack, @Vgutierrez! I agr... [08:01:58] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/830752 (owner: 10L10n-bot) [08:26:43] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: Financial processing of donations and maintenance of member registers - https://phabricator.wikimedia.org/T261831 (10Lokal_Profil) 05Open→03Resolved a:03Jenny_Brandt_WMSE >>! In T261831#7757614, @Jenny_Brandt_WMSE wrote: > We... [08:26:45] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE, 10User-Jopparn: ☂Develop an experimental Face2Face (F2F) fundraising campaign for 2020 - https://phabricator.wikimedia.org/T260495 (10Lokal_Profil) [08:48:01] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/830752 (owner: 10L10n-bot) [10:52:16] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: check_endpoints_critical (Paypal:1) 1 [=1], paypal_transaction_failure 311 [=10] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [10:57:16] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: check_endpoints_critical (Paypal:2) 2 [=1], paypal_transaction_failure 100 [=10] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [11:01:48] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/830376 (owner: 10L10n-bot) [11:02:16] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [14:16:59] 10Wikimedia-Fundraising-Banners, 10Accessibility: Misc Fundraising banner accessibility issues - https://phabricator.wikimedia.org/T273786 (10Pcoombe) [14:17:18] 10Wikimedia-Fundraising-Banners, 10Accessibility: [Dsk Lg] Screen reader navigates to footer after main banner instead of payment form - https://phabricator.wikimedia.org/T274585 (10Pcoombe) 05Open→03Resolved a:03ehughes [14:18:48] 10Wikimedia-Fundraising-Banners, 10Accessibility: Screen reader navigates through buttons and logos on payment options - https://phabricator.wikimedia.org/T274584 (10Pcoombe) 05Open→03Declined Tracking these in Asana now [14:18:56] 10Wikimedia-Fundraising-Banners, 10Accessibility: Misc Fundraising banner accessibility issues - https://phabricator.wikimedia.org/T273786 (10Pcoombe) [14:19:27] 10Wikimedia-Fundraising-Banners, 10Accessibility: Misc Fundraising banner accessibility issues - https://phabricator.wikimedia.org/T273786 (10Pcoombe) 05Open→03Declined Tracking these in Asana now [14:22:58] 10Wikimedia-Fundraising-Banners: Numbers spill over behind modal on Donate Monthly button [Other input] - https://phabricator.wikimedia.org/T259523 (10spatton) 05Open→03Declined Declined as an edge case. [14:23:00] 10Wikimedia-Fundraising-Banners: [Candidate] JP Banners due Aug 3 - https://phabricator.wikimedia.org/T259076 (10spatton) [14:24:33] 10Wikimedia-Fundraising-Banners: [CANDIDATE] QA for 'RML options' banner - https://phabricator.wikimedia.org/T253054 (10spatton) [14:24:39] 10Wikimedia-Fundraising-Banners: No error message displayed when clicking "Submit" on Step 2 and missing data - https://phabricator.wikimedia.org/T257880 (10spatton) 05Open→03Declined Declined bc this pertained to a single banner variant, not control. [14:29:48] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Spike: Spike: investigate negative scroll offset for cancelling "banner bump" - https://phabricator.wikimedia.org/T107967 (10Pcoombe) Removing fundraising-banners as this is unlikely to work well due to varying heights [14:34:10] 10Wikimedia-Fundraising-Banners: Make it easier to fallback to Adyen in banners - https://phabricator.wikimedia.org/T240892 (10Pcoombe) 05Open→03Resolved a:03Pcoombe Adyen now has recurring, and is actually being used as primary processor [14:38:19] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10donate.wikimedia.org, and 2 others: Donation Form Error Message - Country Detection - https://phabricator.wikimedia.org/T316578 (10jgleeson) > {F35512929} > > In the Firefox console, I see a mes... [14:38:23] 10Wikimedia-Fundraising-Banners: Investigate adding email suggestion script from payments to banners - https://phabricator.wikimedia.org/T245664 (10Pcoombe) 05Open→03Declined Tracking this in Asana [14:45:19] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29): Generate list of incomplete iDeal donations - https://phabricator.wikimedia.org/T316778 (10jgleeson) >>! In T316778#8219122, @Ejegg wrote: > As discussed in IRC, the included... [14:45:43] 10Wikimedia-Fundraising-Banners, 10fr-donorservices: Extra decimals on Other amount field gets PTF riled up - https://phabricator.wikimedia.org/T259762 (10Pcoombe) 05Open→03Declined We're tracking this in Asana now: https://app.asana.com/0/1201185843452080/1202946445083292/f [14:49:21] damilare: I'm just look at the updated UML diagram. it looks great! [14:49:31] just a few minor nitpicks [14:49:41] nothing major just wording suggestions [14:49:47] I figure it might be easier to discuss here [14:50:19] actually let me see if I can attach a comment to the line in the source code like we do in gerrit [14:50:40] sounds good [14:50:42] looking* [14:51:04] 10Wikimedia-Fundraising-Banners: [spike] Investigate best practice for images in banners - https://phabricator.wikimedia.org/T254618 (10Pcoombe) 05Open→03Declined Moved to Asana [14:53:00] 10Wikimedia-Fundraising-Banners: Fundraising banner "remind me later" code should be more re-usable - https://phabricator.wikimedia.org/T162937 (10Pcoombe) 05Open→03Declined Moved to Asana [15:00:03] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10donate.wikimedia.org, and 2 others: Donation Form Error Message - Country Detection - https://phabricator.wikimedia.org/T316578 (10SHust) @AndyRussG, and team, Amber is off this week. What I can sa... [15:01:22] 10Wikimedia-Fundraising-Banners: Split out more shared banner javascript - https://phabricator.wikimedia.org/T241829 (10Pcoombe) [15:01:24] 10Wikimedia-Fundraising-Banners: Separate out JS for Mobile banners - https://phabricator.wikimedia.org/T241854 (10Pcoombe) [15:01:26] 10Wikimedia-Fundraising-Banners: Establish naming convention for shared banner UI elements - https://phabricator.wikimedia.org/T241857 (10Pcoombe) 05Open→03Declined Moved to Asana [15:03:09] 10Fundraising-Backlog: Custom field for Direct Mail Appeal not working on Engage import - https://phabricator.wikimedia.org/T317327 (10MDemosWMF) [15:04:42] 10Wikimedia-Fundraising-Banners: Change %MINIMUM% variable name to something less confusing - https://phabricator.wikimedia.org/T229964 (10Pcoombe) 05Open→03Declined Moved to Asana [15:06:59] 10Fundraising Sprint Potato, 10Fundraising-Backlog: Unit tests for Adyen Pending Transaction Resolver - https://phabricator.wikimedia.org/T316588 (10Damilare) a:03Damilare [15:07:29] 10Wikimedia-Fundraising-Banners: Re-think how we structure localization data - https://phabricator.wikimedia.org/T283384 (10Pcoombe) 05Open→03Declined Moved to Asana [15:52:04] 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Delete deleted contacts - lets get a bit more done pre BE - https://phabricator.wikimedia.org/T316059 (10AnnWF) Re-enabled the job at frpm1001 ~/localsettings/process-control/civi1001/delete_deleted_contacts.yaml --- name:... [16:04:52] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10SRE, 10Traffic: Set expiry time for GeoIP cookies - https://phabricator.wikimedia.org/T122097 (10BCornwall) p:05Triage→03Medium [16:10:09] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising-Backlog: Custom field "AF_has_active_recurring_donation" is showing false positives - https://phabricator.wikimedia.org/T315102 (10KHaggard) Thanks @Ejegg ! I ran the query I had from before to see what came up - t... [16:14:57] (03PS1) 10Wfan: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/830901 [16:18:40] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Don't tokenize cards when donation is under Monthly Convert minimum - https://phabricator.wikimedia.org/T316840 (10Dwisehaupt) [16:20:44] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: GatewayChooser: improve error style for 'No Form' message - https://phabricator.wikimedia.org/T316824 (10Dwisehaupt) [16:22:37] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: GatewayChooser: use styled Mustache form rather than MediaWiki error for NoForm error - https://phabricator.wikimedia.org/T316824 (10Ejegg) [16:27:19] (03PS2) 10Wfan: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/830901 [16:29:29] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Remove WmfDatabase - https://phabricator.wikimedia.org/T316823 (10Ejegg) [16:30:26] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Remove WmfDatabase - https://phabricator.wikimedia.org/T316823 (10Dwisehaupt) [17:02:52] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10donate.wikimedia.org, and 2 others: Donation Form Error Message - Country Detection - https://phabricator.wikimedia.org/T316578 (10Pcoombe) Thanks all. I searched the seed emails in my inbox, and n... [17:17:09] 10Fundraising-Backlog: Ingenico FIELD_LENGTH_INVALID error when firstName is too long - https://phabricator.wikimedia.org/T317355 (10Cstone) [17:17:48] 10Fundraising-Backlog: Ingenico FIELD_LENGTH_INVALID error when firstName is too long - https://phabricator.wikimedia.org/T317355 (10Cstone) [17:31:18] wfan so what should we do about those delete_deleted_contacts failmails? [17:31:28] is it going to fail on every run? [17:31:49] oh I see, it's timing out [17:31:57] do you want to adjust the timeout, then? [17:32:17] or is there a command-line parameter for the timing? [17:40:08] allow_overtime: true [17:40:20] this is in the original job [17:47:19] wfan oh so 'allow_overtime' just supresses the warning that the previous job is still running [17:47:26] I guess it could use a different name [17:47:54] but you also need to set a timeout: NN key to suppress the 'timed out' failmails we're getting now [17:57:09] ok, I will update the timeout, I remember that I have seen that before [18:13:02] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations: Recurring charge job shouldn't crash on email send error - https://phabricator.wikimedia.org/T256176 (10Ejegg) [18:19:12] ejegg: I see the longest timeout is recurring_smashpig_charge.yaml:timeout: 1200, do we have a way to do it as never time out or you think 1200 is enough [18:20:06] we are getting failmail 31 mins [18:20:14] and probably 35 mins is enough? [18:20:36] you don't want it to never time out since a fouled up job could keep others from running possibly forever. [18:20:51] so probably 35 is enough? [18:21:08] wfan is there a way to limit it to do fewer contacts per batch? [18:21:24] worth a test. i'm assuming that there is a backlog to clear and once we get through that the job will finish in a more approriate time. [18:22:26] like ejegg says doing fewer per batch might work. [18:22:58] also, if it were possible to run a bulk process outside of the job framework and let it chew away at the backlog before enabling the job. i'm not sure of the specifics, just listing some methods that have worked in the past. [18:23:01] ok, will do 35 mins first and update the code to handle fewer contacts per batch [18:23:27] or we can update the time from 1 years old to 2 years old for now [18:23:27] ? [18:24:27] one advantage of doing runs with a smaller batch is that you can find an approximate number of records you can process in a set time. then you can choose the timeout and batchsize appropriately. [18:25:16] oh I see, so you want to limit to certain contacts and see how long will it take~ [18:25:50] it' [18:25:53] s an option. [18:26:38] for instance, if we know 1000 contacts process in 2 minutes, then we could safely to 14000 in 30 minutes with a little room to spare. [18:28:08] ok, but I will put 35 first to prevent failmail for now, and update the contacts limit on that job later with new deploy to prod [18:28:20] sure. [18:51:48] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29): Remove incomplete iDeal transactions from CiviCRM - https://phabricator.wikimedia.org/T316780 (10jgleeson) a:03jgleeson [18:57:13] so croatia is going to the EUR [18:58:39] fr-tech I'd like to get some movement on the payments-wiki bullseye upgrade in fr-dev. Does anyone have some time free today to try that out? [18:59:54] sure ejegg although I might start it tomorrow morning unless you really need it today? [19:00:09] if so, non-UK folks would be best [19:00:24] jgleeson: OK, I just won't be in tomorrow is all [19:00:31] and it would be nice to get this done in sprint [19:01:34] I'll take a peek now and start the script I was looking at tomorrow [19:01:51] thank you so much! [19:02:04] np [19:02:08] I guess just enough to see if you have any questions or see any obvious deficiencies [19:03:01] i guess the testing plan would be something like, confirm the images build, confirm basic functionalities of the local stack and then check any logs for unexpected broken stuff [19:03:15] yep yep [19:03:17] does that sound ok [19:03:19] coo [19:03:26] so I only updated paymentswiki for this task [19:03:46] no need to test listeners or civi [19:04:06] oh hah, but I think in production listeners are already on bullseye [19:04:27] is frpig already upgraded dwisehaupt or am I imagining things? [19:06:16] anyone know a url on the wmcloud? my test site stopped responding and i dont know if its just me [19:06:25] oh let me see [19:06:35] it was just working [19:07:12] hmm, taking a long time to connect to my https://paymentstest5.wmcloud.org [19:07:39] the proxy-forward script succeeded fine [19:07:53] but browser is spinning [19:07:59] ya looks like an issue [19:08:16] ok thanks not me then [19:08:37] oh even the main wmcloud.org seems to be taking forever [19:09:03] could be related to traffic on the main site? [19:09:19] some wmcloud service is overtaxed... [19:09:33] it all the ipns i was trying to get adyen to send me :P [19:09:49] https://www.wikimediastatus.net/ [19:10:06] says all is green, but I guess it's not including wmcloud [19:11:41] cstone maybe worth asking asking over in #wikimedia-cloud? [19:12:12] I just asked ejegg [19:12:16] sorry should have said [19:12:18] hah thanks for asking [19:13:24] i was just emailing adyen anyway cause wasn't really getting the ipn with actual data [19:14:03] cstone: I just got my page to load [19:14:16] woo mine is behaving too [19:14:45] OMG and a url! [19:14:54] oooh [19:16:14] (03PS1) 10Ejegg: EMBARGOED TILL 01-01-2023: Change Croatia currency to EUR [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/830927 [19:18:02] ejegg: frpig is not updated yet. [19:18:12] oh ok, thanks [19:19:56] if you want to test that one too, that would be fine. it's pretty straight forward on the systems side since it's largely just another nginx server with minimal mods.. [19:39:47] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10FR-Braintree-Integration: Update PayPal IPN listener to mark Braintree donations with correct gateway and txn_id - https://phabricator.wikimedia.org/T315370 (10Ejegg) 05Open→03Declined Our contact... [19:40:17] ok, I can't find a lot more to do in this sprint, so I'll start making bullseye images for the rest of the fr-dev boxes [19:41:01] images built good for me ejegg [19:41:34] might wanna add this to test instructions on the patch, `docker-pkg -c dockerfiles/config.yaml build --no-pull --select 'docker-registry.wikimedia.org/dev/fundraising*bullseye*:*' dockerfiles/` [19:41:53] makes life easier knowing how to get that thing running [19:42:03] oh yeah, good call! [19:42:10] thanks so much for the local testing [19:43:10] oh hey, just saw dwisehaupt's comments. thanks for those, too! [19:43:21] I'll update the MR with those text fixes [19:46:04] docker@payments:/$ cat /etc/*rel* [19:46:06] PRETTY_NAME="Debian GNU/Linux 11 (bullseye)" [19:46:08] NAME="Debian GNU/Linux" [19:46:10] VERSION_ID="11" [19:46:12] VERSION="11 (bullseye)" [19:46:14] VERSION_CODENAME=bullseye [19:46:16] ID=debian [19:46:18] HOME_URL="https://www.debian.org/" [19:46:20] SUPPORT_URL="https://www.debian.org/support" [19:46:22] BUG_REPORT_URL="https://bugs.debian.org/" [19:46:24] pretty! [19:46:28] nice [19:50:15] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Name changes required for Ingenico 3S2.0 - https://phabricator.wikimedia.org/T312877 (10EMartin) Please note these comments from Ingenico pertaining to this topic from recent account calls re the name field on 3DS2.0: From Ingenico: // Please note that... [19:56:49] ejegg I don't know how it works but on our local devs smashpig failmail is still set to go to fr-tech-failmail@ could we sent that to mailcatcher? [19:56:54] saw it when running the job runner [19:57:57] Composer version 2.3.10 2022-07-13 15:48:23 [19:58:00] woo [19:58:02] p [19:58:28] not sure if that should be a separate patch? [19:58:45] i guess there's no visible side effects [19:59:50] (03Abandoned) 10Ejegg: Generic SmashPig maintenance script [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/731859 (owner: 10Ejegg) [20:01:48] jgleeson: oh right that just felt super out of date [20:02:47] agreed. it does feel distinct though to the OS upgrade [20:03:15] I'm torn [20:03:29] ehh, i guess. though a new OS generally involves new versions of a ton of packages [20:03:39] it's a whole new version of PHP for instance [20:04:15] yeah fair point [20:13:32] hmm ejegg [20:13:43] did you try out xdebug? I noticed that has moved up to 3 [20:13:59] oho, no! I guess that will need changes to the config [20:14:24] I'll see if it works using the as-is config I have locally [20:14:45] thanks, or I'll just try playing with that locally if you want to hang it up for tonight [20:14:47] 10fundraising-tech-ops: Fundraising access request for lmedley - https://phabricator.wikimedia.org/T314075 (10LMedley-WMF) Greetings Dallas, I hope your day is going very well! I was kindly able to successfully log-in to all parameters. Thank you for all of your help! Cheers, Laurice Laurice Medley (she/h... [20:14:55] should be enough to keep me busy for a lil while [20:16:48] yeah it looks like xdebug no longer works [20:19:01] ejegg: this is what the new config params look like https://github.com/jackgleeson/fr-tech-docker/blob/master/apps/payments/docker/xdebug.ini [20:19:25] rockin, I'll get those into the new image [20:19:48] oh wait, but that's on the fundraising-dev config, not the dev-images repo, right? [20:20:14] (03CR) 10Wfan: [C: 03+2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/830901 (owner: 10Wfan) [20:20:47] 10fundraising-tech-ops: Fundraising access request for lmedley - https://phabricator.wikimedia.org/T314075 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt Thanks! Closing this request. [20:20:49] (03Merged) 10jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/830901 (owner: 10Wfan) [20:20:57] ejegg: I think the config is on fundraising-dev yeah [20:21:27] 10fundraising-tech-ops: Fundraising access request for lmedley - https://phabricator.wikimedia.org/T314075 (10Dwisehaupt) [20:21:35] cool cool, I'll update that gerrit patch then [20:21:47] dwisehaupt: looks like we do have batch size for this ticket which is 1000, and 35 is fine for 1000 [20:21:47] thanks for all the scrutiny! [20:21:52] actually [20:21:59] they are on dev-images [20:22:12] also [20:22:37] thanks for all the scrutiny! [20:22:40] oh yeah [20:22:43] create-xdebug-common-ini.sh [20:23:06] https://gitlab.wikimedia.org/repos/releng/dev-images/-/blob/1e657a0d1c7112d85d9906eea38c5c3298986d30/dockerfiles/fundraising-bullseye-php74/create-xdebug-common-ini.sh [20:23:07] ya [20:23:08] will update that in the dev-images MR then [20:23:46] so discover_client_host replaces remote_host [20:25:44] wfan: cool. time to just let it run and do it's thing. :) [20:29:31] I think that replaces 'remote_enable' ejegg [20:29:38] like a flag to turn things on [20:29:50] ok, but there's no remote IP in the new setting? [20:30:10] oh let me see what mine is [20:30:39] oh i see xdebug.client_host=127.0.0.1 in my local [20:30:52] if you run `php -i | grep xdebug` on the new container you'll see a list of new and old commands [20:30:57] config* [20:31:23] ah i just destroyed my new containter to rebuild [20:32:00] https://xdebug.org/docs/upgrade_guide#Changed-Configuration-Settings [20:32:06] thanks! [20:32:12] https://xdebug.org/docs/upgrade_guide#New-Concepts [20:34:30] ok, looks like discover_client_host replaced remote_connect_back, which we didn't have in the old one [20:34:37] so I'll omit that [20:34:44] and just use client_host [20:36:51] hmm it might not be as straight forward as just editing the dev-images config ejegg. looks like in fundraisisng-dev we generate a template config file that is written to each project's config dir, and it is using xdebug-2-specific config here: [20:36:52] https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/fundraising/dev/+/refs/heads/master/setup.sh#107 [20:36:54] and [20:37:05] here https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/fundraising/dev/+/refs/heads/master/setup.sh#482 [20:37:18] ok, I'll come up with something to make that work for both now [20:38:48] ah yeah, we're using 'xdebug.remote_autostart=on' on fundraising-dev which is basically a shortcut for remote_enable=1 [20:39:23] that config got removed in xdebug 3 [20:39:51] > Use xdebug.mode=debug with xdebug.start_with_request=yes. [20:39:58] got it [20:40:00] yep! [20:40:04] that's it [20:42:12] I think you also need debug, so xdebug.mode=develop,debug [20:42:31] https://xdebug.org/docs/all_settings#mode [20:42:50] develop gives you the pretty var_dump. debug gives you the good stuff [20:43:08] (good stuff = breakpoint debugging) [20:43:27] it might be worth breaking this out? [20:44:19] although that would mean you'd have to backport xdebug 2.7 to the new images [20:45:56] I'll leave that one to you [20:46:17] I'm dropping off for tonight. bye for now fr-tech o/ [20:46:39] night jgleeson [20:47:18] fr-tech this might be the issue Dami ran into but I just rebuilt my civi and its erroring on [20:47:32] /srv/civi-sites/wmff/vendor/clio does not exist and could not be created. [20:47:41] has anyone run into that [20:48:02] cstone: not yet but I can try in about 1.5 hrs [20:48:15] no rush AndyRussG [20:48:27] ill try again maybe itll be fine [20:49:56] oki [21:03:21] AndyRussG: I figured it out I had a cursed local version of smashpig that didn't get deleted and then composer install didn't run properly, its behaving now [21:04:24] ah cool glad it's fixed! [21:44:48] (03PS1) 10Wfan: Add last modified date for last delete_deleted_modified_date to skip the check of those contact not able to get deleted [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830946 (https://phabricator.wikimedia.org/T316059) [21:45:13] (03CR) 10CI reject: [V: 04-1] Add last modified date for last delete_deleted_modified_date to skip the check of those contact not able to get deleted [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830946 (https://phabricator.wikimedia.org/T316059) (owner: 10Wfan) [21:49:52] (03PS2) 10Wfan: Add last modified date for last delete_deleted_modified_date to skip the check of those contact not able to get deleted [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830946 (https://phabricator.wikimedia.org/T316059) [22:21:22] (03CR) 10Eileen: "CiviCRM settings are not quite as lightweight as drupal variables - you need to define the setting." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830946 (https://phabricator.wikimedia.org/T316059) (owner: 10Wfan) [22:24:28] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising-Backlog: Custom field "AF_has_active_recurring_donation" is showing false positives - https://phabricator.wikimedia.org/T315102 (10Eileenmcnaughton) I vote for a full export just on the basis of doing one occassion... [22:46:09] (03PS3) 10Wfan: Add last modified date for last delete_deleted_modified_date to skip the check of those contact not able to get deleted [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830946 (https://phabricator.wikimedia.org/T316059) [23:10:42] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising-Backlog: Custom field "AF_has_active_recurring_donation" is showing false positives - https://phabricator.wikimedia.org/T315102 (10KHaggard) Ok, let me know if I should create a new sub-phab for that. We do launch...