[00:16:42] (03PS15) 10Cstone: Adding payments_details_report as an option for the Adyen Audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831146 (https://phabricator.wikimedia.org/T314753) [00:19:33] (03PS3) 10Cstone: Create wmf-audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833870 (https://phabricator.wikimedia.org/T314753) [00:24:08] (03PS16) 10Cstone: Adding payments_details_report as an option for the Adyen Audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831146 (https://phabricator.wikimedia.org/T314753) [00:26:26] (03PS17) 10Cstone: Adding payments_details_report as an option for the Adyen Audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831146 (https://phabricator.wikimedia.org/T314753) [00:34:10] (03PS4) 10Cstone: Create wmf-audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833870 (https://phabricator.wikimedia.org/T314753) [00:34:36] (03PS18) 10Cstone: Adding payments_details_report as an option for the Adyen Audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831146 (https://phabricator.wikimedia.org/T314753) [00:42:18] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Alerts, 10Patch-For-Review: INVALID_MESSAGE Recurring donation, but no subscription ID or recurring payment token found failmail coming from the listener on ideal - https://phabricator.wikimedia.org/T315031 (10Cstone) Looking at the failmail it l... [00:47:14] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Amazon requesting URL removal to avoid violation - https://phabricator.wikimedia.org/T316389 (10Cstone) Got into the console for this today sellercentral.amazon.com There are two weird URLs in there: https://payments.samazon.com/sdk/2018-02-08-63k6q26l/... [00:50:39] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Amazon requesting URL removal to avoid violation - https://phabricator.wikimedia.org/T316389 (10Cstone) @EMartin So when I go into our console I can see those URLs listed there but when I go to remove them by clicking on the pencil icon they disappear and... [01:52:22] (03PS1) 10Ejegg: Add suppressed count to failmails [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834411 (https://phabricator.wikimedia.org/T315238) [01:52:47] (03CR) 10CI reject: [V: 04-1] Add suppressed count to failmails [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834411 (https://phabricator.wikimedia.org/T315238) (owner: 10Ejegg) [01:56:20] (03PS2) 10Ejegg: Add suppressed count to failmails [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834411 (https://phabricator.wikimedia.org/T315238) [02:04:16] (03PS1) 10Ejegg: Use Redis for SmashPig cache [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/834412 [02:05:35] (03PS3) 10Ejegg: Add suppressed count to failmails [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834411 (https://phabricator.wikimedia.org/T315238) [02:26:33] (03PS5) 10Ejegg: Create wmf-audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833870 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [02:26:59] (03CR) 10Ejegg: [C: 03+2] "One small step towards de-drupalization!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833870 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [02:38:42] (03Merged) 10jenkins-bot: Create wmf-audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833870 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [03:19:18] 10Fundraising Sprint Quarkery, 10Fundraising-Backlog: Check need to account for opt-in param loss from 2022-06-15 through 2022-06-30 - https://phabricator.wikimedia.org/T311974 (10Ejegg) Luckily, the banner team has had to deal with our flakiness on this parameter before :P - since then they have been tacking... [03:32:36] 10Fundraising Sprint Quarkery, 10Fundraising-Backlog: Check need to account for opt-in param loss from 2022-06-15 through 2022-06-30 - https://phabricator.wikimedia.org/T311974 (10Ejegg) It's not quite as simple as running an update statement with that join setting opt_in=0 though - we need to insert rows for... [04:02:31] (03PS1) 10Ejegg: Opt-out users missed due to GatewayChooser bug [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/834413 (https://phabricator.wikimedia.org/T311974) [04:03:35] 10Fundraising Sprint Quarkery, 10Fundraising-Backlog, 10Patch-For-Review: Check need to account for opt-in param loss from 2022-06-15 through 2022-06-30 - https://phabricator.wikimedia.org/T311974 (10Ejegg) a:03Ejegg [04:04:06] (03PS2) 10Ejegg: Opt-out users missed due to GatewayChooser bug [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/834413 (https://phabricator.wikimedia.org/T311974) [04:04:42] (03PS3) 10Ejegg: Update namespaces for SmashPig responses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/832523 [04:04:44] (03PS3) 10Ejegg: Add Adyen data deletion requests to forgetme [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/832580 (https://phabricator.wikimedia.org/T311741) [04:14:15] (03CR) 10Ejegg: "AndyRussG did you say you made more changes to this? Maybe they didn't get sent up for review? I don't see any difference from PS2" [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/831243 (https://phabricator.wikimedia.org/T317427) (owner: 10AndyRussG) [04:16:16] (03CR) 10CI reject: [V: 04-1] Add Adyen data deletion requests to forgetme [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/832580 (https://phabricator.wikimedia.org/T311741) (owner: 10Ejegg) [04:16:26] (03CR) 10CI reject: [V: 04-1] Update namespaces for SmashPig responses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/832523 (owner: 10Ejegg) [06:32:01] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/834435 (owner: 10L10n-bot) [07:00:59] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/834435 (owner: 10L10n-bot) [08:19:12] (03CR) 10Awight: "This change is ready for review." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/834490 (https://phabricator.wikimedia.org/T318222) (owner: 10Awight) [08:21:19] 10Wikimedia-Fundraising, 10MediaWiki-extensions-CentralNotice, 10Patch-For-Review: Special:CentralNotice shows broken text in "short lists" - https://phabricator.wikimedia.org/T318222 (10awight) a:05awight→03None [08:21:22] 10Wikimedia-Fundraising, 10MediaWiki-extensions-CentralNotice, 10Patch-For-Review: Special:CentralNotice shows broken text in "short lists" - https://phabricator.wikimedia.org/T318222 (10awight) To be clear, the "Detect empty list" patch fixes the original bug, and the other two patches are just optional cle... [08:28:13] (03CR) 10Awight: [C: 03+1] schema: Convert Unique Index to Primary Key on cn_notice_languages [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/817879 (https://phabricator.wikimedia.org/T312270) (owner: 10Umherirrender) [08:29:06] (03CR) 10Awight: [C: 03+1] schema: Convert Unique Index to Primary Key on cn_notice_projects [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/817880 (https://phabricator.wikimedia.org/T312272) (owner: 10Umherirrender) [08:30:15] (03CR) 10Awight: [C: 03+1] schema: Convert Unique Index to Primary Key on cn_notice_countries [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/817881 (https://phabricator.wikimedia.org/T312273) (owner: 10Umherirrender) [08:30:49] (03CR) 10Awight: [C: 03+1] schema: Convert Unique Index to Primary Key on cn_notice_regions [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/817882 (https://phabricator.wikimedia.org/T312274) (owner: 10Umherirrender) [08:33:08] (03CR) 10Awight: [C: 03+2] Simplify CentralNotice::sanitizeSearchTerms implementation [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/688960 (owner: 10Thiemo Kreuz (WMDE)) [08:33:43] (03CR) 10Awight: "Looks like the sanitizeSearchTerms chunk of this patch is superceded by I1702073dcfe8." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/683619 (owner: 10Thiemo Kreuz (WMDE)) [08:35:46] (03CR) 10Awight: [C: 03+1] "Now it needs to be ported to abstract schema." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/78172 (owner: 10Mwalker) [08:35:48] (03Merged) 10jenkins-bot: Simplify CentralNotice::sanitizeSearchTerms implementation [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/688960 (owner: 10Thiemo Kreuz (WMDE)) [08:47:39] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Schema-change, 10User-DannyS712: CentralNotice schema audit - https://phabricator.wikimedia.org/T263343 (10awight) +1 to what AndyRussG said here, the log columns in particular are meant for auditing purposes and so we write valid data but don'... [09:39:18] (03PS13) 10Awight: Drop unused columns and tables [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/78172 (https://phabricator.wikimedia.org/T263343) (owner: 10Mwalker) [09:39:36] (03CR) 10Awight: "PS 13: abstract schema" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/78172 (https://phabricator.wikimedia.org/T263343) (owner: 10Mwalker) [09:41:05] (03CR) 10CI reject: [V: 04-1] Drop unused columns and tables [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/78172 (https://phabricator.wikimedia.org/T263343) (owner: 10Mwalker) [09:58:26] (03PS6) 10Thiemo Kreuz (WMDE): Optimize regular expression code in PHP and JavaScript [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/683619 [09:58:45] (03CR) 10Thiemo Kreuz (WMDE): Optimize regular expression code in PHP and JavaScript (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/683619 (owner: 10Thiemo Kreuz (WMDE)) [12:11:40] (03CR) 10Jgleeson: Create wmf-audit (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833870 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [12:14:15] (03CR) 10Jgleeson: [C: 03+2] "Thanks for the updates! LGTM" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831146 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [13:19:28] 10Fundraising-Backlog, 10fundraising-tech-ops: Vanity URL for Major Gifts Annual Appeal Mailing - https://phabricator.wikimedia.org/T318224 (10Jgreen) The annual appeal URL is all set. The endowment one is on a separate website and has to go through a separate process. [13:33:51] 10Fundraising-Backlog, 10fundraising-tech-ops: Vanity URL for Major Gifts Annual Appeal Mailing - https://phabricator.wikimedia.org/T318224 (10Jgreen) p:05Triage→03Medium a:03Jgreen [15:24:24] (03CR) 10Zabe: [C: 03+2] "zuul?" [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/834163 (owner: 10L10n-bot) [15:41:11] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Amazon requesting URL removal to avoid violation - https://phabricator.wikimedia.org/T316389 (10EMartin) @Cstone - ok let me reply to the thread concerning this with our technical contact at Amazon. [16:20:07] (03CR) 10Jgleeson: [C: 04-1] "Thanks for this! The Adyen form looks good. However, the Ingenico form has side effects. Check out https://phabricator.wikimedia.org/F3553" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/834348 (https://phabricator.wikimedia.org/T314603) (owner: 10Wfan) [16:32:47] (03PS1) 10Damilare Adedoyin: Maintenance script useful for testing the Adyen cancel payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834598 [16:33:41] (03PS2) 10Damilare Adedoyin: Maintenance script useful for testing the Adyen cancel payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834598 [16:36:25] (03CR) 10Damilare Adedoyin: "Thanks for the update and apologies for the back and forth on this, just one thing we may be missing out that I discovered when testing wi" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/714578 (https://phabricator.wikimedia.org/T317836) (owner: 10Ejegg) [16:37:17] (03PS1) 10Wfan: Add filter arg to fetchMessageByGatewayOldest [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834599 (https://phabricator.wikimedia.org/T316587) [16:37:55] (03PS2) 10Wfan: Add filter arg to fetchMessageByGatewayOldest [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834599 (https://phabricator.wikimedia.org/T316587) [16:42:31] (03PS10) 10Wfan: Add adyen to pending transaction resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831618 (https://phabricator.wikimedia.org/T316587) [17:00:20] (03PS2) 10Wfan: Move Employer Field below credit card [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/834348 (https://phabricator.wikimedia.org/T314603) [17:03:42] Jgleeson: My Ingenico looks fine, and it's controlled by .thirdwidth:not( :first-child ) { [17:03:42] margin-left: 2%; [17:03:42] } [17:03:42] .thirdwidth { [17:03:43] width: 32%; [17:03:43] } so could you check if your css cross out the width:32% ? [17:04:31] sure [17:06:39] wfan: https://phabricator.wikimedia.org/F35531006 [17:06:51] looks good from a styles-applied point [17:08:07] Hmm, jgleeson: could you check if your master, still looks odd or just with my patch? [17:08:24] yeah master is fine [17:09:22] wfan: https://phabricator.wikimedia.org/F35531008 [17:10:11] weird, could you checkout my newest patch, my local looks fine~ and if you check the code, nothing related [17:11:56] wfan: whatever you did just fixed it [17:13:00] oh haha, then it's probably the code reformat issue, thanks for confirm that [17:13:28] np. that's on your latest patch https://phabricator.wikimedia.org/F35531014 [17:14:45] 😀 thnaks~ [17:14:49] thanks* [17:15:20] :) [17:15:46] just gonna grab food but should be good to +2 when I get back. [17:15:54] thanks for the updates! [17:23:14] sure, take your time and thanks for review this patch :) [17:27:35] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Complete Adyen Checkout documentation to include donation statuses for all stages/permutations - https://phabricator.wikimedia.org/T316583 (10AndyRussG) [17:31:12] fr-tech this task is an epic so we might just boot it out of the sprink? https://phabricator.wikimedia.org/T299692 [17:51:14] 10Fundraising-Backlog: Unsub Link in "Donation Thank You" email - https://phabricator.wikimedia.org/T318234 (10KHaggard) Hi @DBu-WMF ! Heads up that I already made a ticket about the email address text box request here: https://phabricator.wikimedia.org/T317929 As for the sentence edit, a few of us (me, Thea, T... [17:52:03] 10Fundraising-Backlog, 10FR-AutoTY-Email: Unsub Link in "Donation Thank You" email - https://phabricator.wikimedia.org/T318234 (10KHaggard) [18:03:33] 10Fundraising-Backlog, 10FR-AutoTY-Email: Unsub Link in "Donation Thank You" email - https://phabricator.wikimedia.org/T318234 (10DBu-WMF) Thank you Katie. [18:16:43] AndyRussG: I'm easy on that but I seem to remember someone saying we let epics freeload in the sprint backlog. not sure why [18:18:45] wfan: is the cc on this template condition credit card? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/834348/2/gateway_forms/mustache/personal_info.html.mustache [18:19:15] if so, how come paypal still works [18:20:28] sorry, Braintree to be precise [18:35:13] will not affect braintree or paypal or google pay [18:36:58] so this patch only move the employer field for cc, which https://localhost:9001/index.php?title=Special:AdyenCheckoutGateway&appeal=JimmyQuote&payment_method=google&recurring=0&uselang=en&language=en¤cy=USD&amount=10&country=US&ffname=adyen&debug=true google pay will still have employer field above the pay button [20:01:37] thanks wfan [20:01:56] (03CR) 10Jgleeson: [C: 03+2] "Thanks for this! LGTM :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/834348 (https://phabricator.wikimedia.org/T314603) (owner: 10Wfan) [20:02:12] Thanks Jack 😊 [20:02:19] np :) [20:14:06] (03Merged) 10jenkins-bot: Move Employer Field below credit card [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/834348 (https://phabricator.wikimedia.org/T314603) (owner: 10Wfan)