[01:41:13] <wikibugs>	 (03PS1) 10Wfan: Add api to delete recurring and customer [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963853 (https://phabricator.wikimedia.org/T347606)
[06:39:34] <wikibugs>	 10Fundraising-Backlog, 10FR-donorservices: Indian donor charged twice for second installment of recurring donation - https://phabricator.wikimedia.org/T348258 (10RKumar_WMF) Does this mean we need to manually refund or will FR-Tech do it?
[07:18:30] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: Donation amount in Civi does not match the donation amount received at dLocal - https://phabricator.wikimedia.org/T346101 (10RKumar_WMF) I am trying to replicate the issue but when i click on the link given, I am getting error:  This...
[09:03:59] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: Donation amount in Civi does not match the donation amount received at dLocal - https://phabricator.wikimedia.org/T346101 (10Damilare) Apologies @RKumar_WMF, that was an internal test link for the engineers on the team. Here are the...
[11:37:15] <icinga-wm>	 PROBLEM - check_redis on frqueue1004 is CRITICAL: CRITICAL: recurring is 9861 9500 - REDIS 6.0.16 on 127.0.0.1:6379 has 1 databases (db0) with 14 keys, up 55 days 18 hours - memory use is 7.52M (peak 28.06M, 0.18% of max, fragmentation 1.93%), connected_slaves is 3, donations is 51, jobs is 0, jobs-adyen is 21, jobs-dlocal is 0, jobs-paypal is 7, payments-antifraud is 2, payments-init is 0, pending is 2, refund is 0, unsubscribe is 9 htt
[11:37:15] <icinga-wm>	 ga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_redis
[11:42:15] <icinga-wm>	 PROBLEM - check_redis on frqueue1004 is CRITICAL: CRITICAL: recurring is 10140 9500 - REDIS 6.0.16 on 127.0.0.1:6379 has 1 databases (db0) with 15 keys, up 55 days 19 hours - memory use is 7.70M (peak 28.06M, 0.18% of max, fragmentation 1.90%), connected_slaves is 3, donations is 33, jobs is 0, jobs-adyen is 14, jobs-dlocal is 7, jobs-paypal is 4, payments-antifraud is 2, payments-init is 14, pending is 0, refund is 0, unsubscribe is 10 
[11:42:15] <icinga-wm>	 cinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_redis
[11:47:15] <icinga-wm>	 PROBLEM - check_redis on frqueue1004 is CRITICAL: CRITICAL: recurring is 10830 9500 - REDIS 6.0.16 on 127.0.0.1:6379 has 1 databases (db0) with 15 keys, up 55 days 19 hours - memory use is 8.18M (peak 28.06M, 0.18% of max, fragmentation 1.87%), connected_slaves is 3, donations is 64, jobs is 0, jobs-adyen is 6, jobs-dlocal is 0, jobs-paypal is 2, payments-antifraud is 1, payments-init is 1, pending is 0, refund is 0, unsubscribe is 10 ht
[11:47:15] <icinga-wm>	 nga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_redis
[11:52:13] <icinga-wm>	 PROBLEM - check_redis on frqueue1004 is CRITICAL: CRITICAL: recurring is 10731 9500 - REDIS 6.0.16 on 127.0.0.1:6379 has 1 databases (db0) with 14 keys, up 55 days 19 hours - memory use is 8.08M (peak 28.06M, 0.18% of max, fragmentation 1.81%), connected_slaves is 3, donations is 72, jobs is 0, jobs-adyen is 19, jobs-dlocal is 0, jobs-paypal is 0, payments-antifraud is 1, payments-init is 12, pending is 0, refund is 0, unsubscribe is 11 
[11:52:13] <icinga-wm>	 cinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_redis
[11:57:15] <icinga-wm>	 PROBLEM - check_redis on frqueue1004 is CRITICAL: CRITICAL: recurring is 10733 9500 - REDIS 6.0.16 on 127.0.0.1:6379 has 1 databases (db0) with 12 keys, up 55 days 19 hours - memory use is 8.01M (peak 28.06M, 0.17% of max, fragmentation 1.77%), connected_slaves is 3, donations is 43, jobs is 0, jobs-adyen is 9, jobs-dlocal is 7, jobs-paypal is 0, payments-antifraud is 3, payments-init is 0, pending is 0, refund is 0, unsubscribe is 11 ht
[11:57:15] <icinga-wm>	 nga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_redis
[12:02:15] <icinga-wm>	 PROBLEM - check_redis on frqueue1004 is CRITICAL: CRITICAL: recurring is 10378 9500 - REDIS 6.0.16 on 127.0.0.1:6379 has 1 databases (db0) with 13 keys, up 55 days 19 hours - memory use is 7.86M (peak 28.06M, 0.17% of max, fragmentation 1.80%), connected_slaves is 3, donations is 73, jobs is 0, jobs-adyen is 0, jobs-dlocal is 2, jobs-paypal is 0, payments-antifraud is 3, payments-init is 10, pending is 0, refund is 0, unsubscribe is 2 ht
[12:02:15] <icinga-wm>	 nga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_redis
[12:07:17] <icinga-wm>	 PROBLEM - check_redis on frqueue1004 is CRITICAL: CRITICAL: recurring is 10378 9500 - REDIS 6.0.16 on 127.0.0.1:6379 has 1 databases (db0) with 13 keys, up 55 days 19 hours - memory use is 7.81M (peak 28.06M, 0.17% of max, fragmentation 1.82%), connected_slaves is 3, donations is 58, jobs is 0, jobs-adyen is 23, jobs-dlocal is 0, jobs-paypal is 0, payments-antifraud is 3, payments-init is 1, pending is 0, refund is 0, unsubscribe is 3 ht
[12:07:17] <icinga-wm>	 nga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_redis
[12:12:15] <icinga-wm>	 PROBLEM - check_redis on frqueue1004 is CRITICAL: CRITICAL: recurring is 10048 9500 - REDIS 6.0.16 on 127.0.0.1:6379 has 1 databases (db0) with 15 keys, up 55 days 19 hours - memory use is 7.72M (peak 28.06M, 0.17% of max, fragmentation 1.82%), connected_slaves is 3, donations is 48, jobs is 0, jobs-adyen is 12, jobs-dlocal is 9, jobs-paypal is 2, payments-antifraud is 6, payments-init is 16, pending is 0, refund is 0, unsubscribe is 3 h
[12:12:15] <icinga-wm>	 inga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_redis
[12:17:15] <icinga-wm>	 PROBLEM - check_redis on frqueue1004 is CRITICAL: CRITICAL: recurring is 10052 9500 - REDIS 6.0.16 on 127.0.0.1:6379 has 1 databases (db0) with 12 keys, up 55 days 19 hours - memory use is 7.72M (peak 28.06M, 0.17% of max, fragmentation 1.79%), connected_slaves is 3, donations is 46, jobs is 0, jobs-adyen is 0, jobs-dlocal is 0, jobs-paypal is 1, payments-antifraud is 1, payments-init is 0, pending is 0, refund is 0, unsubscribe is 4 htt
[12:17:15] <icinga-wm>	 ga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_redis
[12:22:15] <icinga-wm>	 PROBLEM - check_redis on frqueue1004 is CRITICAL: CRITICAL: recurring is 9731 9500 - REDIS 6.0.16 on 127.0.0.1:6379 has 1 databases (db0) with 14 keys, up 55 days 19 hours - memory use is 7.59M (peak 28.06M, 0.17% of max, fragmentation 1.83%), connected_slaves is 3, donations is 80, jobs is 0, jobs-adyen is 26, jobs-dlocal is 1, jobs-paypal is 0, payments-antifraud is 5, payments-init is 18, pending is 0, refund is 0, unsubscribe is 4 ht
[12:22:15] <icinga-wm>	 nga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_redis
[12:27:17] <icinga-wm>	 PROBLEM - check_redis on frqueue1004 is CRITICAL: CRITICAL: recurring is 9734 9500 - REDIS 6.0.16 on 127.0.0.1:6379 has 1 databases (db0) with 12 keys, up 55 days 19 hours - memory use is 7.46M (peak 28.06M, 0.17% of max, fragmentation 1.84%), connected_slaves is 3, donations is 64, jobs is 0, jobs-adyen is 18, jobs-dlocal is 10, jobs-paypal is 0, payments-antifraud is 0, payments-init is 1, pending is 0, refund is 0, unsubscribe is 4 ht
[12:27:17] <icinga-wm>	 nga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_redis
[13:22:14] <icinga-wm>	 RECOVERY - check_redis on frqueue1004 is OK: OK: REDIS 6.0.16 on 127.0.0.1:6379 has 1 databases (db0) with 12 keys, up 55 days 20 hours - memory use is 6.35M (peak 28.06M, 0.15% of max, fragmentation 2.00%), connected_slaves is 3, donations is 52, jobs is 0, jobs-adyen is 26, jobs-dlocal is 0, jobs-paypal is 0, payments-antifraud is 0, payments-init is 9, pending is 0, recurring is 7740, refund is 0, unsubscribe is 4 https://icinga.wikim
[13:22:14] <icinga-wm>	 cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_redis
[13:40:39] <ejegg>	 ok, we need to consume that recurring queue more often
[13:40:54] <ejegg>	 course, that will probably increase deadlocks when it conflicts with the donations queue
[13:41:24] <ejegg>	 unless we do T240581
[13:41:24] <stashbot>	 T240581: Send recurring payment notifications to the donations queue - https://phabricator.wikimedia.org/T240581
[13:59:12] <ejegg>	 relocating
[14:18:15] <wikibugs>	 10fundraising-tech-ops: Fundraising environment support for Debian 12 (Bookworm) - https://phabricator.wikimedia.org/T344290 (10Jgreen)
[14:19:30] <wikibugs>	 10fundraising-tech-ops: Fundraising environment support for Debian 12 (Bookworm) - https://phabricator.wikimedia.org/T344290 (10Jgreen)
[14:20:42] <wikibugs>	 10fundraising-tech-ops: Fundraising environment support for Debian 12 (Bookworm) - https://phabricator.wikimedia.org/T344290 (10Jgreen)
[14:24:07] <wikibugs>	 (03PS1) 10Damilare Adedoyin: Donation amount in Civi does not match the donation amount received at dLocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/964015 (https://phabricator.wikimedia.org/T346101)
[14:25:47] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Donation amount in Civi does not match the donation amount received at dLocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/964015 (https://phabricator.wikimedia.org/T346101) (owner: 10Damilare Adedoyin)
[14:29:40] <wikibugs>	 (03PS2) 10Damilare Adedoyin: Donation amount in Civi does not match the donation amount received at dLocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/964015 (https://phabricator.wikimedia.org/T346101)
[14:31:06] <wikibugs>	 (03CR) 10Ejegg: "If we're adding amount, let's put currency in there as well please." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/964015 (https://phabricator.wikimedia.org/T346101) (owner: 10Damilare Adedoyin)
[14:31:14] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Donation amount in Civi does not match the donation amount received at dLocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/964015 (https://phabricator.wikimedia.org/T346101) (owner: 10Damilare Adedoyin)
[14:51:46] <wikibugs>	 (03CR) 10Ejegg: [C: 04-1] "Thanks for the cleanup! Noted a few things that can be deleted rather than renamed." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/960675 (https://phabricator.wikimedia.org/T326594) (owner: 10Wfan)
[15:00:11] <wikibugs>	 (03PS3) 10Damilare Adedoyin: Donation amount in Civi does not match the donation amount received at dLocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/964015 (https://phabricator.wikimedia.org/T346101)
[15:00:43] <wikibugs>	 (03CR) 10Ejegg: "one request to rename a function" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963853 (https://phabricator.wikimedia.org/T347606) (owner: 10Wfan)
[15:05:27] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices, 10Patch-For-Review: Donation amount in Civi does not match the donation amount received at dLocal - https://phabricator.wikimedia.org/T346101 (10Damilare) Another solution is to pass the amount and other parameters to identify the...
[15:09:25] <wikibugs>	 10Fundraising Sprint Spacebar Oddity 👾, 10Fundraising-Backlog: Handle contact update from Fundraiseup - https://phabricator.wikimedia.org/T347882 (10AKanji-WMF)
[15:09:48] <wikibugs>	 (03CR) 10Damilare Adedoyin: "Thanks ejegg for the initial review, I added the currency and some other parameters that'd be useful in identifying the donation." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/964015 (https://phabricator.wikimedia.org/T346101) (owner: 10Damilare Adedoyin)
[15:11:26] <wikibugs>	 (03PS3) 10Ejegg: use description for descriptor otherwise  Wikimedia Foundation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963834 (https://phabricator.wikimedia.org/T347537) (owner: 10Wfan)
[15:11:30] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] use description for descriptor otherwise  Wikimedia Foundation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963834 (https://phabricator.wikimedia.org/T347537) (owner: 10Wfan)
[15:12:12] <wikibugs>	 (03Merged) 10jenkins-bot: use description for descriptor otherwise  Wikimedia Foundation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963834 (https://phabricator.wikimedia.org/T347537) (owner: 10Wfan)
[15:16:13] <wikibugs>	 (03PS2) 10Ejegg: Use upstream selectField where appropriate [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/963704 (owner: 10Thiemo Kreuz (WMDE))
[15:16:35] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] "Looks good. Method is only used in test teardown for now, and seems to be working fine there. Thanks!" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/963704 (owner: 10Thiemo Kreuz (WMDE))
[15:19:45] <wikibugs>	 (03Merged) 10jenkins-bot: Use upstream selectField where appropriate [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/963704 (owner: 10Thiemo Kreuz (WMDE))
[15:25:29] <ejegg>	 ah dami I just noticed you brought the contribution tracking function split-off into your patch. I can abandon the standalone one then
[15:26:13] <ejegg>	 oh, just one detail - looks like your patch reformats all that function to mediawiki styles rather than civicrm styles
[15:26:42] <ejegg>	 My IDE has started doing that again too - I need to get the per-folder styles working right
[15:27:03] <ejegg>	 should be working with the .editorconfig files, but maybe we've got that overridden somewhere?
[15:30:49] <wikibugs>	 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog, 10Wikipedia-iOS-App-Backlog (Design): JSON for new app fundraising banners (multilingual, Italy and Netherlands) - https://phabricator.wikimedia.org/T348278 (10Pcoombe) Thanks @Tsevener, great points about compatibility. That's fine to keep th...
[15:39:44] <wikibugs>	 (03PS7) 10Ejegg: Make the submethods alphabetical [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/926547 (https://phabricator.wikimedia.org/T335388) (owner: 10Wfan)
[15:40:28] <wikibugs>	 (03CR) 10Ejegg: "PS7: rebase & restore three logo_hd sections" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/926547 (https://phabricator.wikimedia.org/T335388) (owner: 10Wfan)
[15:41:10] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] "Thanks for this work, Wenjun! It'll be a lot quicker to find what we're looking for in this file now." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/926547 (https://phabricator.wikimedia.org/T335388) (owner: 10Wfan)
[15:42:52] <wikibugs>	 (03Merged) 10jenkins-bot: Make the submethods alphabetical [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/926547 (https://phabricator.wikimedia.org/T335388) (owner: 10Wfan)
[16:13:57] <wikibugs>	 10Fundraising-Backlog, 10FR-dlocal: dlocal refund and script to batch refund csv files - https://phabricator.wikimedia.org/T334311 (10Cstone) a:03Cstone
[16:17:04] <wikibugs>	 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog, 10Wikipedia-iOS-App-Backlog (Design): JSON for new app fundraising banners (multilingual, Italy and Netherlands) - https://phabricator.wikimedia.org/T348278 (10Tsevener) @Pcoombe great thanks, this all looks good! I updated your Sandbox config...
[16:19:44] <wikibugs>	 10Fundraising-Backlog, 10FR-donorservices: Indian donor charged twice for second installment of recurring donation - https://phabricator.wikimedia.org/T348258 (10EMartin) @RKumar_WMF It looks like FRTech are working on a script to do it.
[16:24:27] <wikibugs>	 10Fundraising-Backlog, 10FR-donorservices: Indian donor charged twice for second installment of recurring donation - https://phabricator.wikimedia.org/T348258 (10greg) yeah, @Cstone will be working on that today as that would probably be faster than clicking around for those affected.
[16:29:20] <wikibugs>	 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog, 10Wikipedia-iOS-App-Backlog (Design), 10iOS Release FY2023-24: JSON for new app fundraising banners (multilingual, Italy and Netherlands) - https://phabricator.wikimedia.org/T348278 (10Tsevener)
[17:29:52] <wikibugs>	 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog, 10Wikipedia-iOS-App-Backlog (Design), 10iOS Release FY2023-24: JSON for new app fundraising banners (multilingual, Italy and Netherlands) - https://phabricator.wikimedia.org/T348278 (10Tsevener) Here's some screenshots! I tried to get both e...
[17:36:11] <wikibugs>	 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog, 10Wikipedia-iOS-App-Backlog (Design), 10iOS Release FY2023-24: JSON for new app fundraising banners (multilingual, Italy and Netherlands) - https://phabricator.wikimedia.org/T348278 (10Tsevener) In terms of clipping on the SE size - the cont...
[17:37:52] <wikibugs>	 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Form variant with lock icon next to credit card number label - https://phabricator.wikimedia.org/T348339 (10Pcoombe)
[17:44:05] <damilare>	 sorry ejegg|food I just saw your message, I had totally missed yours, I just split that part out based on the reviews you had left. I'd merge yours in then, it's easier that way.
[17:49:24] <wikibugs>	 (03PS3) 10Damilare Adedoyin: Break contribution_tracking insert out of normalize fn [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963056 (https://phabricator.wikimedia.org/T346620) (owner: 10Ejegg)
[17:49:28] <wikibugs>	 (03PS30) 10Damilare Adedoyin: Create Fundraiseup Audit Processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959346 (https://phabricator.wikimedia.org/T346620)
[18:00:47] <ejegg>	 thanks damilare !
[18:02:52] <wikibugs>	 10fundraising-tech-ops: Fundraising environment support for Debian 12 (Bookworm) - https://phabricator.wikimedia.org/T344290 (10Jgreen)
[18:03:25] <wikibugs>	 10fundraising-tech-ops: Fundraising environment support for Debian 12 (Bookworm) - https://phabricator.wikimedia.org/T344290 (10Jgreen)
[18:06:06] <damilare>	 np
[18:06:39] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C: 03+2] Break contribution_tracking insert out of normalize fn [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963056 (https://phabricator.wikimedia.org/T346620) (owner: 10Ejegg)
[18:12:53] <wikibugs>	 (03PS4) 10Wfan: Add fetch customer info graphql for venmo [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963268 (https://phabricator.wikimedia.org/T347771)
[18:24:19] <wikibugs>	 (03Merged) 10jenkins-bot: Break contribution_tracking insert out of normalize fn [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963056 (https://phabricator.wikimedia.org/T346620) (owner: 10Ejegg)
[18:29:21] <wikibugs>	 (03PS5) 10Ejegg: Add missing name to matched contact [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959334 (https://phabricator.wikimedia.org/T326986)
[18:43:54] <ejegg>	 cstone: just lmk if you want any rubber ducks to listen through your batch refund script crafting
[18:56:45] <wikibugs>	 10Fundraising-Backlog, 10FR-donorservices: Indian donor charged twice for second installment of recurring donation - https://phabricator.wikimedia.org/T348258 (10Ejegg) Looks like the bad calculation setting the next date to 10/01 happened during the recurring charge job for that row on 09/30, so that narrows...
[18:59:34] <ejegg>	 ^^^ let's try replicating that in a test case
[19:01:49] <cstone>	 ejegg: wfan added the api call needed to the phab task yesterday so hopefully straight forward, following the pattern of the other scripts for a start
[19:03:16] <ejegg>	 cool cool
[19:19:43] <wikibugs>	 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog, 10Wikipedia-iOS-App-Backlog (Design), 10iOS Release FY2023-24: JSON for new app fundraising banners (multilingual, Italy and Netherlands) - https://phabricator.wikimedia.org/T348278 (10cooltey) Screenshots from Android devices:  ===== Samsun...
[19:25:12] <cstone>	 ejegg: are you able to get into our dlocal sandbox
[19:25:32] <wikibugs>	 (03PS1) 10Ejegg: Calculate UPI next charge from one day later [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964070 (https://phabricator.wikimedia.org/T348258)
[19:25:43] <ejegg>	 cstone: let me check
[19:25:55] <cstone>	 er console
[19:26:18] <cstone>	 it 500 errors on me
[19:26:49] <ejegg>	 oh right i have two accounts there for some reason
[19:26:49] <cstone>	 guess its fine
[19:27:07] <cstone>	 oh yeah cause we had to do a hard cutover
[19:27:12] <ejegg>	 yeah i just got a 500 error too
[19:27:18] <cstone>	 ok thanks
[19:27:59] <ejegg>	 so I thought https://gerrit.wikimedia.org/r/964070 might be the solution to the UPI thing
[19:28:37] <cstone>	 i think we should separately remove the whole -1 day thing too right?
[19:28:38] <ejegg>	 but as I was writing the commit message I thought maybe we should just fix the cycle_day
[19:29:50] <ejegg>	 yeah, maybe just don't subtract one from that first next_sched_charge_date, OK
[19:30:31] <ejegg>	 so the first prenotification is one month later
[19:30:47] <ejegg>	 and the first charge is one month + 1 day later
[19:31:09] <ejegg>	 but subsequent charges should just be 1 month apart I think?
[19:31:21] <cstone>	 next sched is currently set before we know if its sucessfull or not too
[19:31:37] <cstone>	 like move the day of the month along?
[19:32:15] <ejegg>	 right, I think we have to set that pre-emptively so the row doesn't get picked up again
[19:32:41] <ejegg>	 I guess just make sure the cycle_day matches with the first next_sched_date
[19:32:47] <cstone>	 hmm
[19:32:59] <cstone>	 do you understand how it got set to 10/1
[19:33:01] <cstone>	 did it fail?
[19:33:05] <ejegg>	 whether that's moving cycle_day one day back or leaving next_sched_date to the next one
[19:33:17] <cstone>	 oh wait so
[19:33:29] <ejegg>	 cstone if you call CRM_Core_Payment_Scheduler::getNextDateForMonth()
[19:33:37] <ejegg>	 with the cycle_day set to 1
[19:33:38] <cstone>	 9/1 original but then we modified next sched to -1 9_30 and then it got set back to 10/1?
[19:33:47] <ejegg>	 and the current date set to 9/30 
[19:33:52] <ejegg>	 you'll get 10/1
[19:34:09] <cstone>	 cause next moth + cycle day?
[19:34:20] <ejegg>	 yep, next month + cycle day
[19:34:52] <ejegg>	 so fortunately CRM_Core_Payment_Scheduler::getNextDateForMonth has an optional second param to send the 'current timestamp'
[19:35:02] <ejegg>	 (just added for testing, defaults to time())
[19:35:10] <ejegg>	 and the patch I just wrote takes advantage of that
[19:35:24] <ejegg>	 to pass time() + 1 day as the nowStamp
[19:36:18] <ejegg>	 but if we can fix it by removing the special-case if (UPI) { next_sched_date-- } code that we use for the first next_sched_date
[19:36:29] <ejegg>	 that might be better than fixing it by adding more special-case code
[19:37:35] <ejegg>	 so in the 'less code' fix, let's just think through what happens for ppl that start on the 31st
[19:37:56] <cstone>	 there is the subset that are still on monthly too i dont know how many are left
[19:38:02] <ejegg>	 cycle day gets set to 31, next_date is next month's 31 (or last day of next month)
[19:38:36] <ejegg>	 cstone yeah if any of them started on the 1st I guess they would have failed the duplicate charge
[19:38:58] <cstone>	 i dont think any of those started on the 1st though
[19:39:11] <ejegg>	 cool cool. back to the hypothetical ppl with last day of month cycle_day
[19:39:21] <ejegg>	 and no advancing that one day
[19:39:36] <cstone>	 oh sorry thats wrong
[19:39:49] <cstone>	 but it was may 1 
[19:39:53] <ejegg>	 So hypothetical person gets their prenotification on the 31st
[19:40:25] <ejegg>	 and then we set the next charge date to the 31st of the following month
[19:40:27] <cstone>	 next sched is then set to last day of next month
[19:40:37] <ejegg>	 and the actual charge is on the 1st of the month
[19:40:59] <ejegg>	 I guess as long as they're not on the MONTHLY limitation plan that's no problem
[19:41:10] <ejegg>	 err even then
[19:41:26] <ejegg>	 on the monthly limit
[19:41:30] <ejegg>	 it's no big deal
[19:41:48] <ejegg>	 they just get one charge recorded Mar 31 then the next recorded May 1st
[19:42:07] <ejegg>	 so we skip our chance to charge 'em in April, but it's still basically a month
[19:42:11] <ejegg>	 from one to the next
[19:42:17] <ejegg>	 OK, let's try that fix
[19:42:28] <cstone>	 yeah sounds good
[19:43:08] <ejegg>	 So... where are we doing that special if(upi) next_date-- ???
[19:43:13] <ejegg>	 RecurringQueueConsumer?
[19:43:35] <ejegg>	 ahh right getNextContributionDate
[19:43:37] <ejegg>	 derp
[19:43:51] <ejegg>	 UpiDonationsQueueConsumer
[19:54:59] <wikibugs>	 (03PS1) 10Ejegg: UPI: stop setting early next_sched_contribution_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964074 (https://phabricator.wikimedia.org/T348258)
[19:56:14] <ejegg>	 ok, so just for completion's sake I'mma make a patch to keep the '1 day forward for prenotification' and just set the matching cycle_day
[19:56:28] <ejegg>	 so we can look at 'em all and decide which we like best
[20:00:07] <cstone>	 ejegg: i might need refund help just on how our smashpig classes work being brain dead
[20:01:02] <cstone>	 ohm aybe not
[20:02:28] <cstone>	 no im confused again haha
[20:06:20] <wikibugs>	 (03PS1) 10Ejegg: UPI: cycle_day must match next_sched_contribution_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964077 (https://phabricator.wikimedia.org/T348258)
[20:09:52] <wikibugs>	 (03CR) 10Wfan: [C: 03+2] Calculate UPI next charge from one day later [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964070 (https://phabricator.wikimedia.org/T348258) (owner: 10Ejegg)
[20:10:02] <wikibugs>	 (03PS1) 10Cstone: Add dlocal refund script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/964078 (https://phabricator.wikimedia.org/T334311)
[20:10:27] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Add dlocal refund script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/964078 (https://phabricator.wikimedia.org/T334311) (owner: 10Cstone)
[20:10:52] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] UPI: stop setting early next_sched_contribution_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964074 (https://phabricator.wikimedia.org/T348258) (owner: 10Ejegg)
[20:12:23] <wikibugs>	 (03PS2) 10Ejegg: Calculate UPI next charge from one day later [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964070 (https://phabricator.wikimedia.org/T348258)
[20:12:54] <wfan>	 ejegg: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/964074 this needs unit test update
[20:12:56] <cstone>	 wfan: ejegg did we want to merge the one that just got +2d?
[20:13:11] <wfan>	 no that one needs to wait this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/964074
[20:13:24] <ejegg>	 wait, which got +2ed
[20:13:25] <ejegg>	 nooo
[20:13:27] <cstone>	 the first one
[20:13:39] <ejegg>	 sorry maybe I should have set it WIP
[20:13:49] <ejegg>	 I just deleted the C+2
[20:14:19] <ejegg>	 wfan so those are three different possibilities for solving the problem
[20:14:23] <wfan>	 cool, yeah, they should com together~
[20:14:32] <ejegg>	 err, we should choose one of the three
[20:14:37] <ejegg>	 and then abandon the other two
[20:15:18] <ejegg>	 I'm currently leaning towards the third, actually
[20:15:22] <cstone>	 wfan: theres discussion above of what we were thinking about there
[20:15:56] <ejegg>	 ok, i just marked the one i don't like as WIP
[20:15:58] <wfan>	 Oh ok the third one is update the cycle_day right
[20:16:11] <ejegg>	 I'll update unit tests for both of the others, actually
[20:16:43] <cstone>	 is the third one where the monthlys get charged like 1 day later ?
[20:16:55] <ejegg>	 i think that's the second...
[20:17:04] <ejegg>	 sorry, confusing to refer to them that way
[20:17:47] <ejegg>	 annnnnd yeah, the one to just make the cycle_day is not what we want either
[20:18:17] <ejegg>	 Since ppl who start on Feb 1 will get cycle_day set to 28
[20:18:35] <ejegg>	 then get 2nd donation in the record on Mar 1st
[20:18:50] <ejegg>	 but third will come in on March 29th
[20:18:54] <ejegg>	 still ugly
[20:19:06] <wikibugs>	 (03PS2) 10Cstone: Add dlocal refund script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/964078 (https://phabricator.wikimedia.org/T334311)
[20:19:09] <ejegg>	 ok, so back to the simplification patch
[20:19:15] <ejegg>	 and I'll just fix that unit test
[20:20:43] <cstone>	 ^^ i was able to get test payment refunds through with that script
[20:20:49] <cstone>	 im gona go get some food brb
[20:21:05] <ejegg>	 cool cool
[20:25:59] <wikibugs>	 (03PS2) 10Ejegg: UPI: stop setting early next_sched_contribution_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964074 (https://phabricator.wikimedia.org/T348258)
[20:26:41] <ejegg>	 dang, I'mma have to relocate
[20:26:48] <ejegg>	 but I hope PS2 does the trick
[20:27:19] <ejegg>	 anyway, we shouldn't see this happen again till end of month
[20:27:27] <ejegg>	 so no urgency on that
[20:27:48] <ejegg>	 I'll just try to review that refund script later today
[20:51:14] <wikibugs>	 10fundraising-tech-ops: Fundraising environment support for Debian 12 (Bookworm) - https://phabricator.wikimedia.org/T344290 (10Jgreen)
[20:51:38] <wikibugs>	 10fundraising-tech-ops: Fundraising environment support for Debian 12 (Bookworm) - https://phabricator.wikimedia.org/T344290 (10Jgreen)
[22:03:22] <wikibugs>	 10Fundraising Sprint Spacebar Oddity 👾, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Individual Engage File Import Duplicates - https://phabricator.wikimedia.org/T347362 (10MDemosWMF) @Damilare checking in to see how this is going. thanks!
[23:15:32] <wikibugs>	 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog, 10Wikipedia-iOS-App-Backlog (Design), 10iOS Release FY2023-24: JSON for new app fundraising banners (multilingual, Italy and Netherlands) - https://phabricator.wikimedia.org/T348278 (10Tsevener) https://github.com/wikimedia/wikipedia-ios/pul...