[00:05:46] <wfan>	 so I used a different pr https://github.com/civicrm/civicrm-core/pull/28160
[00:10:43] <wikibugs>	 (03Merged) 10jenkins-bot: Do not use decline-recurring for logprefix, use donation_queue_process_message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/973266 (https://phabricator.wikimedia.org/T350831) (owner: 10Wfan)
[00:31:52] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Successful Adyen transactions not making it into CiviCRM - https://phabricator.wikimedia.org/T345736 (10Dwisehaupt) Moving to chaos crew backlog and main board triage since it was an open task in a hidden column.
[00:33:38] <wikibugs>	 (03PS1) 10Eileen: Update MoveContrib [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974701
[00:34:50] <eileen>	 wfan: looks like it already has C+2 equivalent
[00:34:57] <eileen>	 cstone: see ^^
[00:35:05] <eileen>	 ie the move contrib patch
[00:37:30] <wikibugs>	 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog, 10Wikipedia-iOS-App-Backlog (Design), 10iOS Release FY2023-24: For smaller screens (SE) ensure that the ability to scroll is visible to users - https://phabricator.wikimedia.org/T348695 (10ABorbaWMF) Looking good on 7.4.6 (2872) {F41509294}
[00:37:38] <wikibugs>	 (03CR) 10Wfan: [C: 03+2] "merged at upstream looks good" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974701 (owner: 10Eileen)
[00:37:57] <wfan>	 Not merged at upstream just an open pr, right?
[00:38:48] <wfan>	 eileen: also once this upstream merged, will create a one locally https://github.com/civicrm/civicrm-core/pull/28160
[00:41:42] <wikibugs>	 (03CR) 10Wfan: [C: 03+2] "Besides the pr 'Add weight to move contrib link' is pending, others code changes get merged on upstream already, feel safe to merge it" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974701 (owner: 10Eileen)
[00:55:01] <wikibugs>	 (03Merged) 10jenkins-bot: Update MoveContrib [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974701 (owner: 10Eileen)
[01:10:06] <wikibugs>	 (03CR) 10Eileen: [C: 03+2] Add last donation amount on summary profile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/973240 (https://phabricator.wikimedia.org/T346917) (owner: 10Ejegg)
[01:10:30] <wikibugs>	 (03CR) 10Eileen: [C: 03+2] "Adding a follow on to create the fields locally for dev-ease" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/973240 (https://phabricator.wikimedia.org/T346917) (owner: 10Ejegg)
[01:14:54] <wikibugs>	 (03PS1) 10Eileen: Add mgd to add summary overlay fields on dev [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974703 (https://phabricator.wikimedia.org/T346917)
[01:26:35] <wikibugs>	 (03Merged) 10jenkins-bot: Add last donation amount on summary profile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/973240 (https://phabricator.wikimedia.org/T346917) (owner: 10Ejegg)
[01:31:00] <wikibugs>	 (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/974705
[01:31:27] <wikibugs>	 (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/974705 (owner: 10Eileen)
[01:32:20] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/974705 (owner: 10Eileen)
[01:34:22] <eileen>	 !log civicrm upgraded from ec6992e0 to 6e53198c
[01:34:25] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[01:37:46] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Endowment donation not showing up in the pop-up when mousing over the Civi icon - https://phabricator.wikimedia.org/T346917 (10Eileenmcnaughton) I pushed out the patch to fix this but pulled it back to being reviewed cos I added a fo...
[01:45:51] <cstone>	 im gona deploy DI to get that utm change out for inapp
[01:47:25] <wikibugs>	 (03PS1) 10Cstone: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/974706
[01:48:36] <wikibugs>	 (03CR) 10Cstone: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/974706 (owner: 10Cstone)
[01:49:38] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/974706 (owner: 10Cstone)
[01:53:25] <cstone>	 !log payments-wiki upgraded from b4465e23 to 084370bb
[01:53:28] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[02:10:37] <eileen>	 well I rarely run setup.sh but just did & it was a drama
[02:10:37] <eileen>	 docker-compose exec -w /var/www/html/w/ donut php maintenance/run.php update --quick
[02:10:37] <eileen>	 #!/usr/bin/env php
[02:10:37] <eileen>	 Error: The MinervaNeue skin cannot be loaded. Check that all of its files are installed properly.
[02:10:49] <wikibugs>	 (03PS2) 10Ejegg: Add mgd to add summary overlay fields on dev [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974703 (https://phabricator.wikimedia.org/T346917) (owner: 10Eileen)
[02:10:49] <eileen>	 - got past it by not letting that bit run
[02:10:55] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] Add mgd to add summary overlay fields on dev [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974703 (https://phabricator.wikimedia.org/T346917) (owner: 10Eileen)
[02:14:07] <ejegg>	 eileen: oops my patch added the FIRST donation amount, not the last
[02:14:14] <ejegg>	 gonna fix that right quick
[02:14:33] <wikibugs>	 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog, 10Wikipedia-iOS-App-Backlog (Design), 10iOS Release FY2023-24: For smaller screens (SE) ensure that the ability to scroll is visible to users - https://phabricator.wikimedia.org/T348695 (10Tsevener) a:03ABorbaWMF
[02:14:37] <ejegg>	 ah hmm, no donut for you?
[02:14:58] <wikibugs>	 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog, 10Wikipedia-iOS-App-Backlog (Design), 10iOS Release FY2023-24: For smaller screens (SE) ensure that the ability to scroll is visible to users - https://phabricator.wikimedia.org/T348695 (10Tsevener) a:05ABorbaWMF→03None
[02:17:42] <wikibugs>	 (03PS1) 10Cstone: Add catch for in app donation with no banner [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/974708 (https://phabricator.wikimedia.org/T350919)
[02:17:46] <wikibugs>	 (03PS1) 10Ejegg: Fix profile summary donation date to be last [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974709 (https://phabricator.wikimedia.org/T346917)
[02:17:50] <cstone>	 missed a place where appmenu hadn't been set ^
[02:18:29] <cstone>	 but the numbers are gone at least!
[02:18:53] <wikibugs>	 (03CR) 10Eileen: [C: 03+2] Fix profile summary donation date to be last [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974709 (https://phabricator.wikimedia.org/T346917) (owner: 10Ejegg)
[02:19:34] <eileen>	 ejegg: yeah not even sure what donut is but hopefully I can get preference centre to work anyway
[02:19:51] <ejegg>	 eileen: ah yep, email-pref-center should be less tricky
[02:20:02] <ejegg>	 donut is donate-wiki (with centralnotice)
[02:20:32] <ejegg>	 so email-pref-center is basically identical to payments (same git branch, same submodules, just different config)
[02:20:49] <cstone>	 i thought i had a clean install last week but i might have skipped donut
[02:21:00] <eileen>	 cool - well I did lots of git pulling & such like so I guess I'm more up-to-date
[02:21:46] <ejegg>	 donut uses the main branch of mediawiki, so it's liable to have bleeding-edge problems, but ALSO it doesn't have the skins & extensions checked out as proper submodules - they're just cloned into the right folders by setup.sh the first time you install it
[02:22:00] <ejegg>	 so maybe if that gets interrupted it doesn't recover well
[02:23:16] <eileen>	 yeah - I noticed lots of composer complaints about smashpig too - test classes being skipped due to failure to comply with prs4 or whichever it is
[02:24:25] <eileen>	 bugger - MediaWiki 1.39.5
[02:24:26] <eileen>	 LocalSettings.php not found.
[02:24:26] <eileen>	 Please set up the wiki first.
[02:24:59] <ejegg>	 ah phooey, is that on email-pref-ctr?
[02:25:01] <eileen>	 which is a different error but the same theme as what started me off setuping in the first place
[02:25:16] <ejegg>	 donut I think is on a newer mw version
[02:26:39] <ejegg>	 eileen you could just copy this line into a LocalSettings.php file at /src/email-pref-ctr
[02:26:58] <ejegg>	 <?php
[02:26:58] <ejegg>	 require( '/srv/config/exposed/email-pref-ctr/LocalSettings.php');
[02:27:02] <wikibugs>	 (03Merged) 10jenkins-bot: Add mgd to add summary overlay fields on dev [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974703 (https://phabricator.wikimedia.org/T346917) (owner: 10Eileen)
[02:27:34] <eileen>	 hmm - it might have gotten there - there was still some stuff running - it has changed at any rate
[02:28:11] <ejegg>	 ah nice
[02:28:40] <eileen>	 - it there a reason we don't rende r the email prefs link like <a href="something short">that long string</a>
[02:29:00] <ejegg>	 right though, we should move those SmashPig tests to the namespace matching the folder structure, huh?
[02:29:03] <eileen>	 ok - this might be that uf thing [b7644764a1bd85650998e5e4] /index.php?title=Special:EmailPreferences/emailPreferences&contact_id=205&checksum=5a6bb3cdddae48139acb8d7718f67d2b_1700101663_168 RuntimeException: Error retrieving current e-mail preferences.
[02:29:06] <ejegg>	 quiet down that composer spam
[02:29:36] <ejegg>	 eileen: you can also go straight to the civiproxy URL to get more error details
[02:29:58] <ejegg>	 let's see, that would be something like 
[02:30:00] <ejegg>	 https://localhost:9005/rest.php?entity=civiproxy&action=getpreferences&key=SITE_KEY&api_key=API_KEY&version=3&json=1&checksum=f5bde5c512d836be1e0cc3517a6b295e_1664506678_168&contact_id=209
[02:30:13] <ejegg>	 (with your contact ID and checksum replaced)
[02:31:01] <eileen>	 hmm - I'm missing that hack "SSL certificate problem: self signed certificate"
[02:31:12] <ejegg>	 ahh, that is in the fr-dev repo
[02:31:36] <ejegg>	 pull down https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/970411
[02:32:04] <ejegg>	 (and maybe docker-compose restart civiproxy)
[02:32:05] <eileen>	 I have that
[02:32:14] <ejegg>	 ok, then just the restart civiproxy
[02:32:16] <eileen>	 but will try the restart
[02:32:41] <ejegg>	 yeah, that darn overlay mount gets confused when the mounted file is swapped out by git
[02:33:44] <ejegg>	 I think I'll take your suggestion to submit a pull request for a dev-mode define that skips that cert check
[02:34:36] <eileen>	 ok - looks like it is working now on the pre-existing stuff (phew)
[02:34:41] <ejegg>	 yay!
[02:34:50] <wikibugs>	 (03Merged) 10jenkins-bot: Fix profile summary donation date to be last [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974709 (https://phabricator.wikimedia.org/T346917) (owner: 10Ejegg)
[02:35:31] <eileen>	 so those updates are queued rather than done in real time?
[02:36:33] <ejegg>	 eileen: yep
[02:36:58] <ejegg>	 gotta run the scripts/consume-queues
[02:37:10] <ejegg>	 or scripts/civicrm-consume-queues if it's been renamed
[02:39:24] <eileen>	 ok - that seemed to work (& the patch didn't break it!)
[02:41:12] <eileen>	 so what is the new action to try?
[02:45:24] <wikibugs>	 (03CR) 10Ejegg: "This works, looks like it could just be in the sendToContributionTracking fn though." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/974708 (https://phabricator.wikimedia.org/T350919) (owner: 10Cstone)
[02:45:44] <eileen>	 got  it
[02:45:45] <ejegg>	 cstone do either of those sound worth doing? Happy to just C+2 as is
[02:46:14] <ejegg>	 eileen: oh sorry, so you crafted the url?
[02:46:29] <ejegg>	 I think it's just replacing EmailPreferences with RecurUpgrade in the link
[02:47:00] <eileen>	 yeah - I tried that - just checking if I did it right
[02:47:11] <ejegg>	 k, i'mma deploy that fix to the last donation date before ppl notice the error
[02:47:30] <eileen>	 how does it know it is v4?
[02:48:10] <ejegg>	 civiproxy knows it's v4 because we hit the rest4.php endpoint
[02:48:45] <ejegg>	 should it require a version param?
[02:49:42] <wikibugs>	 (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/974710
[02:49:54] <eileen>	 nah I mean - how does it know to hit the rest4 endpoint?
[02:50:12] <ejegg>	 so that mgd file matches on 'uf_group_id', 'name'
[02:50:30] <ejegg>	 and there is no 'name' in the UFField
[02:50:54] <ejegg>	 but somehow it finds the field_name:name to match on?
[02:51:20] <cstone>	 ah yeah ejegg I didn't think too hard cause we're going to be removing it eventually but sure
[02:51:45] <ejegg>	 eileen sorry, back to your question, how does the email-pref-ctr know to hit the rest4 endpoint?
[02:52:04] <eileen>	 yeah - my link isn't actually working - https://localhost:9002/index.php?title=Special:ContributionRecur/getUpgradableRecur&contact_id=205&checksum=7a06060b810c716072eeb2b3089b79eb_1700102327_168
[02:52:21] <eileen>	 but I don't know how it would decide that is restv4 not rest
[02:52:33] <eileen>	 (it's saying login required)
[02:52:36] <ejegg>	 ahhh sorry, that's not quite it
[02:52:49] <wikibugs>	 (03PS2) 10Cstone: Add catch for in app donation with no banner [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/974708 (https://phabricator.wikimedia.org/T350919)
[02:52:55] <ejegg>	 https://localhost:9002/index.php?title=Special:RecurUpgrade/recurUpgrade&contact_id=205&checksum=7a06060b810c716072eeb2b3089b79eb_1700102327_168
[02:53:20] <ejegg>	 so that 9002 port is serving up the email-pref-ctr copy of mediawiki, not civiproxy
[02:53:43] <ejegg>	 we're being really overcautious here, making our own wiki hit Civi API via a proxy
[02:54:36] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Add catch for in app donation with no banner [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/974708 (https://phabricator.wikimedia.org/T350919) (owner: 10Cstone)
[02:55:05] <ejegg>	 so that Special:RecurUpgrade is a special page defined in DonationInterface https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/special/RecurUpgrade.php
[02:55:16] <eileen>	 progress! There was an error processing your request, please contact donate@wikimedia.org.
[02:55:33] <ejegg>	 :)
[02:55:47] <ejegg>	 ok, so if you want to try hitting the civiproxy v4 endpoint directly
[02:55:48] <wikibugs>	 (03PS3) 10Cstone: Add catch for in app donation with no banner [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/974708 (https://phabricator.wikimedia.org/T350919)
[02:55:59] <cstone>	 maybe whitespace should be allowed to exist at the end of a line :P
[02:56:20] <ejegg>	 that's at something like
[02:56:22] <ejegg>	 https://localhost:9005/civicrm/ajax/api4/ContributionRecur/getUpgradableRecur?params={%22contact_id%22%3A1234%2C%22checksum%22%3A%22abcd%22}&key=SITE_KEY&api_key=API_KEY
[02:57:57] <eileen>	 ok - that's getting closer
[02:59:57] <eileen>	 ok - I see what happened to break debug on rebuild
[03:01:09] <ejegg>	 ohhh was it still on xdebug 2 config?
[03:01:43] <ejegg>	 i always have issues debugging with this prefs / proxy / civi stack
[03:03:50] <eileen>	 nah - it's just not on by default
[03:04:11] <eileen>	 I use xdebug.start_with_request=yes & then toggle whether my ide listens or not
[03:05:47] <ejegg>	 k, cool
[03:10:54] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] Add catch for in app donation with no banner [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/974708 (https://phabricator.wikimedia.org/T350919) (owner: 10Cstone)
[03:11:01] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/974710 (owner: 10Ejegg)
[03:11:53] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/974710 (owner: 10Ejegg)
[03:11:55] <wikibugs>	 (03PS1) 10Cstone: Switch from directly calling the api to using the PaymentProvider [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/974711
[03:12:48] <wikibugs>	 (03Merged) 10jenkins-bot: Add catch for in app donation with no banner [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/974708 (https://phabricator.wikimedia.org/T350919) (owner: 10Cstone)
[03:13:04] <cstone>	 thanks ejegg !
[03:15:19] <eileen>	 ejegg: well I got it to work!
[03:15:31] <ejegg>	 yay eileen !
[03:15:54] <ejegg>	 oh shoot cstone i still haven't tagged a new smashpig version
[03:15:57] <ejegg>	 lemme do that now
[03:16:31] <eileen>	 There is that whitespace issue on that else - otherwise I'm just trying to figure out what I need to do review wise
[03:17:11] <ejegg>	 ok cstone, tagged v0.8.9.2
[03:17:19] <ejegg>	 oh right eileen, i'll fix that
[03:18:44] <eileen>	 it feels a bit like there might be some changes that come from upstream review but we have to wait & see how that plays but I can see the new thing works & the old thing isn't borked & no obvious horrors in the code
[03:18:52] <ejegg>	 :)
[03:19:13] <ejegg>	 one sec, i'll just do the ws fix
[03:19:24] <eileen>	 cool
[03:20:14] <eileen>	 I guess the main question is whether I need to look deeper into the auth methods - we are only using the very simple one
[03:20:31] <wikibugs>	 (03PS10) 10Ejegg: Support site_key and multiple auth flows [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/970443 (https://phabricator.wikimedia.org/T349946)
[03:21:06] <eileen>	 & also deciding whether to comment on the PR or not - It could make things more complex rather than simpler :-)
[03:21:34] <ejegg>	 eileen: I did some smoke testing locally, and i think i got each one to work on each direction
[03:21:47] <ejegg>	 had to hack around in the email-prf-center requesting class though
[03:22:15] <ejegg>	 but yeah, as long as it works for our site I think it's OK to merge into our fork for now
[03:22:23] <eileen>	 ejegg: ok - well I think it's OK then - I feel like it would be better to use one of the others at some point
[03:22:26] <ejegg>	 and then I'll just pull back in any changes I have to make on the upstream
[03:22:43] <wikibugs>	 (03PS1) 10Cstone: Update SmashPig version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/974712
[03:22:49] <ejegg>	 yep yep, I'd lean towards xheader maybe?
[03:23:10] <ejegg>	 brb
[03:23:20] <wikibugs>	 (03CR) 10Eileen: [C: 03+2] "It works!" [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/970443 (https://phabricator.wikimedia.org/T349946) (owner: 10Ejegg)
[03:23:31] <wikibugs>	 (03CR) 10Eileen: [C: 03+2] "It works!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/970411 (https://phabricator.wikimedia.org/T349946) (owner: 10Ejegg)
[03:23:48] <eileen>	 yeah xheader makes sense - just gets it out of the GET
[03:23:57] <wikibugs>	 (03CR) 10Cstone: [C: 03+2] Update SmashPig version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/974712 (owner: 10Cstone)
[03:24:05] <eileen>	 in future we might be able to use form builder remote form too
[03:25:29] <wikibugs>	 (03Merged) 10jenkins-bot: Update SmashPig version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/974712 (owner: 10Cstone)
[03:27:00] <eileen>	 ejegg: is there anything else you were hoping I would look at?
[03:28:49] <ejegg>	 not right now eileen . Thanks so much!
[03:29:22] <eileen>	 cool - it's good to be reminded what a slog it is to look into a bit of code that you haven't touched for a while
[03:30:00] <ejegg>	 argh yeah. I have been dragging my heels for way too long on reviewing dami's ip velocity patch for just that reason
[03:31:20] <cstone>	 ejegg: if you still have time could you look at this one https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/974711
[03:32:26] <ejegg>	 looks right, lemme just pull it down
[03:33:47] <cstone>	 it was nice locally when running both i could see how much faster the cached one was!
[03:35:25] <ejegg>	 oh right, that needs the smashpig update too
[03:35:41] <ejegg>	 lemme just pull that down as well
[03:37:23] <cstone>	 hmm i said that then there is no cache locally as I didn't have that smashpig update hah
[03:37:32] <cstone>	 maybe adyen just being slow on the second call
[03:37:57] <ejegg>	 oh hmm
[03:38:24] <ejegg>	 i thought it would break on validation without the smashpig update?
[03:38:43] <ejegg>	 i got a null response till i composer updated
[03:38:57] <ejegg>	 anyway, WITH the update it looks good and works locally here
[03:39:08] <wikibugs>	 (03PS2) 10Ejegg: Switch from directly calling the api to using the PaymentProvider [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/974711 (owner: 10Cstone)
[03:39:13] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] Switch from directly calling the api to using the PaymentProvider [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/974711 (owner: 10Cstone)
[03:39:22] <cstone>	 okay maybe i do have it haha
[03:39:57] <ejegg>	 ah like had the actual lib updated in vendor but had rewound the update in composer.json
[03:40:44] <ejegg>	 !log fundraising civicrm upgraded from 6e53198c to 32679ea3
[03:40:47] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[03:40:56] <wikibugs>	 (03Merged) 10jenkins-bot: Switch from directly calling the api to using the PaymentProvider [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/974711 (owner: 10Cstone)
[03:42:17] <cstone>	 hmm the update smashpig instructions are failing me vendor why are you misbehaving
[03:42:33] <ejegg>	 dang, what's failing?
[03:42:44] <cstone>	 when I go onto the vendor branch it says my branch is behind
[03:44:07] <cstone>	 like checking out our branch on the vendor branch
[03:44:08] <cstone>	 hmm
[03:44:14] <cstone>	 yeah its in august why
[03:44:24] <ejegg>	 huh
[03:45:21] <ejegg>	 i just noticed two silly things - casing and field order - that I kindof want to fix with that summary overlay
[03:45:35] <ejegg>	 well, just field order
[03:45:46] <cstone>	 hmm last time i tried to do this was the same date did i mess things up then
[03:45:48] <ejegg>	 just want to get that amount right under the date
[03:45:50] <cstone>	 but what did i mess up!
[03:46:37] <cstone>	 why would the submodue init bring me to an old one 
[03:47:28] <ejegg>	 and your parent repo was up to date?
[03:47:40] <ejegg>	 v odd
[03:48:40] <cstone>	 ive apparenly never done this on 1_39
[03:48:58] <ejegg>	 ooh
[03:49:02] <cstone>	 yeah i just pulled on the payments and see my deploy
[03:49:24] <cstone>	 looks like you and wenjun have done them all since then
[03:49:29] <ejegg>	 eek it's late here
[03:50:08] <cstone>	 hah gooo to beeed
[03:53:19] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Endowment donation not showing up in the pop-up when mousing over the Civi icon - https://phabricator.wikimedia.org/T346917 (10Ejegg) @SHust success! We just deployed a fix to get the real last donation amount (whether endowment or annual fund) into that...
[03:53:39] <cstone>	 hmm Cannot find symbolic reference what did i break
[03:54:26] <cstone>	 oh why arent i on a branch
[03:55:05] <wikibugs>	 (03CR) 10Ejegg: [V: 03+2] Support site_key and multiple auth flows [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/970443 (https://phabricator.wikimedia.org/T349946) (owner: 10Ejegg)
[03:55:13] <wikibugs>	 (03CR) 10Ejegg: [V: 03+2] Pass through site_key in config copy of civiproxy [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/970411 (https://phabricator.wikimedia.org/T349946) (owner: 10Ejegg)
[03:55:21] <wikibugs>	 (03PS7) 10Ejegg: Pass through site_key in config copy of civiproxy [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/970411 (https://phabricator.wikimedia.org/T349946)
[03:55:26] <wikibugs>	 (03CR) 10Ejegg: [V: 03+2] Pass through site_key in config copy of civiproxy [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/970411 (https://phabricator.wikimedia.org/T349946) (owner: 10Ejegg)
[03:56:40] <cstone>	 18th times the charm
[03:58:30] <ejegg>	 :P
[03:58:37] <ejegg>	 best of luck with the rest of it
[03:58:39] <ejegg>	 gnight
[03:58:49] <cstone>	 night
[03:58:52] <cstone>	 i got it behaving
[03:59:00] <cstone>	 just had to delete the cursed branch
[04:03:05] <wikibugs>	 (03PS1) 10Cstone: Update SmashPig to v0.8.9.2 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/974714
[04:11:20] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Update SmashPig to v0.8.9.2 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/974714 (owner: 10Cstone)
[04:13:15] <wikibugs>	 (03PS2) 10Cstone: Update SmashPig to v0.8.9.2 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/974714
[04:21:46] <wikibugs>	 (03CR) 10Cstone: [C: 03+2] Update SmashPig to v0.8.9.2 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/974714 (owner: 10Cstone)
[04:29:06] <wikibugs>	 (03Merged) 10jenkins-bot: Update SmashPig to v0.8.9.2 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/974714 (owner: 10Cstone)
[04:30:38] <cstone>	 !log payments-wiki upgraded from 084370bb to 6affb60a
[04:30:41] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[04:34:14] <wikibugs>	 (03PS1) 10Cstone: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/974715
[04:35:48] <wikibugs>	 (03CR) 10Cstone: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/974715 (owner: 10Cstone)
[04:36:53] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/974715 (owner: 10Cstone)
[04:38:43] <cstone>	 !log payments-wiki upgraded from 6affb60a to eae2f35e
[04:38:46] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[06:50:51] <wikibugs>	 10Fundraising-Backlog, 10FR-Adyen: Enable Vipps through Adyen - https://phabricator.wikimedia.org/T339937 (10JBrungs_WMF) Hi all, Thank you for this. If we do not offer Vipps we need to have a good explanation in place as this is one of the main community request to us from past donation campaigns. In my opini...
[06:59:54] <wikibugs>	 (03PS1) 10Wfan: Update CRM deduper merger.php [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974723 (https://phabricator.wikimedia.org/T345206)
[07:01:56] <wikibugs>	 (03PS1) 10Wfan: For fundraiseup venmo, save fundraiseup_id instead of venmo_user_name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974724 (https://phabricator.wikimedia.org/T351345)
[07:18:46] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Patch-For-Review: fundraiseup_id is miss placed to venmo_user_name - https://phabricator.wikimedia.org/T351345 (10AnnWF) a:03AnnWF
[07:19:50] <wikibugs>	 (03PS2) 10Wfan: Update CRM deduper merger.php [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974723 (https://phabricator.wikimedia.org/T345206)
[07:20:25] <wikibugs>	 (03CR) 10Eileen: [C: 03+2] Update CRM deduper merger.php [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974723 (https://phabricator.wikimedia.org/T345206) (owner: 10Wfan)
[07:20:58] <wfan>	 Aha, thanks eileen :)
[07:23:10] <wikibugs>	 10Fundraising Sprint Uptown cURL, 10Fundraising Sprint vvv - tell me more, 10Fundraising-Backlog, 10Patch-For-Review: Auto-Rescue Audit processing updates and cancel_reason - https://phabricator.wikimedia.org/T340159 (10AnnWF)
[07:34:16] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_40) - 10https://gerrit.wikimedia.org/r/974756 (owner: 10L10n-bot)
[07:36:54] <wikibugs>	 (03Merged) 10jenkins-bot: Update CRM deduper merger.php [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974723 (https://phabricator.wikimedia.org/T345206) (owner: 10Wfan)
[09:33:12] <wikibugs>	 (03PS1) 10Wfan: Move current fundraiseup venmo user name back to fundraiseup_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974936 (https://phabricator.wikimedia.org/T351345)
[10:47:54] <wikibugs>	 10Fundraising-Backlog: No 2023-11-14 Fundraise Up donations in Civi - https://phabricator.wikimedia.org/T351295 (10Pcoombe) Import of 2023-11-15 seems to have worked, but we're still missing 2023-11-14
[10:49:25] <pcoombe>	 Hi, would someone be able to take a look at https://phabricator.wikimedia.org/T351295 ? It's blocking us from analysing results from the FRU test on portal (and I'm worried the problem might also recur)
[12:53:48] <damilare>	 looking pcoombe 
[13:01:49] <jgleeson>	 be there in 2 mins damilare 
[13:02:16] <damilare>	 ohh jgleeson I sent an email asking to cancel about 8 mins ago
[13:03:07] <damilare>	 didn't get much sleep last night, so I'm feeling a little hazy
[13:05:03] <jgleeson>	 ah cool that's fine no problem
[13:05:29] <damilare>	 thanks
[13:05:44] <jgleeson>	 are you a person who can nap in the day?
[13:05:53] <jgleeson>	 I'm not, but sometimes wish I could
[13:07:57] <damilare>	 yep, on some days
[13:08:28] <damilare>	 and sometimes coffee doesn't even help
[13:08:36] <jgleeson>	 ah yes
[13:10:50] <jgleeson>	 When I try to nap during the day, either I lay awake with my eyes closed for an hour and get up feeling the same, or I'll set my alarm to sleep for an hour and fall asleep at 00:50m into the hour and wake up 10 minutes later more tired lol
[13:11:26] <jgleeson>	 also looking at pcoomb's ticket
[13:11:30] <jgleeson>	 lemme know if I can help
[13:11:37] <jgleeson>	 pcoombe*
[13:12:34] <damilare>	 same but that's usually me distracted with scrolling on my phone 
[13:12:50] <damilare>	 yh I'm not sure what blocked the job from running on that day
[13:13:01] <damilare>	 I'd run it again now to have it imported
[13:13:40] <damilare>	 and check the cause, did we do a process-control update recently
[13:15:02] <jgleeson>	 not that I know of
[13:22:26] <damilare>	 so the import is getting stuck on this file export_recurring_2023-11-14_00-00_2023-11-14_23-59.csv
[13:22:40] <damilare>	 gonna pull that down to see what's going on there
[13:40:09] <icinga-wm>	 PROBLEM - check_disk on civi1002 is CRITICAL: DISK CRITICAL - free space: /dev 31939 MB (100% inode=99%): /run 6391 MB (99% inode=99%): / 4563 MB (65% inode=86%): /dev/shm 31962 MB (100% inode=99%): /run/lock 5 MB (100% inode=99%): /boot 318 MB (75% inode=99%): /srv 61012 MB (21% inode=97%): /tmp 10761 MB (87% inode=99%): /var 24558 MB (92% inode=95%): /home 11548 MB (93% inode=99%): /var/log 2225 MB (8% inode=99%): /var/tmp 422 MB (99% 
[13:40:09] <icinga-wm>	 ): /var/log/audit 422 MB (99% inode=99%): /run/user/16778 6392 MB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=civi1002&service=check_disk
[13:42:53] <damilare>	 probably had to do with the job I was running that timed out ^
[13:43:15] <icinga-wm>	 PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 5572 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql
[13:45:09] <icinga-wm>	 PROBLEM - check_disk on civi1002 is CRITICAL: DISK CRITICAL - free space: /dev 31939 MB (100% inode=99%): /run 6391 MB (99% inode=99%): / 4563 MB (65% inode=86%): /dev/shm 31962 MB (100% inode=99%): /run/lock 5 MB (100% inode=99%): /boot 318 MB (75% inode=99%): /srv 61012 MB (20% inode=97%): /tmp 10761 MB (87% inode=99%): /var 24553 MB (92% inode=95%): /home 11548 MB (93% inode=99%): /var/log 1648 MB (6% inode=99%): /var/tmp 422 MB (99% 
[13:45:09] <icinga-wm>	 ): /var/log/audit 422 MB (99% inode=99%): /run/user/16778 6392 MB (100% inode=99%): /run/user/571 6392 MB (100% inode=99%): /run/user/33 6392 MB (100% inode=99%): /run/user/205 6392 MB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=civi1002&service=check_disk
[13:48:15] <icinga-wm>	 RECOVERY - check_mysql on frdb1004 is OK: Uptime: 162520 Threads: 4 Questions: 46604698 Slow queries: 76 Opens: 1283 Open tables: 1183 Queries per second avg: 286.762 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql
[13:50:09] <icinga-wm>	 PROBLEM - check_disk on civi1002 is CRITICAL: DISK CRITICAL - free space: /dev 31939 MB (100% inode=99%): /run 6391 MB (99% inode=99%): / 4563 MB (65% inode=86%): /dev/shm 31962 MB (100% inode=99%): /run/lock 5 MB (100% inode=99%): /boot 318 MB (75% inode=99%): /srv 61012 MB (20% inode=97%): /tmp 10760 MB (87% inode=99%): /var 24553 MB (92% inode=95%): /home 11548 MB (93% inode=99%): /var/log 1799 MB (6% inode=99%): /var/tmp 422 MB (99% 
[13:50:09] <icinga-wm>	 ): /var/log/audit 422 MB (99% inode=99%): /run/user/16778 6392 MB (100% inode=99%): /run/user/571 6392 MB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=civi1002&service=check_disk
[14:10:09] <icinga-wm>	 RECOVERY - check_disk on civi1002 is OK: DISK OK - free space: /dev 31939 MB (100% inode=99%): /run 6391 MB (99% inode=99%): / 4563 MB (65% inode=86%): /dev/shm 31962 MB (100% inode=99%): /run/lock 5 MB (100% inode=99%): /boot 318 MB (75% inode=99%): /srv 61962 MB (21% inode=97%): /tmp 10759 MB (87% inode=99%): /var 24552 MB (92% inode=95%): /home 11548 MB (93% inode=99%): /var/log 14490 MB (54% inode=99%): /var/tmp 422 MB (99% inode=99%
[14:10:09] <icinga-wm>	 og/audit 422 MB (99% inode=99%): /run/user/16778 6392 MB (100% inode=99%): /run/user/571 6392 MB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=civi1002&service=check_disk
[14:17:33] <wikibugs>	 (03PS1) 10Damilare Adedoyin: Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997
[14:18:02] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997 (owner: 10Damilare Adedoyin)
[14:18:50] <wikibugs>	 (03PS2) 10Damilare Adedoyin: Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997
[14:19:25] <damilare>	 jgleeson here's the patch to fix the infinite loop ^
[14:20:17] <damilare>	 fundraiseup changed the header for a column and seem to have reverted it after the export on the 14th.
[14:24:07] <wikibugs>	 (03PS3) 10Damilare Adedoyin: Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997
[14:29:41] <jgleeson>	 looking now damilare thanks
[14:29:49] <jgleeson>	 looks like I got d/c from irc for a moment there
[14:30:04] <damilare>	 thanks
[14:30:19] <damilare>	 yh happened twice this week for me
[14:31:57] <jgleeson>	 damilare: how can I test this code?
[14:32:30] <damilare>	 you can use the tests and make a modiification to the mock data header
[14:33:04] <damilare>	 Let me add a negative test
[14:33:42] <jgleeson>	 thanks. looks like https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/277aecfad6dfe5848926cd6d08df481d4d6da996/PaymentProviders/Fundraiseup/Tests/phpunit/AuditTest.php#L24 runs through it so I can start with that
[14:33:49] <damilare>	 yep
[14:34:57] <jgleeson>	 so is your theory that when we get an exception it doesn't break the loop?
[14:36:19] <jgleeson>	 is csv is valid but something happens it just keeps looping
[14:43:15] <wikibugs>	 (03PS4) 10Damilare Adedoyin: Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997
[14:43:18] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+1] "It looks good. I have a question about exception precision before merging. Thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997 (owner: 10Damilare Adedoyin)
[14:44:05] <damilare>	 yeah jgleeson, technically there's no issue with the CSV, it just doesn't hav the required header
[14:44:49] <damilare>	 oh yh you're right, I'd add that branch
[14:45:12] <jgleeson>	 awesome
[14:47:04] <wikibugs>	 (03PS5) 10Damilare Adedoyin: Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997
[14:47:30] <wikibugs>	 10Fundraising-Backlog: No 2023-11-14 Fundraise Up donations in Civi - https://phabricator.wikimedia.org/T351295 (10AKanji-WMF) p:05Triage→03High Adding to chaos!
[14:47:33] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997 (owner: 10Damilare Adedoyin)
[14:48:14] <wikibugs>	 (03PS6) 10Damilare Adedoyin: Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997
[14:48:41] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997 (owner: 10Damilare Adedoyin)
[14:49:51] <jgleeson>	 damilare: hmm I don't think that exception might make it to that level
[14:50:17] <jgleeson>	 it appears to be caught at a lower level here https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/70f13c5e77fbd147ed3cfd5928b20ca00d865472/PaymentProviders/Fundraiseup/Audit/FundraiseupImports.php#L39
[14:52:27] <wikibugs>	 (03PS7) 10Damilare Adedoyin: Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997
[14:52:43] <jgleeson>	 lemme check out your latest patch with the test
[14:53:12] <jgleeson>	 I can see that exception is thrown in two other places so it might still get thrown
[14:56:31] <jgleeson>	 hmm so I can see your new test throws an exception for $csv = new HeadedCsvReader( $path, ',', 4098, 0 );
[14:58:20] <damilare>	 hmm 
[14:58:29] <damilare>	 that shouldn't be it
[14:59:11] <damilare>	 it should throw the exception here: $csv->currentCol( 'Recurring Status' ) === 'cancelled';
[14:59:52] <damilare>	 because I changed "Recurring Status" to "Basic Recurring Status" just as it is currently in production
[15:00:19] <wikibugs>	 (03PS8) 10Damilare Adedoyin: Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997
[15:00:26] <jgleeson>	 I was just debugging through it and it seemed to throw inside the call on line 15
[15:00:45] <jgleeson>	 I'll try again. I need to pop out to pickup the kids but will jump back on it when I get back
[15:00:48] <jgleeson>	 back soon!
[15:01:14] <damilare>	 ok
[15:08:25] <wikibugs>	 (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/973943 (owner: 10L10n-bot)
[15:08:56] <wikibugs>	 (03PS9) 10Damilare Adedoyin: Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997
[15:09:24] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997 (owner: 10Damilare Adedoyin)
[15:09:48] <wikibugs>	 (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/974339 (owner: 10L10n-bot)
[15:10:06] <wikibugs>	 (03PS10) 10Damilare Adedoyin: Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997
[15:10:34] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997 (owner: 10Damilare Adedoyin)
[15:11:37] <wikibugs>	 (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_40) - 10https://gerrit.wikimedia.org/r/974756 (owner: 10L10n-bot)
[15:11:37] <wikibugs>	 (03PS11) 10Damilare Adedoyin: Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997
[15:36:06] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Endowment donation not showing up in the pop-up when mousing over the Civi icon - https://phabricator.wikimedia.org/T346917 (10SHust) @Ejegg I can’t believe it!!! Thank you so much, it feels like Christmas 😊
[15:55:06] <wikibugs>	 (03PS1) 10Ejegg: URLEncode api_key for API4 [wikimedia/fundraising/crm/civiproxy] (deployment) - 10https://gerrit.wikimedia.org/r/975013
[15:55:08] <wikibugs>	 (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm/civiproxy] (deployment) - 10https://gerrit.wikimedia.org/r/975014
[15:55:28] <wikibugs>	 (03Abandoned) 10Ejegg: URLEncode api_key for API4 [wikimedia/fundraising/crm/civiproxy] (deployment) - 10https://gerrit.wikimedia.org/r/975013 (owner: 10Ejegg)
[15:59:10] <wikibugs>	 (03PS2) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm/civiproxy] (deployment) - 10https://gerrit.wikimedia.org/r/975014
[15:59:27] <wikibugs>	 (03CR) 10Ejegg: [V: 03+2 C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm/civiproxy] (deployment) - 10https://gerrit.wikimedia.org/r/975014 (owner: 10Ejegg)
[16:18:45] <jgleeson>	 back damilare. hows that patch?
[16:18:59] <damilare>	 yh I've added another patch
[16:19:03] <damilare>	 to add a new test
[16:19:10] <damilare>	 so it's all good to go
[16:19:10] <jgleeson>	 awesome will check it out now
[16:30:11] <wikibugs>	 (03CR) 10Jgleeson: Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997 (owner: 10Damilare Adedoyin)
[16:40:07] <damilare>	 thanks jgleeson for catching that, I don't think the conditional is necessary like you said
[16:44:40] <wikibugs>	 (03PS12) 10Damilare Adedoyin: Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997
[16:57:16] <wikibugs>	 (03PS13) 10Damilare Adedoyin: Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997
[17:05:15] <wikibugs>	 (03PS14) 10Damilare Adedoyin: Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997
[17:05:42] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997 (owner: 10Damilare Adedoyin)
[17:07:36] <wikibugs>	 (03PS15) 10Damilare Adedoyin: Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997
[17:09:03] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: "Typed card number does not match card brand" errors - https://phabricator.wikimedia.org/T349600 (10AnnWF) For that bin outdate issue:   Since we do not record our donor's card and they do not recommend to remove the validation, beca...
[17:17:54] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: "Typed card number does not match card brand" errors - https://phabricator.wikimedia.org/T349600 (10AnnWF) a:05Cstone→03AnnWF
[18:29:32] <wikibugs>	 10fundraising-tech-ops, 10FR-Tech-Analytics: ??? showing up in email names with ZB in Superset - https://phabricator.wikimedia.org/T348882 (10Jgreen) 05Open→03Resolved We adjusted the configuration for each database connection in Superset.
[19:11:31] <wikibugs>	 10fundraising-tech-ops: Fundraising access request for Sarah Guseman (Endowment Assistant - Contractor) - https://phabricator.wikimedia.org/T292212 (10Dwisehaupt) 05Open→03Resolved Closing old task.
[19:31:47] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "Works great! thanks for all the updates and the tests!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997 (owner: 10Damilare Adedoyin)
[19:32:23] <wikibugs>	 (03Merged) 10jenkins-bot: Throw exception to prevent infinite loop in csv reading and remove Payment ID that is not present in recurring exports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974997 (owner: 10Damilare Adedoyin)
[19:32:30] <wikibugs>	 10fundraising-tech-ops: Fundraising environment support for Debian 12 (Bookworm) - https://phabricator.wikimedia.org/T344290 (10Jgreen)
[19:33:06] <damilare>	 thanks jgleeson for the CR, lets get that deployed
[19:33:48] <jgleeson>	 np!
[19:50:07] <wikibugs>	 (03PS1) 10Damilare Adedoyin: Update smashpig to v0.8.9.3 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/975074
[20:04:50] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Matching Gift API SSL cert has expired - https://phabricator.wikimedia.org/T351201 (10greg) p:05Triage→03High
[20:06:52] <jgleeson>	 greg-g: I think that one is resolved
[20:07:09] <jgleeson>	 although I don't think they've replied
[20:07:17] <jgleeson>	 I'll check last nights job 
[20:11:05] <jgleeson>	 yep
[20:11:09] <jgleeson>	 I'll mark this one as fixed
[20:12:08] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Matching Gift API SSL cert has expired - https://phabricator.wikimedia.org/T351201 (10jgleeson) 05Open→03Resolved a:03jgleeson Looks like this one has been fixed. The job log from last night shows it was completed successfully as before.
[20:12:10] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C: 03+2] Update smashpig to v0.8.9.3 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/975074 (owner: 10Damilare Adedoyin)
[20:14:07] <greg-g>	 jgleeson: yeah, thanks, I thought it was but it was untriaged and the urge to clear out the backlog was strong
[20:21:48] <jgleeson>	 :)
[20:27:57] <wikibugs>	 (03Merged) 10jenkins-bot: Update smashpig to v0.8.9.3 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/975074 (owner: 10Damilare Adedoyin)
[20:33:10] <wikibugs>	 (03PS1) 10Damilare Adedoyin: Update smashpig to v0.8.9.3 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/975077
[20:45:56] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "This looks good to me. Thanks for the updates!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/958563 (https://phabricator.wikimedia.org/T340159) (owner: 10Wfan)
[20:52:49] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C: 03+2] Update smashpig to v0.8.9.3 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/975077 (owner: 10Damilare Adedoyin)
[21:00:44] <wfan>	 Thanks Jack~
[21:02:18] <wikibugs>	 (03Merged) 10jenkins-bot: Add log and cancel_reason to indicate the failed reason [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/958563 (https://phabricator.wikimedia.org/T340159) (owner: 10Wfan)
[21:02:29] <wikibugs>	 (03PS1) 10Cstone: Change from app to inapp to distinguish donation source [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/975082 (https://phabricator.wikimedia.org/T350919)
[21:03:02] <cstone>	 ^ one more tiny patch there for inapp vs app donation tracking
[21:03:25] <cstone>	 just talked to joseph about it 
[21:03:32] <wikibugs>	 (03CR) 10Wfan: [C: 03+2] Change from app to inapp to distinguish donation source [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/975082 (https://phabricator.wikimedia.org/T350919) (owner: 10Cstone)
[21:03:40] <cstone>	 thanks wfan :)
[21:04:02] <wfan>	 np, and here is the last patch for that auto_rescue https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/958999/ ticket
[21:04:54] <jgleeson>	 np wfan !
[21:05:03] <jgleeson>	 looking at that one also
[21:05:24] <wikibugs>	 (03Merged) 10jenkins-bot: Change from app to inapp to distinguish donation source [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/975082 (https://phabricator.wikimedia.org/T350919) (owner: 10Cstone)
[21:05:25] <wfan>	 appreciate it!
[21:09:02] <wikibugs>	 (03Merged) 10jenkins-bot: Update smashpig to v0.8.9.3 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/975077 (owner: 10Damilare Adedoyin)
[21:09:22] <jgleeson>	 damilare: what happened to that early finish
[21:09:26] <wikibugs>	 (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment 4e7211ef8 Update CRM deduper merger.php 8d23c2430 Update smashpig to v0.8.9.3 [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/975084
[21:10:21] <damilare>	 the deployments, taking a while... I want to see it work before signing out
[21:10:31] <jgleeson>	 I feel your pain
[21:10:36] <jgleeson>	 been there before
[21:11:01] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C: 03+2] Merge branch 'master' into deployment 4e7211ef8 Update CRM deduper merger.php 8d23c2430 Update smashpig to v0.8.9.3 [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/975084 (owner: 10Damilare Adedoyin)
[21:11:49] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' into deployment 4e7211ef8 Update CRM deduper merger.php 8d23c2430 Update smashpig to v0.8.9.3 [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/975084 (owner: 10Damilare Adedoyin)
[21:12:02] <cstone>	 That's when it takes forever to merge too 
[21:18:25] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "Thanks for all the work on this and the tests!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/958999 (https://phabricator.wikimedia.org/T340159) (owner: 10Wfan)
[21:19:05] <wikibugs>	 (03Merged) 10jenkins-bot: Add cancel authorize process from auto rescue end process's webhook message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/958999 (https://phabricator.wikimedia.org/T340159) (owner: 10Wfan)
[21:20:35] <damilare>	 yh exactly
[21:21:05] <damilare>	 I just realised the changes I tagged in smashpig weren't pulled into vendor
[21:21:19] <damilare>	 cstone: jgleeson wfan any idea why that'd be
[21:22:08] <damilare>	 this is the vendor patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/vendor/+/975077
[21:22:40] <jgleeson>	 checking
[21:22:47] <damilare>	 this diff sshowing the changes in the tag: https://github.com/wikimedia/wikimedia-fundraising-SmashPig/compare/v0.8.9.2...v0.8.9.3
[21:23:05] <damilare>	 only the test data made it
[21:36:36] <wikibugs>	 (03PS1) 10Damilare Adedoyin: Update smashpig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/975087
[21:37:16] <damilare>	 ok so now this has the changed files, had to restart docker
[21:37:47] <damilare>	 looks like the changes in docker aren't reflecting the external mount until I restart the services
[21:38:06] <damilare>	 also happens during debug and testing
[21:38:26] <damilare>	 I don't know if anyone else has experienced this
[21:40:07] <jgleeson>	 damilare: I can see the other files if I revert back to smashpig 0.8.9.2
[21:40:18] <jgleeson>	 and the upgrade from that
[21:40:37] <wikibugs>	 (03PS2) 10Damilare Adedoyin: Update smashpig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/975087
[21:42:11] <damilare>	 ohh that's interesting
[21:42:34] <jgleeson>	 damilare: I managed to get the full list by going back into vendor and checking out cstone's patch before yours. I then run composer install --no-dev and cd back to vendor and I see all the expected changed files
[21:43:01] <damilare>	 so an incremental update
[21:43:04] <jgleeson>	 I see some of them in your PS2, is that one what you expect 
[21:43:22] <damilare>	 yeah those are the files I was expecting initially
[21:43:31] <jgleeson>	 my guess is something went wrong with your patch on vendor 
[21:43:37] <damilare>	 had to restart docker and run composer install --no-dev
[21:43:41] <jgleeson>	 maybe git add . didn't bring in the new stuff
[21:43:52] <damilare>	 I checked, it was empty
[21:44:20] <jgleeson>	 try this at your end
[21:44:22] <damilare>	 not sure why restarting did the trick
[21:44:30] <jgleeson>	 rm -rf vendor
[21:44:41] <jgleeson>	 git submodule update --init --recursive 
[21:44:47] <jgleeson>	 cd vendor
[21:44:52] <jgleeson>	 git checkout cstone's commit
[21:44:56] <jgleeson>	 cd ../
[21:45:02] <jgleeson>	 composer install --no-dev
[21:45:11] <jgleeson>	 then if you back to vendor you should all your changes
[21:45:16] <jgleeson>	 (just to verify)
[21:45:33] <jgleeson>	 go* back
[21:45:44] <jgleeson>	 and type git status
[21:46:35] <cstone>	 we were confused because the instructions changed slightly and apparently i cant handle that :P
[21:46:36] <jgleeson>	 do we no longer need to update the submodule pointer in the crm project?
[21:46:42] <cstone>	 you need to
[21:46:52] <jgleeson>	 ok, that will need to happen too dami
[21:47:02] <cstone>	 and you need to still do it in payments with smashpig thats what I did last night
[21:47:49] <cstone>	 damilare: do you want more eyes on it in a call?
[21:48:28] <damilare>	 nah its ok now, I have the files showing here now: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/vendor/+/975087/
[21:48:57] <cstone>	 ok cool!
[21:49:23] <damilare>	 I did the same steps jgleeson just highlighted now earlier, but those files didn't show up. Until I restarted docker
[21:49:41] <cstone>	 git is having git freak week :P
[21:49:44] <jgleeson>	 ah maybe a weird mount issue
[21:49:45] <damilare>	 and immediately I ran composer install they all came out
[21:50:01] <damilare>	 yh that's what I'm thinking also happens when I'm debugging
[21:50:17] <jgleeson>	 I tend to run most composer commands on the host
[21:51:06] <damilare>	 if I make a change to a file I'm debugging, xdebug doesn't see it and still uses the old code
[21:51:25] <damilare>	 yh I should install php and composer on the host, haven't done that...
[21:51:56] <damilare>	 I have to restart docker to get that sorted
[21:53:19] <icinga-wm>	 PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 2 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages
[21:54:36] <jgleeson>	 we need to revisit docker on the mac
[21:55:25] <jgleeson>	 it would be great to kick the tyres of this patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/953984
[21:55:47] <jgleeson>	 I need to wake my mac from hibernation under my desk
[21:57:32] <damilare>	 yh might be some help to try out some of the suggestions here: https://docs.docker.com/desktop/troubleshoot/known-issues/#:~:text=run/docker.sock-,There,-are%20a%20number
[21:58:12] <damilare>	 for mac with intel chip->last bullet point
[21:58:19] <icinga-wm>	 PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 4 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages
[21:58:29] <jgleeson>	 feel free to drop that on the patch
[21:58:39] <jgleeson>	 we could hash it out on our next call
[21:58:55] <jgleeson>	 tech-talks are so busy lately
[22:00:49] <damilare>	 yep
[22:03:21] <icinga-wm>	 RECOVERY - check_log_messages on frav1003 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages
[22:03:32] <damilare>	 I should also add that this issue just started recently, probably related to a docker update I did recently too
[22:05:05] <jgleeson>	 I need to update my local docker. all those platform config directives don't work for me. I keep having to apply a git stash commenting them all out
[22:05:56] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C: 03+2] Update smashpig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/975087 (owner: 10Damilare Adedoyin)
[22:23:23] <wikibugs>	 (03Merged) 10jenkins-bot: Update smashpig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/975087 (owner: 10Damilare Adedoyin)
[22:24:52] <wikibugs>	 (03PS1) 10Damilare Adedoyin: Update smashpig with files [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/975090
[22:26:22] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C: 03+2] Update smashpig with files [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/975090 (owner: 10Damilare Adedoyin)
[22:27:13] <wikibugs>	 (03Merged) 10jenkins-bot: Update smashpig with files [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/975090 (owner: 10Damilare Adedoyin)
[22:43:09] <wikibugs>	 10Fundraising-Backlog: No 2023-11-14 Fundraise Up donations in Civi - https://phabricator.wikimedia.org/T351295 (10Damilare) Hi @Pcoombe thanks for bringing this up, Fundraiseup confirmed that they had an issue on their end that led to the sending of the export with a different template. We resolved the issue an...