[10:21:19] (03PS1) 10Thiemo Kreuz (WMDE): Replace more Xml::… methods with Html::… equivalents [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1025290 (https://phabricator.wikimedia.org/T341775) [10:51:37] (03CR) 10Jforrester: [C:03+1] build: Expand the list of directories for phan to analyze [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1015093 (https://phabricator.wikimedia.org/T224763) (owner: 10Umherirrender) [10:52:12] (03CR) 10Jforrester: [V:03+2] "No non-FR branch CI, but this is fine and makes LibUp happy." [extensions/DonationInterface] (REL1_40) - 10https://gerrit.wikimedia.org/r/996972 (owner: 10Libraryupgrader) [10:52:20] (03CR) 10Jforrester: [V:03+2] "No non-FR branch CI, but this is fine and makes LibUp happy." [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/996971 (owner: 10Libraryupgrader) [14:08:30] 03Fundraising Sprint: hammertime($touch_this=false), 06Fundraising-Backlog: Enable 90 day snooze: Comms Preferences Centre update - https://phabricator.wikimedia.org/T358878#9753331 (10Ejegg) a:03Ejegg [15:13:53] (03PS1) 10Ejegg: WIP add snooze option to Email Preferences form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1025388 (https://phabricator.wikimedia.org/T358878) [15:17:49] 06Fundraising-Backlog, 10FR-email-preferences, 10MediaWiki-extensions-DonationInterface: Update text on email preferences success page - https://phabricator.wikimedia.org/T363717 (10Ejegg) 03NEW [15:19:21] 03Fundraising Sprint: hammertime($touch_this=false), 06Fundraising-Backlog, 13Patch-For-Review: Enable 90 day snooze: Comms Preferences Centre update - https://phabricator.wikimedia.org/T358878#9753675 (10Ejegg) >>! In T358878#9596774, @AnnWF wrote: > From slack, we need to make unsubscribe success message i... [15:46:27] (03CR) 10Krinkle: Replace a lot of more trivial Xml::… calls with Html::… (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1021962 (https://phabricator.wikimedia.org/T341775) (owner: 10Thiemo Kreuz (WMDE)) [15:50:29] anilk: which stakeholder should answer questions about the new donor-facing snooze functionality? [15:50:39] I've added some questions at https://phabricator.wikimedia.org/T358878#9753900 [16:17:25] thanks ejegg|food - I asked about who should pick this up on team email's side... [17:14:34] (03PS1) 10Ejegg: Add snooze date to getPreferences output [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1025418 (https://phabricator.wikimedia.org/T358878) [17:44:47] (03PS2) 10Ejegg: Add snooze option to Email Preferences form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1025388 (https://phabricator.wikimedia.org/T358878) [17:47:12] ejegg: aaaand sounds like it will be Mariana - I will loop her in! [18:04:35] (03PS1) 10Ejegg: WIP set snooze_date from email preferences consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1025435 (https://phabricator.wikimedia.org/T358878) [18:04:48] thanks anilk ! [18:13:27] 03Fundraising Sprint: hammertime($touch_this=false), 06Fundraising-Backlog, 13Patch-For-Review: Enable 90 day snooze: Comms Preferences Centre update - https://phabricator.wikimedia.org/T358878#9754788 (10AKanji-WMF) @MSuijkerbuijk_WMF adding you to this task so we can discuss these questions! [18:23:20] (03PS8) 10Eileen: Consolidate calls to message_import within Benevity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020478 (https://phabricator.wikimedia.org/T240581) [18:23:36] (03CR) 10Ejegg: [C:03+2] Consolidate calls to message_import within Benevity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020478 (https://phabricator.wikimedia.org/T240581) (owner: 10Eileen) [18:28:50] (03PS6) 10Jgleeson: Add SEPA js [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1009950 (https://phabricator.wikimedia.org/T324520) (owner: 10Wfan) [18:28:50] (03PS6) 10Jgleeson: Delay sending recurring SEPA payments to donations queue. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1020868 (https://phabricator.wikimedia.org/T324520) [18:31:00] (03CR) 10CI reject: [V:04-1] Delay sending recurring SEPA payments to donations queue. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1020868 (https://phabricator.wikimedia.org/T324520) (owner: 10Jgleeson) [18:34:10] (03PS7) 10Jgleeson: Delay sending recurring SEPA payments to donations queue. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1020868 (https://phabricator.wikimedia.org/T324520) [18:44:22] (03Merged) 10jenkins-bot: Consolidate calls to message_import within Benevity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020478 (https://phabricator.wikimedia.org/T240581) (owner: 10Eileen) [19:29:05] brb [19:36:24] (03CR) 10Eileen: [C:03+2] Add snooze date to getPreferences output [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1025418 (https://phabricator.wikimedia.org/T358878) (owner: 10Ejegg) [19:42:47] (03PS2) 10Eileen: Rename WMF folder to match capitalization on similar folders [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023561 [19:43:36] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: We lost some stats moving the donations queue consumer form drush - https://phabricator.wikimedia.org/T362206#9755167 (10jgleeson) a:03jgleeson [19:45:12] (03PS9) 10Eileen: Separate import code from main message_import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1020479 (https://phabricator.wikimedia.org/T240581) [19:45:30] 03Fundraising Sprint: hammertime($touch_this=false), 06Fundraising-Backlog, 10fundraising-tech-ops: Request access to CIVI Staging - https://phabricator.wikimedia.org/T358042#9755172 (10Dwisehaupt) [19:49:36] (03PS11) 10Eileen: Get rid of name_prefix & name_suffix in favour of the api fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022309 (https://phabricator.wikimedia.org/T240581) [19:51:35] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: hammertime($touch_this=false), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Convert Queue2civicrm to civicrm extension - https://phabricator.wikimedia.org/T270672#9755185 (10Eileenmcnaughton) a:03Eileenmcnaughton [19:52:19] (03PS8) 10Eileen: Move clean up of incoming strings to the Normalize function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022492 (https://phabricator.wikimedia.org/T357471) [19:52:19] (03PS3) 10Eileen: Clean up handling of fiscal_number / legal_identifier [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023564 (https://phabricator.wikimedia.org/T357471) [19:53:45] 06Fundraising-Backlog: Update contact on CiviCRM when FRUP donor updates their email through donor portal - https://phabricator.wikimedia.org/T349663#9755190 (10AKanji-WMF) [19:57:10] (03Merged) 10jenkins-bot: Add snooze date to getPreferences output [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1025418 (https://phabricator.wikimedia.org/T358878) (owner: 10Ejegg) [20:01:29] (03PS1) 10Ejegg: Use bookworm images by default [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1025454 [20:08:38] (03CR) 10CI reject: [V:04-1] Get rid of name_prefix & name_suffix in favour of the api fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022309 (https://phabricator.wikimedia.org/T240581) (owner: 10Eileen) [20:11:14] (03CR) 10CI reject: [V:04-1] Clean up handling of fiscal_number / legal_identifier [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023564 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [20:11:30] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Smashpig, 10MediaWiki-extensions-DonationInterface: We're sending duplicate order_ids to dlocal - https://phabricator.wikimedia.org/T363104#9755258 (10greg) p:05Triage→03Medium [20:11:47] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Donations QC not sending messages to damaged on deadlocks - https://phabricator.wikimedia.org/T362997#9755259 (10greg) p:05Triage→03High [20:12:10] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: We lost some stats moving the donations queue consumer form drush - https://phabricator.wikimedia.org/T362206#9755261 (10greg) p:05Triage→03High [20:12:36] (03CR) 10CI reject: [V:04-1] Move clean up of incoming strings to the Normalize function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022492 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [20:14:32] 06Fundraising-Backlog, 10FR-email-preferences, 10MediaWiki-extensions-DonationInterface: Update text on email preferences success page - https://phabricator.wikimedia.org/T363717#9755274 (10AKanji-WMF) @MSuijkerbuijk_WMF - let's chat about this too. need confirmation language that accounts for the array of... [20:15:56] 06Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig: Retry (with idempotency ID) when Adyen returns error code 703 - https://phabricator.wikimedia.org/T363603#9755278 (10AKanji-WMF) Keep tabs to see if errors of this type recurr [20:17:43] (03PS12) 10Eileen: Get rid of name_prefix & name_suffix in favour of the api fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022309 (https://phabricator.wikimedia.org/T240581) [20:26:39] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: hammertime($touch_this=false), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Remove unused import code from main codebase - https://phabricator.wikimedia.org/T363524#9755326 (10AKanji-WMF) [20:27:52] 06Fundraising-Backlog, 10FR-donorservices: Unusual Inclusion of Non-3C Donors in Springlish Segmentation - https://phabricator.wikimedia.org/T363498#9755331 (10AKanji-WMF) @KHaggard is there someone on team email who could have a look at the targeting on this? Would have been set up in Acoustic... [20:30:33] 06Fundraising-Backlog: Jazz up the mailcheck.js suggestion text - https://phabricator.wikimedia.org/T363473#9755347 (10AKanji-WMF) @spatton this seems appropriate for me to bring to the weekly design call? [20:32:21] (03PS1) 10Umherirrender: maintenance: Migrate to IReadableDatabase::newSelectQueryBuilder [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1025458 (https://phabricator.wikimedia.org/T312369) [20:36:34] fr-tech here's the patch to start using bookworm by default locally: https://gerrit.wikimedia.org/r/1025454 [20:36:57] oops, didn't mean to add those xdebugs [20:37:51] (03PS2) 10Ejegg: Use bookworm images by default [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1025454 [20:50:36] (03PS1) 10Ejegg: Comments to clarify where to find fraud filters [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1025461 [21:06:59] 06Fundraising-Backlog: Jazz up the mailcheck.js suggestion text - https://phabricator.wikimedia.org/T363473#9755481 (10spatton) Sure @AKanji-WMF looks like a great task. Though I say **just ship the flames**, it's fail-proof :) I added it to the [[ https://docs.google.com/document/d/1TDg1BrF3z2u5Yi4vDJvvEzcUXaF... [21:12:59] (03PS9) 10Eileen: Move clean up of incoming strings to the Normalize function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1022492 (https://phabricator.wikimedia.org/T357471) [21:13:48] (03PS4) 10Eileen: Clean up handling of fiscal_number / legal_identifier [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023564 (https://phabricator.wikimedia.org/T357471) [21:25:18] if anyone feels up for looking at https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1022309 there is a bit of code in there - happy to talk you through it [21:41:29] (03PS1) 10Eileen: Update OptInQueueConsuer to use a Message class, apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1025472 (https://phabricator.wikimedia.org/T357471) [21:44:20] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1025473 [21:45:41] cstone: looks like that merge commit is huge - how do we feel about pushing it out now? I guess I should try to figure out asana [21:46:00] 06Fundraising-Backlog: Paypal Giving Fund donations added to Civi under incorrect CID - https://phabricator.wikimedia.org/T363768 (10EMartin) 03NEW [22:00:01] (03CR) 10CI reject: [V:04-1] Update OptInQueueConsuer to use a Message class, apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1025472 (https://phabricator.wikimedia.org/T357471) (owner: 10Eileen) [22:06:53] hah it is giant eileen [22:07:15] japanese pretest in 2 hours but I think its low volume enough to be fine? [22:07:46] to push it out now [22:10:42] I'm going to go for a quick bike ride but will be back in like ~45 mins and be around the rest of the night to watch things [22:12:35] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1025473 (owner: 10Eileen) [22:13:24] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1025473 (owner: 10Eileen) [22:13:29] 06Fundraising-Backlog, 10FR-donorservices: Unusual Inclusion of Non-3C Donors in Springlish Segmentation - https://phabricator.wikimedia.org/T363498#9755674 (10KHaggard) Hi @AKanji-WMF - yes we already looked at this together with DR before the ticket was logged and we've confirmed on our side that all our que... [22:34:57] (03CR) 10DannyS712: [C:03+2] maintenance: Migrate to IReadableDatabase::newSelectQueryBuilder [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1025458 (https://phabricator.wikimedia.org/T312369) (owner: 10Umherirrender) [22:36:22] 03Fundraising Sprint: hammertime($touch_this=false), 06Fundraising-Backlog: Civi batch data entry tool build out - https://phabricator.wikimedia.org/T360139#9755732 (10Eileenmcnaughton) @MDemosWMF arg - it's because I made the field auto-complete - but I feel like that's the right type of field ?- I'll see if... [22:57:28] !log civicrm upgraded from e95e03d9 to 393e1deb [22:57:28] * config revision changed from 240feaec to cd22e732 [22:57:31] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:58:47] (03Merged) 10jenkins-bot: maintenance: Migrate to IReadableDatabase::newSelectQueryBuilder [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1025458 (https://phabricator.wikimedia.org/T312369) (owner: 10Umherirrender) [23:08:49] im back there was a headwind :( haha [23:25:03] cool - I deployed [23:59:17] cstone: looking at https://phabricator.wikimedia.org/T363768 - do we know what paypal giving is?