[00:06:36] 10fundraising-tech-ops: Fundraising access request for jcraig - https://phabricator.wikimedia.org/T363949#9776198 (10Dwisehaupt) [00:07:38] 10fundraising-tech-ops: Fundraising access request for jcraig - https://phabricator.wikimedia.org/T363949#9776200 (10Dwisehaupt) SSL client certificate created and sent via email. Password sent via SMS. Superset account created and set with random password. Follow up email sent with access and password change in... [00:08:23] (03Merged) 10jenkins-bot: Set snooze_date from email preferences consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1025435 (https://phabricator.wikimedia.org/T358878) (owner: 10Ejegg) [00:10:54] (03Merged) 10jenkins-bot: Set SmashPig recur fields to hidden [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1003006 (owner: 10Ejegg) [00:12:21] thanks eileen ! [00:12:52] no worries - I was close to +2ing one of your others - I just had a question about ?? vs ?: [00:13:57] 10fundraising-tech-ops: Fundraising access request for ncreasy - https://phabricator.wikimedia.org/T346174#9776203 (10Dwisehaupt) [00:14:43] 10fundraising-tech-ops: Fundraising access request for ncreasy - https://phabricator.wikimedia.org/T346174#9776204 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt Verified jupyter access has been working. [00:19:37] 06Fundraising-Backlog, 10fundraising-tech-ops: Fix disk capacity issues on civi1002 - https://phabricator.wikimedia.org/T343071#9776221 (10Dwisehaupt) 05Stalled→03Resolved a:03Dwisehaupt This has been largely addressed by not syncing some debug log files that were not required. Closing. ` commit fab... [00:20:41] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for dkozlowski - https://phabricator.wikimedia.org/T356671#9776225 (10Dwisehaupt) 05Open→03Resolved [00:21:26] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jgleeson - https://phabricator.wikimedia.org/T355702#9776226 (10Dwisehaupt) 05Open→03Resolved [00:21:29] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ylavappa - https://phabricator.wikimedia.org/T356667#9776239 (10Dwisehaupt) 05Open→03Resolved [00:27:29] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for lnavarro - https://phabricator.wikimedia.org/T356309#9776244 (10Dwisehaupt) 05Open→03Resolved Closing for inactivity. Can reissue the certificate when required. [00:27:40] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for lgruwell - https://phabricator.wikimedia.org/T356311#9776247 (10Dwisehaupt) 05Open→03Resolved Closing for inactivity. Can reissue the certificate when required. [00:27:56] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jtanner - https://phabricator.wikimedia.org/T356674#9776254 (10Dwisehaupt) 05Open→03Resolved Closing for inactivity. Can reissue the certificate when required. [00:27:58] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jbaldwin - https://phabricator.wikimedia.org/T356670#9776257 (10Dwisehaupt) 05Open→03Resolved Closing for inactivity. Can reissue the certificate when required. [00:50:48] 06Fundraising-Backlog: Large workplace giving companies not showing $ totals - https://phabricator.wikimedia.org/T364324#9776294 (10NNichols) Interesting. @RLewis You'll have to include these manually in your report. @Eileenmcnaughton thank you! I'll make a note in the workplace giving documentation [01:19:09] 06Fundraising-Backlog: Large workplace giving companies not showing $ totals - https://phabricator.wikimedia.org/T364324#9776313 (10Eileenmcnaughton) If there is a particular field you search on we could arbitrarily make it a million for these contacts.... [09:24:10] 06Fundraising-Backlog, 10Desktop Improvements (Vector 2022), 10Web-Team-Backlog (FY2023-24 Q4 Sprint 4): Plan for Donate Wiki and Thank You Wiki Rollback and Redesign - https://phabricator.wikimedia.org/T361500#9776730 (10ovasileva) [13:12:08] hi fr-tech! [13:23:48] hi ejegg [13:33:26] (03PS5) 10Ejegg: Migrate exchange rates variables to Civi settings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026683 (https://phabricator.wikimedia.org/T270666) [13:33:26] (03PS4) 10Ejegg: Create ExchangeRate entity in CiviCRM [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027004 (https://phabricator.wikimedia.org/T270666) [13:33:26] (03PS5) 10Ejegg: Copy exchanges rates from old drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027006 (https://phabricator.wikimedia.org/T270666) [13:36:01] (03CR) 10Ejegg: "Thanks for the review, Eileen! I think I've addressed all your comments in PS5" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026683 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [13:53:02] (03PS6) 10Ejegg: Copy exchanges rates from old drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027006 (https://phabricator.wikimedia.org/T270666) [13:53:02] (03PS3) 10Ejegg: Switch exchange rate retrievers to Guzzle [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027054 (https://phabricator.wikimedia.org/T270666) [13:54:32] 03Fundraising Sprint: hammertime($touch_this=false), 06Fundraising-Backlog, 10FR-Adyen: Add ability to accept JSON notifications - https://phabricator.wikimedia.org/T289166#9777502 (10Damilare) @Ejegg I don't think there's any left. What's left is to deploy and test the json notifications. [13:54:46] thanks damilare ! [13:54:57] let's see how much traffic we're getting through adyen right now [13:55:10] np [13:55:19] how do we check that, the queues? [13:55:28] or the logs [13:55:37] okk [13:58:09] there's this too, top left graph is scraped from logs: https://frmon.wikimedia.org/d/xbcwsjY4k/payment-transaction-outcomes?orgId=1 [13:58:35] looks like 2-3 per minute [13:58:49] oops, just as I said that we got a burst of like 7 [13:59:55] well, still seems like we can switch [14:00:13] I'll switch on my dev machine and try a few txns [14:00:27] yea, seems like at an avg of 6/min [14:00:43] okk sure [14:13:00] oh huh, we're not logging the full IPN in the RestListener [14:13:09] but we do in the SoapListener [14:13:14] let's make it log that... [14:13:52] so let's see, we're already logging in the child class for PayPal [14:14:04] maybe just add logging in the AdyenRestListener for now? [14:14:50] oh wait, paypal isn't a child class of any of those, it's just implementing IHttpActionHandler [14:14:53] simpler I guess [14:19:00] ah crap, the Capture IPNs for JPY are getting divided by 100 [14:19:07] 250 JPY getting recorded as 2.5 [14:19:43] but... that's not because of the switch to JSON [14:20:12] no it isn't [14:21:05] looks like we are doing some rounding stuff for certain currencies in adyen [14:21:28] 06Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig: We're recording the wrong amount from Adyen Capture IPNs in JPY - https://phabricator.wikimedia.org/T364392 (10Ejegg) 03NEW [14:21:50] we're doing a JPY campaign soon (now?) so let's maybe pull that into sprint [14:24:28] it caused an issue with autorescue when we had to capture from the IPN message: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1013133 [14:25:49] I'm not sure it's changing any other thing otherwise though, I agree we need to pull the phab iinto the sprint to confirm [14:26:24] (03PS1) 10Ejegg: Log raw JSON for Adyen IPNs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1028846 [14:26:50] damilare: do you have a sec to take a look at that one? ^^^ [14:26:56] yep looking [14:27:12] It seems to be logging well for me locally (i.e. I actually did smoke test this time, I promise!) [14:27:49] 😂😂 [14:29:59] (03PS2) 10Ejegg: Pull in frequency_unit and interval from logs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1028562 (https://phabricator.wikimedia.org/T358914) [14:29:59] (03PS3) 10Ejegg: Support annual donations in SmashPig Scheduler [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1028549 (https://phabricator.wikimedia.org/T358914) [14:31:38] I didn't actually review those preg_replace patterns tho, just copied them from the SoapListener [14:35:35] (03CR) 10Damilare Adedoyin: [C:03+2] "LGTM, tested and can see items in the logs." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1028846 (owner: 10Ejegg) [14:36:22] (03Merged) 10jenkins-bot: Log raw JSON for Adyen IPNs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1028846 (owner: 10Ejegg) [14:36:37] (03PS4) 10Ejegg: Support annual donations in SmashPig Scheduler [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1028549 (https://phabricator.wikimedia.org/T358914) [14:37:22] (03CR) 10Ejegg: "Thanks Eileen, ?: was the better choice." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1028549 (https://phabricator.wikimedia.org/T358914) (owner: 10Ejegg) [14:37:25] yh I couldn't find any sample message with the expiry date, the authorization message didn't have that [14:37:50] ah ok, maybe that was just copied from another processor who does send it? [14:38:15] or maybe it was something we could configure at Adyen [14:39:37] ahh yeah it's in the merchant console config [14:39:43] under Developer / Additional Data [14:39:47] well possibly, but I added a new key-value pair manually to the message like this "expiryDate: "02/2030"" [14:39:55] and it didn't reflect in the logs [14:39:58] and we've got it unchecked [14:40:15] ohh that's cool, same in prod [14:40:18] ? [14:40:27] Lemme check that field in the merchant console for test, just to see if that log cleaner works [14:41:47] ok [14:42:55] huh, it's still logged [14:43:03] {"additionalData":{"expiryDate":"03\/2030", [14:43:08] I guess that extra \ [14:43:13] yhh [14:46:32] also, should we put the logging and preg match in the base class [14:48:41] ah ok [14:48:58] hi folks [14:49:16] good hackathon damilare !? [14:49:56] ah damilare we will have to touch the other child classes if we put it in the base classes [14:50:10] since dlocal listener and adyen listener are already doing their own logging [14:50:15] yep jgleeson it was quite cool, got to see a lot of faces [14:50:28] oh yeah, I meant to ask about that! [14:50:32] how was the travel? [14:50:36] awesome [14:50:43] did you get to see anything beyond the event? [14:51:14] hmm, and dlocal sanitization is specific to their format [14:51:15] yea was in Italy for a bit that was cool, but didn't go out as much in Estonia [14:51:30] I think maybe in the child class is OK for RestListener subclasses [14:51:37] right, best to leave it as it is then [14:51:45] ah right, Italy! [14:52:31] looks like the Colombia fraud is still ongoing [14:52:38] bunch of dlocal failmail [14:53:29] (03PS1) 10Ejegg: Fix expiry data sanitization for Adyen IPN log [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1028851 [14:53:51] ah yeah jgleeson we need to figure out a better filter [14:53:58] (03CR) 10CI reject: [V:04-1] Fix expiry data sanitization for Adyen IPN log [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1028851 (owner: 10Ejegg) [14:54:14] ack, that wasn't what I wanted [14:55:37] (03CR) 10CI reject: [V:04-1] Support annual donations in SmashPig Scheduler [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1028549 (https://phabricator.wikimedia.org/T358914) (owner: 10Ejegg) [14:57:22] (03PS2) 10Ejegg: Fix expiry data sanitization for Adyen IPN log [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1028851 [15:00:22] damilare: it took 5 backslashes to make that replacement actually work ^^^ [15:00:54] oh nice, I also just got this to work: '/(\d{1,2})(\\\)(\/)(19|20)(\d{2})/' [15:01:20] oh huh, only 4 slashes, [15:01:26] wait, let me try again with the 5 [15:01:47] 14Fundraising Spring - anybodyKnowWhatThisDoes(), 06Fundraising-Backlog, 10Wikipedia-Android-App-Backlog (Android Release - FY2023-24), 10Wikipedia-iOS-App-Backlog (iOS Release FY2023-24): Standardize utm_source from app donations without a banner and clea... - https://phabricator.wikimedia.org/T350919#9777719 [15:02:22] I wonder why we considered cards with expiry date in the 19s previously [15:02:40] hah right [15:02:54] maybe a regex copied from someplace else? [15:03:24] right, I don't see a reason we'd have dob on those messages [15:05:03] ok, just tested again and the version I pushed up there is indeed working to sanitize expiryDate [15:05:20] I'll uncheck it in the merchant console config now [15:06:23] (03PS6) 10Eileen: Add custom field to allow batch data entry to create a relationship [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1021084 (https://phabricator.wikimedia.org/T360139) [15:06:26] (03CR) 10Ejegg: [C:03+2] Add custom field to allow batch data entry to create a relationship [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1021084 (https://phabricator.wikimedia.org/T360139) (owner: 10Eileen) [15:06:39] ok I just tested also [15:06:54] (03CR) 10Damilare Adedoyin: [C:03+2] Fix expiry data sanitization for Adyen IPN log [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1028851 (owner: 10Ejegg) [15:07:45] thanks damilare [15:07:54] OK, I'll deploy that logging thing [15:07:55] np [15:08:07] then maybe we can switch the prod notifications to JSON [15:11:41] sounds good [15:19:29] huh, zuul is just sitting on it [15:19:47] test passed: https://integration.wikimedia.org/ci/job/composer-php74/750/console [15:21:31] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1028856 [15:21:33] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1028856 (owner: 10Ejegg) [15:24:16] 06Fundraising-Backlog: Systems access for new employee - https://phabricator.wikimedia.org/T364396 (10AParker) 03NEW [15:26:17] gonna just V+2 it manually [15:26:29] (03CR) 10Ejegg: [V:03+2] Fix expiry data sanitization for Adyen IPN log [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1028851 (owner: 10Ejegg) [15:26:39] (03Merged) 10jenkins-bot: Add custom field to allow batch data entry to create a relationship [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1021084 (https://phabricator.wikimedia.org/T360139) (owner: 10Eileen) [15:27:27] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1028856 (owner: 10Ejegg) [15:31:39] !log SmashPig (standalone IPN listener) upgraded from 71b9be53 to 67db9d96 [15:31:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:33:00] ok, I'm about to switch the prod IPNs to JSON [15:34:02] fingers crossed [15:34:05] !log switched Adyen IPN format to JSON in merchant console [15:34:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:34:25] OK, here's a JSON one in the log! [15:35:18] huh, followed by a few SOAP ones [15:35:25] good thing we went with the multilistener [15:36:09] still back and forth between SOAP and JSON [15:37:16] yep [15:39:44] so far so good though as far as I can tesll [15:39:47] *tell [15:53:51] no failmails [15:55:36] job runner logs look OK too [15:55:57] I'll head out for lunch soon but I'll keep an eye out for failmails [16:06:08] 06Fundraising-Backlog, 10fundraising-tech-ops: Systems access for new employee - https://phabricator.wikimedia.org/T364396#9778032 (10Dwisehaupt) [16:10:17] (03Merged) 10jenkins-bot: Pull in frequency_unit and interval from logs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1028562 (https://phabricator.wikimedia.org/T358914) (owner: 10Ejegg) [17:13:43] ok, looks like it's consistently sending just JSON now [17:22:07] (03PS5) 10Ejegg: Support annual donations in SmashPig Scheduler [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1028549 (https://phabricator.wikimedia.org/T358914) [17:36:01] 03Fundraising Sprint: hammertime($touch_this=false), 06Fundraising-Backlog, 13Patch-For-Review: Enable Recurring Annual Donations - https://phabricator.wikimedia.org/T358914#9778444 (10Ejegg) >>! In T358914#9775326, @Ejegg wrote: > Other things we'll need: import frequency_unit in queue consumer, read it out... [17:38:48] grr, pycharm freezing [17:44:08] (03PS1) 10Ejegg: Handle annual donations in PayPal audit [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1028875 (https://phabricator.wikimedia.org/T358914) [17:45:18] (03CR) 10CI reject: [V:04-1] Handle annual donations in PayPal audit [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1028875 (https://phabricator.wikimedia.org/T358914) (owner: 10Ejegg) [17:47:16] 03Fundraising Sprint: hammertime($touch_this=false), 06Fundraising-Backlog, 13Patch-For-Review: Enable Recurring Annual Donations - https://phabricator.wikimedia.org/T358914#9778476 (10Ejegg) OK, got another small patch up for the python PayPal audit. That's all I can think of for now! [17:47:44] wat - that test fail seems spurious [17:47:52] some date bug? [18:04:04] 06Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for jschoenig - https://phabricator.wikimedia.org/T364396#9778518 (10Dwisehaupt) [18:05:34] 10fundraising-tech-ops: Fundraising access request for bjordan-ctr - https://phabricator.wikimedia.org/T364415 (10Dwisehaupt) 03NEW [18:25:23] 06Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for jschoenig - https://phabricator.wikimedia.org/T364396#9778650 (10Dwisehaupt) [18:29:32] 06Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for jschoenig - https://phabricator.wikimedia.org/T364396#9778674 (10Dwisehaupt) Approval received. ` Date: Tue, 7 May 2024 11:17:37 From: Lisa Seitz Gruwell To: Amy Parker Cc: Caitlin Virtue, Dallas Wisehaupt Subject: Re: Civi access f... [18:46:10] 10fundraising-tech-ops: Fundraising access request for bjordan-ctr - https://phabricator.wikimedia.org/T364415#9778744 (10MDemosWMF) [18:50:15] (03CR) 10Jgleeson: "I don't think approach now. I'm gonna try tidying it up and try to figure out a good place to put the stats collectors. It would be nice i" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026688 (https://phabricator.wikimedia.org/T362206) (owner: 10Jgleeson) [18:50:41] (03CR) 10Jgleeson: "I don't like*** or think :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026688 (https://phabricator.wikimedia.org/T362206) (owner: 10Jgleeson) [19:04:30] (03CR) 10Eileen: [C:03+2] Support annual donations in SmashPig Scheduler [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1028549 (https://phabricator.wikimedia.org/T358914) (owner: 10Ejegg) [19:06:41] oh hey fr-tech, there's just one more little thing to merge for the 90 day snooze: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1026948 [19:23:24] 06Fundraising-Backlog, 10FR-Civi-Dedupe, 10FR-donorservices: Deduper Issue - https://phabricator.wikimedia.org/T363958#9778843 (10AKanji-WMF) [19:25:33] (03Merged) 10jenkins-bot: Support annual donations in SmashPig Scheduler [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1028549 (https://phabricator.wikimedia.org/T358914) (owner: 10Ejegg) [19:57:34] thanks eileen [19:57:55] ejegg: no worries - just looking at the settings patch - you didn't add a menu entry did you? [19:58:03] ahhh that part I forgot [19:58:09] let me do that in a follow-on? [19:59:00] oh i see, you had comments on the entity creation too [19:59:17] eileen: OK, I'll change that settings patch too [19:59:44] ejegg: it's ok - if you want to follow on - I was looking for an easy way to view the settings after the upgrade [20:00:08] nah, I'm going to edit the next patch too so I might as well fix the settings patch [20:02:24] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Latest civi point point version upgrade - https://phabricator.wikimedia.org/T364339#9778970 (10AKanji-WMF) [20:02:26] 03Fundraising Sprint: ick(), 06Fundraising-Backlog: Greece - Campaign Readyness Checklist - https://phabricator.wikimedia.org/T362784#9778973 (10AKanji-WMF) [20:02:32] 03Fundraising Sprint: ick(), 06Fundraising-Backlog: Sprint H - Priorities (WIP) - https://phabricator.wikimedia.org/T363121#9778971 (10AKanji-WMF) [20:02:44] 03Fundraising Sprint: ick(), 06Fundraising-Backlog: Consider phonetic names when deduping - https://phabricator.wikimedia.org/T362196#9778974 (10AKanji-WMF) [20:02:46] 03Fundraising Sprint: ick(), 06Fundraising-Backlog: Add dLocal support to Gr4vy POC - https://phabricator.wikimedia.org/T361892#9778976 (10AKanji-WMF) [20:02:48] eileen: I see both a php-level navigation hook and the Naviagtion.mgd.php [20:02:48] 03Fundraising Sprint: ick(), 06Fundraising-Backlog: CiviMail Unsubscribe Footer Broken - https://phabricator.wikimedia.org/T361630#9778977 (10AKanji-WMF) [20:02:49] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Remove unused import code from main codebase - https://phabricator.wikimedia.org/T363524#9778972 (10AKanji-WMF) [20:02:50] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 13Patch-For-Review: Save phonetic names into civi fields - https://phabricator.wikimedia.org/T362195#9778975 (10AKanji-WMF) [20:02:52] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), 13Patch-For-Review: Placeholder - Research Task - Implementing GPay on Android - https://phabricator.wikimedia.org/T360377#9778978 (10AKanji-WMF) [20:02:54] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 13Patch-For-Review: Civi batch data entry tool build out - https://phabricator.wikimedia.org/T360139#9778979 (10AKanji-WMF) [20:02:57] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog: Create new Benevity import - https://phabricator.wikimedia.org/T359219#9778980 (10AKanji-WMF) [20:03:01] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Data axle import addresses - https://phabricator.wikimedia.org/T357345#9778983 (10AKanji-WMF) [20:03:04] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 13Patch-For-Review: Enable Recurring Annual Donations - https://phabricator.wikimedia.org/T358914#9778981 (10AKanji-WMF) [20:03:05] you'd suggest putting it in the Navigation.mgd.php right? [20:03:11] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Consolidate rest of normalize into WMFMessage class - https://phabricator.wikimedia.org/T357471#9778984 (10AKanji-WMF) [20:03:15] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), 13Patch-For-Review: Enable 90 day snooze: Comms Preferences Centre update - https://phabricator.wikimedia.org/T358878#9778982 (10AKanji-WMF) [20:03:19] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Paypal: Revisit old PayPal bugs, delete code if no longer needed - https://phabricator.wikimedia.org/T355448#9778986 (10AKanji-WMF) [20:03:23] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 07Unplanned-Sprint-Work: Sandra can't dedupe Name + address matching contacts (no email match) - https://phabricator.wikimedia.org/T353971#9778988 (10AKanji-WMF) [20:03:27] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Year end update for donor segments & statuses - https://phabricator.wikimedia.org/T344216#9778989 (10AKanji-WMF) [20:03:32] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Analytics request for 5 years of donor segment & status fields - https://phabricator.wikimedia.org/T344215#9778990 (10AKanji-WMF) [20:03:36] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 13Patch-For-Review: Recurring transaction information from dLocal console - https://phabricator.wikimedia.org/T356963#9778987 (10AKanji-WMF) [20:03:40] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10MW-1.43-notes (1.43.0-wmf.4; 2024-05-07): SEPA direct debit as mainstream payment method in EU campaigns - https://phabricator.wikimedia.org/T324520#9778993 (10AKanji-WMF) [20:03:44] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 13Patch-For-Review: Civi shouldn't show "cancellation not supported" message for processors where we handle schedule - https://phabricator.wikimedia.org/T335712#9778991 (10AKanji-WMF) [20:03:48] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert Queue2civicrm to civicrm extension - https://phabricator.wikimedia.org/T270672#9778995 (10AKanji-WMF) [20:03:52] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 13Patch-For-Review: SmashPig Adapter Layer - https://phabricator.wikimedia.org/T332236#9778992 (10AKanji-WMF) [20:03:56] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Spike - do practice standalong installs locally to get our heads around it - https://phabricator.wikimedia.org/T276395#9778994 (10AKanji-WMF) [20:04:00] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert metrics reporting to a drupal module - https://phabricator.wikimedia.org/T270668#9778996 (10AKanji-WMF) [20:04:04] 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021, 13Patch-For-Review: Convert exchange rates module to an extension - https://phabricator.wikimedia.org/T270666#9778997 (10AKanji-WMF) [20:04:10] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10FR-Email, and 3 others: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330#9778999 (10AKanji-WMF) [20:04:14] 14Fundraising Sprint Uptown cURL, 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Send recurring payment notifications to the donations queue - https://phabricator.wikimedia.org/T240581#9779000 (10AKanji-WMF) [20:05:15] eileen: ah, or do I need both the _civicrm_navigationMenu hook AND the mgd entry? [20:07:55] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Remove unused import code from main codebase - https://phabricator.wikimedia.org/T363524#9779013 (10Eileenmcnaughton) 05Open→03Resolved [20:08:08] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: ick(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Remove unused import code from main codebase - https://phabricator.wikimedia.org/T363524#9779015 (10Eileenmcnaughton) [20:11:18] ok, I'm trying with just the Navigation.mgd.php file and the xml/Menu/exchange_rates.xml [20:13:23] didn't quite do it, let's try adding the hook [20:17:45] huh, the hook seems to do about the same thing as the mgd file, no? [20:19:18] (03PS6) 10Ejegg: Migrate exchange rates variables to Civi settings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026683 (https://phabricator.wikimedia.org/T270666) [20:19:32] eileen with ^^ I can see the new menu item but when I click it just reloads the Civi main page [20:20:25] ah maybe also I should put it under the Administer/CiviContribute link? [20:26:34] (03PS7) 10Ejegg: Migrate exchange rates variables to Civi settings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026683 (https://phabricator.wikimedia.org/T270666) [20:27:49] dang, that still didn't do it [20:37:55] eileen: can you see anything obviously missing there? [20:37:59] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1028899 [20:38:24] I tried adding the exchange_rates_civicrm_navigationMenu hook but that didn't do anything [20:38:57] It looks like the CRM_Admin_Form_Generic should be able to display those settings [20:39:08] I'll pull it down & look - did you managed.reconcile AND menu/rebuild? [20:39:34] and I /think/ the xml/Menu/exchange_rates.xml should be wiring that url to that class OK [20:39:38] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1028899 (owner: 10Eileen) [20:39:45] ahh i just did a system.flush [20:39:47] 06Fundraising-Backlog, 10fundraising-tech-ops: Investigate pulling in page view data to the fr-tech version of superset - https://phabricator.wikimedia.org/T252049#9779081 (10Jgreen) Bumping this task back to "Up Next" because there is renewed interest from FR Analytics on whether this is feasible. [20:40:30] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1028899 (owner: 10Eileen) [20:43:31] hmm - odd not working but looks like it should - maybe info.xml needs an add [20:44:03] yep menu-xml@1.0.0 [20:44:40] aha ok [20:44:54] ok that works - to show it up [20:45:36] I don't have any settings locally - but maybe had no variables either.... [20:46:45] (03PS8) 10Ejegg: Migrate exchange rates variables to Civi settings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026683 (https://phabricator.wikimedia.org/T270666) [20:47:10] eileen: that would make sense, unless you had run an exchange rate update manually [20:47:26] hmm, I thought I would have a latest update though [20:47:47] ah let me see if that data is actually set on the ECB retriever [20:47:51] I can test it on staging I think [20:47:59] maybe it only comes from the OANDA one (paid for, needs key) [20:49:14] nah, it should be there [20:49:39] oh right, but I've changed the variable name since I ran the upgrade script to copy it from drupal [20:51:30] ok, will move on to that entity patch [20:52:07] OK - the settings upgrade worked on staging [20:53:55] if I were to run the settings drush command on stagin I guess it would charge us to update a whole bunch of days - I think I'm good to ok it & we can just watch it when it goes out [20:54:41] so what do you think for those timestamp fields, better to store them as datetime? [20:55:29] i noticed the timestamp field format is YYYYmmddHHiiss [20:55:42] is this the ones on the entity rather than the settings? [20:55:45] which is the 'weird old format' we used to have for contribution_tracking.ts [20:55:50] yeah, the entity [20:55:56] sorry, I moved on to the next patch [20:56:03] (03CR) 10Eileen: [C:03+2] Migrate exchange rates variables to Civi settings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026683 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [20:56:56] yeah that timestamp thing is weird [20:58:11] if you just switch the order of the fields the defaults are a bit more acceptable [20:58:32] ie current_date for local update & something meaningless for bank update [20:58:47] hmm, ok [20:59:06] actually - maybe may it explicity [20:59:11] make back_update required [20:59:35] & use CURRENT_TIMESTAMP [20:59:40] OK, I'll do that later - gotta go pick up my kid soon [20:59:41] for the one that should default to that [20:59:44] thanks! [21:01:38] (03PS5) 10Ejegg: Create ExchangeRate entity in CiviCRM [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027004 (https://phabricator.wikimedia.org/T270666) [21:01:55] ok, that's the order switched and the default added [21:05:24] ah right you said indicate the charset too [21:05:37] 10fundraising-tech-ops, 10FR-Tech-Analytics: Investigate direct python/pip installs for fundraising analytics tools. - https://phabricator.wikimedia.org/T364124#9779157 (10Jgreen) p:05Triage→03Medium a:03Jgreen [21:05:38] well, for the currency code I guess we just need ASCII :P [21:16:01] 06Fundraising-Backlog: Dark Mode - Codex on Payments Forms - https://phabricator.wikimedia.org/T364434 (10Damilare) 03NEW [21:17:22] 10fundraising-tech-ops, 10FR-Tech-Analytics: Investigate direct python/pip installs for fundraising analytics tools. - https://phabricator.wikimedia.org/T364124#9779193 (10Jgreen) (Puppetized) progress so far: I have an nginx https vhost running on tcp/444 using, and have configured pip to route everything to... [21:20:52] (03Merged) 10jenkins-bot: Migrate exchange rates variables to Civi settings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1026683 (https://phabricator.wikimedia.org/T270666) (owner: 10Ejegg) [22:05:26] ejegg: tech talk? [22:19:57] (03PS2) 10Eileen: Add clicked_total & unique to stats fetched [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1028609 (https://phabricator.wikimedia.org/T344383) [22:24:05] (03PS4) 10Eileen: WIP CiviCRM 5.73 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1028068 [22:24:39] (03PS4) 10Eileen: Rename WMF folder to match capitalization on similar folders [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023561 [22:24:41] (03CR) 10Ejegg: [C:03+2] Rename WMF folder to match capitalization on similar folders [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023561 (owner: 10Eileen) [22:25:38] (03CR) 10CI reject: [V:04-1] WIP CiviCRM 5.73 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1028068 (owner: 10Eileen) [22:40:47] (03PS1) 10Eileen: Ensure we convert exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1028904 [22:45:54] (03Merged) 10jenkins-bot: Rename WMF folder to match capitalization on similar folders [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1023561 (owner: 10Eileen) [22:47:21] (03PS1) 10Eileen: Limit retrieved values for prior contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1028905 [22:47:57] (03PS2) 10Eileen: Ensure we convert exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1028904 [22:48:22] (03CR) 10Ejegg: [C:03+2] Ensure we convert exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1028904 (owner: 10Eileen) [22:50:36] !log civicrm upgraded from 80ae4543 to aee07c4e [22:50:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:08:10] (03Merged) 10jenkins-bot: Ensure we convert exceptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1028904 (owner: 10Eileen) [23:15:11] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1028908 [23:15:25] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1028908 (owner: 10Eileen) [23:16:14] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1028908 (owner: 10Eileen) [23:21:14] !log civicrm upgraded from aee07c4e to 867c3a0d [23:21:15] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:49:23] 10fundraising-tech-ops: Fundraising access request for bjordan-ctr - https://phabricator.wikimedia.org/T364415#9779374 (10Dwisehaupt) [23:50:17] 10fundraising-tech-ops: Fundraising access request for bjordan-ctr - https://phabricator.wikimedia.org/T364415#9779375 (10Dwisehaupt) Approval received. ` Date: Tue, 7 May 2024 16:45:48 From: Lisa Seitz Gruwell To: Dallas Wisehaupt Cc: Melanie Demos Subject: Re: Access request for bjordan Approved `