[00:09:10] hey back but will be away & then back [00:10:09] ok- ejegg it looks like 5.74 passes with the patch over the top - which I'm gonna improve on in the next 1-2 days [00:11:48] (03PS4) 10Eileen: Re-key donor statuses [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035039 [00:12:50] (03CR) 10CI reject: [V:04-1] Re-key donor statuses [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035039 (owner: 10Eileen) [00:14:16] eileen: ignore if busy with upgrade things but any idea why this one would have failed, are we defining all the values too? Error: INVALID_MESSAGE Invalid value (c11_waystogive) submitted for custom field 20:Gift Data Direct Mail Appeal - Gift_Data.Appeal Source: array ( ) [00:15:54] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 10MW-1.43-notes (1.43.0-wmf.4; 2024-05-07): SEPA direct debit as mainstream payment method in EU campaigns - https://phabricator.wikimedia.org/T324520#9823945 (10Cstone) a:05AnnWF→03Cstone [00:16:26] cstone: I'll check - just been at the doc for Jack's adhd assessment but in car now [00:17:37] no rush at all [00:17:40] eileen: ^ [00:18:02] cstone: I'm gonna re-queue - it could be that the option was created but some caching in play so let's see [00:19:47] i guess im confused what that even is since its the utm_campaign on the message, couldn't it be any value? [00:21:11] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 10MW-1.43-notes (1.43.0-wmf.4; 2024-05-07): SEPA direct debit as mainstream payment method in EU campaigns - https://phabricator.wikimedia.org/T324520#9823957 (10Cstone) Test one time donation: cid=63848894 2... [00:21:46] cstone: it's supposed to create an option [00:22:04] do we want infinite options though? [00:22:47] or is something else constraining it [00:22:54] dwisehaupt: look at wmf_civicrm_ensure_option_value_exists($field['option_group_id'], $appealValue); in DonationMessage [00:23:25] is someone OK to + 2 the upgrade &then we can push out in about an hour? [00:24:28] sorry that look at was to you cstone [00:25:47] have we always been saving every unique utm_campaign then? [00:26:02] cstone yep, we have a lot of junk in there [00:26:07] ahhh hah [00:26:24] but also... we want to create new ones every time the banner team invents a new banner name [00:26:28] at one point there was an issue cos we had these x-rated options [00:26:29] or the email team sends a new email [00:26:31] yeah makes sense [00:26:42] ...without them having to add them to civi beforehand [00:26:56] that was the big friction point with Nora's 'source coding' project [00:27:16] yeah i was going to say if we have been doing this all along isnt this what they wanted there? [00:27:38] eileen: sorry, i merged to deployment, but I didn't push anything out [00:27:49] I can deploy now to regenerate those triggers [00:27:51] I think if you look at all the created options in our DB you will find it's not quite what they want :-) [00:28:12] ejegg: no - it's the actual 5.74 upgrade I want to push out in an hour or so (in co-ordination with dwisehaupt [00:29:20] !log fundraising civicrm upgraded from 84c36324 to 172feea2 [00:29:22] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:29:30] oh so no trigger regeneration before that? [00:29:53] if dwisehaupt is restarting queues won't we be saving folks with the wrong status values then? [00:31:59] just popped over and saw this. i can stop queues again if needed. [00:37:10] (03PS5) 10Eileen: Re-key donor statuses [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035039 [00:37:59] ejegg: yeah - I just figured we were close enough to pushing out that we might as well push through while they were down & do the triggers once [00:38:26] cos we need to regen once the upgrade is out too [00:38:35] dwisehaupt: yes please let's keep the queues off [00:38:39] ok. [00:38:41] doing so. [00:39:03] ct tracking just broke in an usual way i assume due to upgrade? [00:40:06] yeah I saw that - weird [00:40:07] puppet runs in progress [00:40:26] running fine after it though [00:40:34] hmm - ok [00:40:47] let's push through & get the civi upgrade out & then reload & turn all back on [00:41:06] it's this - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1027983/12 but needs the follow on patch [00:41:23] ok. the recurring_smashpig_charge is wrapping up and then we'll be all clear [00:41:56] sorry about any issues from me turning them back on. [00:42:11] ah that will run for a little bit [00:42:34] whoa, DB Error: already exists [00:42:36] it's been running for 21 mins. [00:42:39] that is strange [00:42:51] so its weird the data all got switched to NULL [00:42:54] but the banner id is there [00:42:54] we could kill it if needed. [00:43:03] dwisehaupt: it should finish before 51 [00:43:08] lemme see how close it is [00:43:25] nah I think it's OK - but if cstone or ejegg could + 2 those civi patches I can ready them to go out too [00:43:33] (ie 5.74) [00:43:47] looking [00:43:52] well, downloading [00:44:15] eileen: ejegg should we kill current recurring charge job run to get queues back off? [00:44:19] it's deployed on staging [00:44:26] cstone: let's not kill it [00:44:29] the queues can finish can't they? [00:44:36] i didnt know if it was in a bad state ok [00:44:36] ie staging has 5.74 [00:44:45] i'm afraid killing to job would leave something charge but unrecorded [00:44:48] *charged [00:45:12] it should finish around :48 [00:45:24] cool [00:48:21] ok. it finished. [00:49:03] sorry, I need to go help with Tavi [00:50:53] cstone: do you want to approve the upgrade patch/s so we can push out? it's running on staging now [00:51:11] & then we can 'mop up' fall out from any of today's efforst [00:51:13] yeah sorry was trying to catch up there [00:51:18] :-) [00:51:37] cool - I'm just about to get Jack's prescription & head home & then I wil be fully there [00:54:14] eileen: is it supposed to be failing tests and we need whatever usual magic/ [00:59:38] looking agsin, sorry [01:00:42] some change in the core import logic in 5.74 maybe? [01:02:04] update went cleanly locally [01:02:16] dashboard is super wide - lotsa horizontal scroll [01:02:36] but contact summary looks fine [01:02:42] on staging my billion donations load okay and everything ive clicked around on [01:04:45] Failed asserting that true is false. classic [01:04:56] locally I get the same test failures as in CI [01:05:02] so it's at least something we can fix [01:07:06] eileen: so shall we just override those test failures for now? [01:07:28] I guess folks won't be running imports for another day or two probably if there really is something weird with imports now [01:09:44] maybe it fixed 2 of whatever those 3 error rows were [01:15:25] looks like the error that's supposed to happen has to do with restrictions=>'Invalid Name' [01:15:30] (at least in the streak test) [01:15:45] but that's not throwing any errors now [01:15:55] that error is fixed in the next patch [01:16:08] sorry - I didn't make it clear [01:16:15] I will re-fix again soonish [01:16:18] ahh oops [01:17:17] yeah - I think I can do a better fix with a bit more time but that should be OK for now [01:19:11] ahh i see, so in .74 getCustomFieldMetadataByFieldName doesn't load the full option list when there's an optionGroupId [01:19:37] ok, seems fine to me [01:20:11] (03PS13) 10Ejegg: 5.74 rc, stock [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027983 (https://phabricator.wikimedia.org/T364339) (owner: 10Eileen) [01:20:26] (just had to delete that unmatched doublequote!) [01:20:37] (03PS14) 10Ejegg: 5.74 rc, stock [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027983 (https://phabricator.wikimedia.org/T364339) (owner: 10Eileen) [01:20:43] (03CR) 10Ejegg: [C:03+2] 5.74 rc, stock [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027983 (https://phabricator.wikimedia.org/T364339) (owner: 10Eileen) [01:20:52] (03CR) 10Ejegg: [V:03+2 C:03+2] 5.74 rc, stock [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1027983 (https://phabricator.wikimedia.org/T364339) (owner: 10Eileen) [01:21:05] (03PS2) 10Eileen: Temp load options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035053 [01:21:07] (03CR) 10Ejegg: [C:03+2] Temp load options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035053 (owner: 10Eileen) [01:21:30] ejegg: yeah - it's not an actual supported api funciton Im using & it changed - but should be pretty stable going forwards - Coleman did a bit refactor so I'll look at what he did & the best one to use (to be honest I knew that there would be an issue if we switched to that code before the update - but that tests would catch it) [01:22:03] (03CR) 10Eileen: [V:03+2] Temp load options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035053 (owner: 10Eileen) [01:24:00] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035065 [01:24:37] dwisehaupt: ok - I'm ready to push out the civi update - are queues off? if so I guess we should drop triggers for a moment but tbh I don't think there are any db updates that would require that [01:24:48] queues are off [01:24:50] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035065 (owner: 10Eileen) [01:24:56] let me grab a backup of the current triggers [01:25:10] ok. got that. [01:25:24] cool cool - are jobs off? [01:25:35] oh you said they are [01:25:40] (03CR) 10Eileen: [V:03+2 C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035065 (owner: 10Eileen) [01:26:37] !log civicrm upgraded from 172feea2 to 5cb7c467 [01:26:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:27:08] (03CR) 10Ejegg: [C:04-1] "Oops, we shouldn't try to add the score if it's nonsense." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035027 (https://phabricator.wikimedia.org/T365469) (owner: 10Damilare Adedoyin) [01:29:18] ejegg: so this should be right now - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/1035039 [01:29:44] i've stopped replication on frdb1004 as a safetynet. like normal. [01:30:47] dwisehaupt: ok - I ran it so just regnerating triggers [01:31:22] ejegg: cstone new system check notice - tbh I thought we had that configured but if not can speed up rebuilds with it - also on crm.community [01:31:39] https://docs.civicrm.org/sysadmin/en/latest/setup/optimizations/#exclude-dirs-that-do-not-need-to-be-scanned [01:32:25] oh nice [01:32:36] sorry by rebuilds I mean Managed.reconcile actions [01:32:39] vendor dirs will likely be a big win [01:32:44] yep! [01:33:57] this dog. i'm laying on the sofa and he has decided to sit on my chest so i can't see the screen. [01:34:21] ok. he has laid down now. we are good to go. :) [01:35:28] your dog is def part of the team [01:35:54] maybe he'll make a visit at the onsite. but definitely not the whole time. [01:37:11] (03PS1) 10Eileen: Trigger update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035066 [01:37:15] ok - just pushed up the trigger update [01:38:13] PROBLEM - check_mysql on frdb1004 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [01:38:47] I'm having trouble loading gerrit page to see the trigger update [01:39:20] ACKNOWLEDGEMENT - check_mysql on frdb1004 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) Dwisehaupt known - trigger updates https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [01:39:46] yeah, me too [01:40:10] arg [01:40:14] (03PS1) 10Ejegg: Exclude dirs from scanning under CiviCRM [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1035067 [01:40:24] oh. it just loaded for me. [01:42:50] cool - the changes look ok to me [01:43:49] huh, tried a system.flush with that exclude_dirs setting and got an error (via the web api explorer) [01:43:53] will try via commandline [01:44:03] looks like a diff to me. one i can compare when doing the updates. :) need me to +2 it? [01:44:08] hmm - fyi the whitespace is not right [01:44:16] dwisehaupt: yes please + 2 it [01:44:26] I eyeballed it & it looks OK [01:44:35] which whitespace? the one in front of the SUM lines? [01:45:12] (03CR) 10Ejegg: [C:03+2] Trigger update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035066 (owner: 10Eileen) [01:45:34] he beat me. [01:45:45] oh no that was on ejegg's patch the whitespace is off [01:45:54] (03CR) 10Eileen: [V:03+2] Trigger update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035066 (owner: 10Eileen) [01:46:20] opps I thought I was putting the v+2 back - well that file isn't tested [01:47:20] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035069 [01:47:31] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035069 (owner: 10Eileen) [01:50:22] (03PS2) 10Ejegg: Exclude dirs from scanning under CiviCRM [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1035067 [01:50:37] !log civicrm upgraded from 5cb7c467 to 50211434 [01:50:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:50:44] dwisehaupt: ok - triggers deployed [01:51:33] opps error on prod [01:51:33] CRM_Core_Exception: Unrecognized Angular module afsearchTabParticipant. Please ensure that all Angular modules are declared. in Civi\Angular\Manager->resolveDependencies() (line 160 of /srv/org.wikimedia.civicrm/drupal/sites/all/modules/civicrm/Civi/Angular/Manager.php). [01:52:12] ok. do you want me to hold or do the trigger update? [01:52:54] https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=1815780 [01:52:58] dwisehaupt:nah - go ahead [01:53:05] ok. proceeding. [01:55:27] ok diff looks good [01:56:12] any testing you want to do before i turn back on replication? [01:56:50] no - replicate is good to go - this angular thing is annoying [01:57:09] ok turning on replication but leaving the queues stopped. [01:58:15] RECOVERY - check_mysql on frdb1004 is OK: Uptime: 545364 Threads: 4 Questions: 24292097 Slow queries: 241 Opens: 2856 Open tables: 918 Queries per second avg: 44.542 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [02:00:04] ok - that error has gone - although more by good luck than good management [02:02:28] I think jobs can go back on - I ran a few [02:04:56] ok. [02:06:49] ok. process-contrl is back on. [02:08:40] ok - it looks like the silverpop export will have been skipped [02:09:39] yeah [02:10:27] that's common with late day maint. but we could kick it off again [02:10:38] let's do that [02:11:16] i can do the run-job [02:11:18] ejegg: yeah - I'm just looking at the transitional recurring statuses tho [02:11:24] ahhh right [02:11:32] needs a tools deploy first then [02:12:23] yeah I think so - it prob won't mess up any that still have the wrong numbers cos they won't be modified .... [02:14:39] (03PS1) 10Eileen: Remove disabled extensions targetsmart & shoreditch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035071 [02:20:19] (03CR) 10Ejegg: [C:03+2] Remove disabled extensions targetsmart & shoreditch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035071 (owner: 10Eileen) [02:21:54] (03PS3) 10Ejegg: Exclude dirs from scanning under CiviCRM [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1035067 [02:23:09] shoot, DB Error:Unknown error [02:23:21] argh, and the damaged message viewer is broken [02:24:12] unknown url scheme?? [02:24:25] it's working locally... [02:24:44] oh, is it the connection to the smashpig db that's broken somehow? [02:25:13] hmm - I was trying to change the option values in the UI as they failed to change via the udpate [02:25:24] not sure if it's related [02:25:59] oh - def sql snarled up by me [02:26:41] no just me actually [02:26:44] not just me [02:26:49] oh? that broke the damaged message viewer? [02:26:56] not sure [02:27:01] It seems to be working on staging too [02:27:13] (though there are no damaged messages to view there) [02:27:20] killing queries by 1534 [02:29:38] ok - when I change it in the UI it looks like it updates the db which is slow.... but it also updates it [02:32:58] ok - I'll update the last of these & then check damaged ... [02:33:28] recur job broke on just a database lock encountered [02:36:55] ok - that was prob me [02:37:41] the statuses are updated now so if we can get https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/1035039 merged I'll deploy & we can run silverpop [02:37:50] I know why it didn't run too [02:38:39] eileen: is non donors different than non donor [02:38:41] (03CR) 10Ejegg: [C:03+2] Re-key donor statuses [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035039 (owner: 10Eileen) [02:38:54] Non Donors vs Non donor [02:39:09] Yeah - I think we are already inconsistent between the 2 fields? [02:39:17] so I just mirrored the existing? [02:39:32] oh i see ones a segment ones a status confusion [02:39:38] (03Merged) 10jenkins-bot: Re-key donor statuses [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035039 (owner: 10Eileen) [02:40:31] yeah - we could maybe fix but then it would be inconsistent at acoustic I guess [02:41:02] ejegg: I just pushed to update the segmentation aging job - but should we disable banner tracking now (that push prob needs an irc+2) [02:42:14] re the damaged issue - I think there is something a bit funky in the afforms & so maybe it failed when rebuilding before hitting that url? [02:42:58] - just clearing caches [02:45:31] ok damaged is loading - I did a 'revert' on the afform & it worked - not sure why it was even an option as we should be managing in code [02:45:54] i see the damaged! [02:47:43] oh weird [02:48:46] dang, we're getting a new failure on the recurring charge job too [02:48:48] Undefined index: refusalReason CardPaymentProvider.php:114 [02:48:50] I requeued some of those failed recurring fails [02:49:01] though that seems to be at the SmashPig layer [02:49:03] but there are way more than I expected of them [02:49:17] i think thats been there ejegg [02:49:41] oh really? [02:50:01] let's fix that [02:50:06] i feel like i saw it and must have gotten distractef [02:50:08] ah I see, the actual failure was a db lock [02:50:20] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1035072 [02:50:22] yeah eileen thinks that was her [02:50:46] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1035072 (owner: 10Eileen) [02:50:58] ok, requeue should fix it then [02:51:07] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1035072 (owner: 10Eileen) [02:51:19] sorry, i should get to bed [02:51:27] hmm - we hadn't done a deploy of tools for a while [02:52:52] Since Jan, huh? [02:53:03] yeah - I bet I thought that stuff had gone out [02:53:11] - I just pushed out the pc change I made [02:53:36] !log tools upgraded from ad48f63e to bce5f52b [02:53:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:53:59] & Banner queue might be ready to go [02:54:19] !log config revision changed from b9fbe283 to f8af8188 [02:54:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:54:52] sounds good eileen [02:55:12] ejegg: do we need to do more checks on BannerQueue - or is it toast [02:55:20] we can keep sending the messages for a day or so just in case we find the c_t queue isn't picking them up [02:55:29] but disable and remove the consumer [02:56:07] i saw them in the ct table just now [02:56:10] ok - here is the change I'm pushing... [02:56:16] git rm banner_history_queue_consume.yaml [02:56:55] !log config revision changed from f8af8188 to d8905b73 [02:56:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:57:39] (03Merged) 10jenkins-bot: Remove disabled extensions targetsmart & shoreditch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035071 (owner: 10Eileen) [03:01:25] im gona head out too, ill check phone eileen incase you need anything else [03:01:34] (03PS3) 10Ejegg: Use banner_history_log_id from c_t queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032893 (https://phabricator.wikimedia.org/T270672) [03:02:01] thanks cstone [03:10:58] (03CR) 10Eileen: [V:03+2 C:03+2] Use banner_history_log_id from c_t queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032893 (https://phabricator.wikimedia.org/T270672) (owner: 10Ejegg) [03:11:44] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035073 [03:11:57] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035073 (owner: 10Eileen) [03:15:51] (03CR) 10Eileen: [V:03+2 C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035073 (owner: 10Eileen) [03:16:36] !log civicrm upgraded from 50211434 to 252eed3c [03:16:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:11:24] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 13Patch-For-Review: Non-donor status missing records in our segmentation framework - https://phabricator.wikimedia.org/T363959#9824174 (10Eileenmcnaughton) @KHaggard the places where one of donor_status & donor_segment being set & not the other will be... [04:22:05] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 13Patch-For-Review: Non-donor status missing records in our segmentation framework - https://phabricator.wikimedia.org/T363959#9824175 (10Eileenmcnaughton) @KHaggard @JMando @ERoden-WMF we have updated the numbering for the statuses (the recurring ones... [04:23:40] (03PS2) 10Ejegg: Remove BannerHistoryQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032895 (https://phabricator.wikimedia.org/T270672) [04:24:32] (03CR) 10Eileen: "This is +2 from my pov - but leaving at +1 until we are ready to deploy - probably tomorrow" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032895 (https://phabricator.wikimedia.org/T270672) (owner: 10Ejegg) [04:26:09] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert banner history from a drupal table to a column in contribution_tracking - https://phabricator.wikimedia.org/T365090#9824179 (10Eileenmcnaughton) Putting this in pending deployment as... [06:43:44] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_42) - 10https://gerrit.wikimedia.org/r/1035117 (owner: 10L10n-bot) [11:56:45] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 13Patch-For-Review: SmashPig Adapter/Mapper Layer - https://phabricator.wikimedia.org/T332236#9825206 (10jgleeson) [12:25:51] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 13Patch-For-Review: SmashPig Adapter/Mapper Layer - https://phabricator.wikimedia.org/T332236#9825315 (10jgleeson) 05Open→03Resolved [12:26:58] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 13Patch-For-Review: SmashPig Adapter/Mapper Layer - https://phabricator.wikimedia.org/T332236#9825312 (10jgleeson) I think we can close this as it became a back-and-forth conversation instead of a piece of work. We produced an experimented patch re... [12:48:51] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog: Gravy frontend createPayment - https://phabricator.wikimedia.org/T364508#9825433 (10jgleeson) a:03jgleeson [13:01:56] (03PS5) 10Damilare Adedoyin: Throw failmail on custom filters error [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035027 (https://phabricator.wikimedia.org/T365469) [13:16:15] hmm 1 deadlock [13:32:22] argh [13:39:10] just the 1 so far, no delayed process on civi, so I guess it was only a trip off [13:39:15] resending back to the queue [13:40:17] ohh not a deadlock, but DB Error: ZAR 400000000000000000.00 [13:45:25] looks like spam, but the CT table seems to be erroring on the form amount [13:46:21] yep yep, so let's see how we should handle that [13:46:39] I guess it gets sent to the queue before we validate that it's way too big [13:46:47] I think before we would just truncate it [13:46:58] maybe we should do that again on the consumer side [13:48:50] (03PS6) 10Damilare Adedoyin: Throw failmail on custom filters error [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035027 (https://phabricator.wikimedia.org/T365469) [13:48:53] (03CR) 10Ejegg: [C:03+2] Throw failmail on custom filters error [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035027 (https://phabricator.wikimedia.org/T365469) (owner: 10Damilare Adedoyin) [13:49:52] (03PS4) 10Damilare Adedoyin: Update recur status to failed when recurring is failing and use appropriate date for retry date if available. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034974 [13:49:54] (03CR) 10Ejegg: [C:03+2] Update recur status to failed when recurring is failing and use appropriate date for retry date if available. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034974 (owner: 10Damilare Adedoyin) [13:50:06] thanks for the CR ejegg [13:51:37] sure thing! [13:51:57] After we get that civi patch out we can requeue all those paypal recurring messages, right? [13:52:21] (03Merged) 10jenkins-bot: Throw failmail on custom filters error [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035027 (https://phabricator.wikimedia.org/T365469) (owner: 10Damilare Adedoyin) [13:52:30] yep [14:00:31] (03PS1) 10Ejegg: Fix PHP notice [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1035432 [14:10:44] (03Merged) 10jenkins-bot: Update recur status to failed when recurring is failing and use appropriate date for retry date if available. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034974 (owner: 10Damilare Adedoyin) [14:12:22] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035435 [14:13:51] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog: Enable Recurring for SEPA transactions in all EU countries - https://phabricator.wikimedia.org/T365106#9825827 (10Damilare) a:03Damilare [14:15:06] (03CR) 10Damilare Adedoyin: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035435 (owner: 10Damilare Adedoyin) [14:16:04] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035435 (owner: 10Damilare Adedoyin) [14:39:35] (03PS2) 10Ejegg: Remove all curl overrides in tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1034582 [14:39:36] (03PS1) 10Ejegg: Remove curl_transaction and associated methods [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035444 [14:41:08] (03PS2) 10Ejegg: Remove curl_transaction and associated methods [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035444 [14:41:58] (03CR) 10CI reject: [V:04-1] Remove curl_transaction and associated methods [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035444 (owner: 10Ejegg) [14:42:58] (03PS3) 10Ejegg: Remove curl_transaction and associated methods [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035444 [14:51:46] ah, looks like it's going to rain here and I don't have anything to cover the child seat on the bike. I might head back to work at home today [15:17:31] successfully requeued all the paypal failures [15:17:59] now we have two additional fields to filter by in the damaged table: "Damaged date" and "Error" [15:18:25] I'd add them to the afform templates for reusability [15:26:25] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2324Q4 maintenance window - https://phabricator.wikimedia.org/T359885#9826229 (10Dwisehaupt) [15:26:48] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2324Q4 maintenance window - https://phabricator.wikimedia.org/T359885#9826232 (10Dwisehaupt) [16:10:26] (03CR) 10Cstone: [C:03+2] Fix PHP notice [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1035432 (owner: 10Ejegg) [16:12:30] (03Merged) 10jenkins-bot: Fix PHP notice [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1035432 (owner: 10Ejegg) [16:23:21] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Recurring Donor (segment_id 400) records have conflicting status Deep Lapsed (status_id 60) - https://phabricator.wikimedia.org/T365639#9826563 (10XenoRyet) p:05Triage→03High [16:23:33] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Fail Mail (civi1002) run-job: Get recipient data from Silverpop failed with code 1 - https://phabricator.wikimedia.org/T365544#9826569 (10XenoRyet) p:05Triage→03High [16:24:14] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Civi / Adyen mismatch re: recurring retries - https://phabricator.wikimedia.org/T365519#9826570 (10XenoRyet) [16:31:27] (03CR) 10Pcoombe: "Nice, that works for me now. The skin doesn't load MediaWiki:Common.js or Common.css though, is it possible to add them? We're relying on " [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1020408 (https://phabricator.wikimedia.org/T257862) (owner: 10Jdlrobson) [17:39:52] (03PS2) 10Thiemo Kreuz (WMDE): Replace more Xml::… methods with Html::… equivalents [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1025290 (https://phabricator.wikimedia.org/T341775) [17:39:59] (03CR) 10Ejegg: [C:03+2] Replace more Xml::… methods with Html::… equivalents [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1025290 (https://phabricator.wikimedia.org/T341775) (owner: 10Thiemo Kreuz (WMDE)) [17:43:27] (03PS2) 10Eileen: Remove extraneous initialize [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034628 (https://phabricator.wikimedia.org/T365415) [17:43:30] (03CR) 10Ejegg: [C:03+2] Remove extraneous initialize [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034628 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [17:46:32] (03Merged) 10jenkins-bot: Replace more Xml::… methods with Html::… equivalents [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1025290 (https://phabricator.wikimedia.org/T341775) (owner: 10Thiemo Kreuz (WMDE)) [17:51:13] (03PS2) 10Eileen: Move minor helper to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034629 (https://phabricator.wikimedia.org/T365415) [17:51:28] (03CR) 10Ejegg: [C:03+2] Move minor helper to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034629 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [17:58:09] (03PS1) 10Ejegg: Update TheIsland theme [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035535 [18:01:39] 06Fundraising-Backlog, 10fundraising-tech-ops, 10Wikipedia-iOS-App-Backlog (iOS Release FY2023-24): [S] Strange API traffic pattern from WikipediaApp on payments.wikipedia.org - https://phabricator.wikimedia.org/T354575#9827066 (10ABorbaWMF) Looks good from my end on 7.5.2.83 [18:06:29] (03Merged) 10jenkins-bot: Remove extraneous initialize [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034628 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [18:13:18] (03Merged) 10jenkins-bot: Move minor helper to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034629 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [18:18:21] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Spike - do practice standalong installs locally to get our heads around it - https://phabricator.wikimedia.org/T276395#9827136 (10jgleeson) @Eileenmcnaughton excited much! [18:19:39] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Import error reported by Melanie - country - https://phabricator.wikimedia.org/T365082#9827139 (10MDemosWMF) Hi @Eileenmcnaughton just ran the Engage Org import and no issues this time. I will let you know if the problem resurfaces! [18:20:36] (03PS1) 10Ejegg: Delete generated csvs after test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035544 [18:28:21] Hi Wikimedia/Wikipedia Fundraising team, [18:29:28] I had always wanted to have some position in Wikipedia team and would be very interested in share some Ideas to rise the fundraising/income of the campings. [18:32:10] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 13Patch-For-Review: Non-donor status missing records in our segmentation framework - https://phabricator.wikimedia.org/T363959#9827158 (10KHaggard) Thanks all. Quick question for you @Eileenmcnaughton - Mariana brought to my attention that Major Donor... [18:38:16] hi clonickdotcom! [18:38:35] There's a list of open jobs at the foundation here: https://wikimediafoundation.org/about/jobs/ [18:39:09] The fundraising team is under the 'Advancement' department, so all the fundraising-related positions will be at the top of that list [18:40:07] (though they're mixed in with other positions in the Advancement department which are not related to fundraising, such as the Research Library Fellow) [18:45:04] 06Fundraising-Backlog: run refund script for dLocal May 23rd - https://phabricator.wikimedia.org/T365751 (10MBeat33) 03NEW [18:50:02] (03PS2) 10Eileen: Remove calls to legacy timer function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034630 (https://phabricator.wikimedia.org/T365415) [18:50:04] 06Fundraising-Backlog, 10FR-donorservices: Civi "thank you letter summary" feature request - https://phabricator.wikimedia.org/T299096#9827225 (10AKanji-WMF) Resurfacing this as a current DR ask - Asana [[ https://app.asana.com/0/1203951928644291/1204913271420758/f | thread ]] copied below: {F54247668} [18:50:06] (03CR) 10Ejegg: [C:03+2] Remove calls to legacy timer function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034630 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [18:58:15] (03PS3) 10Eileen: Remove no-longer-used property [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034579 (https://phabricator.wikimedia.org/T363959) [18:58:33] (03CR) 10Ejegg: [C:03+2] Remove no-longer-used property [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034579 (https://phabricator.wikimedia.org/T363959) (owner: 10Eileen) [18:59:53] 06Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations: Enable drop-down menu for DR to indicate recurring cancel reason - https://phabricator.wikimedia.org/T341247#9827250 (10AKanji-WMF) [18:59:54] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add dropdown with standard reasons to refunded donation area. - https://phabricator.wikimedia.org/T125224#9827251 (10AKanji-WMF) [19:00:08] (03PS4) 10Eileen: Remove old WMFDataManagement.updateWMFDonor api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034580 (https://phabricator.wikimedia.org/T363959) [19:00:09] (03CR) 10Ejegg: [C:03+2] Remove old WMFDataManagement.updateWMFDonor api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034580 (https://phabricator.wikimedia.org/T363959) (owner: 10Eileen) [19:12:49] (03Merged) 10jenkins-bot: Remove calls to legacy timer function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034630 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [19:18:30] (03CR) 10Ejegg: "haven't fully reviewed this, but one question on seemingly-unused test function" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034643 (https://phabricator.wikimedia.org/T363959) (owner: 10Eileen) [19:20:50] (03Merged) 10jenkins-bot: Remove no-longer-used property [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034579 (https://phabricator.wikimedia.org/T363959) (owner: 10Eileen) [19:22:21] (03Merged) 10jenkins-bot: Remove old WMFDataManagement.updateWMFDonor api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034580 (https://phabricator.wikimedia.org/T363959) (owner: 10Eileen) [19:30:49] 06Fundraising-Backlog: run refund script for dLocal May 23rd - https://phabricator.wikimedia.org/T365751#9827379 (10MBeat33) [19:57:42] (03PS3) 10Eileen: Save the 'new' (hello 2018) subscriber_id to trxn_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034639 (https://phabricator.wikimedia.org/T355448) [19:59:07] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog: Non-donor status missing records in our segmentation framework - https://phabricator.wikimedia.org/T363959#9827459 (10Eileenmcnaughton) @KHaggard - yes we can change the value to 1000 or 1001 instead of 100 - ideally right away as we are in maintenance... [20:01:50] (03CR) 10Ejegg: [C:03+2] "This looks like a good refactor!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034639 (https://phabricator.wikimedia.org/T355448) (owner: 10Eileen) [20:02:32] (03CR) 10Eileen: [C:03+2] "Seems fine - those files are sometimes useful when debugging is required but are also annoying" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035544 (owner: 10Ejegg) [20:03:12] (03CR) 10Eileen: "It feels like just yesterday we were updating this...." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035535 (owner: 10Ejegg) [20:03:58] I just applied for Affiliate Fundraising Training Consultant (Part-Time). thanks a lot. [20:04:08] :) best of luck! [20:05:02] lol yep eileen, this version just became available after updating core past 5.72 [20:05:15] ejegg: ah that makes sense [20:06:21] hmm feel like I could close most of these older ingenico tasks....https://phabricator.wikimedia.org/tag/fr-ingenico-integration_2017-18/ [20:06:33] oh yep [20:06:51] ejegg: I might put up a patch to move the main contribution_insert function - we have less in review so a good time to move it - since it's also called from the outgoing checksFile I will split it into 2 copies - I know that goes against the DRI theory but I find it works quite well when trying to simplify code if one usage is going away - cos there is usually some cross contamination of usages - at least in old [20:06:52] fugly code [20:07:05] anilk: https://phabricator.wikimedia.org/T163947 is still maybe a good idea [20:07:15] but the rest on that board are obsolete [20:09:22] thanks for flagging ejegg ! [20:09:51] 14Fundraising Sprint Judgement Suspenders, 14Fundraising Sprint Loose Lego Carpeting, 06Fundraising-Backlog, 10FR-Smashpig, and 2 others: Epic: Support and normalize multiple payment identifiers - https://phabricator.wikimedia.org/T163947#9827487 (10AKanji-WMF) [20:10:30] 06Fundraising-Backlog, 10Fr-Ingenico-integration_2017-18, 10MediaWiki-extensions-DonationInterface: Reconcile field length limits between DonationInterface and Ingenico Connect - https://phabricator.wikimedia.org/T211832#9827488 (10AKanji-WMF) 05Open→03Declined [20:10:31] 06Fundraising-Backlog, 10Fr-Ingenico-integration_2017-18: Malformed gateway definition in Ingenico broke at least one payment attempt - https://phabricator.wikimedia.org/T208555#9827489 (10AKanji-WMF) 05Open→03Declined [20:10:35] 06Fundraising-Backlog, 10Fr-Ingenico-integration_2017-18: Localize 'Donate' button in Ingenico Connect iframe - https://phabricator.wikimedia.org/T199173#9827492 (10AKanji-WMF) 05Open→03Declined [20:10:36] 06Fundraising-Backlog, 10Fr-Ingenico-integration_2017-18: New Ingenico form has incorrect CVV instructions for Amex - https://phabricator.wikimedia.org/T194514#9827493 (10AKanji-WMF) 05Open→03Declined [20:10:37] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-Ingenico-integration_2017-18, 10Recurring-Donations: Ingenico recurring: can we make them associate a series of donations in the console? - https://phabricator.wikimedia.org/T204870#9827491 (10AKanji-WMF) 05Open→03Declined [20:10:40] 06Fundraising-Backlog, 10Fr-Ingenico-integration_2017-18: investigate auto updater features for new ingenico - https://phabricator.wikimedia.org/T186554#9827494 (10AKanji-WMF) 05Open→03Declined [20:11:15] 06Fundraising-Backlog, 10Fr-Ingenico-integration_2017-18: Create mustache forms for online bank transfer - https://phabricator.wikimedia.org/T171312#9827499 (10AKanji-WMF) 05Open→03Invalid [20:11:16] 06Fundraising-Backlog, 10Fr-Ingenico-integration_2017-18: Implement Ingenico Connect API call to create bank transfer payment - https://phabricator.wikimedia.org/T171311#9827500 (10AKanji-WMF) 05Open→03Invalid [20:11:17] 06Fundraising-Backlog, 10Fr-Ingenico-integration_2017-18: Implement Ingenico Connect API call to create direct debit payment - https://phabricator.wikimedia.org/T171309#9827501 (10AKanji-WMF) 05Open→03Invalid [20:22:02] (03CR) 10Eileen: [C:03+2] Update TheIsland theme [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035535 (owner: 10Ejegg) [20:25:56] (03Merged) 10jenkins-bot: Save the 'new' (hello 2018) subscriber_id to trxn_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1034639 (https://phabricator.wikimedia.org/T355448) (owner: 10Eileen) [20:26:34] (03Merged) 10jenkins-bot: Delete generated csvs after test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035544 (owner: 10Ejegg) [20:30:44] (03PS1) 10Eileen: Move wrapper function for contribution_recur_insert to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035563 (https://phabricator.wikimedia.org/T365415) [20:30:46] (03PS1) 10Eileen: Take a copy of contribution_insert back to the checks class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035564 (https://phabricator.wikimedia.org/T365415) [20:30:48] (03PS1) 10Eileen: Copy back timing wrapper to DonationQueue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035565 (https://phabricator.wikimedia.org/T365415) [20:30:50] (03PS1) 10Eileen: Move main donation insert function to DonationQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035566 (https://phabricator.wikimedia.org/T365415) [20:30:53] (03PS1) 10Eileen: Remove soft credit handling from newly split code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035567 (https://phabricator.wikimedia.org/T365415) [20:32:32] ejegg: so 2 things [20:32:32] - 1 those move the code around without any other change (except for the one I put last so it could be thought about separately) & will be a bit conflicty but will also help us to get those moved & [20:32:32] - 2 - I'm gonna +2 your banner queue removal now - any last things we need to check? [20:32:43] (03CR) 10CI reject: [V:04-1] Copy back timing wrapper to DonationQueue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035565 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [20:33:21] 06Fundraising-Backlog: run refund script for dLocal May 23rd - https://phabricator.wikimedia.org/T365751#9827582 (10MBeat33) script run by @jgleeson - thank you [20:34:07] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Import error reported by Melanie - country - https://phabricator.wikimedia.org/T365082#9827583 (10Eileenmcnaughton) 05Open→03Resolved a:03Eileenmcnaughton thanks @MDemosWMF - I'll close this then & we can do a new phab if we need to [20:42:46] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog: Non-donor status missing records in our segmentation framework - https://phabricator.wikimedia.org/T363959#9827592 (10KHaggard) Yeah, actually if they are the same, then 1000 for both status and segment makes sense to me. Thank you. and thanks yes their... [20:45:14] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog: Non-donor status missing records in our segmentation framework - https://phabricator.wikimedia.org/T363959#9827594 (10Eileenmcnaughton) @KHaggard so if someone donates via RML & has a non-donor status we do pretty much suck them into Civi & update Acoust... [20:45:48] (03Merged) 10jenkins-bot: Update TheIsland theme [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035535 (owner: 10Ejegg) [20:52:23] (03PS1) 10Eileen: Update the non-donor value to 1000 for segments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035571 (https://phabricator.wikimedia.org/T363959) [20:54:40] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 13Patch-For-Review: Non-donor status missing records in our segmentation framework - https://phabricator.wikimedia.org/T363959#9827632 (10Eileenmcnaughton) @KHaggard we are also pushing up slightly different words - Non donor vs Non Donors - should we... [20:54:43] (03CR) 10CI reject: [V:04-1] Move main donation insert function to DonationQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035566 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [20:54:50] (03CR) 10CI reject: [V:04-1] Remove soft credit handling from newly split code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035567 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [20:57:29] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035572 [20:58:02] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035572 (owner: 10Eileen) [20:59:19] !log civicrm upgraded from de92d6bc to 55cb3cf7 [20:59:22] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:00:19] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035565 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [21:16:35] eileen I think we should be fine to just do the queue removal [21:16:50] and then check for some history logs [21:17:02] (assuming there are any campaigns live with the feature enabled) [21:17:20] (03CR) 10Eileen: [C:03+2] Remove BannerHistoryQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1032895 (https://phabricator.wikimedia.org/T270672) (owner: 10Ejegg) [21:17:34] ejegg: ok - it's merged now [21:19:02] (03CR) 10Dwisehaupt: [C:03+2] Update the non-donor value to 1000 for segments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035571 (https://phabricator.wikimedia.org/T363959) (owner: 10Eileen) [21:21:15] gotta go pick up Tavi, might be a while before I'm back on [21:22:21] (03PS1) 10Ejegg: WIP Show custom data for email on contact summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035575 (https://phabricator.wikimedia.org/T364913) [21:27:10] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035577 [21:27:21] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035577 (owner: 10Eileen) [21:29:56] !log civicrm upgraded from 55cb3cf7 to 22a38356 [21:29:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:44:23] (03PS1) 10Eileen: Re-fix trigger generator [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035581 (https://phabricator.wikimedia.org/T363959) [21:45:09] (03CR) 10Dwisehaupt: [C:03+2] Re-fix trigger generator [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035581 (https://phabricator.wikimedia.org/T363959) (owner: 10Eileen) [21:45:17] thanks [21:46:41] (03PS2) 10Eileen: Copy back timing wrapper to DonationQueue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035565 (https://phabricator.wikimedia.org/T365415) [21:46:59] (03PS2) 10Eileen: Move main donation insert function to DonationQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035566 (https://phabricator.wikimedia.org/T365415) [22:08:13] (03CR) 10CI reject: [V:04-1] Copy back timing wrapper to DonationQueue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035565 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [22:09:45] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035586 [22:10:15] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035586 (owner: 10Eileen) [22:11:43] (03CR) 10CI reject: [V:04-1] Move main donation insert function to DonationQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035566 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [22:11:58] !log civicrm upgraded from 22a38356 to 72aa5118 [22:12:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:14:27] (03PS1) 10Eileen: Update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035587 (https://phabricator.wikimedia.org/T363959) [22:15:21] ok - here are the updated triggers https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1035587 [22:15:36] dwisehaupt: if you are still about can you +2 that? [22:15:46] or cstone [22:19:04] looking [22:19:37] (03CR) 10Dwisehaupt: [C:03+2] "0's in the right place." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035587 (https://phabricator.wikimedia.org/T363959) (owner: 10Eileen) [22:20:44] oh. i should v+2 that also. [22:21:09] (03CR) 10Dwisehaupt: [V:03+2 C:03+2] Update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035587 (https://phabricator.wikimedia.org/T363959) (owner: 10Eileen) [22:22:40] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Recurring Donor (segment_id 400) records have conflicting status Deep Lapsed (status_id 60) - https://phabricator.wikimedia.org/T365639#9827897 (10Eileenmcnaughton) This should be fixed by our renumbering of the statuses [22:23:50] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035588 [22:24:00] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1035588 (owner: 10Eileen) [22:26:21] !log civicrm upgraded from 72aa5118 to 6c1fdd4f [22:26:23] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:36:56] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Recurring Donor (segment_id 400) records have conflicting status Deep Lapsed (status_id 60) - https://phabricator.wikimedia.org/T365639#9827977 (10Eileenmcnaughton) This should be fixed by our renumbering - when contact's are Acoustic-merged (not merged i... [22:41:21] (03PS1) 10Eileen: Alter non donor number on export to Acoustic [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035592 [22:44:35] (03CR) 10Dwisehaupt: [C:03+2] "New 0s where they are supposed to be." [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035592 (owner: 10Eileen) [22:44:41] cstone: a couple of errors with 'recurring but no subscription ID' - do you know where they come from? [22:45:30] (03Merged) 10jenkins-bot: Alter non donor number on export to Acoustic [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1035592 (owner: 10Eileen) [22:48:46] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1035593 [22:48:57] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1035593 (owner: 10Eileen) [22:49:27] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1035593 (owner: 10Eileen) [22:53:03] Eileen probably ideal fallout [22:53:16] cstone: ah ok - will that age out? [22:53:49] Yeah it'll take like a month [22:54:06] !log tools upgraded from bce5f52b to 91893e29 [22:54:08] ah ok [22:54:09] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:54:37] cstone: would you be able to look at a couple of those code move patches - I just don't want to keep them around too long cos code moves are conflicty [22:55:52] Eileen currently in a car I might be able to get to it later tonight [22:56:13] cstone: ah yeah - cars ... [22:57:57] (03PS2) 10Eileen: Move wrapper function for contribution_recur_insert to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035563 (https://phabricator.wikimedia.org/T365415) [23:00:10] (03PS2) 10Eileen: Take a copy of contribution_insert back to the checks class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035564 (https://phabricator.wikimedia.org/T365415) [23:00:10] (03PS3) 10Eileen: Copy back timing wrapper to DonationQueue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035565 (https://phabricator.wikimedia.org/T365415) [23:00:11] (03PS3) 10Eileen: Move main donation insert function to DonationQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035566 (https://phabricator.wikimedia.org/T365415) [23:00:12] (03PS2) 10Eileen: Remove soft credit handling from newly split code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035567 (https://phabricator.wikimedia.org/T365415) [23:03:37] (03PS1) 10Eileen: Minor clean up - move setting on contribution value to contribution import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1035594 [23:40:49] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog: Non-donor status missing records in our segmentation framework - https://phabricator.wikimedia.org/T363959#9828188 (10Eileenmcnaughton) @KHaggard from today's run the non donor number should be changed to 1000 fr donor_status_id