[00:08:50] lol - not security was actually really good - no queue - & the people were really nice [02:31:53] (03CR) 10Ejegg: Set default subject for upgrade decline activity (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037088 (https://phabricator.wikimedia.org/T362087) (owner: 10Ejegg) [03:43:18] (03PS1) 10Cstone: Send message to the pending queue for recurring SEPA [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1037660 (https://phabricator.wikimedia.org/T366231) [03:54:01] rip 2 inch hail [03:59:36] (03PS3) 10Cstone: Add acitives for recurring failure and autorescue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037204 (https://phabricator.wikimedia.org/T361256) [04:02:55] (03CR) 10CI reject: [V:04-1] Add acitives for recurring failure and autorescue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037204 (https://phabricator.wikimedia.org/T361256) (owner: 10Cstone) [08:31:35] 06Fundraising-Backlog, 13Patch-For-Review: Phase out cergen for Fundraising services - https://phabricator.wikimedia.org/T360779#9849539 (10MoritzMuehlenhoff) >>! In T360779#9842162, @Jgreen wrote: >>>! In T360779#9841199, @MoritzMuehlenhoff wrote: >> @jgreen: Just to doublecheck, the certificate expiry is... [08:56:04] (03CR) 10Nikerabbit: Remove $this->tablesUsed from PHPUnit tests (031 comment) [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1036209 (owner: 10Novem Linguae) [10:40:28] (03CR) 10Thiemo Kreuz (WMDE): [C:03+2] Remove $this->tablesUsed from PHPUnit tests (031 comment) [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1036209 (owner: 10Novem Linguae) [10:50:27] (03CR) 10CI reject: [V:04-1] Remove $this->tablesUsed from PHPUnit tests [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1036209 (owner: 10Novem Linguae) [10:55:36] (03CR) 10Jgleeson: [C:03+2] Delete 'isBatchProcessor' in extras [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035821 (https://phabricator.wikimedia.org/T336024) (owner: 10Ejegg) [10:56:44] (03CR) 10Jgleeson: [C:03+2] Stop using batch_mode in tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035823 (https://phabricator.wikimedia.org/T336024) (owner: 10Ejegg) [11:17:13] (03Merged) 10jenkins-bot: Delete 'isBatchProcessor' in extras [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035821 (https://phabricator.wikimedia.org/T336024) (owner: 10Ejegg) [11:17:15] (03Merged) 10jenkins-bot: Stop using batch_mode in tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035823 (https://phabricator.wikimedia.org/T336024) (owner: 10Ejegg) [11:30:16] (03CR) 10Jgleeson: [C:03+2] Get rid of the rest of batch processor code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035824 (https://phabricator.wikimedia.org/T336024) (owner: 10Ejegg) [11:30:44] (03CR) 10Jgleeson: [C:03+2] Remove ext-curl dependency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035835 (owner: 10Ejegg) [11:32:02] (03CR) 10Jgleeson: [C:03+2] "It's like watching an iceberg break up! nice" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035836 (owner: 10Ejegg) [11:32:27] (03Merged) 10jenkins-bot: Get rid of the rest of batch processor code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035824 (https://phabricator.wikimedia.org/T336024) (owner: 10Ejegg) [11:32:43] (03Merged) 10jenkins-bot: Remove ext-curl dependency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035835 (owner: 10Ejegg) [11:34:01] (03Merged) 10jenkins-bot: Remove code to generate XML trees [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035836 (owner: 10Ejegg) [11:35:01] (03CR) 10Jgleeson: [C:03+2] "I had to click around this one. I was surprised to see 'processResponse()' wasn't used!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035838 (owner: 10Ejegg) [11:35:18] (03CR) 10Jgleeson: [C:03+2] Delete old globalcollect js [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035839 (owner: 10Ejegg) [11:35:46] (03CR) 10Jgleeson: [C:03+2] Delete a bunch more unused functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035840 (owner: 10Ejegg) [11:37:01] (03Merged) 10jenkins-bot: Remove communicationType and response parsing [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035838 (owner: 10Ejegg) [11:38:09] (03CR) 10Jgleeson: [C:03+2] "Bye bye!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035842 (owner: 10Ejegg) [11:39:50] (03Merged) 10jenkins-bot: Delete ReturnValueMap [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035841 (owner: 10Ejegg) [11:40:05] (03Merged) 10jenkins-bot: Delete a drupal shim [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035842 (owner: 10Ejegg) [11:44:20] (03PS10) 10Damilare Adedoyin: WIP: Gravy createPayment call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1029267 (https://phabricator.wikimedia.org/T364506) (owner: 10Jgleeson) [11:44:43] (03CR) 10CI reject: [V:04-1] WIP: Gravy createPayment call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1029267 (https://phabricator.wikimedia.org/T364506) (owner: 10Jgleeson) [11:47:41] (03PS11) 10Damilare Adedoyin: Experiment: Gravy createPayment call skeleton [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1029267 (https://phabricator.wikimedia.org/T364506) (owner: 10Jgleeson) [11:47:55] (03CR) 10CI reject: [V:04-1] Experiment: Gravy createPayment call skeleton [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1029267 (https://phabricator.wikimedia.org/T364506) (owner: 10Jgleeson) [11:53:13] (03PS12) 10Damilare Adedoyin: Experiment: Gravy createPayment call skeleton [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1029267 (https://phabricator.wikimedia.org/T364506) (owner: 10Jgleeson) [11:53:37] (03CR) 10CI reject: [V:04-1] Experiment: Gravy createPayment call skeleton [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1029267 (https://phabricator.wikimedia.org/T364506) (owner: 10Jgleeson) [11:54:13] (03PS13) 10Damilare Adedoyin: Experiment: Gravy createPayment call skeleton [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1029267 (https://phabricator.wikimedia.org/T364506) (owner: 10Jgleeson) [11:54:36] (03CR) 10CI reject: [V:04-1] Experiment: Gravy createPayment call skeleton [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1029267 (https://phabricator.wikimedia.org/T364506) (owner: 10Jgleeson) [11:57:59] (03PS1) 10Damilare Adedoyin: Gravy create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) [11:58:22] (03CR) 10CI reject: [V:04-1] Gravy create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) (owner: 10Damilare Adedoyin) [12:09:06] (03CR) 10Novem Linguae: "CI is broken for this repo :( https://phabricator.wikimedia.org/T357804" [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1036209 (owner: 10Novem Linguae) [13:09:57] (03PS2) 10Damilare Adedoyin: Gravy create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) [13:10:19] (03CR) 10CI reject: [V:04-1] Gravy create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) (owner: 10Damilare Adedoyin) [13:37:52] (03PS4) 10Eileen: Stop setting names to anonymouse [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037205 (https://phabricator.wikimedia.org/T366231) [13:43:27] (03PS2) 10Eileen: Superficial clean up [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1036577 [13:43:50] (03PS2) 10Eileen: Add test & fix for issue with type hints [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1036576 (https://phabricator.wikimedia.org/T363965) [13:46:15] 06Fundraising-Backlog, 13Patch-For-Review: Phase out cergen for Fundraising services - https://phabricator.wikimedia.org/T360779#9850057 (10Jgreen) >>! In T360779#9849539, @MoritzMuehlenhoff wrote: >>>! In T360779#9842162, @Jgreen wrote: >>>>! In T360779#9841199, @MoritzMuehlenhoff wrote: >>> @jgreen: Just... [13:59:22] (03PS3) 10Damilare Adedoyin: Gravy create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) [13:59:47] (03CR) 10CI reject: [V:04-1] Gravy create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) (owner: 10Damilare Adedoyin) [14:14:05] thanks for all the CR jgleeson! [14:14:17] np! [14:21:37] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 10FR-donorservices, 10FR-email-preferences: Show snooze_date on contact summary - https://phabricator.wikimedia.org/T364913#9850145 (10Ejegg) Visible on contacts now, e.g. cid 2241615. Will create another ticket for making the custom fields editable... [14:21:40] (03PS14) 10Jgleeson: Experiment: Gravy createPayment call skeleton [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1029267 (https://phabricator.wikimedia.org/T364506) [14:21:40] (03PS4) 10Jgleeson: Gravy create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) (owner: 10Damilare Adedoyin) [14:22:02] (03CR) 10CI reject: [V:04-1] Gravy create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) (owner: 10Damilare Adedoyin) [14:23:27] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Make email custom fields editable from contact summary, upstream patch - https://phabricator.wikimedia.org/T366356 (10Ejegg) 03NEW [14:39:13] 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Make email custom fields editable from contact summary, upstream patch - https://phabricator.wikimedia.org/T366356#9850214 (10Ejegg) [14:57:14] hmm, paypal sandbox IPNPB is not verifying IPNs [14:57:28] maybe we should make that step optional for dev? [15:00:39] IPNPB? [15:00:41] ejegg: [15:03:40] (03CR) 10Damilare Adedoyin: [C:03+2] Experiment: Gravy createPayment call skeleton [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1029267 (https://phabricator.wikimedia.org/T364506) (owner: 10Jgleeson) [15:04:06] (03Merged) 10jenkins-bot: Experiment: Gravy createPayment call skeleton [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1029267 (https://phabricator.wikimedia.org/T364506) (owner: 10Jgleeson) [15:10:46] (03PS1) 10Jgleeson: Preserve .idea config during reclones for SmashPig [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1037807 [15:10:55] damilare: ^ [15:12:02] (03CR) 10Damilare Adedoyin: [C:03+2] Preserve .idea config during reclones for SmashPig [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1037807 (owner: 10Jgleeson) [15:12:04] (03CR) 10Damilare Adedoyin: [V:03+2 C:03+2] Preserve .idea config during reclones for SmashPig [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1037807 (owner: 10Jgleeson) [15:12:14] ty damilare [15:12:20] np [15:15:44] (03PS1) 10Jgleeson: Small fix to previous "Preserve .idea config" patch [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1037810 [15:16:27] damilare: I made a small mistake in that last one. the "restoring .idea config" but should have been inside the if statement [15:16:45] just to avoid it being applied each time without recloning [15:16:48] sorry! [15:17:05] lol no p, I must have missed it also [15:17:21] (03CR) 10Damilare Adedoyin: [C:03+2] Small fix to previous "Preserve .idea config" patch [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1037810 (owner: 10Jgleeson) [15:17:25] (03CR) 10Damilare Adedoyin: [V:03+2 C:03+2] Small fix to previous "Preserve .idea config" patch [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1037810 (owner: 10Jgleeson) [15:17:31] (03PS1) 10Ejegg: Dummy IPN validator for PayPal testing [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037811 [15:17:50] (03PS5) 10Damilare Adedoyin: Gravy create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) [15:17:54] ty [15:18:09] (03CR) 10CI reject: [V:04-1] Gravy create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) (owner: 10Damilare Adedoyin) [15:18:13] fr-tech ^^^ is a simple class for getting PayPal recurrings in from IPNs in test even when their verification postback site is broken [15:18:27] sorry jgleeson Instant Payment Notification PostBack [15:18:53] they have a site where you're supposed to echo each IPN to them, and they tell you if it was really from them or not [15:19:04] oh right [15:19:17] and right now their dev one is returning invalid [15:19:41] hmmm oh wait or are we using the prod URL in dev??? [15:19:46] ah that might be it [15:20:45] k, that patch may be unneeded [15:21:15] yeah, let me make a config patch instead [15:24:31] ok, that was all [15:28:11] easy fix :) [15:29:29] (03Abandoned) 10Ejegg: Dummy IPN validator for PayPal testing [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037811 (owner: 10Ejegg) [15:31:52] hmm, a few DUPLICATE_CONTRIBUITIONS dropped from one single paypal recurring [15:32:02] i wonder if we're queuing too many messages [15:32:10] or if we actually getting duplicate IPNs [15:33:01] (03PS4) 10Jgleeson: Add Gravy Gateway base files [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1037605 [15:35:58] ooh, dynamic property created in PayPal\Job [15:36:02] we'll need to fix that [15:38:12] damilare: am I able to use https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1037776/5 locally to get the new session? [15:38:50] (03PS6) 10Damilare Adedoyin: Gravy create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) [15:39:01] yes you should be able to with this patch ^^ [15:39:06] ty [15:39:14] (03CR) 10CI reject: [V:04-1] Gravy create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) (owner: 10Damilare Adedoyin) [15:55:20] 06Fundraising-Backlog, 10FR-Smashpig: Migrate remaining jobs off JsonSerializableObject - https://phabricator.wikimedia.org/T366367 (10Ejegg) 03NEW [15:55:25] (03PS1) 10Ejegg: Switch PayPal jobs over to Runnable interface [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037819 (https://phabricator.wikimedia.org/T366367) [15:55:45] (03CR) 10CI reject: [V:04-1] Switch PayPal jobs over to Runnable interface [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037819 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [15:56:01] 06Fundraising-Backlog, 10FR-Smashpig, 13Patch-For-Review: Migrate remaining jobs off JsonSerializableObject - https://phabricator.wikimedia.org/T366367#9850535 (10Ejegg) [15:59:11] (03PS2) 10Ejegg: Switch PayPal jobs over to Runnable interface [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037819 (https://phabricator.wikimedia.org/T366367) [15:59:31] (03CR) 10CI reject: [V:04-1] Switch PayPal jobs over to Runnable interface [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037819 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [16:03:36] (03PS3) 10Ejegg: Switch PayPal jobs over to Runnable interface [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037819 (https://phabricator.wikimedia.org/T366367) [16:03:57] (03CR) 10CI reject: [V:04-1] Switch PayPal jobs over to Runnable interface [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037819 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [16:05:18] (03PS4) 10Ejegg: Switch PayPal jobs over to Runnable interface [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037819 (https://phabricator.wikimedia.org/T366367) [16:05:40] (03CR) 10CI reject: [V:04-1] Switch PayPal jobs over to Runnable interface [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037819 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [16:06:50] weird, why would testIgnore start failing now? [16:07:07] ejegg: standup [16:07:13] oops! [16:07:15] coming [16:07:18] :> [17:20:38] (03CR) 10Umherirrender: Remove $this->tablesUsed from PHPUnit tests (031 comment) [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1036209 (owner: 10Novem Linguae) [17:20:43] (03PS7) 10Damilare Adedoyin: Gravy create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) [17:21:06] (03CR) 10CI reject: [V:04-1] Gravy create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) (owner: 10Damilare Adedoyin) [17:21:46] (03CR) 10Umherirrender: "Still has to support 1.39 - I22e9a32d7fdf11e9c0e818a865fa881230b6f726" [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1036334 (owner: 10Novem Linguae) [17:59:48] (03CR) 10Ejegg: "Hi @umherirrender_de.wp@web.de ! I think this extension is actually OK to upgrade past MW 1.39. While it is used by Fundraising, it is onl" [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1036334 (owner: 10Novem Linguae) [18:34:24] cstone: so can we review why we need to call the recurring bank payments 'complete' at donate-wiki? [18:34:39] I think we really should be calling them 'pending' and getting rid of the exceptions to the flow [18:35:35] i guess i thought it made sense to match whatever ideal was doing which was complete but their final status from adyen is Recieved [18:35:45] which i know we changed before to complete for something else [18:35:59] right, I feel like recurring ideal should be marked as pending there too [18:36:13] it would be simpler code [18:36:23] i just want to understand why that exception got added [18:36:39] i guess payment wise the one time payment is complete but the token is pending? [18:37:02] looks like in this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1020868 [18:37:05] like it should be pending-token or something [18:37:12] hmm, ok [18:37:18] i'd just call it pending [18:37:23] yeah we added it originally for recurring ideal [18:37:24] since we're waiting on the payment processor [18:37:32] i dont remember liking the way I wrote it [18:37:35] jack was just matching that [18:37:41] ok, let's see what we need to do to make it consistent [18:40:39] logPending was already only being called on redirects though unless its called in another way [18:43:19] ejegg: when you say marking as complete, what do you mean [18:43:42] that patch you linked is preventing the push to the donations queue [18:44:11] the comment is explaining that it's *not* complete until the IPN comes in [18:44:27] the final status of the payment is complete jgleeson [18:44:40] 14Fundraising Sprint: hammertime($touch_this=false), 03Fundraising Sprint: justWork(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 3 others: Allow DR to manually add a "Recurring Upgrade Declined" activity - https://phabricator.wikimedia.org/T362087#9851266 (10AMJohnson) Awesome, thanks @Ej... [18:45:00] I don't see that happening in the patch? [18:45:05] that ejegg linked [18:45:17] were we doing that already [18:45:22] no its not in the patch its how it already was [18:45:47] jgleeson: so we want to be able to avoid exceptions like that one [18:46:11] by just making the status be 'pending' [18:46:13] the exception being, skipping the push to the donations queue? [18:46:55] ah i thought you meant my if sepa then put on pending [18:48:06] for that patch linked, we're extracting the "skip the push to donations" logic to a fn and then adding SEPA to the check [18:48:24] ejegg: are you saying we don't want to do that ? [18:50:15] jgleeson: right, i want the status to come back from SmashPig::createPayment as pending [18:50:28] so the normal flow skips the push to donations, and pushes to pending instead [18:50:42] without having to do any check on isRecurringBankPayment up in the DonationInterface code [18:51:12] also this is making me wonder how iDEAL monthly convert would work [18:51:17] so we need to update smashpig [18:51:22] don't we need the recurring token to send the subscr_start message? [18:51:23] and then remove that check [18:51:31] jgleeson: yep, a small SmashPig update [18:51:33] we dont have ideal monthly convert [18:51:46] i think? [18:51:48] oh good, that's less mysterious then! [18:53:02] would it get two pending msgs then from the redirect and then final status for ideal? [18:54:11] the status from adyen for sepa at least is Recived which we also get for other ones so we would have to make some complete and some pending there [18:56:51] ejegg: feels like a good one to throw in a sequence diagram [18:57:07] as-is vs new [19:01:17] sorry, got called away [19:01:55] cstone: good question about the two pending messages [19:02:49] cstone so we would probably call sepa/Recieved 'pending' when we had the 'recurring' param set on the createPayment call, and 'complete' otherwise [19:16:12] hmm where would we put that though [19:16:24] glad php storm decided nothing should be indexed [19:17:20] guess the banktransferpaymentprovider has a if redirect already [19:24:21] cstone argh, phpstorm has been wonky for me since the latest update too. Like not showing any files in the project view except for the ones I had open right then [19:27:20] (03CR) 10Ejegg: "Looks pretty good, I just don't quite understand why we set $locationTypeForUnassigned to all the different location_type_ids we encounter" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1036576 (https://phabricator.wikimedia.org/T363965) (owner: 10Eileen) [19:33:32] (03CR) 10Umherirrender: [C:03+2] "Thanks for the feedback." [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1036334 (owner: 10Novem Linguae) [19:43:28] (03CR) 10CI reject: [V:04-1] add namespace to PHP use statement [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1036334 (owner: 10Novem Linguae) [19:44:48] (03CR) 10Ejegg: "maybe overly aggressive cleanup!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1036577 (owner: 10Eileen) [19:46:01] ejegg: hmm but subsequent recurring sepas we would want to be complete [19:46:20] cstone ah, OK [19:46:31] is there some difference in the way the call is made? [19:46:51] Like we use a token for the subsequent ones? [19:47:06] yes [19:47:13] sorry, focussing back on the sepa thing [19:47:24] 06Fundraising-Backlog, 10fundraising-tech-ops: Investigate pulling in page view data to the fr-tech version of superset - https://phabricator.wikimedia.org/T252049#9851474 (10AKanji-WMF) Thanks @RMurthy - I'll add this to triage so the team can discuss together. [19:47:47] but that is all separate before the status gets dealt with [19:48:41] ok, so we want to use a different status mapper per path [19:48:47] let me see [19:49:34] (03CR) 10Umherirrender: [V:03+2 C:03+2] "T357804" [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1036334 (owner: 10Novem Linguae) [19:50:00] InitialRecurringSEPAStatus ??? [19:50:36] (03CR) 10Umherirrender: Remove $this->tablesUsed from PHPUnit tests (031 comment) [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1036209 (owner: 10Novem Linguae) [19:55:40] DelayedTokenStatus? wed want it for ideal too right? [19:56:18] sure [20:02:30] (03PS1) 10Ejegg: Set initial sepa/iDEAL recurrings to 'pending' [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037848 [20:02:36] cstone maybe like that? ^^^ [20:03:14] oh that might fail tests, let me run em locally [20:04:21] ok, all passing except some with timezone issues [20:08:38] (03PS2) 10Ejegg: Set initial SEPA/iDEAL recurrings to 'pending' [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037848 [20:18:51] ok cool ejegg and checking for recurring there [20:22:51] right, now let me see why that little PayPal job class refactor would make the ignore test fail... [20:23:05] for double pending would it just delete both anyway is it a problem [20:23:20] cstone would we really get a double pending message? [20:23:32] just from the redirect [20:23:46] i guess i havent confirmed but it sends it to pendnig when it redirects [20:24:06] Right, but I think we don't get to the postProcessDonation line when it redirects [20:24:09] we have a real sepa ipn now at least so i can hack that one and adyen will send a ideal one on test [20:24:41] the redirect is an early return from doPayment with no call to handleCreatedPayment [20:24:59] Let's see if we have a test for that [20:25:16] and we can assert just one pending message, when there is a redirect + pending status [20:26:53] how do you handle smashpig locally ejegg do you use override yaml or just check out in each vendor? [20:27:27] i just clone from real to vendor [20:27:40] except this time i made the edits in payments/vendor by mistake :P [20:31:30] cstone: oh you were saying the extra logging happens when the donor comes back from the redirect? [20:34:17] going through it all now [20:34:17] i just saw it going to pending somewhere in that redirect flow last night [20:34:35] it should log pending just once before redirect [20:34:36] which is why ideal one had a pending msg in the first place [20:34:44] and I think with the new flow it should do that too [20:34:59] log pending before redirect and then send to pending on final status pending would be the two msgs? [20:35:56] right, let's check [20:36:55] So let's see where we get the final status after the donor returns [20:37:40] looks like from a getHostedPaymentDetails [20:38:00] ah i see [20:38:21] so that might still return 'complete' [20:39:08] OK, it might be more difficult to determine the right status mapper in the SmashPig layer in that case [20:39:21] since we're only sending in that $redirectResult blob [20:43:58] hmmmm [20:44:27] still not seeing a good way to get that status to return pending [20:47:03] ok cstone and jgleeson|away i guess the special casing in DonationInterface might be necessary after all [20:49:53] its annoying that they are almost the same but then not where its convienent [20:50:14] we could leave ideal alone and just do it for sepa? [20:51:54] although since they are kind of the same maybe it is less confusing to keep them with the same structure [20:59:33] 06Fundraising-Backlog, 10fundraising-tech-ops: On missing audit file, send Notification - https://phabricator.wikimedia.org/T365466#9851649 (10Dwisehaupt) a:03Dwisehaupt Script coded up and initial testing done. Need to test a little more and enable in icinga. [21:55:52] 06Fundraising-Backlog: Engage mapping import - Individual - https://phabricator.wikimedia.org/T364653#9851830 (10MDemosWMF) I have tested this again this week with the new dedupe rule @Eileenmcnaughton created with me and everything seemed to run well! I can start trying out the real data files using this template. [22:03:17] so cstone yeah maybe let's just set the status to pending for SEPA [22:03:37] and then it should get the pending message pushed over in postProcessDonation [22:09:36] (03PS3) 10Ejegg: Set initial SEPA recurrings to 'pending' [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037848 [22:15:55] hmm, if we log something as complete, I think the payments-init queue consumer might be deleting pending messages [22:16:14] now I do feel like we should be setting both methods to pending [22:26:25] (03PS1) 10Ejegg: Fully delete all WSDL/SOAP stuff from Adyen [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037863 (https://phabricator.wikimedia.org/T263621) [22:26:46] (03CR) 10CI reject: [V:04-1] Fully delete all WSDL/SOAP stuff from Adyen [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037863 (https://phabricator.wikimedia.org/T263621) (owner: 10Ejegg) [22:30:55] nice patch to make ejegg [22:31:29] :) [22:31:44] I just couldn't help myself [22:31:51] not in sprint or anything though [22:32:38] (03PS2) 10Ejegg: Fully delete all WSDL/SOAP stuff from Adyen [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037863 (https://phabricator.wikimedia.org/T263621) [22:46:35] (03PS5) 10Ejegg: Switch PayPal jobs over to Runnable interface [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037819 (https://phabricator.wikimedia.org/T366367) [22:46:52] cstone: ok, new suggestion [22:46:59] (03CR) 10CI reject: [V:04-1] Switch PayPal jobs over to Runnable interface [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037819 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [22:47:18] we go with the PS2 version of that SmashPig patch [22:47:47] sorry ejegg was building hail cover for my balcony plants haha im back fully now [22:48:01] and then up in DonationInterface we move the exception into the processDonorReturn [22:48:10] oh man, more storms coming? [22:49:11] yeah what we get here in tornado season just predicting more storms than yesterday today and tomorrow [22:49:18] yikes [22:49:49] the actual hail is in a super small area but I just barely skirted by yesterday haha [22:50:07] one pot just weighs like 40 lbs so annoying to keep moving inside [22:50:27] what did you build the shields out of? [22:50:47] haha its basically bunbuns travel cage flipped upside down [22:51:05] https://usercontent.irccloud-cdn.com/file/0xGYPZbG/1000047916.jpg [22:51:14] aww [22:51:31] darn it gerrit, how do I rewind to an earlier patch set? [22:51:46] (03PS4) 10Ejegg: Set initial SEPA/iDEAL recurrings to 'pending' [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037848 [22:51:51] ok, that did it [23:03:04] (03PS1) 10Ejegg: iDEAL recurring: change status instead of queue push [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1037865 (https://phabricator.wikimedia.org/T366231) [23:03:17] cstone: OK, I think those two patches might do what we want [23:03:27] I'm going to try locally and see if I get duplicate pending messages [23:11:02] ok, yeah, i do get the double pending messages on recurring iDEAL [23:14:24] let's see if that's actually a problem, what happens when I run the consumer [23:14:40] also... i was apparently working on old information [23:15:06] payment-init queue used to delete pending messages when it got a corresponding payments-init message with status complete [23:15:36] it still does delete on status failed [23:15:46] ugh, it should, but has been failing due to a typo [23:15:49] there is a comment in there referring double sending pending messages i think but its from 2021 and did we stop that? like it was putting everything in pending [23:16:03] oh where is that comment? [23:16:17] good question lets see [23:19:05] (03PS1) 10Ejegg: Fix typo in processorAllowsRepeat check [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037866 [23:19:24] shoot, I gotta go help make dinner [23:19:32] i found another comment saying when we made the weird ideal flow we want it to go to through postprocess for filters and logging [23:20:59] i need to head out too [23:23:46] well at least those missing submethod ones are coming in on the audit correctly [23:25:29] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Carte Bancaire losing payment_submethod and recurring token - https://phabricator.wikimedia.org/T365884#9851924 (10Cstone) these are coming in successfully on the audit