[00:23:15] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: check_endpoints_critical (Astropay-DLocal:2, Paypal:2, minFraud:2) 6 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [00:25:19] ^^^ i believe these are from the new payments hosts i'm building. checking in on it. [00:25:57] ACKNOWLEDGEMENT - check_log_messages on frav1003 is CRITICAL: CRITICAL: check_endpoints_critical (Astropay-DLocal:2, Paypal:2, minFraud:2) 6 [=1] Dwisehaupt new host building triggered this. https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [00:28:17] RECOVERY - check_log_messages on frav1003 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [00:38:15] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: check_endpoints_critical (Astropay-DLocal:2, Paypal:2, minFraud:2) 6 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [00:43:17] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: check_endpoints_critical (Astropay-DLocal:2, Paypal:2, minFraud:2) 6 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [00:48:15] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: check_endpoints_critical (Astropay-DLocal:2, Paypal:2, minFraud:2) 6 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [00:48:25] ACKNOWLEDGEMENT - check_log_messages on frav1003 is CRITICAL: CRITICAL: check_endpoints_critical (Astropay-DLocal:2, Paypal:2, minFraud:2) 6 [=1] Dwisehaupt re-ack-ing https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [01:20:48] going to power off the new payments machines until the pfw rules get updated for the endpoint checks. [01:23:15] RECOVERY - check_log_messages on frav1003 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [02:18:49] cstone: I looked at your autoreference patch - if you want to give me a bit more info I can +2 [02:19:19] yeah I meant to dig up its ticket but I got distracted [02:19:28] its supposed to add an activity when an autorescue completes sucessfully [02:19:32] i had it in the wrong place before [02:20:25] maybe it didn't have a ticket thats why I couldn't find it [02:20:35] its part of the getting better stats to track transient statuses [02:48:05] cstone: so there is still SOMETHING happening in Recurring - just that it is ONLY setting a custom value? [02:48:38] but if a payment comes in with that value then it winds up in the Donation queue [02:48:41] I had it in the complete wrong place the recuring queue just passes it along to the donations queue best i ccan tell [02:49:05] and then the donations queue already had that if auto rescue check so I thought it made more sense to put it there [02:49:24] ok [02:49:31] but this is still true sometimes if (isset($msg['rescue_reference'])) { [02:49:41] that was on the signup msg [02:49:45] and this is a payment message [02:50:36] ok [02:50:40] (03CR) 10Eileen: [C:03+2] Move autorescue activity to donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062154 (owner: 10Cstone) [02:51:14] thanks eileen ! [02:51:41] only added recently from the looks - I wonder if the code changed under you while you were working on it [02:55:17] I think that one I just straight up put it in the wrong place since the final one is on a payment message [03:10:18] (03Merged) 10jenkins-bot: Move autorescue activity to donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062154 (owner: 10Cstone) [03:21:58] (03PS1) 10Eileen: Restore custom data for email on contact summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062217 (https://phabricator.wikimedia.org/T364913) [04:43:05] (03PS2) 10Eileen: Fix dedupe query speed - port https://github.com/civicrm/civicrm-core/pull/30591 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1059950 (https://phabricator.wikimedia.org/T353971) [04:43:11] (03PS2) 10Eileen: Civi5.77-beta [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1059946 (https://phabricator.wikimedia.org/T353971) [05:50:17] (03PS15) 10Jdlrobson: Introduce the Donate skin [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1020408 (https://phabricator.wikimedia.org/T257862) [05:50:21] (03PS5) 10Jdlrobson: POC: Potential styles [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1020409 (https://phabricator.wikimedia.org/T257862) [06:40:13] (03CR) 10Jdlrobson: [C:03+2] "Before: https://phabricator.wikimedia.org/F57270852" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1057938 (https://phabricator.wikimedia.org/T360668) (owner: 10Abaris) [07:04:04] (03Merged) 10jenkins-bot: Convert setValidationError message boxes to use Codex styles [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1057938 (https://phabricator.wikimedia.org/T360668) (owner: 10Abaris) [07:23:15] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [07:28:15] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 2 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [07:33:17] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [07:38:17] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 3 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [07:43:15] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 3 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [07:48:17] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 3 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [07:53:15] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [07:58:15] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [08:03:17] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 2 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [08:08:19] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [08:13:25] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [08:18:25] RECOVERY - check_log_messages on frav1003 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [08:56:58] 06Fundraising-Backlog: Annual Recurring - Tagging and segmenting in Civi and Acoustic - https://phabricator.wikimedia.org/T372378 (10MSuijkerbuijk_WMF) 03NEW [09:00:53] 03Fundraising Sprint: ogFunction(), 06Fundraising-Backlog, 10MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), 13Patch-For-Review: Annual Recurring as Post-Payment Option - https://phabricator.wikimedia.org/T368155#10060792 (10MSuijkerbuijk_WMF) Cross-posting this request. If this is in progress, would you mind a... [09:01:41] 06Fundraising-Backlog: Annual Recurring - Tagging and segmenting in Civi and Acoustic - https://phabricator.wikimedia.org/T372378#10060797 (10MSuijkerbuijk_WMF) [10:57:16] (03PS2) 10Fomafix: Use overrideConfigValue/overrideConfigValues instead of setMwGlobals [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1059880 [13:11:28] 06Fundraising-Backlog, 10GitLab (Project Migration): Migrate fundraising-dev repo to gitlab - https://phabricator.wikimedia.org/T353374#10061573 (10Aklapper) [15:07:08] (03CR) 10Jgleeson: [C:03+2] Civi5.77-beta [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1059946 (https://phabricator.wikimedia.org/T353971) (owner: 10Eileen) [15:34:34] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE, 13Patch-For-Review: Q1:rack/setup/install frlog2002 - https://phabricator.wikimedia.org/T369935#10062140 (10Papaul) [15:35:43] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1062435 [15:35:55] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE, 13Patch-For-Review: Q1:rack/setup/install frdb200[45] - https://phabricator.wikimedia.org/T369920#10062143 (10Papaul) [15:36:23] damilare: I was gonna release that patch for gravy now that it's merged. are you about to do that? [15:36:56] or are you deploying something else [15:36:56] yep jgleeson [15:37:01] ok thanks [15:37:18] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE, 13Patch-For-Review: Q1:rack/setup/install frlog2002 - https://phabricator.wikimedia.org/T369935#10062141 (10Papaul) a:05Papaul→03Dwisehaupt @Dwisehaupt this is ready for you [15:37:19] wanna clear out the pending deployment col [15:37:44] greg +2ed it last night [15:37:55] and it finallly merged [15:38:24] not sure why it stalled initially though [15:38:25] we should try a live test [15:38:33] (03CR) 10Damilare Adedoyin: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1062435 (owner: 10Damilare Adedoyin) [15:39:04] damilare: I think I'd forgotten that it was dependant on a related smashpig patch [15:39:17] but then it got +2ed by elliott and then jenkins so not sure [15:39:29] yea [15:39:39] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1056527 [15:40:46] it didn't merge probably because of a CI hiccup after the dependent change was merged, just needed a new +2 :) [15:41:09] anything else you want me to +2 without fully reading the diff? :P [15:41:09] ahh thanks greg-g [15:41:22] none for now :) [15:41:35] (I was in a call with c.stone when I did it ;) ) [15:42:10] thanks greg-g [15:43:31] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE, 13Patch-For-Review: Q1:rack/setup/install frdb200[45] - https://phabricator.wikimedia.org/T369920#10062163 (10Papaul) a:05Papaul→03Dwisehaupt @Dwisehaupt this it is ready for you [15:44:16] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE, 13Patch-For-Review: Q1:rack/setup/install civi2002, frpig2002, frpm2002 - https://phabricator.wikimedia.org/T369937#10062167 (10Papaul) [15:44:28] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE, 13Patch-For-Review: Q1:rack/setup/install civi2002, frpig2002, frpm2002 - https://phabricator.wikimedia.org/T369937#10062168 (10Papaul) ` papaul@fasw-c-codfw# show | compare [edit interfaces interface-range disabled] - member ge-0/0/34; - mem... [15:47:02] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE, 13Patch-For-Review: Q1:rack/setup/install civi2002, frpig2002, frpm2002 - https://phabricator.wikimedia.org/T369937#10062170 (10Papaul) a:05Papaul→03Dwisehaupt @Dwisehaupt this is ready for you [16:24:06] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1062435 (owner: 10Damilare Adedoyin) [16:50:00] yeah but I dont see it in the merges to deployment [16:50:07] I might need to push it out [16:50:09] jgleeson: ah i had +2ed them in the last version [16:50:21] they're things that just weren't upstreamed [16:50:36] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1057968 [16:50:43] jgleeson it's here ^^ [16:51:15] 20b230ee2 Mon Jul 29 23:05:38 2024 jenkins-bot Merge "Add Gravy ID to external identifiers" [16:51:20] just found the commit [16:51:32] it's been deployed [16:51:40] that's the deployment patch I linked [16:51:43] yeah I just found the commit on deployment [16:51:50] awesome! [16:55:54] (03Merged) 10jenkins-bot: Fix dedupe query speed - port https://github.com/civicrm/civicrm-core/pull/30591 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1059950 (https://phabricator.wikimedia.org/T353971) (owner: 10Eileen) [16:57:43] (03Merged) 10jenkins-bot: Restore custom data for email on contact summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062217 (https://phabricator.wikimedia.org/T364913) (owner: 10Eileen) [17:12:20] damilare: that localsettings patch enabling the gatewy looks good. I can see we added a smashpig config for gravy here 19a9946ee67f06354cf5d09c072ca0c873f4c8c0 but that looks like a copy of our sandbox config. Do we need to add some new details to that one too? [17:12:51] checking [17:13:02] we might need to update/remove the api-prefix [17:15:34] from what I can see, the gravy package code only does something if 'sandbox' is present [17:15:48] the yes [17:16:08] so we can remove that and it'll skip the prefix [17:16:17] and send in "" [17:16:59] you could send in api-prefix: leeroy-jenkins and it would do the same [17:17:11] the gravy code looks like this [17:17:13] $this->environment = $environment; [17:17:14] I thought to add production [17:17:16] $apiPrefix = $environment === "sandbox" ? "sandbox." : ""; [17:17:17] $this->host = "https://api." . $apiPrefix . $gr4vyId .".gr4vy.app"; [17:17:36] and we pass our api-prefix to the arg for $environment [17:17:46] yea I saw that, I thought to use production instead of keeping the space [17:17:57] acts like a placeholder [17:18:13] maybe add a commit saying that this doesn't have any effect but to make it clear this prod [17:18:29] true [17:18:36] comment* [17:18:55] I kinda like the idea of using 'leeroy jenkins' [17:18:59] lol j/k [17:19:27] the whole "OK Let's do this!!!" feels fiting for a production launch [17:20:17] albeit we don't want it to end in disaster like that guild battle [17:21:01] ubrs run jgleeson :P [17:21:51] jgleeson: I've updated the prefix and added the comment as well. [17:21:59] thanks! [17:22:12] cstone: I'm not on wowpedia [17:22:12] * damilare googles 'leeroy jenkins' [17:22:15] now* [17:22:18] waaaaaaaa [17:22:27] we had a sprint named after him [17:22:29] https://en.wikipedia.org/wiki/Leeroy_Jenkins [17:22:38] you need to watch the video. it will all make sense [17:26:23] "Leeroy Jenkins!" [17:26:25] -Sun Tzu, The Art of War [17:27:05] omg that was hilarious, ends with him say "at least I'm not a chicken" [17:27:10] lol [17:27:12] :D [17:32:36] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q1:rack/setup/install frdb200[45] - https://phabricator.wikimedia.org/T369920#10062452 (10Dwisehaupt) @papaul This host is still listed as `frdc2004` in netbox instead of `frdb2004` thus has an incorrect mgmt dns setup. I could rename it and the mgmt in... [17:32:37] I spent too long in that instance I just have ubrs rage still :P [17:46:05] config update looks good damilare ! [17:46:45] thanks, I'd push that out now [17:46:54] random unrelated point. I just found out that tesla cybertrucks have bulletproof doors but not bulletproof glass. seems a bit pointless? [17:47:31] going to all the effort to make the doors bulletproof that is [17:52:36] i think they originally stated bulletproof glass until the release demo. [17:54:19] was that when they broke the glass when demoing it wasnt breakable? [17:59:14] with that metal ball, yup [18:00:43] jgleeson: I just updated the config with the path to the api key [18:01:25] please can you help review [18:02:31] sure [18:09:13] damilare: dwisehaupt: in damilare's patch I see the gravy key path as '/etc/gravy_api_cert.pem' but then in the puppet config I see a symlink is created at '/etc/fundraising/gravy_api_cert.pem' pointing to '/etc/gravy_api_cert.pem'. Should we be pointing to the symlink in the application code or the underlying? [18:10:47] i am unsure. i would follow whatever the current convention is. i created it following the examples already in use. [18:10:58] for paypal, we're using the symlink path, /etc/fundraising/paypal_api_cert.pem [18:11:12] not sure of the history of the /etc/fundraising and the symlinks. [18:11:47] also for apple pay, we're using /etc/fundraising/ [18:12:12] damilare: ^ let's update that path to point to the symlink to keep with the convention [18:12:43] sure I'd make the update [18:14:10] done jgleeson [18:15:19] perfect [18:15:21] lgtm damilare ! [18:15:29] thanks [18:19:41] (03CR) 10Ejegg: "Thanks for the review, jgleeson! Replied inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1060922 (https://phabricator.wikimedia.org/T368155) (owner: 10Ejegg) [18:21:19] seems smashpig is not able to access the key [18:21:22] 211578261.1 [18:22:05] here's the returned error: "Processor failed to create new payment session with response:Key cannot be empty" [18:22:22] testing with this url: https://payments.wikimedia.org/index.php?title=Special:GravyGateway&appeal=JimmyQuote [18:22:58] XenoRyet: damilare fr-tech. just a heads up before we give out any prod test links, we're gonna have to set up the flows in gravy's prod console for adyen. To do that we need to add the new connection config for Adyen with prod details. However, if folks remember, we had to get a different type of API accouunt added for the original gravy/adyen sandbox testing to support raw card [18:22:59] details to be sent via API. Do you want me to reply to the original thread where we requested that from Adyen and included the gravy PCI document which they needed, adding that we now want to enable this on a NEW separate API account as we're moving to the deployment stages? [18:23:45] damilare: I don't think it's ready just yet [18:24:39] also, it's important that we state clearly this is a new thing, so we don't break out existing API account [18:24:54] our* [18:26:04] Would this be something that we might want to talk out with them on the slack channel rather than via email? Also is there anything we need from Evelyn on this? [18:26:24] hmmm [18:26:33] it's pretty much between us and adyen at this point [18:26:50] we just supply gravy with the upgraded api account [18:26:51] Oh, I misread that a bit. [18:27:22] So yea, email Adyen and probably CC Evelyn if she's not already on the thread. [18:27:35] we need this setting up on prod [18:27:38] https://sandbox.wikimedia.gr4vy.app/merchants/default/connections/payment-services/9996be63-1e6f-4290-9d6e-b70f5d9b6bf8/credentials [18:27:46] and then we can add a new flow to point to it [18:27:53] ok will do [18:28:16] Cool, thanks [18:34:30] XenoRyet: it might be worth mentioning that last requirement to Evelyn just so she knows we have a dependency on that to deploy fully. [18:48:46] (03PS3) 10Ejegg: Fix Monthly Convert min amount validation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1060875 (https://phabricator.wikimedia.org/T368155) [18:48:46] (03PS7) 10Ejegg: Make annual recurring convert look like latest mockup [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1060922 (https://phabricator.wikimedia.org/T368155) [18:49:49] exciting, failmail in prod with 'gravy' in the name :) [18:49:58] llol [19:02:38] (03CR) 10Jgleeson: "Thanks ejegg. counter-proposal attached" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1060922 (https://phabricator.wikimedia.org/T368155) (owner: 10Ejegg) [19:07:18] 14Fundraising Sprint: meow(), 03Fundraising Sprint: ogFunction(), 06Fundraising-Backlog, 07payments-orchestration: Gravy Webhook Processing - https://phabricator.wikimedia.org/T367807#10062664 (10AKanji-WMF) [19:07:24] 06Fundraising-Backlog, 07payments-orchestration: Add Gravy fraud filter default scores - https://phabricator.wikimedia.org/T372430 (10jgleeson) 03NEW [19:07:26] 14Fundraising Sprint: meow(), 03Fundraising Sprint: ogFunction(), 06Fundraising-Backlog, 07payments-orchestration: Gravy Webhook Processing - https://phabricator.wikimedia.org/T367807#10062675 (10AKanji-WMF) 05Open→03Resolved [19:08:21] 14Fundraising Sprint: meow(), 03Fundraising Sprint: ogFunction(), 06Fundraising-Backlog, 07Epic, and 2 others: Gravy - Import donations to CIviCRM - https://phabricator.wikimedia.org/T368039#10062689 (10AKanji-WMF) [19:08:35] 14Fundraising Sprint: meow(), 03Fundraising Sprint: ogFunction(), 06Fundraising-Backlog, 07Epic, and 2 others: Gravy - Import donations to CIviCRM - https://phabricator.wikimedia.org/T368039#10062691 (10AKanji-WMF) 05Open→03Resolved [19:34:06] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Create WMF standalone config - https://phabricator.wikimedia.org/T372005#10062759 (10AKanji-WMF) a:05jgleeson→03None [19:58:54] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Tech-Analytics, 10FR-tech-data-integrity: Banner Closed Status Code Increase Year over Year - https://phabricator.wikimedia.org/T371632#10062819 (10spatton) @Ejegg , I wanted to follow up to clarify one more point you included above, and I'll cc... [20:07:29] 14Fundraising Sprint: didAnyoneTryThis(), 14Fundraising Sprint: meow(), 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, and 2 others: Sandra can't dedupe Name + address matching contacts (no email match) - https://phabricator.wikimedia.org/T353971#10062825... [20:07:30] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 07recurring upgrade: Update text for recurring upgrade thank you email - https://phabricator.wikimedia.org/T371848#10062828 (10AKanji-WMF) [20:07:32] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 07payments-orchestration: Gravy ACH (Trustly) - https://phabricator.wikimedia.org/T371810#10062829 (10AKanji-WMF) [20:07:33] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog: Tweak Zendesk API integration - https://phabricator.wikimedia.org/T371705#10062831 (10AKanji-WMF) [20:07:37] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog: Migration of India recurring to an alternate dlocal processor - https://phabricator.wikimedia.org/T371723#10062830 (10AKanji-WMF) [20:07:40] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations: Update RecurringUpgrade flow to account for annual donations - https://phabricator.wikimedia.org/T371517#10062833 (10AKanji-WMF) [20:07:41] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog: 2024 Sprint O - Priorities - https://phabricator.wikimedia.org/T371308#10062834 (10AKanji-WMF) [20:07:42] 14Fundraising Sprint: meow(), 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Import migration - add support for currency conversion - https://phabricator.wikimedia.org/T368998#10062836 (10AKanji-WMF) [20:07:45] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10Recurring-Donations, 13Patch-For-Review: Implement Post-Payment Monthly Convert variant for testing - https://phabricator.wikimedia.org/T371523#10062832 (10AKanji-WMF) [20:07:49] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Switch Acoustic mapping to use the API to define the columns - https://phabricator.wikimedia.org/T368470#10062837 (10AKanji-WMF) [20:07:53] 14Fundraising Sprint: meow(), 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 13Patch-For-Review, 07payments-orchestration: Create jobs for the events pushed to the jobs-gravy queue - https://phabricator.wikimedia.org/T370797#10062835 (10AKanji-WMF) [20:07:57] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), 13Patch-For-Review: Annual Recurring as Post-Payment Option - https://phabricator.wikimedia.org/T368155#10062838 (10AKanji-WMF) [20:08:02] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 07payments-orchestration: Gravy Audit/Settlement Processing - https://phabricator.wikimedia.org/T367788#10062840 (10AKanji-WMF) [20:08:06] 14Fundraising Sprint: meow(), 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog: Need to not autocancel recurring iDEAL/SEPA chargebacks - https://phabricator.wikimedia.org/T366769#10062842 (10AKanji-WMF) [20:08:10] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 13Patch-For-Review, 07payments-orchestration: Gravy Refunds - https://phabricator.wikimedia.org/T367808#10062839 (10AKanji-WMF) [20:08:14] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 13Patch-For-Review, 07payments-orchestration: Gravy 3DSecure - https://phabricator.wikimedia.org/T367786#10062841 (10AKanji-WMF) [20:08:18] 14Fundraising Sprint: meow(), 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10FR-Smashpig, 13Patch-For-Review: Migrate remaining jobs off JsonSerializableObject - https://phabricator.wikimedia.org/T366367#10062843 (10AKanji-WMF) [20:08:22] 14Fundraising Sprint: justWork(), 14Fundraising Sprint: meow(), 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, and 3 others: Make email custom fields editable from contact summary, upstream patch - https://phabricator.wikimedia.org/T366356#10062844 (10AKa... [20:08:26] 14Fundraising Sprint: justWork(), 14Fundraising Sprint: meow(), 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog: Add Auto Rescue for SEPA Direct Debit - https://phabricator.wikimedia.org/T362575#10062847 (10AKanji-WMF) [20:08:30] 14Fundraising Sprint: justWork(), 14Fundraising Sprint: meow(), 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog: Re-try data prior to Auto-Rescue was enabled - https://phabricator.wikimedia.org/T365348#10062846 (10AKanji-WMF) [20:08:34] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Imports to CiviCRM - make it possible to specify the default for a field without having to have a column - https://phabricator.wikimedia.org/T342717#10062848 (10AKanji-WMF) [20:08:38] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog: Building Fidelity import - issue with addressee column - https://phabricator.wikimedia.org/T370469#10062849 (10AKanji-WMF) [20:08:42] 14Fundraising Sprint: meow(), 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Consolidate error handling in queues - https://phabricator.wikimedia.org/T365418#10062845 (10AKanji-WMF) [20:08:46] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog: Benevity import not working - https://phabricator.wikimedia.org/T369647#10062851 (10AKanji-WMF) [20:08:50] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2425Q1 maintenance window - https://phabricator.wikimedia.org/T337582#10062853 (10AKanji-WMF) [20:08:56] 14Fundraising Sprint: didAnyoneTryThis(), 14Fundraising Sprint: justWork(), 14Fundraising Sprint: meow(), 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), and 5 others: Make unsubscribe work in EmailPreferences, delete Unsub ext... - https://phabricator.wikimedia.org/T223330#10062850 [20:09:00] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10FR-Civi-Dedupe, 13Patch-For-Review: Create button to merge "Unknown: Shares contact information" - https://phabricator.wikimedia.org/T367234#10062852 (10AKanji-WMF) [20:12:34] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10FR-Civi-Dedupe, 07Unplanned-Sprint-Work: Sandra can't dedupe Name + address matching contacts (no email match) - https://phabricator.wikimedia.org/T353971#10062866... [20:12:38] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Import migration - add support for currency conversion - https://phabricator.wikimedia.org/T368998#10062868 (10AKanji-WMF) [20:12:39] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog: Need to not autocancel recurring iDEAL/SEPA chargebacks - https://phabricator.wikimedia.org/T366769#10062870 (10AKanji-WMF) [20:12:41] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 13Patch-For-Review, 07payments-orchestration: Create jobs for the events pushed to the jobs-gravy queue - https://phabricator.wikimedia.org/T370797#10062867 (10AKanji-WMF) [20:12:42] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10FR-Smashpig, 13Patch-For-Review: Migrate remaining jobs off JsonSerializableObject - https://phabricator.wikimedia.org/T366367#10062869 (10AKanji-WMF) [20:12:43] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Make email custom fields editable from contact summary, upstream patch - https://phabricator.wikimedia.org/T366356#10062871 (10... [20:12:47] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Consolidate error handling in queues - https://phabricator.wikimedia.org/T365418#10062872 (10AKanji-WMF) [20:12:49] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog: Add Auto Rescue for SEPA Direct Debit - https://phabricator.wikimedia.org/T362575#10062874 (10AKanji-WMF) [20:12:52] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog: Re-try data prior to Auto-Rescue was enabled - https://phabricator.wikimedia.org/T365348#10062873 (10AKanji-WMF) [20:12:58] 14Fundraising Sprint: didAnyoneTryThis(), 14Fundraising Sprint: justWork(), 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, and 4 others: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330#10062875... [20:19:46] (03PS8) 10Ejegg: Make annual recurring convert look like latest mockup [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1060922 (https://phabricator.wikimedia.org/T368155) [20:20:05] jgleeson: OK, that's using Number() for all the casts in that script ^^ [20:20:27] note there is a parent patch that fixes the min amount validation for monthly convert in general [20:20:38] thanks ejegg! [20:33:56] Hey - so is someone able to look at merging the CiviCRM point version so we can deploy in a few hours- sorry about the short notice [20:35:18] (03CR) 10Jgleeson: [C:03+2] "LGTM! thanks" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1060922 (https://phabricator.wikimedia.org/T368155) (owner: 10Ejegg) [20:35:33] eileen: I think we did [20:35:40] I did one and ejegg did a bunch [20:35:53] jgleeson: ok yeah - blind! [20:36:04] :> [20:43:01] (03PS2) 10Cstone: Reset dlocal emails to before 0000@dlocal issue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1060189 (https://phabricator.wikimedia.org/T371911) [20:43:52] thanks for the C+2 jgleeson ! [20:43:57] ^ that one is ready to go too just tested it locally [20:44:04] can anyone take a look at this patch? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1060875/3 - it's a parent of the one jgleeson just C+2ed above [20:44:10] looking cstone [20:44:21] trade you ejegg [20:45:09] cstone: so $email['email_primary'] ends up being the id and not the email itself? [20:45:13] yeah [20:45:21] email_primary is the id and id is the contact id [20:45:25] er email id * [20:52:36] sorry ejegg missed that one [20:52:54] ok, thanks cstone! [20:55:11] (03CR) 10Cstone: [C:03+2] "looks good, thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1060875 (https://phabricator.wikimedia.org/T368155) (owner: 10Ejegg) [20:57:09] (03Merged) 10jenkins-bot: Fix Monthly Convert min amount validation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1060875 (https://phabricator.wikimedia.org/T368155) (owner: 10Ejegg) [20:57:25] (03Merged) 10jenkins-bot: Make annual recurring convert look like latest mockup [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1060922 (https://phabricator.wikimedia.org/T368155) (owner: 10Ejegg) [20:57:39] (03PS3) 10Cstone: Reset dlocal emails to before 0000@dlocal issue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1060189 (https://phabricator.wikimedia.org/T371911) [21:02:25] (03CR) 10Ejegg: [C:03+2] Reset dlocal emails to before 0000@dlocal issue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1060189 (https://phabricator.wikimedia.org/T371911) (owner: 10Cstone) [21:02:29] looks good! [21:02:34] thanks! [21:02:35] thanks for the review [21:21:22] (03Merged) 10jenkins-bot: Reset dlocal emails to before 0000@dlocal issue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1060189 (https://phabricator.wikimedia.org/T371911) (owner: 10Cstone) [22:18:14] (03PS5) 10Cstone: Add monthly convert variant 15 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1059960 [22:20:21] (03CR) 10Ejegg: [C:03+2] Add monthly convert variant 15 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1059960 (owner: 10Cstone) [22:22:19] (03Merged) 10jenkins-bot: Add monthly convert variant 15 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1059960 (owner: 10Cstone) [22:29:31] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1062464 [22:29:33] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1062464 (owner: 10Ejegg) [22:31:01] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1062464 (owner: 10Ejegg) [22:46:05] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1062469 [22:49:01] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1062469 (owner: 10Eileen) [22:49:48] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1062469 (owner: 10Eileen) [23:08:24] !log payments-wiki upgraded from 2d48f432 to 3eb3be67 [23:08:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log