[00:15:49] (03PS3) 10Eileen: Move our wmf tweaks to the deduper form to our own custom code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064147 [00:15:49] (03PS4) 10Eileen: Add in subset name resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1059523 [00:15:49] (03PS2) 10Eileen: Remove no longer used property in deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064148 [00:15:49] (03PS5) 10Eileen: Move support for full_name to the api layer (deduper extension) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064149 (https://phabricator.wikimedia.org/T370469) [00:15:50] (03PS8) 10Eileen: Upgrade references to 'special' org_contact_name to the actual apiv4 field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062770 (https://phabricator.wikimedia.org/T370469) [00:15:53] (03PS7) 10Eileen: Move a couple of tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062778 [00:15:57] (03PS8) 10Eileen: Fix custom field to be wrangled consistently on message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062777 (https://phabricator.wikimedia.org/T370469) [00:16:01] (03PS7) 10Eileen: Fix WMFSave to use apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062779 (https://phabricator.wikimedia.org/T370469) [00:16:05] (03PS4) 10Eileen: Port import fix upstream [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064151 (https://phabricator.wikimedia.org/T370469) [00:16:09] (03PS2) 10Eileen: Port https://github.com/civicrm/civicrm-core/pull/30941 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064457 [00:19:44] eileen: if we end up rolling those table modifications today, just ping me so i'll be aware in case they happen to have any replication or queue knock on effects. thanks! [00:20:21] dwisehaupt: ok - well I haven't got anyone definitely able to review so if it's easier for you we can just say 'we will do them tomorrow' [00:22:23] sure eileen im back now [00:23:38] cstone: oh cool - there are 2 patches - one adds the fields locally as they currently are on prod & then the second runs an upgrade to rename them [00:24:04] so best to pull https://gerrit.wikimedia.org/r/1064489 & run furst [00:24:07] first [00:31:03] locally package and channel have _numbers after them is that just since I'm updating? [00:31:09] just that the other columns don't have that [00:31:28] oh donor specified does have it [00:37:56] (03CR) 10Cstone: [C:03+2] Add gift source custom field updates from live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064489 (https://phabricator.wikimedia.org/T371636) (owner: 10Eileen) [00:38:36] cstone: yeah - so those numbers get added when the fields are created through the UI [00:38:43] it's kinda ok on 'normal' fields [00:38:52] cos we don't care much about them from a code POV [00:39:03] ah okay I think I have asked this before [00:39:11] but for fields we will be doing stuff in code with it's nice to have 'clean' field names [00:39:43] (the numbers mean there can be no sql issue if more than one table has the same field name & hence is 'safer' for the general use case) [00:40:20] ok cool I see now with 2nd patch [00:40:41] yep [00:41:00] if we had caught if before Nora created them we could have done this in the first place [00:46:35] (03CR) 10Cstone: [C:03+2] Update script to change column name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064492 (https://phabricator.wikimedia.org/T371636) (owner: 10Eileen) [00:47:02] thanks cstone [00:55:21] (03CR) 10Cstone: [C:03+2] "thanks for all the work on this Dami!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1063208 (https://phabricator.wikimedia.org/T371810) (owner: 10Damilare Adedoyin) [00:57:16] (03Merged) 10jenkins-bot: Add gift source custom field updates from live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064489 (https://phabricator.wikimedia.org/T371636) (owner: 10Eileen) [00:58:29] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1064475 (owner: 10Eileen) [01:00:03] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1064500 [01:00:52] !log civicrm upgraded from 3b22c823 to ed72cf6c [01:00:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:01:07] (that isn't the db update but I will run it if you are about to ack dwisehaupt ) [01:06:28] (03Merged) 10jenkins-bot: Update script to change column name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064492 (https://phabricator.wikimedia.org/T371636) (owner: 10Eileen) [01:06:29] (03Merged) 10jenkins-bot: Gravy ACH (Trustly) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1063208 (https://phabricator.wikimedia.org/T371810) (owner: 10Damilare Adedoyin) [01:10:14] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10FR-Civi-Dedupe, 13Patch-For-Review: Create button to merge "Unknown: Shares contact information" - https://phabricator.wikimedia.org/T367234#10083471 (10Eileenmcnaughton) I just deployed this & tested it -... [01:11:09] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1064500 (owner: 10Eileen) [01:11:56] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1064502 [01:24:10] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1064502 (owner: 10Eileen) [01:26:06] !log config revision changed from b1b3a1e6 to 69a40997 [01:26:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:26:23] !log civicrm upgraded from ed72cf6c to 3183c865 [01:26:24] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:28:12] ok - turning queues off - will run that update after [01:50:03] dwisehaupt: I'm gonna do that update [02:04:05] sounds good. just finished dinner. [02:04:32] dwisehaupt: it's running - seems like a large table.... [02:05:00] yeah. that's fine. i'm expecting we may get knock on effects for replication. i'll just ack them when they come along. [02:08:23] (03CR) 10Cstone: [C:03+2] Prefetch payments DNS on donatewiki form [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1064049 (https://phabricator.wikimedia.org/T372903) (owner: 10Ejegg) [02:11:26] (03PS46) 10Damilare Adedoyin: Setup listener for transaction event message. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) [02:11:53] (03Merged) 10jenkins-bot: Prefetch payments DNS on donatewiki form [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1064049 (https://phabricator.wikimedia.org/T372903) (owner: 10Ejegg) [02:12:11] (03PS16) 10Damilare Adedoyin: Setup 3DS Flow [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1060129 (https://phabricator.wikimedia.org/T367786) [02:17:28] first query finished [02:25:36] (03PS1) 10Eileen: Triggers update rename package_377 to package, channel_378 to channel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064506 (https://phabricator.wikimedia.org/T371636) [02:26:41] dwisehaupt: once the second query is done we should load those triggers ^^ [02:28:37] is there a reason that the civicrm_value_email triggers are duplicated there? [02:29:20] good question - it was autogenerated by the civi site but it's unusual [02:29:35] I think it's harmless tho [02:30:45] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 13Patch-For-Review: New contribution field - https://phabricator.wikimedia.org/T371636#10083564 (10Eileenmcnaughton) [02:30:57] yeah, only concern is that they are duplicated and being added new. unless they are actually there somewhere else. [02:31:33] yeah. they are there further up. [02:31:58] line 925 ish and 3428 ish [02:32:04] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 13Patch-For-Review: New contribution field - https://phabricator.wikimedia.org/T371636#10083566 (10Eileenmcnaughton) I brought this into the sprint to take advantage of the maintenance window to change the col... [02:32:34] dwisehaupt: I can maybe regenerate again when all done & see what happens [02:35:17] yeah. since it does the delete it isn't an issue, just odd. [02:35:33] just don't want it to catch us out in the future. [02:37:10] PROBLEM - check_mysql on frdb2001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1296 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_mysql [02:38:16] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1363 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [02:40:05] ok. downtimes put in for those. [02:42:16] did you want to regen those triggers or should +2 for now. [02:46:48] dwisehaupt: yep [02:46:58] sorry +2 [02:47:03] :) [02:47:13] then we will run & re-gen once the fields are dropped [02:47:17] (03CR) 10Dwisehaupt: [C:03+2] Triggers update rename package_377 to package, channel_378 to channel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064506 (https://phabricator.wikimedia.org/T371636) (owner: 10Eileen) [02:47:28] ok. all set. [02:48:39] you did give me flashbacks to dealing with my kids though. many times i have asked if the wanted to do X of Y and they respond with "yes". [02:52:10] ol [02:52:13] lol [02:58:14] RECOVERY - check_mysql on frdb1004 is OK: Uptime: 96201 Threads: 4 Questions: 1704211 Slow queries: 45 Opens: 1452 Open tables: 1093 Queries per second avg: 17.715 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [02:58:52] (03PS1) 10Eileen: Finish removing the fields from 4570. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064509 (https://phabricator.wikimedia.org/T353971) [02:59:53] dwisehaupt: ^^ is the last step (note I cheated & ran the fixed query) - if you or cstone is ok to +2 that too we can make it as if those columns never existed [03:00:51] (03CR) 10Cstone: [C:03+2] Finish removing the fields from 4570. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064509 (https://phabricator.wikimedia.org/T353971) (owner: 10Eileen) [03:00:58] thanks cstone [03:02:10] RECOVERY - check_mysql on frdb2001 is OK: Uptime: 121042 Threads: 4 Questions: 1845069 Slow queries: 44 Opens: 1481 Open tables: 1103 Queries per second avg: 15.243 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_mysql [03:05:53] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1064511 [03:06:01] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1064511 (owner: 10Eileen) [03:10:16] !log civicrm upgraded from 3183c865 to b27307a9 [03:10:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:10:27] dwisehaupt: those updated triggers are deployed if you want to run them [03:10:41] ok. pulling them down and doing the shuffle. [03:10:42] afterwards _378 &_377 should not be found [03:12:52] triggers look good and clean. no _377 or _388 [03:13:49] cool - so the last step is to remove those fields - https://gerrit.wikimedia.org/r/1064509 (tests running I think although they would skip the change anyway) [03:14:39] hmm - everything on a go slow here [03:15:06] at least with gerrit [03:15:52] is it down? [03:16:17] it's up for me. [03:16:30] i see the diff with a c+2 on it. [03:17:00] hmm hmm - not much going on for me [03:17:24] i could v+2/submit if you need. [03:18:02] dwisehaupt: could do - but I can't pull to merge to deployment either - I'm thinking of just running that sql directly since it has been +2d [03:18:24] oh yeah. [03:18:45] wonder what's up. let me try a ssh based action for gerrit. [03:19:12] that worked fine also. [03:19:38] i'm ok with running the sql and then pulling it in for deploy later. [03:19:38] ohh I think I'm back [03:19:44] even better. :) [03:20:14] (03CR) 10Eileen: [V:03+2] Finish removing the fields from 4570. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064509 (https://phabricator.wikimedia.org/T353971) (owner: 10Eileen) [03:20:15] i blame the sharks and their taste for underwater fiber. [03:20:49] (03PS1) 10Eileen: iMerge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1064512 [03:20:59] (03CR) 10Eileen: [V:03+2 C:03+2] iMerge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1064512 (owner: 10Eileen) [03:21:39] !log civicrm upgraded from b27307a9 to 7dc4401a [03:21:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:24:48] I guess we could drop the fields on the log table too - I didn't think of that [03:26:26] (03PS1) 10Eileen: Regen triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064513 (https://phabricator.wikimedia.org/T353971) [03:26:39] dwisehaupt: can you +2 - it dropped them again [03:27:10] also should we do the hoopla or just [03:27:10] ALTER TABLE log_civicrm_value_1_gift_data_7 [03:27:11] DROP column package_377, [03:27:11] DROP column channel_378 [03:28:46] i just see that as dropping the 2 duplicates. is that correct? [03:29:04] well, 2 duplicate stanzas of the civicrm_value_email triggers. [03:29:46] yeah [03:30:03] ok. cool. so nothing really needed on my end for it in terms of deploying. [03:30:04] I think I regenerated in a slightly different way the first time & it did that thing [03:30:13] (03CR) 10Dwisehaupt: [V:03+2 C:03+2] Regen triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064513 (https://phabricator.wikimedia.org/T353971) (owner: 10Eileen) [03:30:33] no no deploy on the triggers - just we need to decide re dropping the log table columns if I should do it via an upgrade script [03:30:39] or we just run it [03:31:18] i think that it's ok to run it. the reason to add it in to the upgrade script would be the fail case that we have to rebuild from scratch and would want to make sure they were deleted if they had been added. [03:31:29] but since they won't be added, then we don't really need to delete them. [03:31:35] at least that's my take. [03:31:51] (03PS1) 10Eileen: Also remove columns from the log table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064515 [03:32:13] dwisehaupt: ok - well I pushed up the update for completeness - but I will run on prod now as above [03:32:22] sounds good. [03:33:25] its running - do you want to +2 ^^ [03:33:33] sure. [03:33:34] once it has run I will re-enable pc [03:33:41] (03CR) 10Dwisehaupt: [C:03+2] Also remove columns from the log table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064515 (owner: 10Eileen) [03:33:44] (03CR) 10Dwisehaupt: [V:03+2 C:03+2] Also remove columns from the log table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064515 (owner: 10Eileen) [03:34:10] all set [03:34:30] cool - let's hope those columns don't take too long to add [03:35:55] sorry - to drop [03:36:49] don't think it should. [03:47:02] ok - it finished & I ran a donation - restarting jobs [03:47:12] cool cool [03:48:18] !log config revision changed from b1b3a1e6 to 69a40997 [03:48:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:48:31] thunderbirds we are go [03:49:41] sweet. [03:50:15] are we looking for any more stuff like this tomorrow? just trying to plan the end of day email for fr all [04:04:02] not that I can think of [04:04:16] (although I hadn't planned this one - it kinda just came up) [04:04:56] ok. i'll just list it as cleanup and testing for tomorrow but not mention anything about wrapping up early. [04:05:08] just in case. [04:07:07] (03PS3) 10Eileen: Deduper test fixes (merged upstream) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064145 [04:07:07] (03PS4) 10Eileen: Move our wmf tweaks to the deduper form to our own custom code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064147 [04:07:07] (03PS5) 10Eileen: Add in subset name resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1059523 [04:07:07] (03PS3) 10Eileen: Remove no longer used property in deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064148 [04:07:08] (03PS6) 10Eileen: Move support for full_name to the api layer (deduper extension) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064149 (https://phabricator.wikimedia.org/T370469) [04:07:11] (03PS9) 10Eileen: Upgrade references to 'special' org_contact_name to the actual apiv4 field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062770 (https://phabricator.wikimedia.org/T370469) [04:07:15] (03PS8) 10Eileen: Move a couple of tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062778 [04:07:19] (03PS9) 10Eileen: Fix custom field to be wrangled consistently on message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062777 (https://phabricator.wikimedia.org/T370469) [04:07:23] (03PS8) 10Eileen: Fix WMFSave to use apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062779 (https://phabricator.wikimedia.org/T370469) [04:07:27] (03PS5) 10Eileen: Port import fix upstream [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064151 (https://phabricator.wikimedia.org/T370469) [04:07:31] (03PS3) 10Eileen: Port https://github.com/civicrm/civicrm-core/pull/30941 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064457 [07:02:09] (03PS1) 10Eileen: Fix for location merge oddball [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064641 (https://phabricator.wikimedia.org/T363965) [07:07:46] (03PS1) 10Eileen: Fix typo causing dedupe js to not work [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064643 (https://phabricator.wikimedia.org/T367234) [07:08:43] (03CR) 10Eileen: [V:03+2 C:03+2] "I'm gonna push this through myself - it's so obviously just a typo I made & it can only cause confusion having dedupers hit it" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064643 (https://phabricator.wikimedia.org/T367234) (owner: 10Eileen) [07:09:45] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1064644 [07:09:57] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1064644 (owner: 10Eileen) [07:14:54] (03PS1) 10Eileen: Sync with upstread - add ordering [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064645 [07:20:58] !log civicrm upgraded from 7dc4401a to 975fc66e [07:21:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [07:29:06] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10FR-Civi-Dedupe, 13Patch-For-Review: Create button to merge "Unknown: Shares contact information" - https://phabricator.wikimedia.org/T367234#10083780 (10Eileenmcnaughton) I fixed the annoying thing - this... [11:48:46] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog: Tweak Zendesk API integration - https://phabricator.wikimedia.org/T371705#10084391 (10jgleeson) a:03jgleeson [11:50:38] (03CR) 10Damilare Adedoyin: "Recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1063242 (https://phabricator.wikimedia.org/T371810) (owner: 10Damilare Adedoyin) [11:55:34] (03CR) 10Damilare Adedoyin: [C:03+2] "+2ing again to get it CI to submit the change" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1063242 (https://phabricator.wikimedia.org/T371810) (owner: 10Damilare Adedoyin) [11:57:32] (03Merged) 10jenkins-bot: Gravy ACH (Trustly) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1063242 (https://phabricator.wikimedia.org/T371810) (owner: 10Damilare Adedoyin) [12:00:08] (03PS25) 10Damilare Adedoyin: ProcessCaptureRequestJob for authorization messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1057937 (https://phabricator.wikimedia.org/T370797) [12:00:44] (03PS19) 10Damilare Adedoyin: Record capture job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1058580 (https://phabricator.wikimedia.org/T370797) [12:00:58] (03PS20) 10Damilare Adedoyin: Setup Refunds method and maintenance script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059078 (https://phabricator.wikimedia.org/T367808) [13:43:55] (03PS14) 10Damilare Adedoyin: Refund job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059356 (https://phabricator.wikimedia.org/T370797) [13:44:23] (03PS20) 10Damilare Adedoyin: Handle Report execution webhook message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059932 (https://phabricator.wikimedia.org/T370797) [13:44:30] (03PS10) 10Damilare Adedoyin: Implement DownloadReportJob execute function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064020 [13:45:16] (03CR) 10CI reject: [V:04-1] Handle Report execution webhook message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059932 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [13:45:27] (03CR) 10CI reject: [V:04-1] Implement DownloadReportJob execute function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064020 (owner: 10Damilare Adedoyin) [13:51:08] (03PS15) 10Damilare Adedoyin: Refund job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059356 (https://phabricator.wikimedia.org/T370797) [13:54:42] (03PS21) 10Damilare Adedoyin: Handle Report execution webhook message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059932 (https://phabricator.wikimedia.org/T370797) [14:06:06] (03PS22) 10Damilare Adedoyin: Handle Report execution webhook message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059932 (https://phabricator.wikimedia.org/T370797) [14:06:45] (03CR) 10CI reject: [V:04-1] Handle Report execution webhook message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059932 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [14:09:29] (03PS23) 10Damilare Adedoyin: Handle Report execution webhook message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059932 (https://phabricator.wikimedia.org/T370797) [14:12:59] (03PS11) 10Damilare Adedoyin: Implement DownloadReportJob execute function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064020 [14:21:34] 06Fundraising-Backlog, 07payments-orchestration: Accept all Gravy webhook messages - https://phabricator.wikimedia.org/T373117 (10Damilare) 03NEW [14:31:51] (03PS1) 10Damilare Adedoyin: Upgrade smashpig to v0.8.11.3 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1064768 [14:33:14] (03PS1) 10Jgleeson: Tweak Zendesk API call [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064769 [14:34:20] (03PS2) 10Jgleeson: Tweak Zendesk API call [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064769 (https://phabricator.wikimedia.org/T371705) [14:34:36] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1064770 [14:34:55] (03CR) 10Damilare Adedoyin: [C:03+2] Upgrade smashpig to v0.8.11.3 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1064768 (owner: 10Damilare Adedoyin) [14:37:09] (03Merged) 10jenkins-bot: Upgrade smashpig to v0.8.11.3 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1064768 (owner: 10Damilare Adedoyin) [14:39:04] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 13Patch-For-Review: Tweak Zendesk API integration - https://phabricator.wikimedia.org/T371705#10085204 (10jgleeson) After reading the Zendesk API docs, I couldn't see a way to combine properties to search agai... [14:52:47] (03CR) 10Damilare Adedoyin: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1064770 (owner: 10Damilare Adedoyin) [15:04:50] 06Fundraising-Backlog: Make the phone number field mandator on all payment types in the India Form - https://phabricator.wikimedia.org/T373060#10085289 (10EMartin) p:05Triage→03High [15:07:53] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1064770 (owner: 10Damilare Adedoyin) [15:46:39] (03PS4) 10Ejegg: Remove JsonSerializableMessage from more tests [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064422 (https://phabricator.wikimedia.org/T366367) [15:46:39] (03PS2) 10Ejegg: Stop calling parent::__construct() in Amazon messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064448 (https://phabricator.wikimedia.org/T366367) [15:46:39] (03PS1) 10Ejegg: Stop using fromJson in DLocal tests [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064784 (https://phabricator.wikimedia.org/T366367) [15:46:41] (03PS1) 10Ejegg: Remove JsonSerializableObject [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064785 (https://phabricator.wikimedia.org/T366367) [15:47:29] (03CR) 10CI reject: [V:04-1] Remove JsonSerializableObject [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064785 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [15:51:13] (03PS1) 10Ejegg: Add response property for backend processor [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064786 (https://phabricator.wikimedia.org/T372589) [15:51:51] oops, we can't actually return static while on php7.4 [15:58:51] ah that's just a typehint, no worries [16:01:33] (03PS2) 10Ejegg: Add response property for backend processor [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064786 (https://phabricator.wikimedia.org/T372589) [16:17:05] (03PS2) 10Ejegg: Stop using fromJson in DLocal tests [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064784 (https://phabricator.wikimedia.org/T366367) [16:17:05] (03PS2) 10Ejegg: Remove JsonSerializableObject [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064785 (https://phabricator.wikimedia.org/T366367) [16:17:05] (03PS1) 10Ejegg: Stop RejectedMessageJob extending JsonSerializableObject [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064796 (https://phabricator.wikimedia.org/T366367) [16:17:29] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog: Make the phone number field mandator on all payment types in the India Form - https://phabricator.wikimedia.org/T373060#10085632 (10jgleeson) [16:26:27] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: ACH address setting N/A in civi instead of empty data - https://phabricator.wikimedia.org/T372482#10085644 (10AnnWF) example CIDs: 64409790 47388088 [16:39:54] (03PS1) 10Wfan: Set address2/supplimental address to blank if N/A [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064801 [16:40:16] (03CR) 10CI reject: [V:04-1] Set address2/supplimental address to blank if N/A [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064801 (owner: 10Wfan) [16:42:00] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices, and 2 others: Job that sets PayPal recurs as cancelled after 90 days w/no donation should also cancel at PayPal - https://phabricator.wikimedia.org/T341346#10085682 (10AMJohnson) Thanks for implemen... [17:29:00] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog: Make the phone number field mandatory on all payment types in the India Form - https://phabricator.wikimedia.org/T373060#10085804 (10EMartin) [17:42:50] (03CR) 10Thiemo Kreuz (WMDE): [C:03+2] Add missing documentation to class properties [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/1064072 (owner: 10Umherirrender) [18:13:03] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Uptick in Dutch donors experiencing issues donating - https://phabricator.wikimedia.org/T372571#10085935 (10EMartin) Notice today from Adyen {F57286498} [18:28:59] (03Merged) 10jenkins-bot: Add missing documentation to class properties [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/1064072 (owner: 10Umherirrender) [18:58:16] (03Merged) 10jenkins-bot: Deduper test fixes (merged upstream) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064145 (owner: 10Eileen) [19:06:33] (03Merged) 10jenkins-bot: Move our wmf tweaks to the deduper form to our own custom code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064147 (owner: 10Eileen) [19:14:19] (03PS1) 10Ejegg: Set backendProcessor on CreatePaymentResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064834 (https://phabricator.wikimedia.org/T372589) [19:44:11] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Paypal: Really fix PayPal fluctuating subscr_id problem - https://phabricator.wikimedia.org/T371845#10086205 (10Ejegg) OK, I've just updated the trxn_id on those two recurring subscriptions and re-sent the damaged... [20:14:40] (03CR) 10Jgleeson: [C:04-1] "This is really close! Thanks for the thoroughness of the unit test coverage. I tested locally with a mixture of live and test notification" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [20:39:35] (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.43 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1064865 [20:42:33] (03PS1) 10Cstone: Add PaymentSettings to allowlist [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1064870 [20:44:04] 10fundraising-tech-ops, 10decommission-hardware: decommission of codfw frack servers - frdb2001 frqueue2001 payments2003 - https://phabricator.wikimedia.org/T373149 (10Dwisehaupt) 03NEW [21:05:23] (03PS1) 10Cstone: Add payment methods [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1064895 [21:10:20] (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.43 [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1064901 [21:27:45] (03CR) 10CI reject: [V:04-1] Add payment methods [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1064895 (owner: 10Cstone) [21:35:06] 10fundraising-tech-ops, 10decommission-hardware: decommission of codfw frack servers - frdb2001 frqueue2001 payments2003 - https://phabricator.wikimedia.org/T373149#10086503 (10Dwisehaupt) [21:35:38] (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.43 [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/1064928 [21:41:36] (03CR) 10CI reject: [V:04-1] build: Update MediaWiki requirement to 1.43 [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1064901 (owner: 10Jforrester) [23:16:24] (03CR) 10Eileen: [C:03+2] Tweak Zendesk API call [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064769 (https://phabricator.wikimedia.org/T371705) (owner: 10Jgleeson) [23:27:49] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 13Patch-For-Review: Tweak Zendesk API integration - https://phabricator.wikimedia.org/T371705#10086650 (10AnnWF) requester looks like the right field, also tested locally look good! [23:28:43] (03Abandoned) 10Wfan: remove contribution check from email unsubscribe [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/995269 (https://phabricator.wikimedia.org/T223330) (owner: 10Wfan) [23:36:57] (03Merged) 10jenkins-bot: Tweak Zendesk API call [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064769 (https://phabricator.wikimedia.org/T371705) (owner: 10Jgleeson)