[00:36:31] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Uptick in Dutch donors experiencing issues donating - https://phabricator.wikimedia.org/T372571#10086734 (10Cstone) Here's a searchkit of donors that successful with a second donation: https://civicrm.wikimedia.org/civicrm/admin/sear... [02:11:53] 06Fundraising-Backlog: Already cancelled Paypal cancel dates at 1969-12-31 - need to update to actual cancel date - https://phabricator.wikimedia.org/T373162 (10Cstone) 03NEW [05:20:26] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog: Migration of India recurring to an alternate dlocal processor - https://phabricator.wikimedia.org/T371723#10086860 (10RKumar_WMF) Mandate information sent to dlocal [09:51:02] 10fundraising-tech-ops, 10decommission-hardware, 13Patch-For-Review: decommission of codfw frack servers - frdb2001 frqueue2001 payments2003 - https://phabricator.wikimedia.org/T373149#10087224 (10Clement_Goubert) Just a heads up that the removal of the management DNS entries for these three servers popped u... [11:00:03] (03CR) 10Damilare Adedoyin: [C:03+2] Add response property for backend processor [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064786 (https://phabricator.wikimedia.org/T372589) (owner: 10Ejegg) [11:00:44] (03Merged) 10jenkins-bot: Add response property for backend processor [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064786 (https://phabricator.wikimedia.org/T372589) (owner: 10Ejegg) [11:11:49] howdy damilare|away not sure if seen but i rereviewed the gravy transaction patch. it looks really close [11:12:35] jgleeson: thanks I'm working on it thanks for the CR [11:14:48] damilare: when running composer install on payments I'm getting [11:14:50] docker@payments:/var/www/html$ composer install [11:14:52] > ComposerHookHandler::onPreInstall [11:14:54] Installing dependencies from lock file (including require-dev) [11:14:56] Verifying lock file contents can be installed on current platform. [11:14:58] - Required package "wikimedia/smash-pig" is in the lock file as "v0.8.11.1" but that does not satisfy your constraint "0.8.11.3". [11:15:00] have you seen thast [11:15:51] I wonder if it's just my lock file [11:15:55] yea had to delete the composer.lock in DI [11:16:24] I just realised we don't push the lcok file as it's in gitignore [11:17:27] I tried commiting it with this change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1064768 when I noticed [11:18:01] which is strange because we do that in other projects [11:21:26] (03CR) 10Jgleeson: [C:03+2] "Formats the backend processor as expected. LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064834 (https://phabricator.wikimedia.org/T372589) (owner: 10Ejegg) [11:21:54] (03Merged) 10jenkins-bot: Set backendProcessor on CreatePaymentResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064834 (https://phabricator.wikimedia.org/T372589) (owner: 10Ejegg) [11:21:55] damilare: I'll start reviewing the patches above the base one just to get a head start [11:27:31] (03PS47) 10Damilare Adedoyin: Setup listener for transaction event message. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) [11:28:00] thanks jgleeson! [11:29:49] (03CR) 10Damilare Adedoyin: "thanks for the CR jgleeson. Made the recommended changes." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [11:29:59] (03PS48) 10Damilare Adedoyin: Setup listener for transaction event message. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) [11:29:59] (03PS26) 10Damilare Adedoyin: ProcessCaptureRequestJob for authorization messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1057937 (https://phabricator.wikimedia.org/T370797) [11:29:59] (03PS20) 10Damilare Adedoyin: Record capture job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1058580 (https://phabricator.wikimedia.org/T370797) [11:29:59] (03PS21) 10Damilare Adedoyin: Setup Refunds method and maintenance script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059078 (https://phabricator.wikimedia.org/T367808) [11:30:00] (03PS16) 10Damilare Adedoyin: Refund job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059356 (https://phabricator.wikimedia.org/T370797) [11:30:02] (03PS24) 10Damilare Adedoyin: Handle Report execution webhook message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059932 (https://phabricator.wikimedia.org/T370797) [11:30:06] (03PS12) 10Damilare Adedoyin: Implement DownloadReportJob execute function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064020 [13:40:34] 10fundraising-tech-ops, 06DC-Ops, 10decommission-hardware, 10ops-codfw, 13Patch-For-Review: decommission of codfw frack servers - frdb2001 frqueue2001 payments2003 - https://phabricator.wikimedia.org/T373149#10087813 (10Papaul) @Clement_Goubert thank you [13:41:22] 10fundraising-tech-ops, 06DC-Ops, 10decommission-hardware, 10ops-codfw, 13Patch-For-Review: decommission of codfw frack servers - frdb2001 frqueue2001 payments2003 - https://phabricator.wikimedia.org/T373149#10087815 (10Papaul) [13:43:17] (03CR) 10Jgleeson: [C:03+2] "Thanks for all the work on this. Looks great!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [13:43:47] (03Merged) 10jenkins-bot: Setup listener for transaction event message. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [14:42:00] T373060 [14:42:01] T373060: Make the phone number field mandatory on all payment types in the India Form - https://phabricator.wikimedia.org/T373060 [14:50:11] cool [14:50:12] T1 [14:50:25] wah doesn't work [14:51:59] T2001 [14:51:59] T2001: [DO NOT USE] Documentation is out of date, incomplete (tracking) [superseded by #Documentation] - https://phabricator.wikimedia.org/T2001 [14:52:04] T12 [14:52:21] T100 [14:52:21] T100: Decide how to organize iterations and releases - https://phabricator.wikimedia.org/T100 [14:52:41] I guess it ignores single digit phabs [14:52:41] I think it has a hard cutoff somewhere low so it doesn't give false positives [14:53:25] T90210 [14:53:26] T90210: Pasting from clipboard should not keep only basic formatting - https://phabricator.wikimedia.org/T90210 [14:53:32] :) [14:53:51] T8675309 [14:53:55] (we aren't there yet) [15:00:56] (03PS1) 10Jgleeson: WIP: Make phone number mandatory for India payment forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1065236 (https://phabricator.wikimedia.org/T373060) [15:06:18] (03CR) 10Jgleeson: [C:03+2] "This is working well for me. I stepped through the tests and see we followed the Adyen pattern closely, which makes sense here." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1057937 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [15:06:52] (03Merged) 10jenkins-bot: ProcessCaptureRequestJob for authorization messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1057937 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [15:19:00] 10fundraising-tech-ops, 06DC-Ops, 10decommission-hardware, 10ops-codfw, 13Patch-For-Review: decommission of codfw frack servers - frdb2001 frqueue2001 payments2003 - https://phabricator.wikimedia.org/T373149#10088195 (10Jhancock.wm) [15:20:48] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1065238 [15:22:48] fr-tech I'm gonna deploy civicrm and push out that zendesk tweak that got merged last night to civicrm. I'm not here Monday. There's a few deduper updates too. It feels low risk even though it is Friday @_@ [15:25:13] greg-g: anilk you sent me down a terminator model rabit hole [15:25:17] and this stood out [15:25:27] T-1000 - https://en.wikipedia.org/wiki/T-1000 [15:25:31] First appearanceTerminator 2: Judgment Day (1991) [15:25:38] Last appearanceCall of Duty: Vanguard (2022) <<<<< [15:26:21] (03CR) 10Jgleeson: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1065238 (owner: 10Jgleeson) [15:27:22] (03CR) 10Jforrester: "Failure is known: T357804" [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1064901 (owner: 10Jforrester) [15:27:23] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1065238 (owner: 10Jgleeson) [15:27:32] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06Language and Product Localization, 10MediaWiki-extensions-Translate, 10ci-test-error (WMF-deployed Build Failure): phpunit test failure for extension FundraisingTranslateWorkflow - https://phabricator.wikimedia.org/T357804#10088211 (10Jdforrester-W... [15:29:20] !log updated civicrm from 975fc66e to e629834c [15:29:22] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:32:44] jgleeson: YES, I was hoping someone else would so i didn't have to (go down that rabbit hole) [15:33:09] I did not realize there was a Call of Duty/Terminator cross over [15:36:07] me neither [15:48:37] 10fundraising-tech-ops, 06DC-Ops, 10decommission-hardware, 10ops-codfw, 13Patch-For-Review: decommission of codfw frack servers - frdb2001 frqueue2001 payments2003 - https://phabricator.wikimedia.org/T373149#10088261 (10Dwisehaupt) @Clement_Goubert Oh. Thanks for that. I must have forgot it last night. S... [15:49:37] was there ever a Terminator + Alien or Predator cross over? one big monster universe? :) [15:49:59] yes: https://en.wikipedia.org/wiki/Aliens_versus_Predator_versus_The_Terminator [15:53:36] (03PS2) 10Jgleeson: WIP: Make phone number mandatory for India payment forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1065236 (https://phabricator.wikimedia.org/T373060) [16:18:01] 10fundraising-tech-ops, 06DC-Ops, 10decommission-hardware, 10ops-codfw, 13Patch-For-Review: decommission of codfw frack servers - frdb2001 frqueue2001 payments2003 - https://phabricator.wikimedia.org/T373149#10088365 (10Clement_Goubert) >>! In T373149#10088261, @Dwisehaupt wrote: > @Clement_Goubert Oh. T... [16:27:31] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q1:rack/setup/install frban2002 - https://phabricator.wikimedia.org/T369931#10088394 (10Jhancock.wm) [16:28:01] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE, 13Patch-For-Review: Q1:rack/setup/install frdb200[45] - https://phabricator.wikimedia.org/T369920#10088395 (10Jhancock.wm) [16:28:16] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE, 13Patch-For-Review: Q#:rack/setup/install payments200[456] - https://phabricator.wikimedia.org/T369942#10088396 (10Jhancock.wm) [17:07:22] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q1:rack/setup/install frban2002 - https://phabricator.wikimedia.org/T369931#10088494 (10Jhancock.wm) a:05Jhancock.wm→03Papaul This one is ready for ya. ports are on 41 of both frack switches. [17:08:00] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE, 13Patch-For-Review: Q1:rack/setup/install frdb200[45] - https://phabricator.wikimedia.org/T369920#10088497 (10Jhancock.wm) frdb2005 is racked and ready for @Papaul. ports are on port 40 of the FR switches. [17:08:38] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE, 13Patch-For-Review: Q#:rack/setup/install payments200[456] - https://phabricator.wikimedia.org/T369942#10088498 (10Jhancock.wm) @Papaul payments2006 is racked and ready. on ports 39 of the FR switches. [17:21:20] (03CR) 10Jgleeson: [C:03+1] "Thanks Dami. This is pretty much there. I did notice an unusual field in the queue message but I think that might just be due to how we're" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1058580 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [17:23:11] ejegg: should 'propertiesExcludedFromExport' be making it on to donations queue messages that the Adyen (and soon to be Gravy) RecordCaptureJob is producing? It seems to originte here https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/77a7ef7b35ee3d1247a6c74f9cb4cf5942c36e0d/Core/DataStores/JsonSerializableObject.php#L10 [17:23:31] I noticed it when reviewing this patch for damilare https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1058580/comment/69e10872_c9f29eae/ [17:26:28] I think it might have been added to the test fixture here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1058580/20/PaymentProviders/Gravy/Tests/Data/pending.json@32 [17:27:30] I also see it in the Adyen test fixtures https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/f7c8f530885cfc77e2524e882813de6a94729f72/PaymentProviders/Adyen/Tests/Data/pending.json [17:29:32] I wonder if it's an attempt to mock the production pending table, checking [17:29:48] damilare: I checked the db table and I don't see it [17:30:11] it looks like a stray property left over from a var_dump of an object maybe [17:30:22] var_export() even [17:31:31] looks like ejegg added it back in 2016 to the test fixtures [17:31:41] so we probably don't need it for gravy [17:31:57] it got added here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/277554 [17:32:38] (03PS21) 10Damilare Adedoyin: Record capture job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1058580 (https://phabricator.wikimedia.org/T370797) [17:32:52] damilare: removing it from the pending.json fixture didn't break anything for me and the tests still pass [17:33:37] ahh a 2016 slip that's been carried on every since [17:33:59] thanks for catching jgleeson, I've updated the patch. [17:34:05] that's how the best ones stick around! [17:34:14] thanks damilare [17:35:29] (03CR) 10Jgleeson: [C:03+2] "LGTM! thanks again" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1058580 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [17:35:56] (03Merged) 10jenkins-bot: Record capture job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1058580 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [17:36:47] ok damilare I *think* that means we've go the listener with capture and pushing to donations queue over the line [17:37:11] yep! thanks for all the review [17:37:19] the other IPN things I see are refunds and report downloads [17:37:47] I can tie the report downloads patches into the CRM audit patch I'll work on next week [17:38:14] can we do refunds as payments asked about it early this week? [17:38:34] oh right I had that in my head as a medium priority [17:38:52] ok I'll look at that next in line [17:38:59] tnx! [17:43:41] jgleeson oh yep, that propertiesExcludedFromExport should be deleted [17:44:09] just an artifact of JsonSerializable as you figured out [18:07:11] (03CR) 10Bartosz Dziewoński: [C:03+2] Use overrideConfigValue/overrideConfigValues instead of setMwGlobals [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1059880 (owner: 10Fomafix) [18:46:08] (03PS3) 10Cstone: Make phone number mandatory for India payment forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1065236 (https://phabricator.wikimedia.org/T373060) (owner: 10Jgleeson) [18:46:43] (03PS6) 10Eileen: Add in subset name resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1059523 [18:46:45] (03CR) 10Ejegg: [C:03+2] Add in subset name resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1059523 (owner: 10Eileen) [18:46:58] (03PS4) 10Eileen: Remove no longer used property in deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064148 [18:47:02] (03CR) 10Ejegg: [C:03+2] Remove no longer used property in deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064148 (owner: 10Eileen) [18:49:22] (03Merged) 10jenkins-bot: Use overrideConfigValue/overrideConfigValues instead of setMwGlobals [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1059880 (owner: 10Fomafix) [19:06:39] (03Merged) 10jenkins-bot: Add in subset name resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1059523 (owner: 10Eileen) [19:07:33] (03Merged) 10jenkins-bot: Remove no longer used property in deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064148 (owner: 10Eileen) [19:08:13] 06Fundraising-Backlog: Adding a field for last 4 digits of CC number - https://phabricator.wikimedia.org/T373061#10088794 (10AKanji-WMF) a:05Eileenmcnaughton→03None [19:23:25] thanks ejegg [19:48:36] (03PS17) 10Damilare Adedoyin: Setup 3DS Flow [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1060129 (https://phabricator.wikimedia.org/T367786) [20:16:05] oh dang! I overwrote a tag in SmashPig [20:16:35] The last tag I saw on master was 0.8.11.1 so I tagged & pushed 0.8.11.2 [20:16:44] but on packagist I see 0.8.11.3! [20:17:01] so... did it get tagged against deploy maybe? [20:18:14] ah dang, i guess I just didn't fetch that tag when I pulled [20:18:16] that's odd [20:18:45] did you already push the tag up? [20:18:55] oh. yeah. i read that now. [20:19:02] yeah, but I think I can re-attach it to the right commit [20:19:03] hmmm... [20:19:09] yeah. you should be able to. [20:19:35] * dwisehaupt hasn't had the need to deal with tags much [20:20:42] ah phooey, gerrit won't accept a non-fast-forward push [20:20:54] well, are we actually using 0.8.11.2 anywhere? [20:23:35] hmph, yeah, Civi points to that [20:23:45] well, let's just update that pointer [20:25:32] hmm, deduper failing? [22:23:23] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1065290 [22:23:33] ejegg: I looked at that deduper fail [22:23:52] I resolved the contact - it was one with 2 addresses the same [22:24:39] I guess the question is whether the fix to the oddball you found would fix it - ie https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1064641/1 [22:25:06] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1065290 (owner: 10Eileen) [22:26:00] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1065290 (owner: 10Eileen) [22:26:48] !log civicrm upgraded from e629834c to 75c86184 (that didn't turn out to have anything relevant to the new deduper error) [22:26:50] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:45:49] (03PS7) 10Eileen: Move support for full_name to the api layer (deduper extension) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064149 (https://phabricator.wikimedia.org/T370469) [23:45:50] (03CR) 10Ejegg: [C:03+2] Move support for full_name to the api layer (deduper extension) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064149 (https://phabricator.wikimedia.org/T370469) (owner: 10Eileen)