[01:58:20] 06Fundraising-Backlog: Add autorescue for ideal - https://phabricator.wikimedia.org/T360931#10169910 (10Cstone) 05Open→03Invalid duplicate of {T362575} [02:06:30] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: reasonablyAccurate(), 06Fundraising-Backlog: Add Auto Rescue for SEPA Direct Debit - https://phabricator.wikimedia.org/T362575#10169917 (10Cstone) a:05Cstone→03None [02:06:36] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: reasonablyAccurate(), 06Fundraising-Backlog: Add Auto Rescue for SEPA Direct Debit - https://phabricator.wikimedia.org/T362575#10169915 (10Cstone) [02:31:48] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Relocate servers in C8 to make room for new Network devices - https://phabricator.wikimedia.org/T373893#10169921 (10Papaul) 05Open→03Resolved This is complete, thanks @Dwisehaupt @Jhancock.wm [02:33:31] 10fundraising-tech-ops, 06DC-Ops, 06Infrastructure-Foundations, 10netops, and 2 others: codfw:frack:rack/install/configuration new switches - https://phabricator.wikimedia.org/T374587#10169923 (10Papaul) [02:35:08] 10fundraising-tech-ops, 06DC-Ops, 06Infrastructure-Foundations, 10netops, and 2 others: codfw:frack:rack/install/configuration new switches - https://phabricator.wikimedia.org/T374587#10169924 (10Papaul) [02:46:09] 10fundraising-tech-ops, 06DC-Ops, 06Infrastructure-Foundations, 10netops, and 2 others: codfw:frack:rack/install/configuration new switches - https://phabricator.wikimedia.org/T374587#10169925 (10Papaul) [10:10:09] 03Fundraising Sprint: reasonablyAccurate(), 06Fundraising-Backlog, 10FR-donorservices: Civi "thank you letter summary" feature request - https://phabricator.wikimedia.org/T299096#10170596 (10CDenes_WMF) Thank you Eileen. Just to be clear-- no action is needed from Localization for non-English versions? [11:51:02] 06Fundraising-Backlog: Investigate Parallel PHPUnit runs on fr-tech projects - https://phabricator.wikimedia.org/T375491 (10jgleeson) 03NEW [11:56:41] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Civi1002 can't access Gravy Audit files hosted at storage.googleapis.com - https://phabricator.wikimedia.org/T375492 (10jgleeson) 03NEW [12:00:24] 06Fundraising-Backlog, 07payments-orchestration: Pending Transaction Resolver support for Gravy - https://phabricator.wikimedia.org/T374051#10170902 (10jgleeson) a:03jgleeson [12:02:26] 03Fundraising Sprint: reasonablyAccurate(), 06Fundraising-Backlog, 07payments-orchestration: Pending Transaction Resolver support for Gravy - https://phabricator.wikimedia.org/T374051#10170905 (10jgleeson) [12:03:57] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Pending transaction resolver resolving multiple in a short time period - https://phabricator.wikimedia.org/T375397#10170908 (10jgleeson) [13:30:17] (03PS2) 10Jgleeson: Remove payment method mismatch check in base audit processor. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075041 (https://phabricator.wikimedia.org/T373492) [13:30:17] (03PS1) 10Jgleeson: Small test method rename for clarity. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075232 (https://phabricator.wikimedia.org/T375397) [13:30:18] (03PS1) 10Jgleeson: Test to Probe broken $alreadyResolved check. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075233 (https://phabricator.wikimedia.org/T375397) [13:32:27] ejegg: i think we might need to move the $alreadyChecked array up a level [13:32:47] we seem to be losing the contents of it after each call of ::execute [13:33:13] regarding https://phabricator.wikimedia.org/T375397 [13:33:41] I checked one of the affected records and we processed it 4 times in the same pend trxn resolver run and they all shared the same email [13:34:00] I'll try it out now [13:36:44] oh ok it looks like we are setting it here https://github.com/wikimedia/wikimedia-fundraising-crm/blob/808e367a40da88e7dc4d624396137b285f7fef05/drupal/sites/default/civicrm/extensions/wmf-civicrm/Civi/Api4/Action/PendingTable/Consume.php#L78 [13:37:05] let's see why that's not working [13:38:15] yeah, I was looking over that code yesterday and I couldn't find an issue... [13:39:03] the status and email keys get set, right? [13:39:14] just writing a test to confirm [13:39:32] ooh, are we looping with the wrong construct? [13:39:44] foreach ($this->alreadyResolved as $orderId => $alreadyResolved) { [13:39:47] but.... [13:40:07] $resolvedDetails[] = $resolveResult; [13:40:12] so maybe no key [13:41:15] ahhhh [13:41:24] array is the wrong shape [13:42:09] result = [['123']=>['email' => 'blah@localhost', 'status' => 'completed']] [13:42:28] err, something like that [13:42:41] anyway, there's an outer array with just numeric keys [13:43:00] and each entry is an key=>value array with a single key and a single value [13:43:26] result = [['123'=>['email' => 'blah@localhost', 'status' => 'completed']] [13:43:31] ] [13:44:11] ok, so we don't need the order ID in that alreadyResolved thing [13:45:16] I won't do any code changes now though, since it'll be much nicer to have your test [13:46:13] yeah I could have sworn we added a test for this level but we didn't [13:46:26] we added some checks on the pending db messages but not a run through of the entrypoint [13:47:50] (03CR) 10CI reject: [V:04-1] Test to Probe broken $alreadyResolved check. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075233 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [13:48:00] I think there's a few things with this array structure that might be tripping us up [13:48:13] this is the return value of the call [13:48:15] $result = {Civi\Api4\Generic\Result} [13:48:17] entity = "PendingTransaction" [13:48:19] action = "resolve" [13:48:21] debug = null [13:48:23] version = {int} 4 [13:48:25] rowCount = null [13:48:27] matchedCount = null [13:48:29] indexedBy = null [13:48:31] *ArrayObject*storage = {array[1]} [13:48:33] order-783330943 = {array[4]} [13:48:35] email = "test@example.org" [13:48:37] gateway_txn_id = "384301566" [13:48:39] status = "cancelled" [13:48:41] risk_scores = {array[0]} [13:48:43] that key won't match like you say [13:48:49] and we'll be lucky if it just pulls out that ArrayObject from the result [13:54:07] so the Result class is iterable, which was letting us iterate over it [13:54:27] but the keys were just the numeric keys of the outside bit [13:56:15] I think if we just add $result[0] to the $resolvedDetails it'll work [13:56:27] i.e. $resolvedDetails += $result[0] [13:57:10] then the loop in the inner bit will get the right values assigned to $orderId and $alreadyResolved [13:57:43] we could make it more efficient by indexing the outer array by email [13:58:12] and only storing completed resolved things [13:58:18] ok cool. it looks like we could do with a test or two here so I'll add those and we can then confirm the issue and you could push up the fix [13:58:29] sounds great! thank you [13:58:37] just gonna grab the kids. back soon [14:15:36] (03CR) 10Ejegg: [C:04-1] "Thanks! I think we need to do the test on the actual Consume action and just rely on those mock method call assumptions to assure ourselve" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075233 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [14:18:31] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 11236 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [14:18:59] (03PS1) 10Ejegg: Fix duplicate pending resolver check [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075243 (https://phabricator.wikimedia.org/T375397) [14:23:33] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 4828 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [14:28:33] RECOVERY - check_mysql on frdb1004 is OK: Uptime: 2988801 Threads: 5 Questions: 368621164 Slow queries: 1414 Opens: 3469 Open tables: 1183 Queries per second avg: 123.334 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 420 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [14:37:44] (03CR) 10CI reject: [V:04-1] Fix duplicate pending resolver check [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075243 (https://phabricator.wikimedia.org/T375397) (owner: 10Ejegg) [14:40:27] (03CR) 10Ejegg: [C:03+2] Remove payment method mismatch check in base audit processor. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075041 (https://phabricator.wikimedia.org/T373492) (owner: 10Jgleeson) [14:40:54] (03CR) 10Ejegg: [C:03+2] Small test method rename for clarity. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075232 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [14:50:14] ah yeah ejegg that was the old test just to confirm at that level but then I realised it needed to be higher [14:50:32] the idea being, it should fail [14:50:43] just to demonstrate where it was [14:50:50] but yeah I'll abandon it as it's not there [14:50:56] (03Abandoned) 10Jgleeson: Test to Probe broken $alreadyResolved check. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075233 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [14:58:39] (03Merged) 10jenkins-bot: Remove payment method mismatch check in base audit processor. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075041 (https://phabricator.wikimedia.org/T373492) (owner: 10Jgleeson) [14:59:01] (03Merged) 10jenkins-bot: Small test method rename for clarity. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075232 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [15:01:13] (03PS1) 10Damilare Adedoyin: Prevent capture from Gravy listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1075251 [15:08:44] thanks jgleeson - so this I think should work, but I haven't smoketested yet: https://gerrit.wikimedia.org/r/1075243 [15:09:03] lemme just crank up the fraud filters on my local [15:11:27] getting weird test errors relted to local setup [15:11:29] SQLSTATE[HY000]: General error: 1 duplicate column name: payment_method [15:11:35] ohhh [15:11:44] looks like the testing init stuff [15:11:59] fleshing out the smashpig schema [15:12:45] Ahh, make sure you're not trying to create the tables again before dropping them [15:12:53] maybe doing an extra init? [15:13:26] the base tests cases should be doing all the init you need [15:13:56] We could also consolidate the schema scripts [15:13:57] I think the teardown is missing TestingDatabase::clearStatics(); [15:14:04] ah maybe [15:14:16] that's not in the base teardown? [15:14:22] ok that fixed it [15:14:33] this test doesn't extend a base class [15:14:42] ah got it [15:14:55] https://github.com/wikimedia/wikimedia-fundraising-crm/blob/e6ffcdb54d59b1063647ea94e0d968e9685dea96/drupal/sites/default/civicrm/extensions/wmf-civicrm/tests/phpunit/Civi/Api4/Action/PendingTable/ConsumeTest.php#L17 [15:15:53] looks like we could do with adding one for them all [15:15:55] https://github.com/wikimedia/wikimedia-fundraising-crm/blob/e6ffcdb54d59b1063647ea94e0d968e9685dea96/drupal/sites/default/civicrm/extensions/wmf-civicrm/tests/phpunit/Civi/Api4/Action/PendingTransaction/Ingenico/IngenicoResolveTest.php#L29 [15:16:27] we'e got that BaseWmfDrupalPhpUnitTestCase [15:16:41] but 'Drupal' is out of style these days [15:16:50] ha [15:17:31] ok it's working now so let's see what we get [15:23:20] (03CR) 10Jforrester: [C:03+2] specials: Get global via IContextSource::getConfig [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/1073519 (owner: 10Umherirrender) [15:24:03] (03CR) 10Jforrester: [C:03+2] specials: Get global via IContextSource::getConfig [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1073547 (owner: 10Umherirrender) [15:24:40] (03CR) 10Jforrester: [C:03+2] specials: Get global via IContextSource::getConfig [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1073527 (owner: 10Umherirrender) [15:29:46] (03Merged) 10jenkins-bot: specials: Get global via IContextSource::getConfig [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/1073519 (owner: 10Umherirrender) [15:34:29] (03Merged) 10jenkins-bot: specials: Get global via IContextSource::getConfig [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1073547 (owner: 10Umherirrender) [15:34:54] (03Merged) 10jenkins-bot: specials: Get global via IContextSource::getConfig [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1073527 (owner: 10Umherirrender) [15:37:27] 06Fundraising-Backlog: Investigate Parallel PHPUnit runs on fr-tech projects - https://phabricator.wikimedia.org/T375491#10172075 (10Reedy) [15:38:49] 06Fundraising-Backlog: Investigate Parallel PHPUnit runs on fr-tech projects - https://phabricator.wikimedia.org/T375491#10172076 (10Reedy) [15:43:13] 06Fundraising-Backlog: Investigate Parallel PHPUnit runs on fr-tech projects - https://phabricator.wikimedia.org/T375491#10172087 (10Reedy) Just for cross referencing, it's (currently) disabled in `REL1_XX` release branches (which the FR MW side builds ontop of `REL1_39` as an LTS). I think there'd need to be at... [15:43:19] (03PS1) 10Reedy: Test [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1075260 [15:44:34] (03CR) 10Reedy: "Guessing that's what https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1074219 is intended to try and fix..." [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1067358 (https://phabricator.wikimedia.org/T370380) (owner: 10Krinkle) [15:47:09] (03CR) 10Krinkle: "My understanding, basedon https://gerrit.wikimedia.org/r/q/project:mediawiki/core+branch:fundraising/REL1_39, is that failing lock check i" [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1067358 (https://phabricator.wikimedia.org/T370380) (owner: 10Krinkle) [15:49:21] (03PS2) 10Umherirrender: Use ::class for class name resolution [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1074563 [15:49:22] (03CR) 10Ejegg: [C:03+2] Use ::class for class name resolution [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1074563 (owner: 10Umherirrender) [15:50:12] 10fundraising-tech-ops, 06DC-Ops, 06Infrastructure-Foundations, 10netops, and 2 others: codfw:frack:rack/install/configuration new switches - https://phabricator.wikimedia.org/T374587#10172139 (10Papaul) [15:50:19] (03CR) 10Ejegg: [V:03+2] build: Updating micromatch to 4.0.8 [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/1066374 (owner: 10Libraryupgrader) [15:50:34] (03CR) 10Ejegg: [V:03+2] build: Updating micromatch to 4.0.8 [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/1066375 (owner: 10Libraryupgrader) [15:50:57] (03CR) 10Ejegg: [V:03+2] build: Updating micromatch to 4.0.8 [extensions/DonationInterface] (REL1_42) - 10https://gerrit.wikimedia.org/r/1066376 (owner: 10Libraryupgrader) [15:52:17] (03CR) 10CI reject: [V:04-1] Test [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1075260 (owner: 10Reedy) [16:03:05] (03PS3) 10Ejegg: Simplify unsubscribe token using prefs crt link [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1073512 (https://phabricator.wikimedia.org/T223330) [16:04:13] So... maybe we want to have an unsubscribe form that still works without CiviProxy / Civi being up? [16:05:09] gonna go get lunch and think about that [16:26:19] 06Fundraising-Backlog: Investigate Parallel PHPUnit runs on fr-tech projects - https://phabricator.wikimedia.org/T375491#10172283 (10Reedy) Though, it's not running on MW core currently, so that probably isn't an issue (yet)... [16:55:48] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1074563 (owner: 10Umherirrender) [17:14:01] (03PS4) 10Ejegg: Simplify unsubscribe token using prefs ctr link [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1073512 (https://phabricator.wikimedia.org/T223330) [17:18:34] (03PS2) 10Ejegg: Get email prefs for merged contact ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1073822 (https://phabricator.wikimedia.org/T375089) [17:18:35] (03PS2) 10Ejegg: Deal with merged contacts in Preferenes queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1073843 (https://phabricator.wikimedia.org/T375089) [17:56:07] 06Fundraising-Backlog: Monthly convert buttons leave modal area on smaller phone screens - https://phabricator.wikimedia.org/T375545 (10Cstone) 03NEW [17:56:50] 03Fundraising Sprint: reasonablyAccurate(), 06Fundraising-Backlog, 10Recurring-Donations: Implement Post-Payment Monthly Convert variant for testing - https://phabricator.wikimedia.org/T371523#10172546 (10Cstone) @spatton the two issues found here are longstanding bugs and not because of the variant, I made... [17:59:23] ejegg: are we still holding off on deploying civi? [18:05:12] cstone I guess we can deploy that prefs center link... [18:06:37] jgleeson: were you planning to make a new test for the Consume level? Or should I go ahead and add that to the patch with the fix? [18:14:29] (03PS2) 10Ejegg: Fix duplicate pending resolver check [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075243 (https://phabricator.wikimedia.org/T375397) [18:15:38] (03PS3) 10Ejegg: Fix dynamic property declaration warnings [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1067419 [18:18:34] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Uptick in Dutch donors experiencing issues donating - https://phabricator.wikimedia.org/T372571#10172596 (10Cstone) Moving to done as issues reporting this has slowed down, Amber said ~2-3 since banners went live. We'll make a new phab if it comes back [18:21:39] (03PS1) 10Jgleeson: Refactor pending transaction resolver code to improve testability. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075290 (https://phabricator.wikimedia.org/T375397) [18:21:41] (03PS1) 10Jgleeson: Add missing tearDown clean up to ConsumeTest.php [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075291 (https://phabricator.wikimedia.org/T375397) [18:26:05] (03PS2) 10Jgleeson: Refactor pending transaction resolver code to improve testability. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075290 (https://phabricator.wikimedia.org/T375397) [18:26:05] (03PS2) 10Jgleeson: Add missing tearDown clean up to ConsumeTest.php [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075291 (https://phabricator.wikimedia.org/T375397) [18:26:05] (03PS1) 10Jgleeson: Add test to probe Pending Transaction Resolver code handling of duplicate emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075293 (https://phabricator.wikimedia.org/T375397) [18:27:05] ejegg: after a lot more hassle than it was probably worth, I've got a test confirm the current code is mireading the array https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1075293 [18:27:15] confirming* [18:27:52] so I guess now I could rebase that chain over your fix and see if it fixes things [18:27:55] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Tech-Analytics, 10FR-tech-data-integrity: New Donors Donating On Email - https://phabricator.wikimedia.org/T356911#10172623 (10Cstone) a:05Cstone→03None [18:29:58] the asserts on this test here are where you see the array is not what we think https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1075293/1/drupal/sites/default/civicrm/extensions/wmf-civicrm/tests/phpunit/Civi/Api4/Action/PendingTable/ConsumeTest.php#98 [18:30:41] great jgleeson ! [18:31:07] after another whole lot of hassle I managed to smoke test the fix and confirmed it works :) [18:31:15] ah nice [18:31:26] needed to tweak fraud filters more than I hoped [18:31:29] hopefully those two independant whole lot of hassles will line up nicely then ! [18:32:09] and had to manipulate an existing some older test data to get a matching donor record in the db (but without donations from today) [18:34:14] (03CR) 10CI reject: [V:04-1] Fix duplicate pending resolver check [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075243 (https://phabricator.wikimedia.org/T375397) (owner: 10Ejegg) [18:34:21] oh dang! [18:34:33] let's see what that V-1 is [18:35:13] oh I see I need to change the alreadyResolved value passed in [18:35:37] hope that doesn't conflict too much with your test stuff [18:35:53] well, let me just review your cleanup patches before I touch that code [18:38:43] (03CR) 10Ejegg: [C:04-1] "I don't think it makes sense to have the resolvedDetails as an input parameter to this API action - that's what all the rest of the setter" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075290 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [18:38:57] hmm, I guess it wouldn't conflict [18:41:15] (03PS3) 10Ejegg: Fix duplicate pending resolver check [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075243 (https://phabricator.wikimedia.org/T375397) [18:42:16] ejegg: I could probably get rid of those API @methods [18:42:40] I think I just added that to have a getter from in the test [18:42:57] would a normal getter be ok? [18:44:05] also I found some weird civi internal behaviour when it was trying to parse the '?string' and '?array' @var tags [18:44:15] it looks like they aren't supported [18:46:29] (03CR) 10CI reject: [V:04-1] Add test to probe Pending Transaction Resolver code handling of duplicate emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075293 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [18:46:39] ah yeah, maybe too much magic [18:46:50] it also barfed on my @var array [18:47:14] so that test is failing as expected now [18:47:36] I guess I thought it might be useful to set a breakpoint at the point it checks the array to see the underlying bug [18:47:53] although writing tests to confirm problems doesn't work well with our CI model [18:49:06] lemme try rebasing over your code, or did you already try that and hit conflicts [18:51:00] (03CR) 10Jgleeson: Refactor pending transaction resolver code to improve testability. (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075290 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [18:51:02] nope, I haven't tried [18:51:36] ok. I'll fix those API tags on the resolvedItems array first and then try that [18:55:08] (03PS3) 10Jgleeson: Refactor pending transaction resolver code to improve testability. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075290 (https://phabricator.wikimedia.org/T375397) [18:55:43] (03PS3) 10Jgleeson: Add missing tearDown clean up to ConsumeTest.php [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075291 (https://phabricator.wikimedia.org/T375397) [18:55:48] (03PS2) 10Jgleeson: Add test to probe Pending Transaction Resolver code handling of duplicate emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075293 (https://phabricator.wikimedia.org/T375397) [19:04:35] hmm that change broke the test [19:06:41] (03CR) 10Jgleeson: Add missing tearDown clean up to ConsumeTest.php (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075291 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [19:07:34] 03Fundraising Sprint: reasonablyAccurate(), 06Fundraising-Backlog, 07payments-orchestration: Gravy Refunds - https://phabricator.wikimedia.org/T367808#10172767 (10XenoRyet) 05Open→03Resolved [19:07:58] 03Fundraising Sprint: reasonablyAccurate(), 06Fundraising-Backlog, 07payments-orchestration: Gravy Audit/Settlement Multi-Processor strategy - https://phabricator.wikimedia.org/T371812#10172770 (10XenoRyet) 05Open→03Resolved [19:08:57] 03Fundraising Sprint: reasonablyAccurate(), 06Fundraising-Backlog, 10FR-Smashpig, 07payments-orchestration: Update Adyen listener to deal with Gravy transactions - https://phabricator.wikimedia.org/T372508#10172774 (10XenoRyet) 05Open→03Resolved [19:09:19] 03Fundraising Sprint: reasonablyAccurate(), 06Fundraising-Backlog, 10FR-Smashpig, 13Patch-For-Review: Migrate remaining jobs off JsonSerializableObject - https://phabricator.wikimedia.org/T366367#10172778 (10XenoRyet) 05Open→03Resolved [19:11:29] 03Fundraising Sprint: reasonablyAccurate(), 06Fundraising-Backlog, 10FR-WMF-Audit, 13Patch-For-Review, 07payments-orchestration: Update Adyen audit parser to deal with Gravy transactions - https://phabricator.wikimedia.org/T372509#10172780 (10XenoRyet) 05Open→03Resolved [19:12:24] 03Fundraising Sprint: reasonablyAccurate(), 06Fundraising-Backlog, 07payments-orchestration: Gravy SEPA (Trustly) - https://phabricator.wikimedia.org/T371811#10172790 (10XenoRyet) 05Stalled→03Declined [19:12:26] 03Fundraising Sprint: reasonablyAccurate(), 06Fundraising-Backlog, 07FR-Imports, 07Unplanned-Sprint-Work: Fidelity import - addressee issue testing - https://phabricator.wikimedia.org/T373484#10172789 (10Eileenmcnaughton) @MDemosWMF closing this as I created a new phab for the outstanding part [19:12:31] 03Fundraising Sprint: reasonablyAccurate(), 06Fundraising-Backlog, 07FR-Imports, 07Unplanned-Sprint-Work: Fidelity import - addressee issue testing - https://phabricator.wikimedia.org/T373484#10172787 (10XenoRyet) 05Open→03Resolved [19:13:02] 03Fundraising Sprint: reasonablyAccurate(), 06Fundraising-Backlog: Gravy Adyen test rollout plan - https://phabricator.wikimedia.org/T372469#10172792 (10XenoRyet) 05Open→03Resolved [19:13:50] 03Fundraising Sprint: reasonablyAccurate(), 06Fundraising-Backlog, 13Patch-For-Review, 07payments-orchestration: Create jobs for the events pushed to the jobs-gravy queue - https://phabricator.wikimedia.org/T370797#10172783 (10XenoRyet) 05Open→03Resolved [19:13:56] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Smashpig: CZ online banking broken since iDeal 2.0 update - https://phabricator.wikimedia.org/T374564#10172797 (10XenoRyet) 05Open→03Resolved [19:16:13] (03CR) 10CI reject: [V:04-1] Add test to probe Pending Transaction Resolver code handling of duplicate emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075293 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [19:16:17] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Uptick in Dutch donors experiencing issues donating - https://phabricator.wikimedia.org/T372571#10172805 (10XenoRyet) 05Open→03Resolved [19:16:30] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Paypal Meltdown - https://phabricator.wikimedia.org/T375255#10172811 (10XenoRyet) 05Open→03Resolved [19:16:37] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Paypal Giving Fund gift going to wrong CID - https://phabricator.wikimedia.org/T373542#10172814 (10XenoRyet) 05Open→03Resolved [19:16:41] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: ACH address setting N/A in civi instead of empty data - https://phabricator.wikimedia.org/T372482#10172818 (10XenoRyet) 05Open→03Resolved [19:16:53] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Smashpig, 10Recurring-Donations: Adyen error code 703 crashes recurring charge job - https://phabricator.wikimedia.org/T360399#10172821 (10XenoRyet) 05Open→03Resolved [19:41:27] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06MediaWiki-Platform-Team, 10MediaWiki-Vendor, and 3 others: mediawiki/core and mediawiki/vendor both skip composer.lock checks - https://phabricator.wikimedia.org/T370380#10172891 (10AKanji-WMF) [19:41:50] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06MediaWiki-Platform-Team, 10MediaWiki-Vendor, and 3 others: mediawiki/core and mediawiki/vendor both skip composer.lock checks - https://phabricator.wikimedia.org/T370380#10172892 (10AKanji-WMF) [19:42:54] 06Fundraising-Backlog, 07FR-Imports: Record duplicates when processing Engage import - https://phabricator.wikimedia.org/T374063#10172894 (10EMartin) @Eileenmcnaughton @dkozlowski as we are heading into peak season, any thoughts on this? As things stand, we don't want the up front dedupe for peak season giv... [19:47:36] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10fundraising-tech-ops: Civi1002 can't access Gravy Audit files hosted at storage.googleapis.com - https://phabricator.wikimedia.org/T375492#10172898 (10AKanji-WMF) [19:48:37] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Monthly convert buttons leave modal area on smaller phone screens - https://phabricator.wikimedia.org/T375545#10172918 (10AKanji-WMF) [19:50:06] ejegg: where's your patch [19:50:13] I'll try the rebase [20:12:20] jgleeson|away: https://gerrit.wikimedia.org/r/1075243 [20:29:19] thanks ejegg [20:29:32] phew, bag was still in the class room [20:29:40] why does it feel like 2/3 of the time I spend on Acoustic is dealing with their logins! [20:30:19] argh conflcits [20:33:42] (03PS4) 10Ejegg: Fix duplicate pending resolver check [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075243 (https://phabricator.wikimedia.org/T375397) [20:56:23] (03PS4) 10Jgleeson: Refactor pending transaction resolver code to improve testability. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075290 (https://phabricator.wikimedia.org/T375397) [20:56:23] (03PS4) 10Jgleeson: Add missing tearDown clean up to ConsumeTest.php [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075291 (https://phabricator.wikimedia.org/T375397) [21:01:28] (03PS4) 10Jgleeson: Add test to probe Pending Transaction Resolver code handling of duplicate emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075293 (https://phabricator.wikimedia.org/T375397) [21:01:44] ok ejegg that test is passing now locally for me with your changes! [21:01:58] I see two trxns processed and only one completed [21:02:10] although the test I added seems a little flakey [21:03:22] (03Abandoned) 10Jgleeson: Add missing tearDown clean up to ConsumeTest.php [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075291 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [21:05:52] (03PS5) 10Jgleeson: Refactor pending transaction resolver code to improve testability. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075290 (https://phabricator.wikimedia.org/T375397) [21:07:33] (03PS5) 10Jgleeson: Add test to probe Pending Transaction Resolver code handling of duplicate emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075293 (https://phabricator.wikimedia.org/T375397) [21:12:29] ok that'll do for tonight [21:12:32] catch you all tomorrow [21:14:37] (03CR) 10CI reject: [V:04-1] Add test to probe Pending Transaction Resolver code handling of duplicate emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075293 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [21:29:36] (03CR) 10CI reject: [V:04-1] Add test to probe Pending Transaction Resolver code handling of duplicate emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075293 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [21:33:13] (03CR) 10Ejegg: [C:03+2] Refactor pending transaction resolver code to improve testability. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075290 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [22:07:39] (03PS7) 10Eileen: Fix import to handle creating new donor advised organizations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1073930 (https://phabricator.wikimedia.org/T375039) [22:07:41] (03CR) 10Ejegg: [C:03+2] Fix import to handle creating new donor advised organizations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1073930 (https://phabricator.wikimedia.org/T375039) (owner: 10Eileen) [22:09:03] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10fundraising-tech-ops: Civi1002 can't access Gravy Audit files hosted at storage.googleapis.com - https://phabricator.wikimedia.org/T375492#10173436 (10Dwisehaupt) There is a bit of a concern that google colocates many of its api hosts on the same ip a... [22:13:48] (03PS1) 10Ejegg: Revert "Use epc as unsubscribe url for thank you email" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075325 [22:15:53] (03CR) 10Cstone: [C:03+2] Revert "Use epc as unsubscribe url for thank you email" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075325 (owner: 10Ejegg) [22:21:11] (03CR) 10Cstone: [C:03+2] Fix dynamic property declaration warnings [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1067419 (owner: 10Ejegg) [22:26:55] (03Merged) 10jenkins-bot: Fix import to handle creating new donor advised organizations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1073930 (https://phabricator.wikimedia.org/T375039) (owner: 10Eileen) [22:35:39] (03Merged) 10jenkins-bot: Revert "Use epc as unsubscribe url for thank you email" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075325 (owner: 10Ejegg) [22:35:40] (03Merged) 10jenkins-bot: Fix dynamic property declaration warnings [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1067419 (owner: 10Ejegg) [22:44:41] 06Fundraising-Backlog: Foundation logo overlapping monthly convert modal in smaller screen sizes - https://phabricator.wikimedia.org/T374074#10173582 (10EWilfong_WMF) @spatton asked me to take a look at this issue. The simplest fix is to move the modal HTML to the bottom of the document. This will fix the issu... [22:49:29] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Monthly convert buttons leave modal area on smaller phone screens - https://phabricator.wikimedia.org/T375545#10173612 (10EWilfong_WMF) If you add a max-width: 100%; property to the .mc-button style definition it will fix this issue. Note that .mc-butt... [23:16:28] 06Fundraising-Backlog, 10fundraising-tech-ops: Restore civicrm DBs on the frack staging db host - https://phabricator.wikimedia.org/T375578 (10Dwisehaupt) 03NEW [23:17:13] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 10FR-Civi-Dedupe, 07Unplanned-Sprint-Work: Sandra can't dedupe Name + address matching contacts (no email match) - https://phabricator.wikimedia.org/T353971#10173693 (10AKanji-WMF) [23:17:14] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 07payments-orchestration: Gravy Paypal Investigation - https://phabricator.wikimedia.org/T375378#10173694 (10AKanji-WMF) [23:17:15] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 07payments-orchestration: Gravy Braintree implementation: Venmo - https://phabricator.wikimedia.org/T375267#10173695 (10AKanji-WMF) [23:17:16] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 07payments-orchestration: Gravy Braintree implementation: Paypal - https://phabricator.wikimedia.org/T375266#10173696 (10AKanji-WMF) [23:17:18] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 07payments-orchestration: Set up production Gravy Adyen 3DSecure Scheme config - https://phabricator.wikimedia.org/T375214#10173697 (10AKanji-WMF) [23:17:19] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog: Updating gift coding for Paypal Giving Fund - https://phabricator.wikimedia.org/T375131#10173698 (10AKanji-WMF) [23:17:22] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-email-preferences, 13Patch-For-Review: Donor prefs page and consumer should function correctly when contact has been merged after link sent - https://phabricator.wikimedia.org/T375089#10173699 (10AKanji-WMF) [23:17:25] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 07FR-Imports, 07Unplanned-Sprint-Work: Add support to create organization when importing fidelity - https://phabricator.wikimedia.org/T375039#10173700 (10AKanji-WMF) [23:17:29] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 07payments-orchestration: Gravy Audit/Settlement Processing (refunds) - https://phabricator.wikimedia.org/T374947#10173701 (10AKanji-WMF) [23:17:33] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Civi point version update - https://phabricator.wikimedia.org/T374485#10173702 (10AKanji-WMF) [23:17:41] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 07payments-orchestration: Pending Transaction Resolver support for Gravy - https://phabricator.wikimedia.org/T374051#10173704 (10AKanji-WMF) [23:17:45] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 07payments-orchestration: Add refund activity with refund reason - https://phabricator.wikimedia.org/T373555#10173705 (10AKanji-WMF) [23:17:49] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 10FR-WMF-Audit: Audit: Let transactions change payment methods from contribution_tracking to final payment - https://phabricator.wikimedia.org/T373492#10173706 (10AKanji-WMF) [23:17:53] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog: Annual Recurring - Tagging and segmenting in Civi and Acoustic - https://phabricator.wikimedia.org/T372378#10173707 (10AKanji-WMF) [23:17:57] 06Fundraising-Backlog, 10fundraising-tech-ops: Restore civicrm DBs on the frack staging db host - https://phabricator.wikimedia.org/T375578#10173709 (10Dwisehaupt) Copied the backups over and started the restore. ` frdb1006:/srv/db_restore# /usr/local/bin/staging_db_refresh You are looking to load the followin... [23:18:03] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 10MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), 07payments-orchestration: Gravy ACH (Trustly) - https://phabricator.wikimedia.org/T371810#10173710 (10AKanji-WMF) [23:18:07] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 10FR-Batch-Data-Entry: Batch data entry feature request: Add Fee total and Net total - https://phabricator.wikimedia.org/T371545#10173711 (10AKanji-WMF) [23:18:11] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Switch Acoustic mapping to use the API to define the columns - https://phabricator.wikimedia.org/T368470#10173712 (10AKanji-WMF) [23:18:15] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 07payments-orchestration: Gravy Audit/Settlement Processing (donations) - https://phabricator.wikimedia.org/T367788#10173713 (10AKanji-WMF) [23:18:19] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog: Need to not autocancel recurring iDEAL/SEPA chargebacks - https://phabricator.wikimedia.org/T366769#10173714 (10AKanji-WMF) [23:19:17] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog: Scoping: Supporting SMS campaign functionality in Acoustic - https://phabricator.wikimedia.org/T365826#10173719 (10AKanji-WMF) [23:19:19] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 10FR-donorservices: Civi Tag sync with Acoustic - feature request - https://phabricator.wikimedia.org/T366212#10173718 (10AKanji-WMF) [23:19:20] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: Sssss, 06Fundraising-Backlog: Add Auto Rescue for SEPA Direct Debit - https://phabricator.wikimedia.org/T362575#10173720 (10AKanji-WMF) [23:19:23] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog: Add comms preferences footer to all Civi-generated emails - https://phabricator.wikimedia.org/T359445#10173721 (10AKanji-WMF) [23:19:24] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog: Renew Paypal API Certificate by September 19, 2024 - https://phabricator.wikimedia.org/T348725#10173723 (10AKanji-WMF) [23:19:26] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 10FR-donorservices: Civi "thank you letter summary" feature request - https://phabricator.wikimedia.org/T299096#10173722 (10AKanji-WMF) [23:19:28] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 10Recurring-Donations: Implement Post-Payment Monthly Convert variant for testing - https://phabricator.wikimedia.org/T371523#10173725 (10AKanji-WMF) [23:19:32] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 07payments-orchestration: Investigate application of Gravy guest checkout - https://phabricator.wikimedia.org/T374461#10173726 (10AKanji-WMF) [23:19:38] 14Fundraising Sprint: didAnyoneTryThis(), 14Fundraising Sprint: justWork(), 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, and 4 others: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330#10173724 (10AKanji-WMF)