[02:17:47] (03PS1) 10Eileen: [WIP] Adjust donor_segment and donor_status calculations for annual donor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075665 (https://phabricator.wikimedia.org/T372378) [02:34:32] (03CR) 10CI reject: [V:04-1] [WIP] Adjust donor_segment and donor_status calculations for annual donor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075665 (https://phabricator.wikimedia.org/T372378) (owner: 10Eileen) [03:56:56] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog: Annual Recurring - Tagging and segmenting in Civi and Acoustic - https://phabricator.wikimedia.org/T372378#10178213 (10Eileenmcnaughton) @MSuijkerbuijk_WMF I did some work on this today the segment part is straight forward but there are some things to work th... [04:06:09] (03PS2) 10Eileen: [WIP] Adjust donor_segment and donor_status calculations for annual donor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075665 (https://phabricator.wikimedia.org/T372378) [04:30:11] (03CR) 10CI reject: [V:04-1] [WIP] Adjust donor_segment and donor_status calculations for annual donor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075665 (https://phabricator.wikimedia.org/T372378) (owner: 10Eileen) [05:14:36] 06Fundraising-Backlog: Assess appropriate domain for FRUP donate page - https://phabricator.wikimedia.org/T351647#10178227 (10MSuijkerbuijk_WMF) There's a possibility we might in the future, let me explore. Thanks [05:28:12] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations: Improvements to failed recurring charge logic - https://phabricator.wikimedia.org/T356073#10178230 (10MSuijkerbuijk_WMF) Any changes needed for this in timing of email? The Failure email is important to be kept and optimised (fyi... [09:18:44] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Pending transaction resolver resolving multiple in a short time period - https://phabricator.wikimedia.org/T375397#10178598 (10krobinson) Thanks @Ejegg ! That's great. [09:41:04] (03CR) 10Máté Szabó: [C:03+2] build: Update MediaWiki requirement to 1.43 [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1075566 (owner: 10Jforrester) [10:14:18] (03Merged) 10jenkins-bot: build: Update MediaWiki requirement to 1.43 [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1075566 (owner: 10Jforrester) [10:21:50] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Change donation error message for India - https://phabricator.wikimedia.org/T373813#10178815 (10krobinson) Related, the French error message suggests checks or money orders as alternative payment methods, which are not accepted. @AKanji-WMF - I'll add i... [11:45:06] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 07payments-orchestration: Switch Gravy Adyen monthly covert transactions to use card-on-file recurring model - https://phabricator.wikimedia.org/T375612#10178956 (10jgleeson) a:03jgleeson [11:53:33] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog: Delete payment token for Gravy Adyen trxns created during one-hour test - https://phabricator.wikimedia.org/T375734 (10jgleeson) 03NEW [11:55:15] damilare: did you think I should add another ticket related to this one https://phabricator.wikimedia.org/T375734 to update the Gravy PaymentProcessor so that when we call delete payment method / payment token, we also call the same method on the backend processor provider class, if we have it available. [11:56:10] yes I was thinking we should also ask for that feature on gravy jgleeson [11:56:28] the only issue I see with that is isn't not going to scale if we do it on our side [11:56:35] because if we delete a token on gravy, that should also have it deleted on the processor [11:56:48] yeah that might be better, get them to do it [11:57:03] yep [13:51:30] (03PS1) 10Jgleeson: Update composer.lock for smashpig v0.8.11.10 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1075923 [13:52:09] fr-tech I couldn't install payments locally due to a composer.json and composer.lock mismatch so I've pushed that up. has anyone else run into it ? [13:52:48] try resetting payments and installing to test [13:53:16] I get "ack@debian:~/fundraising-dev/src/payments$ composer install [13:53:18] > ComposerHookHandler::onPreInstall [13:53:20] Installing dependencies from lock file (including require-dev) [13:53:22] Verifying lock file contents can be installed on current platform. [13:53:24] - Required package "wikimedia/smash-pig" is in the lock file as "v0.8.11.9" but that does not satisfy your constraint "0.8.11.10". [13:53:26] This usually happens when composer files are incorrectly merged or the composer.json file is manually edited." [13:53:33] back soon [14:09:25] ooh nice catch jgleeson|skrun [14:30:46] nice jgleeson, guess the CI issue has been fixed that was blocking this: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1074219 [14:30:57] (03CR) 10Damilare Adedoyin: "Recheck" [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1074219 (owner: 10Damilare Adedoyin) [14:42:18] uh I don't understand why that's failing on mine [14:43:12] (03Abandoned) 10Damilare Adedoyin: Update composer lock for new smashpig version [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1074219 (owner: 10Damilare Adedoyin) [14:56:14] oh yeah that's weird [14:56:58] I'm sure there's a good reason that we don't have to spend time figuring out since we can merge this identical change that the gods seem to favour :D https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1075923 [15:10:30] (03PS4) 10Damilare Adedoyin: WIP: Setup Venmo and general redirect payment provider class for methods. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1075583 (https://phabricator.wikimedia.org/T375635) [15:10:58] (03CR) 10CI reject: [V:04-1] WIP: Setup Venmo and general redirect payment provider class for methods. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1075583 (https://phabricator.wikimedia.org/T375635) (owner: 10Damilare Adedoyin) [15:11:47] (03CR) 10Damilare Adedoyin: [C:03+2] Update composer.lock for smashpig v0.8.11.10 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1075923 (owner: 10Jgleeson) [15:12:02] ty damilare [15:12:21] the gods work in mysterious ways [15:12:33] indeed! :) [15:12:44] similar to xdebug [15:13:34] even the gods get confused on that sometimes [15:13:35] :) [15:15:06] haha [15:20:15] (03PS5) 10Damilare Adedoyin: WIP: Setup Venmo and general redirect payment provider class for methods. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1075583 (https://phabricator.wikimedia.org/T375635) [15:20:39] (03Merged) 10jenkins-bot: Update composer.lock for smashpig v0.8.11.10 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1075923 (owner: 10Jgleeson) [15:20:41] (03CR) 10CI reject: [V:04-1] WIP: Setup Venmo and general redirect payment provider class for methods. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1075583 (https://phabricator.wikimedia.org/T375635) (owner: 10Damilare Adedoyin) [15:21:36] (03PS6) 10Damilare Adedoyin: WIP: Setup Venmo and general redirect payment provider class for methods. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1075583 (https://phabricator.wikimedia.org/T375635) [15:47:01] (03CR) 10Cstone: "We rolled back the other patch as there were a bunch of other things we had to account for with it, one of them was if the unsubscribe for" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/994366 (https://phabricator.wikimedia.org/T223330) (owner: 10Wfan) [16:13:04] 10fundraising-tech-ops, 06DC-Ops, 06Infrastructure-Foundations, 10netops, and 3 others: codfw:frack:rack/install/configuration new switches - https://phabricator.wikimedia.org/T374587#10180446 (10Papaul) setup/configuration of both switches done. Just need to add the switches to monitoring was we have pfw1... [16:42:40] (03PS1) 10Matr1x: Convert styles to use LESS and make them dark-mode comptatible [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1075963 (https://phabricator.wikimedia.org/T367189) [16:44:23] (03CR) 10Pppery: [C:04-1] "This should be on the "Master" branch not the "wmf_deploy" branch." [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1075963 (https://phabricator.wikimedia.org/T367189) (owner: 10Matr1x) [16:45:29] (03CR) 10Pppery: [C:04-1] "(CentralNotice has a convoluted deployment structure - what happens is code gets merged to master as normal, then a second manual review a" [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1075963 (https://phabricator.wikimedia.org/T367189) (owner: 10Matr1x) [16:56:41] (03Abandoned) 10Matr1x: Convert styles to use LESS and make them dark-mode comptatible [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1075963 (https://phabricator.wikimedia.org/T367189) (owner: 10Matr1x) [16:56:58] (03PS1) 10Matr1x: Convert styles to use LESS and make them dark-mode comptatible [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1075966 (https://phabricator.wikimedia.org/T367189) [16:57:49] (03CR) 10Pppery: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1075966 (https://phabricator.wikimedia.org/T367189) (owner: 10Matr1x) [17:01:00] (03CR) 10CI reject: [V:04-1] Convert styles to use LESS and make them dark-mode comptatible [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1075966 (https://phabricator.wikimedia.org/T367189) (owner: 10Matr1x) [17:16:09] 14Fundraising Sprint: didAnyoneTryThis(), 14Fundraising Sprint: justWork(), 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, and 4 others: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330#10180702 (10AnnWF) We need to consider at least 2 edge... [17:21:26] 14Fundraising Sprint: didAnyoneTryThis(), 14Fundraising Sprint: justWork(), 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, and 4 others: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330#10180718 (10AnnWF) After talked with ejegg, we think it... [18:13:24] (03PS1) 10Ejegg: Add new fields for Giving Fund [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1075983 (https://phabricator.wikimedia.org/T375131) [18:13:51] (03CR) 10CI reject: [V:04-1] Add new fields for Giving Fund [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1075983 (https://phabricator.wikimedia.org/T375131) (owner: 10Ejegg) [18:14:46] (03PS2) 10Ejegg: Add new fields for Giving Fund [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1075983 (https://phabricator.wikimedia.org/T375131) [18:21:40] (03PS1) 10Wfan: Add refund reason to activity for adyen [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075985 (https://phabricator.wikimedia.org/T373555) [18:22:52] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 13Patch-For-Review, 07payments-orchestration: Add refund activity with refund reason - https://phabricator.wikimedia.org/T373555#10180894 (10AnnWF) @Cstone Only adyen have refund reason now, but we can ask if gr4vy can pass it too, also no info from who m... [18:25:10] (03PS1) 10Jgleeson: Add recurring model to Gravy frontend transactions. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1075986 (https://phabricator.wikimedia.org/T375612) [18:28:38] (03PS2) 10Wfan: Add refund reason to activity for adyen [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075985 (https://phabricator.wikimedia.org/T373555) [18:29:20] (03PS1) 10Jgleeson: Support Recurring Model: CardOnFile. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1075988 (https://phabricator.wikimedia.org/T375612) [18:29:46] (03CR) 10CI reject: [V:04-1] Support Recurring Model: CardOnFile. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1075988 (https://phabricator.wikimedia.org/T375612) (owner: 10Jgleeson) [18:29:48] (03PS2) 10Jgleeson: Add recurring model to Gravy frontend transactions. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1075986 (https://phabricator.wikimedia.org/T375612) [18:29:55] (03PS1) 10Ejegg: Merge branch 'REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1075989 [18:33:37] (03PS2) 10Jgleeson: Support Recurring Model: CardOnFile. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1075988 (https://phabricator.wikimedia.org/T375612) [18:48:14] (03PS3) 10Jgleeson: Add recurring model to Gravy frontend transactions. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1075986 (https://phabricator.wikimedia.org/T375612) [18:48:34] (03PS3) 10Jgleeson: Support Recurring Model: CardOnFile. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1075988 (https://phabricator.wikimedia.org/T375612) [18:48:40] (03CR) 10CI reject: [V:04-1] Add recurring model to Gravy frontend transactions. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1075986 (https://phabricator.wikimedia.org/T375612) (owner: 10Jgleeson) [18:48:42] (03CR) 10Ejegg: [C:03+2] Merge branch 'REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1075989 (owner: 10Ejegg) [18:49:00] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 13Patch-For-Review, 07payments-orchestration: Switch Gravy Adyen monthly covert transactions to use card-on-file recurring model - https://phabricator.wikimedia.org/T375612#10180945 (10jgleeson) To test this update, pull down [[ https://gerrit.wikimedia.o... [18:49:44] (03CR) 10Jgleeson: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1075986 (https://phabricator.wikimedia.org/T375612) (owner: 10Jgleeson) [18:53:17] (03PS4) 10Jgleeson: Support Recurring Model: CardOnFile. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1075988 (https://phabricator.wikimedia.org/T375612) [18:56:58] (03Merged) 10jenkins-bot: Merge branch 'REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1075989 (owner: 10Ejegg) [19:12:32] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06MediaWiki-Platform-Team, 10MediaWiki-Vendor, and 3 others: mediawiki/core and mediawiki/vendor both skip composer.lock checks - https://phabricator.wikimedia.org/T370380#10180983 (10Ejegg) Thanks for the suggestion, @Krinkle . I've just merged the R... [19:16:05] (03PS3) 10Krinkle: installer: Support MW_SKIP_EXTERNAL_DEPENDENCIES in update.php [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1067358 [19:16:22] (03Abandoned) 10Krinkle: installer: Support MW_SKIP_EXTERNAL_DEPENDENCIES in update.php [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1067358 (owner: 10Krinkle) [19:16:22] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 13Patch-For-Review: Updating gift coding for Paypal Giving Fund - https://phabricator.wikimedia.org/T375131#10181004 (10Ejegg) Side note - @NNichols / @MDemosWMF do we need to fix the value for Fund choice "Online Fundraising - CC-1005" ? Seems inconsisten... [19:45:22] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 13Patch-For-Review: Updating gift coding for Paypal Giving Fund - https://phabricator.wikimedia.org/T375131#10181068 (10MDemosWMF) Thanks @Ejegg for flagging - @NNichols can confirm when she's back in office [20:10:53] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 07FR-Imports, 07Unplanned-Sprint-Work: Add support to create organization when importing fidelity - https://phabricator.wikimedia.org/T375039#10181130 (10MDemosWMF) @Eileenmcnaughton Just tested it and seems to be working well with creating the relations... [20:14:57] (03PS1) 10Ejegg: Add new fields for Giving Fund (audit) [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1076022 (https://phabricator.wikimedia.org/T375131) [20:16:55] (03CR) 10CI reject: [V:04-1] Add new fields for Giving Fund (audit) [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1076022 (https://phabricator.wikimedia.org/T375131) (owner: 10Ejegg) [20:18:29] (03CR) 10Cstone: [C:03+2] "Sorry for the infinite wait! Since we rolled back the other one let's get this one out finally" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/994366 (https://phabricator.wikimedia.org/T223330) (owner: 10Wfan) [20:18:43] (03PS2) 10Ejegg: Add new fields for Giving Fund (audit) [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1076022 (https://phabricator.wikimedia.org/T375131) [20:19:52] TIL whitemail [20:22:27] yeah, weird, huh? [20:24:24] ejegg: I see 'Gift Type: Donor Advised Fund' in the ticket and 'out['Gift_Data.Campaign'] = 'Donor Advised Fund' # This field is labeled 'Gift Type'' in the code [20:24:46] how come we didn't wanna call it Gift_Data.Type [20:26:08] or a better question, how did you decide on Campaign? is that the campaign name on some layer? [20:27:52] unrelated tangent that gift/donation/contribution i think all means the same thing and i don't like that they are different names [20:28:25] lol [20:28:28] agreed [20:28:52] "and another thing..." [20:31:15] is campaign one of the new fields that got added i thnk? [20:31:47] oh no thats package and channel [20:31:48] wrong c [20:32:50] yeah I'm kinda reviewing blind of surrounding context here but sometimes that's not a bad thing [20:38:56] jgleeson: I think it was one of the old fields that got renamed in the UI but not in the table [20:44:46] gotcha [20:46:39] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 07FR-Imports, 07Unplanned-Sprint-Work: Add support to create organization when importing fidelity - https://phabricator.wikimedia.org/T375039#10181215 (10Eileenmcnaughton) @MDemosWMF that contact had a space in each of the supplemental address fields - I'... [20:47:34] (03CR) 10Jgleeson: [C:03+2] "LGTM!" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1076022 (https://phabricator.wikimedia.org/T375131) (owner: 10Ejegg) [20:48:47] 06Fundraising-Backlog: Have a nicer error page when checksum is invalid - https://phabricator.wikimedia.org/T375798 (10Cstone) 03NEW [20:49:07] (03Merged) 10jenkins-bot: Add new fields for Giving Fund (audit) [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1076022 (https://phabricator.wikimedia.org/T375131) (owner: 10Ejegg) [20:50:45] THanks, jgleeson [20:51:52] (03Merged) 10jenkins-bot: Set up unsubscribe for DonationInterface for remove FundraisingEmailUnsubscribe [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/994366 (https://phabricator.wikimedia.org/T223330) (owner: 10Wfan) [20:54:02] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 07FR-Imports, 07Unplanned-Sprint-Work: Add support to create organization when importing fidelity - https://phabricator.wikimedia.org/T375039#10181238 (10MDemosWMF) Ah ok, looks like it was something wrong with my test file. Thanks! [20:54:43] np [20:56:32] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog: Add comms preferences footer to all Civi-generated emails - https://phabricator.wikimedia.org/T359445#10181263 (10Cstone) [20:57:10] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog: Add comms preferences footer to all Civi-generated emails - https://phabricator.wikimedia.org/T359445#10181264 (10Cstone) [21:11:38] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 07payments-orchestration: Gravy Braintree implementation: Venmo - https://phabricator.wikimedia.org/T375267#10181328 (10AnnWF) [21:30:01] (03CR) 10Wfan: [C:03+2] "LGTM" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1075590 (https://phabricator.wikimedia.org/T374051) (owner: 10Jgleeson) [21:30:29] (03Merged) 10jenkins-bot: Switch getPaymentDetails to getLatestPaymentStatus on Gravy PaymentProcessor [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1075590 (https://phabricator.wikimedia.org/T374051) (owner: 10Jgleeson) [23:55:08] (03CR) 10Cstone: [C:03+2] "thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1075251 (owner: 10Damilare Adedoyin) [23:55:38] (03Merged) 10jenkins-bot: Prevent capture from Gravy listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1075251 (owner: 10Damilare Adedoyin) [23:56:34] (03CR) 10Cstone: [C:03+2] Enable recentmenu on install [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075643 (owner: 10Eileen)