[00:35:24] (03PS1) 10Eileen: Temporary fix for handling duplicate contacts on import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077124 (https://phabricator.wikimedia.org/T374063) [00:42:29] (03PS3) 10Eileen: Minor tidy up in config function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1076895 (https://phabricator.wikimedia.org/T374063) [00:42:29] (03PS2) 10Eileen: WIP - Hook based alternative to core hack [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077120 (https://phabricator.wikimedia.org/T374063) [00:42:29] (03PS1) 10Eileen: Temporary fix for handling duplicate contacts on import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077125 (https://phabricator.wikimedia.org/T374063) [01:36:32] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 07payments-orchestration: Add backend processor to gravy refunds - https://phabricator.wikimedia.org/T374634#10194505 (10Cstone) Looks like this has been fixed in the meantime, refunds now keep their backend processor [01:46:42] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10fundraising-tech-ops: Civi1002 can't access Gravy Audit files hosted at storage.googleapis.com - https://phabricator.wikimedia.org/T375492#10194517 (10Cstone) a:03Cstone [01:48:43] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Tech-Analytics, 10FR-tech-data-integrity: New Donors Donating On Email - https://phabricator.wikimedia.org/T356911#10194520 (10Cstone) a:03Cstone [03:27:55] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10fundraising-tech-ops: Civi1002 can't access Gravy Audit files hosted at storage.googleapis.com - https://phabricator.wikimedia.org/T375492#10194583 (10Dwisehaupt) Created an nginx proxy on the build role to try and handle this. It is restricted to con... [03:29:20] (03PS1) 10Eileen: Minor preliminary composer updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077133 [03:29:20] (03PS1) 10Eileen: Update silverphp-php-connector [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077134 (https://phabricator.wikimedia.org/T368470) [03:29:21] (03PS1) 10Eileen: composer update wikimedia/omnimail-silverpop [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077135 (https://phabricator.wikimedia.org/T368470) [03:29:22] (03PS1) 10Eileen: Add omnimail upload action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077136 (https://phabricator.wikimedia.org/T368470) [03:31:16] 10fundraising-tech-ops, 06DC-Ops, 06Infrastructure-Foundations, 10netops, and 3 others: codfw:frack:rack/install/configuration new switches - https://phabricator.wikimedia.org/T374587#10194593 (10Papaul) @ayounsi I will soon be setting up interfaces and assigning them to VLAN's. I wanted to know if we are... [03:31:26] (03PS1) 10Cstone: Add proxy for gravy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1077137 (https://phabricator.wikimedia.org/T375492) [03:42:55] 10fundraising-tech-ops, 06DC-Ops, 06Infrastructure-Foundations, 10netops, and 2 others: codfw:frack:servers migration task - https://phabricator.wikimedia.org/T375151#10194601 (10Papaul) @ayounsi @cmooney I have been working on the migration process and put together the proposal below. I also had a meetin... [03:45:46] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Switch Acoustic mapping to use the API to define the columns - https://phabricator.wikimedia.org/T368470#10194621 (10Eileenmcnaughton) Thanks @bsisolak - what I saw was that when the file was not in the... [03:49:14] (03CR) 10CI reject: [V:04-1] Add omnimail upload action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077136 (https://phabricator.wikimedia.org/T368470) (owner: 10Eileen) [04:01:01] 10fundraising-tech-ops, 06DC-Ops, 06Infrastructure-Foundations, 10netops, and 2 others: codfw:frack:servers migration task - https://phabricator.wikimedia.org/T375151#10194641 (10Papaul) [06:39:16] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/1077168 (owner: 10L10n-bot) [08:42:39] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog: Annual Recurring - Tagging and segmenting in Civi and Acoustic - https://phabricator.wikimedia.org/T372378#10194892 (10MSuijkerbuijk_WMF) @Eileenmcnaughton Overall, our logic should reflect that **//Monthly recurring will take priority//**. - Annual recu... [09:32:48] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07Wikimedia-production-error: 1.43.0-wmf.25 breaks donate.wikimedia.org - https://phabricator.wikimedia.org/T376255#10195065 (10hashar) p:05Triageā†’03Unbreak! This one is a train blocker and I am thus setting it to {nav Unbreak Now!} priorit... [09:37:21] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07Wikimedia-production-error: 1.43.0-wmf.25 breaks donate.wikimedia.org: MediaWiki\Config\ConfigException: MediaWiki\Config\GlobalVarConfig::get: undefined option: 'ContributionTrackingFundrais... - https://phabricator.wikimedia.org/T376255#10195089 [09:37:23] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07Wikimedia-production-error: 1.43.0-wmf.25 breaks donate.wikimedia.org: MediaWiki\Config\ConfigException: MediaWiki\Config\GlobalVarConfig::get: undefined option: 'ContributionTrackingFundrais... - https://phabricator.wikimedia.org/T376255#10195091 [09:44:21] (03PS1) 10Zabe: Use wgDonationInterfaceFundraiserMaintenance [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1077330 (https://phabricator.wikimedia.org/T376255) [09:48:52] fr-tech: hello, I have filed an unbreak now for donate.wikimedia.org due to `MediaWiki\Config\GlobalVarConfig::get: undefined option: 'ContributionTrackingFundraiserMaintenance'` https://phabricator.wikimedia.org/T376255 [09:48:53] :) [09:49:15] I haven't investigated that much, looks like some config is no more available, but I don't know why [09:53:45] hi hashar [09:54:14] donate.wikimedia.org is looked after by pcoombe's team [09:55:11] we can take a peek and leave some comments [09:57:55] jgleeson: hi :) [09:57:58] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 13Patch-For-Review, 07Wikimedia-production-error: 1.43.0-wmf.25 breaks donate.wikimedia.org: MediaWiki\Config\ConfigException: MediaWiki\Config\GlobalVarConfig::get: undefined option: 'Contri... - https://phabricator.wikimedia.org/T376255#10195180 [09:58:08] jgleeson: I am pretty sure the root cause is https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FundraiserLandingPage/+/1073527 [09:58:32] it replaces a $wg global variable in favor of `MediaWiki\Config\Config.get()` [09:58:50] which leads to an issue. So it is most probably just a cleanup as proposed by https://gerrit.wikimedia.org/r/1077330 [09:58:52] :) [10:02:01] (03CR) 10Hashar: "In the commit message, you can refer to I074bfdf1273eebb47ff8c9ab5a599d1f731d3939 which replaced the usage of global $wg variables by call" [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1077330 (https://phabricator.wikimedia.org/T376255) (owner: 10Zabe) [10:02:13] I have added pcoombe as a reviewer to the change :) [10:02:16] I am off for lunch break [10:05:43] ok I see hashar and yes that explanation makes sense [10:05:56] (03CR) 10Jgleeson: [C:03+2] "LGTM!" [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1077330 (https://phabricator.wikimedia.org/T376255) (owner: 10Zabe) [10:12:18] (03PS7) 10Jgleeson: Add test to probe Pending Transaction Resolver code handling of duplicate emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075293 (https://phabricator.wikimedia.org/T375397) [10:12:46] looks like we needed something in the abandoned patch after all to get that one passing [10:14:11] (03PS8) 10Jgleeson: Add test to probe Pending Transaction Resolver code handling of duplicate emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075293 (https://phabricator.wikimedia.org/T375397) [10:37:04] (03Merged) 10jenkins-bot: Use wgDonationInterfaceFundraiserMaintenance [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1077330 (https://phabricator.wikimedia.org/T376255) (owner: 10Zabe) [10:37:29] (03PS1) 10Zabe: Use wgDonationInterfaceFundraiserMaintenance [extensions/FundraiserLandingPage] (wmf/1.43.0-wmf.25) - 10https://gerrit.wikimedia.org/r/1077344 (https://phabricator.wikimedia.org/T376255) [11:36:14] thanks jgleeson|lunch and hashar! For the record, Online Fundraising (my team) only manages the on-wiki content of donate.wikimedia.org, not the software and configuration which I understood Fundraising Tech was still responsible for [12:26:33] oh right pcoombe fair enough. thanks for explaining [12:37:19] ahhhh [12:37:36] Lead Developer of content rather than software developer :D [12:38:43] I'll roll the cherry pick https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FundraiserLandingPage/+/1077344 [12:38:53] and follow up in #wikimedia-operations [12:38:59] thanks jgleeson & pcoombe ! [12:39:19] (03CR) 10Hashar: [C:03+2] Use wgDonationInterfaceFundraiserMaintenance [extensions/FundraiserLandingPage] (wmf/1.43.0-wmf.25) - 10https://gerrit.wikimedia.org/r/1077344 (https://phabricator.wikimedia.org/T376255) (owner: 10Zabe) [12:39:55] (03CR) 10TrainBranchBot: [C:03+2] "Approved by hashar@deploy2002 using scap backport" [extensions/FundraiserLandingPage] (wmf/1.43.0-wmf.25) - 10https://gerrit.wikimedia.org/r/1077344 (https://phabricator.wikimedia.org/T376255) (owner: 10Zabe) [12:40:34] (03CR) 10ScheduleDeploymentBot: "Scheduled for deployment in the [Wednesday, October 02 UTC afternoon backport window](https://wikitech.wikimedia.org/wiki/Deployments#depl" [extensions/FundraiserLandingPage] (wmf/1.43.0-wmf.25) - 10https://gerrit.wikimedia.org/r/1077344 (https://phabricator.wikimedia.org/T376255) (owner: 10Zabe) [12:41:40] np [12:42:26] (03Merged) 10jenkins-bot: Use wgDonationInterfaceFundraiserMaintenance [extensions/FundraiserLandingPage] (wmf/1.43.0-wmf.25) - 10https://gerrit.wikimedia.org/r/1077344 (https://phabricator.wikimedia.org/T376255) (owner: 10Zabe) [13:02:38] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.43-notes (1.43.0-wmf.25; 2024-10-01), 13Patch-For-Review, 07Wikimedia-production-error: 1.43.0-wmf.25 breaks donate.wikimedia.org: MediaWiki\Config\ConfigException: MediaWiki\Config\... - https://phabricator.wikimedia.org/T376255#10195769 [13:06:51] oh my god [13:07:13] lol [13:09:01] hashar: looks like you can do the same [13:09:10] as that one now lives here I think? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/599079 [13:09:55] https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/988ad78436289ea5e8439d3602ed8cdb1a05ac6b/special/GatewayChooser.php#L37 [13:10:03] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.43-notes (1.43.0-wmf.25; 2024-10-01), 13Patch-For-Review, 07Wikimedia-production-error: 1.43.0-wmf.25 breaks donate.wikimedia.org: MediaWiki\Config\ConfigException: MediaWiki\Config\... - https://phabricator.wikimedia.org/T376255#10195794 [13:10:07] I commented on the task :D [13:10:23] looks like DonationInterface is not loaded anywhere in operations/mediawiki-config [13:10:31] it does not show up at https://donate.wikimedia.org/w/index.php?title=Special:Version [13:10:55] and that extension is the one creating the `DonationInterfaceFundraiserMaintenance` config [13:10:56] yeah that sounds right [13:11:04] then [13:11:18] it looks like it was migrated out of that extension [13:11:22] I thought DonationInterface was the main extension for donatewiki :D [13:11:39] no it's not, that's the main extension for payments-wiki :P [13:11:56] which is on the FRACK cluster managed by Jeff_Green and dallas [13:11:57] * hashar renames DonationInterface PaymentsInterface [13:12:01] AHH [13:12:02] lol [13:12:30] ah yeah that secret "Area 51 grade" cluster in our infra [13:12:33] how confusing :) [13:12:38] so zabe patch was wrong [13:13:35] I'm surprised that the call to $this->getConfig()->get() fails so spectacularly. Maybe we were missing a default value of false in those updates. [13:14:27] (03PS1) 10Hashar: Revert "Use wgDonationInterfaceFundraiserMaintenance" [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1077379 [13:15:12] (03PS2) 10Hashar: Revert "Use wgDonationInterfaceFundraiserMaintenance" [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1077379 (https://phabricator.wikimedia.org/T376255) [13:15:17] (03PS1) 10Hashar: Revert "Use wgDonationInterfaceFundraiserMaintenance" [extensions/FundraiserLandingPage] (wmf/1.43.0-wmf.25) - 10https://gerrit.wikimedia.org/r/1077380 (https://phabricator.wikimedia.org/T376255) [13:15:40] I proposed patches to revert both, I guess you can +2 them [13:15:43] hashar: hmm we might still need a way to tell doantewiki when payments-wiki is in maint mode. I think we will still need that config [13:16:09] I'm not familar with the history of that code but it seems logical to me to assume so [13:16:18] and I guess a new patch needs to be done that adds a new config variable in FundraisierLandingPage extension.json [13:16:23] yeah [13:16:46] here's the guy who will know more ^ [13:17:01] the reason that started failing in production is https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FundraiserLandingPage/+/1073527 [13:17:42] hi all! [13:17:47] howdy ejegg [13:18:32] so the plan (maybe for next year) is to run a single wiki for donate + payments, once we're on the next LTS [13:18:40] that would be on the frack cluster [13:19:11] ejegg: it looks like some maintenance mode flags got migrated out of the FUndraiserLandingPage exctension to DonationInterface and during a config modernisation effort, they were recently renamed. [13:19:16] DonationInterface is still deployed to donatewiki I believe, since donatewiki uses some strings from there [13:19:45] oh right [13:20:11] oh Elliott our savior! [13:20:13] so it's fine to rename them for now, if that'll make things less confusing [13:20:34] ejegg: I think the issue is that we don't have a default of false being set [13:20:37] lol hashar I'm just muddling through like the rest of us [13:20:49] just have seen a bit more of how this mess has developed [13:20:55] lol [13:21:00] jgleeson: OK right, we need a default false [13:21:01] it is always nicer to have three people muddling around :) [13:21:11] (what ever muddling means, I have to look it up in a dictionary hehe) [13:21:18] seems fitting [13:21:51] so is it currently broken in production? [13:22:00] it looks like $wgContributionTrackingFundraiserMaintenance was removed some years ago, and I am not sure why it never exploded until now. My guess is that php simply emits a notice for it and considers it null/falshish [13:22:01] because of that lack of default? [13:22:04] so that went under the rader [13:22:46] ok, can we just deploy a mwconfig patch to set the current thing it's looking for? [13:23:02] then Umherirrender changed the $wg global to use MediaWiki\Config\Config.get() which raiess an exception when it can't find a config [13:23:05] instead of the php notice [13:24:06] I guess there could be a newish `FundraiserLandingPage: "false"` setting added to FundraiserLandingPage extension.json [13:24:23] ok, so the patch to 'Use wgDonationInterfaceFundraiserMaintenance' is currently deployed? [13:24:40] err: `"FundraiserLandingPageMaintenance": "false" [13:25:03] I can load donatewiki with no visible error, so some fix seems to be up [13:25:05] ejegg: I have sent changes to revert it [13:25:32] hashar: well, let's not go back to the wgContributionTrackingFundraiserMaintenance variable name [13:25:39] donatewiki currently runs with wmf.24 which still uses the $wg variable [13:25:49] so my idea was to revert the faulty patch [13:25:50] if anything, let's go ahead to the FundraiserLandingPageMaintenance [13:26:00] and craft a new one that introduces a new config :) [13:26:25] yep yep, sounds good to me, either with a revert or just a patch to overwrite [13:28:14] lol @ FRACK being the wmf equivalent of Area 51 :) [13:28:28] :( [13:29:59] I guess you can +2 https://gerrit.wikimedia.org/r/1077379 and its backport https://gerrit.wikimedia.org/r/1077380 [13:30:00] so hashar there already is a default for DonationInterfaceFundraiserMaintenance set in DonationInterface [13:30:19] which is indeed installed on donatewiki [13:30:27] ah [13:30:38] lets hold the reverts :D [13:30:51] I think maybe we can leave it at using Use wgDonationInterfaceFundraiserMaintenance [13:30:55] my trouble is that when I head to https://donate.wikimedia.org/w/index.php?title=Special:Version [13:30:56] yeah, hold the reverts [13:31:00] I don't see Donation Interface [13:31:05] ooooohhhhh ???? [13:31:16] and in operations/mediawiki-config I see nothing referring to DonationInterface [13:31:27] waitaminute, I remember ppl copied a lot of the strings to mediawikimessages [13:31:35] (or wikimediamessages?) [13:31:45] did we actually get donationinterface out of donatewiki then? [13:31:52] sorry, I should be up to date on this [13:31:58] well [13:32:01] wow, you're right! [13:32:08] OK, new variable needed I guess [13:32:14] if for once the WMF has managed to decommission something, we should celebrate! [13:32:18] hah [13:32:20] yep [13:32:30] so yeah [13:32:44] and I guess that went under the radar cause PHP is happy with unexistent variable [13:33:03] which again brillantly shows up we should rewrite to Java [13:33:13] :P [13:33:16] :b [13:33:33] why not C# ? [13:33:45] so instead of reverting, maybe simply change the variable name [13:33:56] or revert [13:33:57] yep yep, let's do that and add the default to extension.json [13:33:59] and redo a proper change [13:34:03] up to you I guess [13:34:17] Hah, I'mma just go forward [13:34:54] but I don't understand how we never caught $wgContributionTrackingFundraiserMaintenance not being set [13:35:29] lol.... there is no FundraiserMaintenance page in that extension anyway [13:35:40] That was moved to DonationInterface [13:35:48] so... I'mma just remove that whole check [13:36:11] pcoombe has on-wiki JS vars to set to show a pseudo-maintenance page anyway, I think [13:36:52] less code, less bugs! [13:37:15] (03Abandoned) 10Hashar: Revert "Use wgDonationInterfaceFundraiserMaintenance" [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1077379 (https://phabricator.wikimedia.org/T376255) (owner: 10Hashar) [13:37:17] (03Abandoned) 10Hashar: Revert "Use wgDonationInterfaceFundraiserMaintenance" [extensions/FundraiserLandingPage] (wmf/1.43.0-wmf.25) - 10https://gerrit.wikimedia.org/r/1077380 (https://phabricator.wikimedia.org/T376255) (owner: 10Hashar) [13:37:54] (03PS1) 10Ejegg: Remove Maintenance check [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1077387 [13:38:11] (03PS2) 10Ejegg: Remove Maintenance check [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1077387 (https://phabricator.wikimedia.org/T376255) [13:40:46] ejegg: not any clever js, we just wiki redirected the main content to a maintenance message https://donate.wikimedia.org/w/index.php?title=Template:Lp-layout-default&diff=prev&oldid=35613 [13:42:48] ah, got it. Thanks pcoombe [13:45:14] usage `#REDIRECT` falls under my definition of cleverness [13:47:06] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Can we retroactively update a tracking code for this email ID? sp74475455 - https://phabricator.wikimedia.org/T375685#10195986 (10nisrael) Thank you so much @Cstone! [13:47:13] ejegg: FundraiserLandingPage does not fall under PCI complianceso I can +2 it? [13:47:29] (I am pretty sure gerrit would not allow me to do so anyway) [13:47:56] (03CR) 10Hashar: [C:03+2] "Nice cleanup! :)" [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1077387 (https://phabricator.wikimedia.org/T376255) (owner: 10Ejegg) [13:48:00] I will deploy it [13:48:32] (03PS1) 10Hashar: Remove Maintenance check [extensions/FundraiserLandingPage] (wmf/1.43.0-wmf.25) - 10https://gerrit.wikimedia.org/r/1077390 (https://phabricator.wikimedia.org/T376255) [13:53:39] (03PS1) 10Jgleeson: Add tests to cover Gravy pending transaction resolver paths [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077393 (https://phabricator.wikimedia.org/T374051) [13:53:41] (03PS1) 10Jgleeson: Remove Ingenico codes from Adyen test suite comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077394 [13:53:47] hashar: yep, correct [13:53:54] thank you! [13:55:28] (03PS3) 10Damilare Adedoyin: WIP: Setup Venmo frontend on Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1077074 (https://phabricator.wikimedia.org/T376182) [13:55:41] ejegg: this test cofirms your fix from the other day https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1075293 [13:56:03] thanks jgleeson|skrun, just looking at it now! [13:56:35] (03PS4) 10Damilare Adedoyin: WIP: Setup Venmo frontend on Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1077074 (https://phabricator.wikimedia.org/T376182) [13:56:53] (03CR) 10Hashar: [C:03+2] Remove Maintenance check [extensions/FundraiserLandingPage] (wmf/1.43.0-wmf.25) - 10https://gerrit.wikimedia.org/r/1077390 (https://phabricator.wikimedia.org/T376255) (owner: 10Hashar) [13:59:11] (03CR) 10CI reject: [V:04-1] WIP: Setup Venmo frontend on Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1077074 (https://phabricator.wikimedia.org/T376182) (owner: 10Damilare Adedoyin) [14:00:12] (03CR) 10TrainBranchBot: [C:03+2] "Approved by hashar@deploy2002 using scap backport" [extensions/FundraiserLandingPage] (wmf/1.43.0-wmf.25) - 10https://gerrit.wikimedia.org/r/1077390 (https://phabricator.wikimedia.org/T376255) (owner: 10Hashar) [14:00:48] (03Merged) 10jenkins-bot: Remove Maintenance check [extensions/FundraiserLandingPage] (wmf/1.43.0-wmf.25) - 10https://gerrit.wikimedia.org/r/1077390 (https://phabricator.wikimedia.org/T376255) (owner: 10Hashar) [14:04:38] (03PS5) 10Damilare Adedoyin: WIP: Setup Venmo frontend on Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1077074 (https://phabricator.wikimedia.org/T376182) [14:06:29] (03CR) 10CI reject: [V:04-1] WIP: Setup Venmo frontend on Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1077074 (https://phabricator.wikimedia.org/T376182) (owner: 10Damilare Adedoyin) [14:07:21] ejegg: my congratulations on having fixed a train blocker! [14:10:28] (03PS6) 10Damilare Adedoyin: Setup Venmo frontend on Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1077074 (https://phabricator.wikimedia.org/T376182) [14:12:13] (03CR) 10Ejegg: "Looks pretty good, just a question about the mock class" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075293 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [14:12:21] (03CR) 10CI reject: [V:04-1] Setup Venmo frontend on Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1077074 (https://phabricator.wikimedia.org/T376182) (owner: 10Damilare Adedoyin) [14:12:24] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.43-notes (1.43.0-wmf.25; 2024-10-01), 13Patch-For-Review, 07Wikimedia-production-error: 1.43.0-wmf.25 breaks donate.wikimedia.org: MediaWiki\Config\ConfigException: MediaWiki\Config... - https://phabricator.wikimedia.org/T376255#10196093 [14:12:26] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.43-notes (1.43.0-wmf.25; 2024-10-01), 13Patch-For-Review, 07Wikimedia-production-error: 1.43.0-wmf.25 breaks donate.wikimedia.org: MediaWiki\Config\ConfigException: MediaWiki\Config... - https://phabricator.wikimedia.org/T376255#10196096 [14:13:35] (03CR) 10Ejegg: [C:03+2] Fix our import hook for when contact ID is present [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077121 (https://phabricator.wikimedia.org/T374063) (owner: 10Eileen) [14:14:25] (03CR) 10Ejegg: [C:03+2] Create a group to add imported duplicates to [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077122 (https://phabricator.wikimedia.org/T374063) (owner: 10Eileen) [14:14:46] (03CR) 10CI reject: [V:04-1] Add tests to cover Gravy pending transaction resolver paths [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077393 (https://phabricator.wikimedia.org/T374051) (owner: 10Jgleeson) [14:14:52] (03CR) 10CI reject: [V:04-1] Remove Ingenico codes from Adyen test suite comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077394 (owner: 10Jgleeson) [14:17:33] (03Merged) 10jenkins-bot: Remove Maintenance check [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1077387 (https://phabricator.wikimedia.org/T376255) (owner: 10Ejegg) [14:32:28] (03Merged) 10jenkins-bot: Fix our import hook for when contact ID is present [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077121 (https://phabricator.wikimedia.org/T374063) (owner: 10Eileen) [14:34:34] (03Merged) 10jenkins-bot: Create a group to add imported duplicates to [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077122 (https://phabricator.wikimedia.org/T374063) (owner: 10Eileen) [15:15:21] (03CR) 10Ejegg: [C:03+2] "OK, looks like a reasonable stopgap solution" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077124 (https://phabricator.wikimedia.org/T374063) (owner: 10Eileen) [15:30:21] (03CR) 10Jgleeson: Add test to probe Pending Transaction Resolver code handling of duplicate emails (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075293 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [15:31:36] ejegg: regarding the test class. that was just a home to put all the interfaces I needed to stub. I explained a bit more on the patch [15:33:16] it would have been nice to use this https://docs.phpunit.de/en/10.5/test-doubles.html#createmockforintersectionofinterfaces to keep the test separated from a gateway-specific payment provider but I don't think the version of PHPUnit on CiviCRM supports it yet https://docs.phpunit.de/en/10.5/test-doubles.html#createmockforintersectionofinterfaces [15:35:54] (03Merged) 10jenkins-bot: Temporary fix for handling duplicate contacts on import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077124 (https://phabricator.wikimedia.org/T374063) (owner: 10Eileen) [15:40:04] ejegg: lemme update that test to use the getGateways dataProvider so that it isn't tied to Adyen and then the generic test interfaces wrapper class might fit better [15:40:30] it's passing for Adyen and Gravy but not paypal so I need to see what it doesn't like [15:41:37] hmm doesn't paypal not implement all those interfaces [15:42:06] ah it's not cancellable [15:44:40] (03PS9) 10Jgleeson: Add test to probe Pending Transaction Resolver code handling of duplicate emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075293 (https://phabricator.wikimedia.org/T375397) [15:45:31] ah, right, no cancel for Adyen [15:46:33] paypal ejegg ? [15:48:09] oh ok the failure was due to the gateway name being paypal_ec and not paypal [15:48:29] we're checking that string here https://github.com/wikimedia/wikimedia-fundraising-crm/blob/39bf47b8683bf71b51b4ff2b5a0757e06eae15fd/drupal/sites/default/civicrm/extensions/wmf-civicrm/Civi/Api4/Action/PendingTransaction/Resolve.php#L195 [15:50:36] (03PS10) 10Jgleeson: Add test to probe Pending Transaction Resolver code handling of duplicate emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075293 (https://phabricator.wikimedia.org/T375397) [15:50:57] ok that's passing for all gateways using the pending transaction resolver now [15:52:58] (03CR) 10Jgleeson: "Following on from the reply inline, I've made this test gateway-agnostic now which makes more sense and gives us better test coverage." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075293 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [15:53:11] (03PS2) 10Jgleeson: Add tests to cover Gravy pending transaction resolver paths [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077393 (https://phabricator.wikimedia.org/T374051) [15:53:15] (03PS2) 10Jgleeson: Remove Ingenico codes from Adyen test suite comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077394 [16:01:42] (03CR) 10Jgleeson: "ah ok, CI is failing due to civicrm using the earlier version of smashpig" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077393 (https://phabricator.wikimedia.org/T374051) (owner: 10Jgleeson) [16:03:36] 10fundraising-tech-ops, 06DC-Ops, 06Infrastructure-Foundations, 10netops, and 3 others: codfw:frack:rack/install/configuration new switches - https://phabricator.wikimedia.org/T374587#10196649 (10ayounsi) No interface range as each switch will be independent. [16:03:41] 03Fundraising Sprint: Sssss, 06Fundraising-Backlog, 07FR-Imports, 13Patch-For-Review: Record duplicates when processing Engage import - https://phabricator.wikimedia.org/T374063#10196655 (10Ejegg) a:03Eileenmcnaughton [16:04:16] 10fundraising-tech-ops, 06DC-Ops, 06Infrastructure-Foundations, 10netops, and 3 others: codfw:frack:rack/install/configuration new switches - https://phabricator.wikimedia.org/T374587#10196661 (10Papaul) Thanks [16:14:31] (03CR) 10CI reject: [V:04-1] Remove Ingenico codes from Adyen test suite comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077394 (owner: 10Jgleeson) [16:14:41] (03CR) 10CI reject: [V:04-1] Add tests to cover Gravy pending transaction resolver paths [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077393 (https://phabricator.wikimedia.org/T374051) (owner: 10Jgleeson) [16:21:57] (03CR) 10Ejegg: [C:03+2] Add proxy for gravy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1077137 (https://phabricator.wikimedia.org/T375492) (owner: 10Cstone) [16:22:28] (03Merged) 10jenkins-bot: Add proxy for gravy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1077137 (https://phabricator.wikimedia.org/T375492) (owner: 10Cstone) [16:28:41] 06Fundraising-Backlog: Add gravy folders for the audit - https://phabricator.wikimedia.org/T376308 (10Cstone) 03NEW [16:54:08] 06Fundraising-Backlog, 10fundraising-tech-ops: Add gravy folders for the audit - https://phabricator.wikimedia.org/T376308#10197075 (10Jgreen) 05Openā†’03Resolved p:05Triageā†’03Medium a:03Jgreen This is done. ` commit 01ff90803d56c06b0a34729921ab8e7bf72473bd Author: Jeff Green 06Fundraising-Backlog: Clean up unused donation interface messages - https://phabricator.wikimedia.org/T376318 (10Cstone) 03NEW [18:04:21] 06Fundraising-Backlog, 10FR-donorservices: Civi warning - https://phabricator.wikimedia.org/T376321 (10SHust) 03NEW [18:08:26] lol ^ [18:08:59] Sandra got into the matrix [18:39:35] (03PS3) 10Jgleeson: Add tests to cover Gravy pending transaction resolver paths [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077393 (https://phabricator.wikimedia.org/T374051) [18:39:35] (03PS3) 10Jgleeson: Remove Ingenico codes from Adyen test suite comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077394 [18:39:35] (03PS1) 10Jgleeson: Upgrade SmashPig to v0.8.13 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077454 (https://phabricator.wikimedia.org/T374051) [18:41:22] (03CR) 10CI reject: [V:04-1] Add tests to cover Gravy pending transaction resolver paths [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077393 (https://phabricator.wikimedia.org/T374051) (owner: 10Jgleeson) [18:48:42] 19:41:16 0 0 0 0 0 0 0 0 --:--:-- 0:00:02 --:--:-- 0curl: (6) Could not resolve host: github.com [18:48:44] odd [18:51:43] damilare: is it just this patch for the guest checkout? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1073841 [18:52:03] yea it's just that one [18:52:36] oh cool I see that's merged then. so we're using guest checkout now then? [18:52:42] or do we need to deploy it [18:52:50] yep it isn't deployed yet [18:53:04] I can deploy it tonight [18:53:27] as I'd be out tomorrow [18:55:04] it's fine there's no rush [18:55:31] so the main different is that we add a 'buyer' node to the request with the info [18:55:35] difference* [18:56:01] yea exactly, we used to have a buyer_id to point to the gravy buyer resource [18:57:12] gotcha [18:57:27] if it's getting late for UK folks to deploy, i'd be happy to do that [19:10:48] (03CR) 10Jgleeson: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077393 (https://phabricator.wikimedia.org/T374051) (owner: 10Jgleeson) [19:16:02] (03PS1) 10Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1077459 [19:16:40] (03CR) 10Cstone: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1077459 (owner: 10Cstone) [19:17:04] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1077459 (owner: 10Cstone) [19:23:09] (03CR) 10Eileen: "test this please" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077136 (https://phabricator.wikimedia.org/T368470) (owner: 10Eileen) [19:23:43] !log SmashPig upgraded from 715e91fa to df2a9c42 [19:23:44] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:52:48] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10fundraising-tech-ops: Civi1002 can't access Gravy Audit files hosted at storage.googleapis.com - https://phabricator.wikimedia.org/T375492#10197704 (10Cstone) We deployed a test patch with the config mentioned now getting: Could not download report du... [20:01:49] (03PS2) 10Eileen: Temporary fix for handling duplicate contacts on import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077125 (https://phabricator.wikimedia.org/T374063) [20:01:49] (03PS4) 10Eileen: Minor tidy up in config function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1076895 (https://phabricator.wikimedia.org/T374063) [20:02:15] (03CR) 10Ejegg: [C:03+2] Temporary fix for handling duplicate contacts on import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077125 (https://phabricator.wikimedia.org/T374063) (owner: 10Eileen) [20:02:56] (03CR) 10Ejegg: [C:03+2] Minor tidy up in config function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1076895 (https://phabricator.wikimedia.org/T374063) (owner: 10Eileen) [20:03:57] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1077470 [20:04:26] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1077470 (owner: 10Eileen) [20:21:34] (03Merged) 10jenkins-bot: Temporary fix for handling duplicate contacts on import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077125 (https://phabricator.wikimedia.org/T374063) (owner: 10Eileen) [20:22:58] (03PS11) 10Jgleeson: Add test to probe Pending Transaction Resolver code handling of duplicate emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075293 (https://phabricator.wikimedia.org/T375397) [20:23:02] (03CR) 10Ejegg: [C:03+2] Add test to probe Pending Transaction Resolver code handling of duplicate emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075293 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [20:23:06] (03Merged) 10jenkins-bot: Minor tidy up in config function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1076895 (https://phabricator.wikimedia.org/T374063) (owner: 10Eileen) [20:23:07] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1077470 (owner: 10Eileen) [20:23:09] ty ejegg [20:23:12] (03PS2) 10Jgleeson: Upgrade SmashPig to v0.8.13 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077454 (https://phabricator.wikimedia.org/T374051) [20:23:15] (03CR) 10Ejegg: [C:03+2] Upgrade SmashPig to v0.8.13 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077454 (https://phabricator.wikimedia.org/T374051) (owner: 10Jgleeson) [20:23:19] :) [20:33:56] jgleeson: should I review that follow-on Gravy resolver patch? Or is that moot now that the original has the gateway data provider? [20:37:14] ejegg: yeah I think it's still good to have. that resolver patch doens't touch the consume level stuff that the other one did. It mostly probes around the resolve scenarios. [20:37:37] ok, got it [20:40:26] (03Merged) 10jenkins-bot: Add test to probe Pending Transaction Resolver code handling of duplicate emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1075293 (https://phabricator.wikimedia.org/T375397) (owner: 10Jgleeson) [20:41:01] (03Merged) 10jenkins-bot: Upgrade SmashPig to v0.8.13 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077454 (https://phabricator.wikimedia.org/T374051) (owner: 10Jgleeson) [20:43:54] 06Fundraising-Backlog: Checking for code bottlenecks to improve speed of imports - https://phabricator.wikimedia.org/T376337 (10MDemosWMF) 03NEW [20:45:28] 03Fundraising Sprint: Sssss, 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Duplicate contributions after import - https://phabricator.wikimedia.org/T376068#10197813 (10MDemosWMF) Thanks Eileen - I opened a new phab for that - T376337. I think it's worth taking a look and we will try to monitor spee... [20:53:56] (03PS4) 10Jgleeson: Add tests to cover Gravy pending transaction resolver paths [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077393 (https://phabricator.wikimedia.org/T374051) [20:54:21] (03CR) 10Ejegg: [C:03+2] "Looks good, thanks for using the TestEntity functions to simplify cleanup!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077393 (https://phabricator.wikimedia.org/T374051) (owner: 10Jgleeson) [20:54:29] (03PS4) 10Jgleeson: Remove Ingenico codes from Adyen test suite comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077394 [20:54:31] (03CR) 10Ejegg: [C:03+2] Remove Ingenico codes from Adyen test suite comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077394 (owner: 10Jgleeson) [20:57:19] !log civicrm upgraded from 28fd5e3b to 90199f62 [20:57:20] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:57:36] ty ejegg [21:12:35] ah ejegg. I have to give credit to eileen for the test entity stuff. I borrowed most of that from her code :) [21:15:38] (03Merged) 10jenkins-bot: Add tests to cover Gravy pending transaction resolver paths [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077393 (https://phabricator.wikimedia.org/T374051) (owner: 10Jgleeson) [21:15:39] (03Merged) 10jenkins-bot: Remove Ingenico codes from Adyen test suite comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1077394 (owner: 10Jgleeson) [21:57:35] 06Fundraising-Backlog: Data merge on email to acoustic is not updating name - https://phabricator.wikimedia.org/T376347 (10Cstone) 03NEW [21:58:34] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Data merge on email to acoustic is not updating name - https://phabricator.wikimedia.org/T376347#10198077 (10Cstone) a:03Cstone [22:33:10] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Data merge on email to acoustic is not updating name - https://phabricator.wikimedia.org/T376347#10198182 (10SHust) Here's another set of CIDs from the same donor that fits this scenario: CID 57937754 (last donation in 2022) has a misspelled name, and A... [23:05:37] 03Fundraising Sprint: Sssss, 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Duplicate contributions after import - https://phabricator.wikimedia.org/T376068#10198295 (10Eileenmcnaughton) a:03Eileenmcnaughton @MDemosWMF I just pushed out a patch that will add create new contacts and add them to gro... [23:09:37] 03Fundraising Sprint: Sssss, 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Undo core Civi hacks - https://phabricator.wikimedia.org/T376357 (10Eileenmcnaughton) 03NEW [23:12:29] 06Fundraising-Backlog: Undo core Civi hacks - https://phabricator.wikimedia.org/T376357#10198346 (10Eileenmcnaughton) [23:16:07] 06Fundraising-Backlog: Undo core Civi hacks - https://phabricator.wikimedia.org/T376357#10198355 (10Eileenmcnaughton) [23:40:44] 06Fundraising-Backlog, 10FR-donorservices: Civi warning - https://phabricator.wikimedia.org/T376321#10198396 (10SHust) @Eileenmcnaughton, Iā€™m tagging you because I briefly mentioned this pop-up during our call earlier. Ty!