[03:37:53] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage, 10MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), 10MW-1.44-notes (1.44.0-wmf.1; 2024-10-29): PHP Deprecated: Use of MediaWiki\Output\OutputPage::setIndexPo... - https://phabricator.wikimedia.org/T378108#10261555 [03:39:12] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage, 10MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), 10MW-1.44-notes (1.44.0-wmf.1; 2024-10-29): PHP Deprecated: Use of MediaWiki\Output\OutputPage::setIndexPo... - https://phabricator.wikimedia.org/T378108#10261557 [03:40:14] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage, 10MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), 10MW-1.44-notes (1.44.0-wmf.1; 2024-10-29): PHP Deprecated: Use of MediaWiki\Output\OutputPage::setIndexPo... - https://phabricator.wikimedia.org/T378108#10261559 [03:40:23] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage: PHP Deprecated: Use of MediaWiki\Output\OutputPage::setIndexPolicy with index after noindex was deprecated in MediaWiki 1.43. [Called from MediaWiki\Extens... - https://phabricator.wikimedia.org/T378108#10261563 [04:21:55] (03CR) 10C. Scott Ananian: "thanks!" [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1082825 (https://phabricator.wikimedia.org/T378108) (owner: 10Ammarpad) [04:24:38] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage, 10MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), and 2 others: PHP Deprecated: Use of MediaWiki\Output\OutputPage::setIndexPolicy with index after noindex was... - https://phabricator.wikimedia.org/T378108#10261574 [04:25:24] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage, 10MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), and 2 others: PHP Deprecated: Use of MediaWiki\Output\OutputPage::setIndexPolicy with index after noindex wa... - https://phabricator.wikimedia.org/T378108#10261577 [12:21:05] going to push out those address changes, so we can test before next volume test. [12:23:20] (03PS1) 10Damilare Adedoyin: Update smashpig to 0.8.17 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1083164 [12:26:25] cool damilare [12:26:53] We need to find someone in Ireland [12:27:00] I think Rakhi knew someone [12:28:46] yea Rakhi has someone in Ireland waiting to retest [12:29:05] (03CR) 10Damilare Adedoyin: [C:03+2] Update smashpig to 0.8.17 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1083164 (owner: 10Damilare Adedoyin) [12:34:53] (03Merged) 10jenkins-bot: Update smashpig to 0.8.17 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1083164 (owner: 10Damilare Adedoyin) [12:36:01] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment 8fbf624a4 Add monthly convert countries a2797de81 Localisation updates from https://translatewiki.net. 7c9da1c9a Update smashpig to 0.8.17 [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1083167 [12:49:00] (03CR) 10Damilare Adedoyin: [C:03+2] Merge branch 'master' into deployment 8fbf624a4 Add monthly convert countries a2797de81 Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1083167 (owner: 10Damilare Adedoyin) [12:52:33] (03PS1) 10Damilare Adedoyin: Update composer lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1083169 [12:58:41] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment 8fbf624a4 Add monthly convert countries a2797de81 Localisation updates from https://translatewiki.net. 7c9da1c9a Update smashpig to 0.8.17 [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1083167 (owner: 10Damilare Adedoyin) [13:01:06] (03CR) 10CI reject: [V:04-1] Update composer lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1083169 (owner: 10Damilare Adedoyin) [13:04:57] (03CR) 10Damilare Adedoyin: "Recheck" [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1083169 (owner: 10Damilare Adedoyin) [13:18:03] (03CR) 10Damilare Adedoyin: [C:03+2] Update composer lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1083169 (owner: 10Damilare Adedoyin) [13:29:04] (03Merged) 10jenkins-bot: Update composer lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1083169 (owner: 10Damilare Adedoyin) [14:16:59] 03Fundraising Sprint: UnusedFunctionButDontDeleteItIncaseItsUsed(), 06Fundraising-Backlog, 07payments-orchestration: Gravy Google Pay - https://phabricator.wikimedia.org/T367806#10262594 (10Damilare) a:03Damilare [14:23:12] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257276 MB (100% inode=99%): /run 51458 MB (99% inode=99%): / 5000 MB (71% inode=89%): /dev/shm 257299 MB (100% inode=99%): /run/lock 5 MB (100% inode=99%): /home 12348 MB (99% inode=99%): /tmp 12350 MB (99% inode=99%): /var 25122 MB (94% inode=99%): /var/tmp 422 MB (99% inode=99%): /var/log 23696 MB (89% inode=99%): /var/log/audit 422 MB (99% inode=99%): /boot [14:23:12] 84% inode=99%): /srv 498228 MB (10% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [14:25:12] that has been alerting a lot lately ^ [14:28:12] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257276 MB (100% inode=99%): /run 51458 MB (99% inode=99%): / 5000 MB (71% inode=89%): /dev/shm 257299 MB (100% inode=99%): /run/lock 5 MB (100% inode=99%): /home 12348 MB (99% inode=99%): /tmp 12350 MB (99% inode=99%): /var 25122 MB (94% inode=99%): /var/tmp 422 MB (99% inode=99%): /var/log 23696 MB (89% inode=99%): /var/log/audit 422 MB (99% inode=99%): /boot [14:28:12] 84% inode=99%): /srv 487260 MB (10% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [14:31:30] gonna try to cancel a sandbox donation to fr-tech+donor [14:31:38] see if we get an email [14:31:49] not sure if sandbox paypal sends emails or not though [14:33:12] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257276 MB (100% inode=99%): /run 51458 MB (99% inode=99%): / 5000 MB (71% inode=89%): /dev/shm 257299 MB (100% inode=99%): /run/lock 5 MB (100% inode=99%): /home 12348 MB (99% inode=99%): /tmp 12350 MB (99% inode=99%): /var 25122 MB (94% inode=99%): /var/tmp 422 MB (99% inode=99%): /var/log 23696 MB (89% inode=99%): /var/log/audit 422 MB (99% inode=99%): /boot [14:33:12] 84% inode=99%): /srv 479799 MB (10% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [14:34:15] ACKNOWLEDGEMENT - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257276 MB (100% inode=99%): /run 51458 MB (99% inode=99%): / 5000 MB (71% inode=89%): /dev/shm 257299 MB (100% inode=99%): /run/lock 5 MB (100% inode=99%): /home 12348 MB (99% inode=99%): /tmp 12350 MB (99% inode=99%): /var 25122 MB (94% inode=99%): /var/tmp 422 MB (99% inode=99%): /var/log 23696 MB (89% inode=99%): /var/log/audit 422 MB (99% inode=99% [14:34:15] 575 MB (84% inode=99%): /srv 479799 MB (10% inode=99%): Jeff_Green known https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [14:42:59] (03PS1) 10Ejegg: Fix return type to suppress PHP8 warning [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1083188 [14:57:30] (03CR) 10Jgleeson: [C:03+2] "Those return types are good for PHP 7.1 onwards so this LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1083188 (owner: 10Ejegg) [14:57:59] (03Merged) 10jenkins-bot: Fix return type to suppress PHP8 warning [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1083188 (owner: 10Ejegg) [14:58:17] (03PS2) 10Ejegg: Allow sending a note along with a cancellation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1082320 (https://phabricator.wikimedia.org/T373947) [14:58:37] (03PS3) 10Ejegg: Allow sending a note along with a cancellation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1082320 (https://phabricator.wikimedia.org/T373947) [14:59:19] jgleeson: I've smoke tested ^^^ locally and it does make the request correctly, though I can't get it to send an email on paypal sandbox [14:59:39] looking [14:59:44] perhaps we can just merge it and I'll try with a test subscription of my own on prod [15:00:01] as long as it looks like it won't mess up existing uses of the cancel call, that is [15:03:13] ejegg: [15:03:20] I noticed " and can also be seen by both you and the buyer on the Status History page of the PayPal account." [15:03:30] ah right, let's see [15:04:52] hmm, actually, that is saying 'the profile ID is invalid' [15:05:10] let me log the outbound request [15:05:18] or rather, let me try without the patch [15:05:48] ok, the patch messed something up. [15:06:09] sorry jgleeson, I'll let you know when it's actually a success [15:06:14] no worries [15:10:53] hmm so I can no longer login the paypal developer account [15:11:06] it's not giving me the option to recieve the email code [15:11:20] only text/whats-app/call or verify by ID [15:11:26] grrr [15:11:31] it used to say email but now that option is gone [15:11:34] that's so annoying! [15:11:50] and it's not my phone number on there either [15:12:11] not sure what area code it is, but mine would start with either 6 or 8 [15:12:45] so i just turned on outbound logging, and the ONLY thing that changes is the addition of the NOTE param [15:13:23] and somehow it gives us an error about 11552: The profile ID is invalid [15:13:29] so... that's annoying [15:13:36] going to try with a few other subscr_ids [15:14:48] maybe with a shorter note? [15:15:04] oh weird. it seems if you login to their support ticketing system you also getting logged into developer.paypal.com [15:15:15] I went to file a ticket but then I noticed a developer link [15:15:18] and now I'm in [15:15:20] ha [15:15:22] good security [15:15:58] I just added an additional phone number to the list that for 2FA, it looks like we can add more [15:16:31] grr, OK, so they REALLY mean 'The note is too long' when they say 'The profile ID is invalid' [15:16:38] ah [15:18:01] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: CIDs with PayPal cancel date of 1969-12-31 need canceling on Paypals end - https://phabricator.wikimedia.org/T373947#10262806 (10Ejegg) Hi @SHust they seem to have a really small amount of space available for th... [15:18:33] jgleeson: ok, now I see the note at https://www.sandbox.paypal.com/billing/subscriptions/I-D4VSKEVX8S0K [15:19:11] I guess I could trial-and-error it to figure out the actual limit, then validate in code [15:21:39] the internet says they usually cap it at 255 [15:21:49] although no mention of that on the docs [15:21:51] ejegg: [15:23:01] k, looks like 128 [15:23:20] yeah, docs would be nice [15:23:50] what's the max length of varchar again [15:24:03] hmm, longer than 128! [15:24:03] I feel like that would be a perfect paypal thing to work to [15:24:07] ha [15:26:24] (03PS4) 10Ejegg: Allow sending a note along with a cancellation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1082320 (https://phabricator.wikimedia.org/T373947) [15:27:50] (03CR) 10Wfan: [V:03+2] "I noticed that we have other gateway is doing the same hardcofing at smashpig level and civi has one untie descriptor as smashpig_recurrin" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1082048 (https://phabricator.wikimedia.org/T376077) (owner: 10Wfan) [15:28:39] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: CIDs with PayPal cancel date of 1969-12-31 need canceling on Paypals end - https://phabricator.wikimedia.org/T373947#10262840 (10Ejegg) The limit for the note seems to be 128 characters [15:31:01] (03CR) 10Wfan: Add amount validation for inapp payment submit (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1082255 (https://phabricator.wikimedia.org/T376195) (owner: 10Wfan) [15:31:16] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: CIDs with PayPal cancel date of 1969-12-31 need canceling on Paypals end - https://phabricator.wikimedia.org/T373947#10262850 (10SHust) What about this (103 characters): Please note that the canceled recurring d... [15:38:12] RECOVERY - check_disk on frdb1004 is OK: DISK OK - free space: /dev 257276 MB (100% inode=99%): /run 51458 MB (99% inode=99%): / 5000 MB (71% inode=89%): /dev/shm 257299 MB (100% inode=99%): /run/lock 5 MB (100% inode=99%): /home 12348 MB (99% inode=99%): /tmp 12350 MB (99% inode=99%): /var 25122 MB (94% inode=99%): /var/tmp 422 MB (99% inode=99%): /var/log 23696 MB (89% inode=99%): /var/log/audit 422 MB (99% inode=99%): /boot 575 MB (84 [15:38:12] 9%): /srv 1539476 MB (33% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [15:38:40] (03CR) 10Jgleeson: [C:03+2] "LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1082320 (https://phabricator.wikimedia.org/T373947) (owner: 10Ejegg) [15:39:08] (03Merged) 10jenkins-bot: Allow sending a note along with a cancellation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1082320 (https://phabricator.wikimedia.org/T373947) (owner: 10Ejegg) [15:39:14] thanks jgleeson ! [15:39:31] np [15:47:58] hi jgleeson ! I'm just sitting with Kelly talking about gravy vs trustly - do you know if we have any diagrams that show how these integrations map out with payment processors? I've explained (as I think you just did) that gravy enables trustly [15:48:09] But I think rakhi is also talking about adyen which is confusing her [15:50:41] Maybe I can make something - it's straightforward in my head but I can see how it can be confusing for folks [15:50:44] thanks for responding to her [15:51:32] sorry anilk just got your message [15:51:50] hmm [15:52:01] no thank you - your response was clar [15:52:02] clear [15:52:03] I don't think we have a diagram to explain that [15:52:15] but I like the idea of adding one [15:54:15] (03PS1) 10Jgleeson: Send null instead of "" for empty params to keep Gravy API happy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1083199 (https://phabricator.wikimedia.org/T377979) [15:55:23] damilare: looks like "" throws an error for empty fields on the gravy API. I just tested out on live with paypal and it was failing due to missing address line 2 not being 1 char long when set. that patch flips it to null which let's it through [15:55:34] that patch being the last one ^^^ [15:55:41] yea followed the conversation on slack [15:55:49] ty [15:55:49] they may have just changed the rules [15:58:48] (03CR) 10Damilare Adedoyin: [C:03+2] Send null instead of "" for empty params to keep Gravy API happy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1083199 (https://phabricator.wikimedia.org/T377979) (owner: 10Jgleeson) [15:59:19] (03Merged) 10jenkins-bot: Send null instead of "" for empty params to keep Gravy API happy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1083199 (https://phabricator.wikimedia.org/T377979) (owner: 10Jgleeson) [16:00:15] (03PS4) 10Wfan: Add amount validation for inapp payment submit [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1082255 (https://phabricator.wikimedia.org/T376195) [16:02:17] (03PS1) 10Jgleeson: Dump createPayment and approvePayment params to logs to help debugging [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1083202 [16:02:53] also damilare I feel like this will help us debug stuff quicker when it doesn't make it to gravy ^ [16:02:58] oops standup [16:02:59] coming! [16:03:01] oh right [17:02:39] (03PS1) 10Umherirrender: Use type-declaration on api module constructor [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1083212 [17:44:40] (03CR) 10Reedy: [C:03+2] Use type-declaration on api module constructor [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1083212 (owner: 10Umherirrender) [17:57:41] (03Merged) 10jenkins-bot: Use type-declaration on api module constructor [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1083212 (owner: 10Umherirrender) [18:05:20] jgleeson|food: I'd push out those changes as Rakhi just asked for it in the banners channel as a blocker [18:08:59] (03PS1) 10Damilare Adedoyin: Update smashpig to 0.8.18 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1083238 [18:11:06] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1083239 [18:14:30] (03PS1) 10Damilare Adedoyin: Update smashpig to 0.8.18 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1083241 [18:17:29] (03CR) 10Damilare Adedoyin: [C:03+2] Update smashpig to 0.8.18 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1083238 (owner: 10Damilare Adedoyin) [18:17:35] (03CR) 10Damilare Adedoyin: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1083239 (owner: 10Damilare Adedoyin) [18:22:33] (03CR) 10CI reject: [V:04-1] Update smashpig to 0.8.18 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1083241 (owner: 10Damilare Adedoyin) [18:39:18] (03Merged) 10jenkins-bot: Update smashpig to 0.8.18 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1083238 (owner: 10Damilare Adedoyin) [18:39:19] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1083239 (owner: 10Damilare Adedoyin) [19:22:22] thanks damilare|brb